)]}'
{"neutron/agent/l3/ha.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"7fc70d5543a49ab8f9270f80fc6f2298e50bac1d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_2b11a252","side":"PARENT","line":103,"updated":"2016-09-02 10:52:13.000000000","message":"Please keep this function. It improves readability and means you can keep comments in the implementation that rationalize the number you chose.\n\nIs 2 seconds too aggressive? The faster it is, the more notifications you risk sending to the server in the case you get, say, a 1,000 router failovers to this node.","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f87e139678f476371d132a40caea8e8228586065","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_4e00b4ab","side":"PARENT","line":103,"in_reply_to":"fa7ab95a_2b11a252","updated":"2016-09-02 11:29:06.000000000","message":"Done, for keep this function.\n\n\nFor the message queue, send notifications in every 2 seconds is completely affordable. Even its aslo affordable to send this 1000 notifications in 2 secs. And things may get more interesting, if there are 1,000 routers state change, then 16s * 1000 is more than 4 hours.\n\nAnd this long time also seems to be one condition of the creating and deleting HA router race, that we dealt with before, between `HA router was deleted` and `updating HA portbindings notification comes`. Its 16s long, that HA router can be deleted.","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2e1be72a3b168ae4adaafec6ce14dfd2a058e1de","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_baf33a72","side":"PARENT","line":103,"in_reply_to":"fa7ab95a_4493335b","updated":"2016-09-02 12:44:14.000000000","message":"Thanks for point me out.","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"005e27b697053fa49d9c412239039b3bcd0d8fa7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_4493335b","side":"PARENT","line":103,"in_reply_to":"fa7ab95a_4e00b4ab","updated":"2016-09-02 11:56:15.000000000","message":"\u003e if there are 1,000 routers state change, then 16s * 1000 is more than 4 hours.\n\nThat\u0027s not how the BatchNotifier works, please read its code. If you get 1,000 notifications together, you\u0027ll send 1 notification for all 1,000 after 16 seconds.","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"da67a82164d334f5f08effcd440f575da781a16f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_70faaebe","side":"PARENT","line":103,"in_reply_to":"fa7ab95a_82b0c844","updated":"2016-09-02 13:55:46.000000000","message":"That must be a super computer. : )","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bcda72fd916a9e13f515c6c56203a8b4e4743f97","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ff2bf1e8","side":"PARENT","line":103,"in_reply_to":"fa7ab95a_baf33a72","updated":"2016-09-02 13:18:31.000000000","message":"Anywany 1,000 routers in a single host is impractical. One single host state change may not have too much, cloud admins must limit the L3 agent host router to a reliable quantity, then it may not cause high pressure on the neutron server, same as the DB or MQ.","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"56d258b2ff3168529217f3d57c912ac5e5b545d6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            L3AgentKeepalivedStateChangeServer(self, self.conf))"},{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # Slave becomes the master after not hearing from it 3 times"},{"line_number":105,"context_line":"        detection_time \u003d self.conf.ha_vrrp_advert_int * 3"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_82b0c844","side":"PARENT","line":103,"in_reply_to":"fa7ab95a_ff2bf1e8","updated":"2016-09-02 13:23:43.000000000","message":"I actually supported an environment with exactly 1,000 HA routers on every node \u003dD","commit_id":"903eb250bcf829173fe701e3fef20dbd8fc51ef8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"783bc7e012afa850fba187380dbe27cda2fb27a8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # BatchNotifier queue is needed to ensure that the HA router"},{"line_number":105,"context_line":"        # state change sequence is under the proper order."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # set the BatchNotifier interval to ha_vrrp_advert_int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c273b04c","line":104,"updated":"2016-09-02 13:39:31.000000000","message":"Sorry to be a pest but this comment should probably be before line 94.","commit_id":"0d4ca7d2b3ef1e86d44b79290a898acbc6da6730"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e40e45f7be4da6f55ef042b85d2c3d9e470f04b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        state_change_server.run()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":104,"context_line":"        # BatchNotifier queue is needed to ensure that the HA router"},{"line_number":105,"context_line":"        # state change sequence is under the proper order."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # set the BatchNotifier interval to ha_vrrp_advert_int,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_303e668b","line":104,"in_reply_to":"fa7ab95a_c273b04c","updated":"2016-09-02 13:55:51.000000000","message":"Done","commit_id":"0d4ca7d2b3ef1e86d44b79290a898acbc6da6730"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d2104692b430feab9b6507d22cf96712e36efb74","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":106,"context_line":"        # Set the BatchNotifier interval to ha_vrrp_advert_int,"},{"line_number":107,"context_line":"        # default 2 seconds."},{"line_number":108,"context_line":"        return self.conf.ha_vrrp_advert_int"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":111,"context_line":"        LOG.info(_LI(\u0027Router %(router_id)s transitioned to %(state)s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e24df6c4","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":43},"updated":"2016-09-08 07:57:43.000000000","message":"The original 16 seconds may be one condition of the creating and deleting HA router race,\nthat we dealt with before, between `HA router was deleting` and `updating HA portbindings notification comes`.\nIt\u0027s 16s long, that HA router/ha_portbindings/ha_portbindings_port can be deleted.\n\nSo, this change may reduce the following line expects, [1], [2].\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L747\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L774-775","commit_id":"98c18b4353f458d2209b7e43d8f0c56ef809bf73"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"df90eaa81ca90f9f366016a7d2d6a2b199b05d36","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":106,"context_line":"        # Set the BatchNotifier interval to ha_vrrp_advert_int,"},{"line_number":107,"context_line":"        # default 2 seconds."},{"line_number":108,"context_line":"        return self.conf.ha_vrrp_advert_int"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":111,"context_line":"        LOG.info(_LI(\u0027Router %(router_id)s transitioned to %(state)s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_a006401e","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":43},"in_reply_to":"9a89bdaa_453b91eb","updated":"2016-09-14 03:20:41.000000000","message":"Hi, Muller, cloud you give me a reason for *2 interval?\n\nAfter several rally scenario testing, we found that 2 seconds for state change notification interval is not so much aggressive.\nOn the contrary, I want to say, 16s may let the l3 agent squeeze more notification, and then may let the MQ a high pressure.\n\nYou can see the test result here:\n\nhttps://bugs.launchpad.net/neutron/+bug/1612069/comments/3","commit_id":"98c18b4353f458d2209b7e43d8f0c56ef809bf73"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b33faa0ff42d3b0740f954eebda1470fdf461ebd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":106,"context_line":"        # Set the BatchNotifier interval to ha_vrrp_advert_int,"},{"line_number":107,"context_line":"        # default 2 seconds."},{"line_number":108,"context_line":"        return self.conf.ha_vrrp_advert_int"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":111,"context_line":"        LOG.info(_LI(\u0027Router %(router_id)s transitioned to %(state)s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_453b91eb","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":43},"in_reply_to":"9a89bdaa_e24df6c4","updated":"2016-09-10 16:33:47.000000000","message":"I\u0027d +2 a patch that used twice the advertisement interval.","commit_id":"98c18b4353f458d2209b7e43d8f0c56ef809bf73"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b0643208188c00fa1c64c12334893fe9ae70f21b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # BatchNotifier queue is needed to ensure that the HA router"},{"line_number":84,"context_line":"        # state change sequence is under the proper order."},{"line_number":85,"context_line":"        self.state_change_notifier \u003d batch_notifier.BatchNotifier("},{"line_number":86,"context_line":"            self._calculate_batch_duration(), self.notify_server)"},{"line_number":87,"context_line":"        eventlet.spawn(self._start_keepalived_notifications_server)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _start_keepalived_notifications_server(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_34bd21d8","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":44},"updated":"2017-04-07 15:47:18.000000000","message":"can\u0027t we directly use self.conf.ha_vrrp_advert_int here ?\nhelper is not used anywhere else ?","commit_id":"e795a3fcf882ad8130018f32b57f2f887a1d20da"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f316f74f832352575099257e15e598cc150a80ce","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # BatchNotifier queue is needed to ensure that the HA router"},{"line_number":84,"context_line":"        # state change sequence is under the proper order."},{"line_number":85,"context_line":"        self.state_change_notifier \u003d batch_notifier.BatchNotifier("},{"line_number":86,"context_line":"            self._calculate_batch_duration(), self.notify_server)"},{"line_number":87,"context_line":"        eventlet.spawn(self._start_keepalived_notifications_server)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _start_keepalived_notifications_server(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_342c0101","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":44},"in_reply_to":"bff0334d_34bd21d8","updated":"2017-04-07 15:49:06.000000000","message":"nvm read comments on previous ps, so fine keeping the helper","commit_id":"e795a3fcf882ad8130018f32b57f2f887a1d20da"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fe4ffaa14effa540c0c999d913dac2763f6b3001","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":95,"context_line":"        # Set the BatchNotifier interval to ha_vrrp_advert_int,"},{"line_number":96,"context_line":"        # default 2 seconds."},{"line_number":97,"context_line":"        return self.conf.ha_vrrp_advert_int"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":100,"context_line":"        LOG.info(_LI(\u0027Router %(router_id)s transitioned to %(state)s\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_d5df44d4","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":43},"updated":"2017-04-25 11:32:24.000000000","message":"Why not just add in a new configuration variable here that could be tweaked according to the setup. I know that it is one extra parameter but in most cases this will remain the default","commit_id":"e795a3fcf882ad8130018f32b57f2f887a1d20da"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"742d1ba765775da62c8e3c2c42275e30dcb9e19d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _calculate_batch_duration(self):"},{"line_number":95,"context_line":"        # Set the BatchNotifier interval to ha_vrrp_advert_int,"},{"line_number":96,"context_line":"        # default 2 seconds."},{"line_number":97,"context_line":"        return self.conf.ha_vrrp_advert_int"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":100,"context_line":"        LOG.info(_LI(\u0027Router %(router_id)s transitioned to %(state)s\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_de99a179","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":43},"in_reply_to":"5ff73747_d5df44d4","updated":"2017-04-25 12:42:57.000000000","message":"I think this change is worth to be backportable, so let\u0027s keep it as small as possible.","commit_id":"e795a3fcf882ad8130018f32b57f2f887a1d20da"}]}
