)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9f32535576637f471cae4a744daff5471a970f09","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note: This change is not newton critical so projects are welcome"},{"line_number":17,"context_line":"to hold off on committing until post-newton. Ideally this change"},{"line_number":18,"context_line":"will merge by the first part of Ocata so dependant function can"},{"line_number":19,"context_line":"land and have time to solidify for Ocata."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1c0620894d07d58efbba5226b5244fec950354ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_74e5eea6","line":18,"range":{"start_line":18,"start_character":51,"end_line":18,"end_character":59},"updated":"2016-09-03 00:35:49.000000000","message":"Nit: functionality","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f831e730bec7ce09d252ab1a092df2fb3d3f755f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note: This change is not newton critical so projects are welcome"},{"line_number":17,"context_line":"to hold off on committing until post-newton. Ideally this change"},{"line_number":18,"context_line":"will merge by the first part of Ocata so dependant function can"},{"line_number":19,"context_line":"land and have time to solidify for Ocata."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1c0620894d07d58efbba5226b5244fec950354ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_1864f5b6","line":18,"range":{"start_line":18,"start_character":51,"end_line":18,"end_character":59},"in_reply_to":"9a89bdaa_74e5eea6","updated":"2016-09-08 13:11:31.000000000","message":"Done","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e4b57ced22081d501044a3ff87397c2961354bea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"function raises, whereas retrying retried on all exceptions."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This patch updates all usages of retrying with tenacity."},{"line_number":34,"context_line":"Unit tests will be added where applicable."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Note: This change is not newton critical so projects are welcome"},{"line_number":37,"context_line":"to hold off on committing until post-newton. Ideally this change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_57cd3885","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":41},"updated":"2016-10-17 21:50:36.000000000","message":"Do we still need this?","commit_id":"a3b5a06d688bc0184121b27500d1163fa7eadc98"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b8e7a59666a5b850e2b95e9b25ff39a4e366fec2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"function raises, whereas retrying retried on all exceptions."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This patch updates all usages of retrying with tenacity."},{"line_number":34,"context_line":"Unit tests will be added where applicable."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Note: This change is not newton critical so projects are welcome"},{"line_number":37,"context_line":"to hold off on committing until post-newton. Ideally this change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da6895a0_7fc1472e","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":41},"in_reply_to":"fa6399be_42eb8a78","updated":"2016-10-20 19:23:35.000000000","message":"What I think Miguel is getting at is that all patches that change functionality are expected to have full unit test coverage for the changes without mentioning it in the commit message. So, don\u0027t bother saying this is future commit messages. But, this is fine.","commit_id":"a3b5a06d688bc0184121b27500d1163fa7eadc98"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"633fb4fa4576f652294071e1ec4e904d76db675d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"function raises, whereas retrying retried on all exceptions."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This patch updates all usages of retrying with tenacity."},{"line_number":34,"context_line":"Unit tests will be added where applicable."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Note: This change is not newton critical so projects are welcome"},{"line_number":37,"context_line":"to hold off on committing until post-newton. Ideally this change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_42eb8a78","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":41},"in_reply_to":"fa6399be_57cd3885","updated":"2016-10-18 19:55:35.000000000","message":"Sure, why not? This patch did actually add new UTs... Or am I misunderstanding your question?","commit_id":"a3b5a06d688bc0184121b27500d1163fa7eadc98"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9f32535576637f471cae4a744daff5471a970f09","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_utils import excutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"from tenacity import retry"},{"line_number":28,"context_line":"from tenacity.retry import retry_if_result"},{"line_number":29,"context_line":"from tenacity import RetryError"},{"line_number":30,"context_line":"from tenacity.stop import stop_after_delay"},{"line_number":31,"context_line":"from tenacity.wait import wait_exponential"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from neutron._i18n import _, _LE, _LI, _LW"},{"line_number":34,"context_line":"from neutron.agent.common import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_d47ddae8","line":31,"range":{"start_line":27,"start_character":0,"end_line":31,"end_character":42},"updated":"2016-09-03 00:35:49.000000000","message":"Why not follow the OpenStack import guidelines: http://docs.openstack.org/developer/hacking/#imports","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f831e730bec7ce09d252ab1a092df2fb3d3f755f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_utils import excutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"from tenacity import retry"},{"line_number":28,"context_line":"from tenacity.retry import retry_if_result"},{"line_number":29,"context_line":"from tenacity import RetryError"},{"line_number":30,"context_line":"from tenacity.stop import stop_after_delay"},{"line_number":31,"context_line":"from tenacity.wait import wait_exponential"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from neutron._i18n import _, _LE, _LI, _LW"},{"line_number":34,"context_line":"from neutron.agent.common import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_78750162","line":31,"range":{"start_line":27,"start_character":0,"end_line":31,"end_character":42},"in_reply_to":"9a89bdaa_d47ddae8","updated":"2016-09-08 13:11:31.000000000","message":"Done","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"}],"neutron/agent/ovsdb/native/connection.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9f32535576637f471cae4a744daff5471a970f09","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ovs.db import idl"},{"line_number":20,"context_line":"from ovs import poller"},{"line_number":21,"context_line":"from six.moves import queue as Queue"},{"line_number":22,"context_line":"from tenacity import retry"},{"line_number":23,"context_line":"from tenacity.stop import stop_after_delay"},{"line_number":24,"context_line":"from tenacity.wait import wait_exponential"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from neutron.agent.ovsdb.native import helpers"},{"line_number":27,"context_line":"from neutron.agent.ovsdb.native import idlutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_944b52b0","line":24,"range":{"start_line":22,"start_character":1,"end_line":24,"end_character":42},"updated":"2016-09-03 00:35:49.000000000","message":"Why not follow the OpenStack import guidelines: http://docs.openstack.org/developer/hacking/#imports","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f831e730bec7ce09d252ab1a092df2fb3d3f755f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ovs.db import idl"},{"line_number":20,"context_line":"from ovs import poller"},{"line_number":21,"context_line":"from six.moves import queue as Queue"},{"line_number":22,"context_line":"from tenacity import retry"},{"line_number":23,"context_line":"from tenacity.stop import stop_after_delay"},{"line_number":24,"context_line":"from tenacity.wait import wait_exponential"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from neutron.agent.ovsdb.native import helpers"},{"line_number":27,"context_line":"from neutron.agent.ovsdb.native import idlutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_b86b0984","line":24,"range":{"start_line":22,"start_character":1,"end_line":24,"end_character":42},"in_reply_to":"9a89bdaa_944b52b0","updated":"2016-09-08 13:11:31.000000000","message":"Done","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"}],"neutron/tests/unit/agent/common/test_ovs_lib.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9f32535576637f471cae4a744daff5471a970f09","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib import exceptions"},{"line_number":19,"context_line":"from oslo_serialization import jsonutils"},{"line_number":20,"context_line":"from oslo_utils import uuidutils"},{"line_number":21,"context_line":"from tenacity import RetryError"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.agent.common import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_d4cb1a1d","line":21,"updated":"2016-09-03 00:35:49.000000000","message":"Why not follow the OpenStack import guidelines: http://docs.openstack.org/developer/hacking/#imports","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f831e730bec7ce09d252ab1a092df2fb3d3f755f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib import exceptions"},{"line_number":19,"context_line":"from oslo_serialization import jsonutils"},{"line_number":20,"context_line":"from oslo_utils import uuidutils"},{"line_number":21,"context_line":"from tenacity import RetryError"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.agent.common import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_180b15d7","line":21,"in_reply_to":"9a89bdaa_d4cb1a1d","updated":"2016-09-08 13:11:31.000000000","message":"Done","commit_id":"9d40c8baa74402274f71fa829c659ef6bfccfc64"}]}
