)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0a0ff581c16ff50a9e46aa12fd643b46e3c6e2d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch allows the same."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1c7a520aa1bb58984b199c86aca2267b98e6b3e"},{"line_number":16,"context_line":"Closes-Bug: #1408236"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_b70561c3","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2016-09-06 11:30:13.000000000","message":"Bug provided points to\n FWaaS - incorrect behavior in creating firewall with unavailable firewall_policy\n\nIt doesn\u0027t look like correct one.","commit_id":"c8deed3d0ec9fc3e25fab406631bcef4e2a7ec7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"152449397d56bfa112c77b8e2b5bc33f3ea72f95","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch allows the same."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1c7a520aa1bb58984b199c86aca2267b98e6b3e"},{"line_number":16,"context_line":"Closes-Bug: #1408236"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_376eb12f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"9a89bdaa_b70561c3","updated":"2016-09-06 11:35:45.000000000","message":"Oops, worng copy","commit_id":"c8deed3d0ec9fc3e25fab406631bcef4e2a7ec7b"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0a0ff581c16ff50a9e46aa12fd643b46e3c6e2d8","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    __native_bulk_support \u003d True"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_security_group_bulk(self, context, security_groups):"},{"line_number":48,"context_line":"        return self._create_bulk(\u0027security_group\u0027, context,"},{"line_number":49,"context_line":"                                 security_groups)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_771bd91b","line":47,"range":{"start_line":47,"start_character":50,"end_line":47,"end_character":65},"updated":"2016-09-06 11:30:13.000000000","message":"Are you sure, this keyword is not used anywhere?","commit_id":"c8deed3d0ec9fc3e25fab406631bcef4e2a7ec7b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"152449397d56bfa112c77b8e2b5bc33f3ea72f95","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    __native_bulk_support \u003d True"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_security_group_bulk(self, context, security_groups):"},{"line_number":48,"context_line":"        return self._create_bulk(\u0027security_group\u0027, context,"},{"line_number":49,"context_line":"                                 security_groups)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_77fd9939","line":47,"range":{"start_line":47,"start_character":50,"end_line":47,"end_character":65},"in_reply_to":"9a89bdaa_771bd91b","updated":"2016-09-06 11:35:45.000000000","message":"This was the reason why bulk creation failed.\nThe kwargs which is being passed in the below PASTE link would fail if we use the previous code.\n\nhttp://paste.openstack.org/show/567124/\n\nYou can go ahead and try if you want :)","commit_id":"c8deed3d0ec9fc3e25fab406631bcef4e2a7ec7b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ca7929fb43849fc0f5392a9245f9ed07ea39879c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    __native_bulk_support \u003d True"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_security_group_bulk(self, context, security_groups):"},{"line_number":48,"context_line":"        return self._create_bulk(\u0027security_group\u0027, context,"},{"line_number":49,"context_line":"                                 security_groups)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_f3145c45","line":47,"range":{"start_line":47,"start_character":50,"end_line":47,"end_character":65},"in_reply_to":"9a89bdaa_77fd9939","updated":"2016-09-06 11:39:36.000000000","message":"Thanks :)","commit_id":"c8deed3d0ec9fc3e25fab406631bcef4e2a7ec7b"}],"neutron/tests/tempest/api/test_security_groups.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e117b5e5dacd12550b53f07a80d47f804f4fd16f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # Creates 2 sec-groups in one request"},{"line_number":60,"context_line":"        sec_nm \u003d [data_utils.rand_name(\u0027secgroup\u0027),"},{"line_number":61,"context_line":"                  data_utils.rand_name(\u0027secgroup\u0027)]"},{"line_number":62,"context_line":"        body \u003d self.client.create_security_group_bulk(sec_nm)"},{"line_number":63,"context_line":"        created_sec_grps \u003d body[\u0027security_groups\u0027]"},{"line_number":64,"context_line":"        for secgrps in created_sec_grps:"},{"line_number":65,"context_line":"            self.addCleanup(self.client.delete_security_group,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_5dda2fe9","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":53},"updated":"2016-11-28 01:21:12.000000000","message":"It seems the client doesn\u0027t have definition of create_security_group_bulk() and _creater() does\u0027t support it.","commit_id":"6e4482ef63956bd6e91fd6b52f820763892570ab"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"99fc1f46aa2eb186727dd3fc846fa47aa0e0d42f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                  data_utils.rand_name(\u0027secgroup\u0027)]"},{"line_number":62,"context_line":"        body \u003d self.client.create_bulk_security_groups(sec_nm)"},{"line_number":63,"context_line":"        created_sec_grps \u003d body[\u0027security_groups\u0027]"},{"line_number":64,"context_line":"        for secgrps in created_sec_grps:"},{"line_number":65,"context_line":"            self.addCleanup(self.client.delete_security_group,"},{"line_number":66,"context_line":"                            secgrps[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.assertIsNotNone(secgrps[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_f7336511","line":67,"range":{"start_line":64,"start_character":8,"end_line":67,"end_character":47},"updated":"2016-12-01 05:32:18.000000000","message":"We should surely check the name of two security-group because this says OK even if bulk API returns one security-group only in this case.","commit_id":"9d38442f092ecc8bf73dd8b732b8da821af6d7e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ba1d56fee32ca69dea088acc699f43a6b2cedaed","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                  data_utils.rand_name(\u0027secgroup\u0027)]"},{"line_number":62,"context_line":"        body \u003d self.client.create_bulk_security_groups(sec_nm)"},{"line_number":63,"context_line":"        created_sec_grps \u003d body[\u0027security_groups\u0027]"},{"line_number":64,"context_line":"        for secgrps in created_sec_grps:"},{"line_number":65,"context_line":"            self.addCleanup(self.client.delete_security_group,"},{"line_number":66,"context_line":"                            secgrps[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.assertIsNotNone(secgrps[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_db25cec2","line":67,"range":{"start_line":64,"start_character":8,"end_line":67,"end_character":47},"in_reply_to":"5a74a57a_f7336511","updated":"2016-12-02 06:08:25.000000000","message":"Done","commit_id":"9d38442f092ecc8bf73dd8b732b8da821af6d7e1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d866d1bbf3c370d750d36bf3329aa623f95d7082","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                  data_utils.rand_name(\u0027secgroup\u0027)]"},{"line_number":62,"context_line":"        body \u003d self.client.create_bulk_security_groups(sec_nm)"},{"line_number":63,"context_line":"        created_sec_grps \u003d body[\u0027security_groups\u0027]"},{"line_number":64,"context_line":"        for secgrp in created_sec_grps:"},{"line_number":65,"context_line":"            self.addCleanup(self.client.delete_security_group,"},{"line_number":66,"context_line":"                            secgrp[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.assertIn(secgrp[\u0027name\u0027], sec_nm)"},{"line_number":68,"context_line":"            self.assertIsNotNone(secgrp[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a71b18c_edf7ed56","line":67,"range":{"start_line":64,"start_character":8,"end_line":67,"end_character":49},"updated":"2016-12-05 04:03:10.000000000","message":"This change is better for me than previous Patch-set. However, my previous comment meant that we should check that two security-group were surely created. This still says OK even if the body has one security-group only. Could you add a check like \"self.assertEqual(2, len(created_sec_grps))\" between L63 and L64?","commit_id":"5d6f10c93d7e926e79d9612d1e39782b21065300"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cddeb36728d95ec18a05a4e2713e207d8e793b07","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                  data_utils.rand_name(\u0027secgroup\u0027)]"},{"line_number":62,"context_line":"        body \u003d self.client.create_bulk_security_groups(sec_nm)"},{"line_number":63,"context_line":"        created_sec_grps \u003d body[\u0027security_groups\u0027]"},{"line_number":64,"context_line":"        for secgrp in created_sec_grps:"},{"line_number":65,"context_line":"            self.addCleanup(self.client.delete_security_group,"},{"line_number":66,"context_line":"                            secgrp[\u0027id\u0027])"},{"line_number":67,"context_line":"            self.assertIn(secgrp[\u0027name\u0027], sec_nm)"},{"line_number":68,"context_line":"            self.assertIsNotNone(secgrp[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a71b18c_f3c34a55","line":67,"range":{"start_line":64,"start_character":8,"end_line":67,"end_character":49},"in_reply_to":"3a71b18c_edf7ed56","updated":"2016-12-05 05:14:19.000000000","message":"hmm, I thought the name check would work , but you are right, it wont check if more than one has been created :)","commit_id":"5d6f10c93d7e926e79d9612d1e39782b21065300"}],"neutron/tests/unit/extensions/test_securitygroup.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b97675b78ab87486ac6a50b4fb18795e229b8060","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _create_security_group(self, fmt, name, description, **kwargs):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if (\u0027bulk\u0027 in kwargs and kwargs[\u0027bulk\u0027]):"},{"line_number":76,"context_line":"            data \u003d {"},{"line_number":77,"context_line":"                \u0027security_groups\u0027: [{"},{"line_number":78,"context_line":"                    \u0027security_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_28ac8bec","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":49},"updated":"2016-09-06 13:33:12.000000000","message":"if kwargs.get(\u0027bulk\u0027): - no wrapping parenthesis","commit_id":"1b421ba3b1e845834445906deb7e03ec20255015"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b97675b78ab87486ac6a50b4fb18795e229b8060","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        return security_group_rule_req.get_response(self.ext_api)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _make_security_group(self, fmt, name, description, **kwargs):"},{"line_number":138,"context_line":"        if (\u0027bulk\u0027 in kwargs):"},{"line_number":139,"context_line":"            res \u003d self._create_security_group(fmt, name, description,"},{"line_number":140,"context_line":"                                              **kwargs)"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            res \u003d self._create_security_group(fmt, name, description, **kwargs)"},{"line_number":143,"context_line":"        if res.status_int \u003e\u003d webob.exc.HTTPBadRequest.code:"},{"line_number":144,"context_line":"            raise webob.exc.HTTPClientError(code\u003dres.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_88003703","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":13},"updated":"2016-09-06 13:33:12.000000000","message":"You don\u0027t need this. L139 and L142 are the same.","commit_id":"1b421ba3b1e845834445906deb7e03ec20255015"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b97675b78ab87486ac6a50b4fb18795e229b8060","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        if not fmt:"},{"line_number":157,"context_line":"            fmt \u003d self.fmt"},{"line_number":158,"context_line":"        if bulk:"},{"line_number":159,"context_line":"            security_group \u003d self._make_security_group(fmt, name, description,"},{"line_number":160,"context_line":"                                                       bulk\u003dTrue)"},{"line_number":161,"context_line":"        else:"},{"line_number":162,"context_line":"            security_group \u003d self._make_security_group(fmt, name, description)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_cd45f170","line":159,"updated":"2016-09-06 13:33:12.000000000","message":"Can you just pass bulk always?","commit_id":"1b421ba3b1e845834445906deb7e03ec20255015"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fd4592fb6c79dfe405bc2f6c66d9f040964144bd","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        name \u003d \u0027webservers_bulk\u0027"},{"line_number":301,"context_line":"        description \u003d \u0027my webservers_bulk\u0027"},{"line_number":302,"context_line":"        keys \u003d [(\u0027name\u0027, name,), (\u0027description\u0027, description)]"},{"line_number":303,"context_line":"        with self.security_group(name, description, bulk\u003dTrue) as sec_group:"},{"line_number":304,"context_line":"            for k, v, in keys:"},{"line_number":305,"context_line":"                self.assertEqual(sec_group[\u0027security_groups\u0027]["},{"line_number":306,"context_line":"                                 0][k], v)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_4edc3f73","line":303,"updated":"2016-09-07 11:43:49.000000000","message":"To make the bulk tested, we should create more than one security group at once.","commit_id":"b16e7f0afcd04b68637f8bf48c17677b2fa41dfc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"327386e0328dd140bb71d958132acb3ae460cce3","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        name \u003d \u0027webservers_bulk\u0027"},{"line_number":301,"context_line":"        description \u003d \u0027my webservers_bulk\u0027"},{"line_number":302,"context_line":"        keys \u003d [(\u0027name\u0027, name,), (\u0027description\u0027, description)]"},{"line_number":303,"context_line":"        with self.security_group(name, description, bulk\u003dTrue) as sec_group:"},{"line_number":304,"context_line":"            for k, v, in keys:"},{"line_number":305,"context_line":"                self.assertEqual(sec_group[\u0027security_groups\u0027]["},{"line_number":306,"context_line":"                                 0][k], v)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_5312b359","line":303,"in_reply_to":"9a89bdaa_4edc3f73","updated":"2016-11-04 12:11:11.000000000","message":"Done","commit_id":"b16e7f0afcd04b68637f8bf48c17677b2fa41dfc"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"6d2e6c02e4c4769a969e85f182fb8eaca757972c","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        self._assert_sg_rule_has_kvs(v6_rule, expected)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_create_security_group_bulk(self):"},{"line_number":296,"context_line":"            rule1 \u003d self._build_security_group(\"sg_1\", \"sec_grp_1\")"},{"line_number":297,"context_line":"            rule2 \u003d self._build_security_group(\"sg_2\", \"sec_grp_2\")"},{"line_number":298,"context_line":"            rules \u003d {\u0027security_groups\u0027: [rule1[\u0027security_group\u0027],"},{"line_number":299,"context_line":"                                         rule2[\u0027security_group\u0027]]}"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_225de3e9","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":17},"updated":"2016-11-15 01:40:45.000000000","message":"sec_grp1?","commit_id":"485253dc399b7d9e8aa8fa115afc07a9f4059c49"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"6d2e6c02e4c4769a969e85f182fb8eaca757972c","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_create_security_group_bulk(self):"},{"line_number":296,"context_line":"            rule1 \u003d self._build_security_group(\"sg_1\", \"sec_grp_1\")"},{"line_number":297,"context_line":"            rule2 \u003d self._build_security_group(\"sg_2\", \"sec_grp_2\")"},{"line_number":298,"context_line":"            rules \u003d {\u0027security_groups\u0027: [rule1[\u0027security_group\u0027],"},{"line_number":299,"context_line":"                                         rule2[\u0027security_group\u0027]]}"},{"line_number":300,"context_line":"            res \u003d self._create_security_group_response(self.fmt, rules,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_c2042fc8","line":297,"range":{"start_line":297,"start_character":11,"end_line":297,"end_character":17},"updated":"2016-11-15 01:40:45.000000000","message":"sec_grp2?","commit_id":"485253dc399b7d9e8aa8fa115afc07a9f4059c49"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"6d2e6c02e4c4769a969e85f182fb8eaca757972c","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    def test_create_security_group_bulk(self):"},{"line_number":296,"context_line":"            rule1 \u003d self._build_security_group(\"sg_1\", \"sec_grp_1\")"},{"line_number":297,"context_line":"            rule2 \u003d self._build_security_group(\"sg_2\", \"sec_grp_2\")"},{"line_number":298,"context_line":"            rules \u003d {\u0027security_groups\u0027: [rule1[\u0027security_group\u0027],"},{"line_number":299,"context_line":"                                         rule2[\u0027security_group\u0027]]}"},{"line_number":300,"context_line":"            res \u003d self._create_security_group_response(self.fmt, rules,"},{"line_number":301,"context_line":"                                                       bulk\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_e2092bdf","line":298,"range":{"start_line":298,"start_character":12,"end_line":298,"end_character":17},"updated":"2016-11-15 01:40:45.000000000","message":"sec_grps?","commit_id":"485253dc399b7d9e8aa8fa115afc07a9f4059c49"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"e3a58c5248c126d15284c28ceb329059558a15b6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return security_group_req.get_response(self.ext_api)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _create_security_group(self, fmt, name, description, **kwargs):"},{"line_number":91,"context_line":"        if not kwargs.get(\u0027bulk\u0027):"},{"line_number":92,"context_line":"            data \u003d self._build_security_group(name, description, **kwargs)"},{"line_number":93,"context_line":"        return self._create_security_group_response(fmt, data, **kwargs)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a71b18c_f1224d51","line":91,"range":{"start_line":91,"start_character":27,"end_line":91,"end_character":31},"updated":"2016-12-05 15:02:02.000000000","message":"are there tests that passes this keyword?","commit_id":"b851edf1022855824744d1c5638603c95cdd760e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7a79fd782e121ddb925fb10ba4ac3d7fad05a42d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return security_group_req.get_response(self.ext_api)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _create_security_group(self, fmt, name, description, **kwargs):"},{"line_number":91,"context_line":"        if not kwargs.get(\u0027bulk\u0027):"},{"line_number":92,"context_line":"            data \u003d self._build_security_group(name, description, **kwargs)"},{"line_number":93,"context_line":"        return self._create_security_group_response(fmt, data, **kwargs)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a71b18c_77e61116","line":91,"range":{"start_line":91,"start_character":27,"end_line":91,"end_character":31},"in_reply_to":"3a71b18c_f1224d51","updated":"2016-12-06 04:28:49.000000000","message":"Thanks , I missed it.\nIt is passed but this function is not called directly for bulk , but it is for other functions","commit_id":"b851edf1022855824744d1c5638603c95cdd760e"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"e3a58c5248c126d15284c28ceb329059558a15b6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _create_security_group(self, fmt, name, description, **kwargs):"},{"line_number":91,"context_line":"        if not kwargs.get(\u0027bulk\u0027):"},{"line_number":92,"context_line":"            data \u003d self._build_security_group(name, description, **kwargs)"},{"line_number":93,"context_line":"        return self._create_security_group_response(fmt, data, **kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _build_security_group_rule("},{"line_number":96,"context_line":"            self, security_group_id, direction, proto,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a71b18c_b1f1b503","line":93,"range":{"start_line":93,"start_character":57,"end_line":93,"end_character":61},"updated":"2016-12-05 15:02:02.000000000","message":"if kwargs.get(\u0027bulk\u0027) then this var is not defined.","commit_id":"b851edf1022855824744d1c5638603c95cdd760e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8953895fde4518e5ba7996e7d869b6d4247a0673","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                       fmt\u003dNone):"},{"line_number":140,"context_line":"        if not fmt:"},{"line_number":141,"context_line":"            fmt \u003d self.fmt"},{"line_number":142,"context_line":"        security_group \u003d self._make_security_group(fmt, name, description)"},{"line_number":143,"context_line":"        yield security_group"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @contextlib.contextmanager"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_02829d52","side":"PARENT","line":142,"range":{"start_line":142,"start_character":0,"end_line":142,"end_character":74},"updated":"2016-12-13 04:09:45.000000000","message":"It looks like this change is not your intention.","commit_id":"4d7653848d74674d23eed59d334ace5fe89288a0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8953895fde4518e5ba7996e7d869b6d4247a0673","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            rules \u003d {\u0027security_groups\u0027: [rule1[\u0027security_group\u0027],"},{"line_number":298,"context_line":"                                         rule2[\u0027security_group\u0027]]}"},{"line_number":299,"context_line":"            res \u003d self._create_security_group_response(self.fmt, rules,"},{"line_number":300,"context_line":"                                                       bulk\u003dTrue)"},{"line_number":301,"context_line":"            ret \u003d self.deserialize(self.fmt, res)"},{"line_number":302,"context_line":"            self.assertEqual(webob.exc.HTTPCreated.code, res.status_int)"},{"line_number":303,"context_line":"            self.assertEqual(2, len(ret[\u0027security_groups\u0027]))"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_62cfd1b0","line":300,"range":{"start_line":300,"start_character":55,"end_line":300,"end_character":64},"updated":"2016-12-13 04:09:45.000000000","message":"It seems unnecessary.","commit_id":"0fa50d8deb60295f4f94db51424a388626cd143f"}]}
