)]}'
{"neutron/callbacks/manager.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7a73c803f001d7f4d3c1e7048f2eea966875cf5d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def _notify_loop(self, resource, event, trigger, **kwargs):"},{"line_number":138,"context_line":"        \"\"\"The notification loop.\"\"\""},{"line_number":139,"context_line":"        LOG.debug(\"Notify callbacks for %(resource)s, %(event)s\","},{"line_number":140,"context_line":"                  {\u0027resource\u0027: resource, \u0027event\u0027: event})"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        errors \u003d []"},{"line_number":143,"context_line":"        callbacks \u003d list(self._callbacks[resource].get(event, {}).items())"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_2c547a1f","side":"PARENT","line":140,"updated":"2016-09-07 05:45:17.000000000","message":"no, you can\u0027t get rid of this debug and the one below. it\u0027s the only thing that keeps a callback system debuggable!\n\nPick one or the other.","commit_id":"1cf8e5ab5a2cdb2c1fd10edc294766d5ce4eed96"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b2ab90aa06a5bcd4656fe60cc6be1174bbe3eb4c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def _notify_loop(self, resource, event, trigger, **kwargs):"},{"line_number":138,"context_line":"        \"\"\"The notification loop.\"\"\""},{"line_number":139,"context_line":"        LOG.debug(\"Notify callbacks for %(resource)s, %(event)s\","},{"line_number":140,"context_line":"                  {\u0027resource\u0027: resource, \u0027event\u0027: event})"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        errors \u003d []"},{"line_number":143,"context_line":"        callbacks \u003d list(self._callbacks[resource].get(event, {}).items())"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_07c31139","side":"PARENT","line":140,"in_reply_to":"9a89bdaa_2c547a1f","updated":"2016-09-07 06:09:12.000000000","message":"I had this in PS1, but it was still thousands of debug statements. I am still testing how much saving we get, so bear with me.","commit_id":"1cf8e5ab5a2cdb2c1fd10edc294766d5ce4eed96"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7a73c803f001d7f4d3c1e7048f2eea966875cf5d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            try:"},{"line_number":147,"context_line":"                LOG.debug(\"Calling callback %s\", callback_id)"},{"line_number":148,"context_line":"                callback(resource, event, trigger, **kwargs)"},{"line_number":149,"context_line":"            except Exception as e:"},{"line_number":150,"context_line":"                LOG.exception(_LE(\"Error during notification for \""},{"line_number":151,"context_line":"                                  \"%(callback)s %(resource)s, %(event)s\"),"},{"line_number":152,"context_line":"                              {\u0027callback\u0027: callback_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_4c337e14","side":"PARENT","line":149,"updated":"2016-09-07 05:45:17.000000000","message":"I don\u0027t agree with the removal of this. Even though we don\u0027t let exceptions stop things, we should see them in the logs because it\u0027s a programming error of some sort.","commit_id":"1cf8e5ab5a2cdb2c1fd10edc294766d5ce4eed96"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b2ab90aa06a5bcd4656fe60cc6be1174bbe3eb4c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            try:"},{"line_number":147,"context_line":"                LOG.debug(\"Calling callback %s\", callback_id)"},{"line_number":148,"context_line":"                callback(resource, event, trigger, **kwargs)"},{"line_number":149,"context_line":"            except Exception as e:"},{"line_number":150,"context_line":"                LOG.exception(_LE(\"Error during notification for \""},{"line_number":151,"context_line":"                                  \"%(callback)s %(resource)s, %(event)s\"),"},{"line_number":152,"context_line":"                              {\u0027callback\u0027: callback_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_074dd1c3","side":"PARENT","line":149,"in_reply_to":"9a89bdaa_4c337e14","updated":"2016-09-07 06:09:12.000000000","message":"This is probably where not the bulk of this saving comes, I am watching how much saving we\u0027re getting.","commit_id":"1cf8e5ab5a2cdb2c1fd10edc294766d5ce4eed96"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/main.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1e425bc2216c1cafd0a44d5e18ea4973185aa054","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":32,"context_line":"    ryu_cfg.CONF.default_log_level \u003d \u0027INFO\u0027"},{"line_number":33,"context_line":"    ryu_cfg.CONF.verbose \u003d False"},{"line_number":34,"context_line":"    ryu_log.init_log()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_6e811ac3","line":34,"updated":"2016-09-07 04:03:29.000000000","message":"i suppose this is meant to be a separate change.","commit_id":"9eae6ab6c2b54c11f9d8c074455bb182d74613d9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9466dcd8ade9f2f3de319e3de7c10aaaae694247","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":32,"context_line":"    ryu_cfg.CONF.default_log_level \u003d \u0027INFO\u0027"},{"line_number":33,"context_line":"    ryu_cfg.CONF.verbose \u003d False"},{"line_number":34,"context_line":"    ryu_log.init_log()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_8e701ede","line":34,"in_reply_to":"9a89bdaa_0ea6ce52","updated":"2016-09-07 04:17:30.000000000","message":"oh, right. I think I messed up.","commit_id":"9eae6ab6c2b54c11f9d8c074455bb182d74613d9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4e898fe5b48fcb13d0ecb16aa6deecbcbb00c65e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":32,"context_line":"    ryu_cfg.CONF.default_log_level \u003d \u0027INFO\u0027"},{"line_number":33,"context_line":"    ryu_cfg.CONF.verbose \u003d False"},{"line_number":34,"context_line":"    ryu_log.init_log()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_0ea6ce52","line":34,"in_reply_to":"9a89bdaa_6e811ac3","updated":"2016-09-07 04:17:05.000000000","message":"what do you mean? With or without line 34, ryu does not honor the log level :(","commit_id":"9eae6ab6c2b54c11f9d8c074455bb182d74613d9"}]}
