)]}'
{"neutron/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name.\"\"\""},{"line_number":88,"context_line":"    product_name \u003d \"neutron\""},{"line_number":89,"context_line":"    logging.setup(cfg.CONF, product_name)"},{"line_number":90,"context_line":"    # We use the oslo.log default log levels and add only the extra levels"},{"line_number":91,"context_line":"    # that Neutron needs."},{"line_number":92,"context_line":"    logging.set_defaults(default_log_levels\u003dlogging.get_default_log_levels())"},{"line_number":93,"context_line":"    LOG.info(_LI(\"Logging enabled!\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_bd9e9b60","side":"PARENT","line":90,"updated":"2016-09-08 13:02:53.000000000","message":"looks like the comment was not correct before (?) but now it\u0027s fine","commit_id":"311aac286aef0a240284a24ff408440ff287437a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b0ca1289d62f53e738ed14eb6b7c741dd07b0a4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name.\"\"\""},{"line_number":88,"context_line":"    product_name \u003d \"neutron\""},{"line_number":89,"context_line":"    logging.setup(cfg.CONF, product_name)"},{"line_number":90,"context_line":"    # We use the oslo.log default log levels and add only the extra levels"},{"line_number":91,"context_line":"    # that Neutron needs."},{"line_number":92,"context_line":"    logging.set_defaults(default_log_levels\u003dlogging.get_default_log_levels())"},{"line_number":93,"context_line":"    LOG.info(_LI(\"Logging enabled!\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_155af6f1","side":"PARENT","line":90,"in_reply_to":"9a89bdaa_bd9e9b60","updated":"2016-09-08 15:09:43.000000000","message":"I think so","commit_id":"311aac286aef0a240284a24ff408440ff287437a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise Exception(msg)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"EXTRA_LOG_LEVEL_DEFAULTS \u003d None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def set_neutron_log_level_defaults(log_level_defaults):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_9da1d796","line":86,"updated":"2016-09-08 13:02:53.000000000","message":"why do we even need the global? Is it so that multiple callers can add their own defaults?","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e2b972c83a7bd5ee3285d7a505d91269b933ab71","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise Exception(msg)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"EXTRA_LOG_LEVEL_DEFAULTS \u003d None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def set_neutron_log_level_defaults(log_level_defaults):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_f824a760","line":86,"in_reply_to":"9a89bdaa_1143eb6c","updated":"2016-09-08 15:23:46.000000000","message":"Thanks. That is a nice write-up. Do you think it\u0027s possible to have it in a comment?","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b0ca1289d62f53e738ed14eb6b7c741dd07b0a4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise Exception(msg)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"EXTRA_LOG_LEVEL_DEFAULTS \u003d None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def set_neutron_log_level_defaults(log_level_defaults):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_1143eb6c","line":86,"in_reply_to":"9a89bdaa_9da1d796","updated":"2016-09-08 15:09:43.000000000","message":"setup_logging can be called during SIGHUP events and that can happen anywhere in the codebase. If we don\u0027t keep track of the desired extra log levels there\u0027s a chance we have inconsistent log levels during the life cycle of the program.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        EXTRA_LOG_LEVEL_DEFAULTS \u003d []"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    defaults \u003d set(logging.get_default_log_levels())"},{"line_number":96,"context_line":"    log_level_defaults \u003d log_level_defaults or []"},{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_5d110f03","line":96,"updated":"2016-09-08 13:02:53.000000000","message":"nit: if log_level_defaults is bool() \u003d\u003d False then there is no reason to extract defaults in line 95.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b0ca1289d62f53e738ed14eb6b7c741dd07b0a4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        EXTRA_LOG_LEVEL_DEFAULTS \u003d []"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    defaults \u003d set(logging.get_default_log_levels())"},{"line_number":96,"context_line":"    log_level_defaults \u003d log_level_defaults or []"},{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_35445a48","line":96,"in_reply_to":"9a89bdaa_5d110f03","updated":"2016-09-08 15:09:43.000000000","message":"log_level_defaults is a list, and it may be None","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c9ca4c8ac5123cb322550536cbf92ba9df1a9ff2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    defaults \u003d set(logging.get_default_log_levels())"},{"line_number":96,"context_line":"    log_level_defaults \u003d log_level_defaults or []"},{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"},{"line_number":100,"context_line":"            EXTRA_LOG_LEVEL_DEFAULTS.append(log_level_default)"},{"line_number":101,"context_line":"    return EXTRA_LOG_LEVEL_DEFAULTS"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_c85491cb","line":98,"updated":"2016-09-08 08:29:00.000000000","message":"is this necessary?\n\nthe result of this method is used only for set_defaults and what the user specified is preferred anyway, isn\u0027t it?","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b0ca1289d62f53e738ed14eb6b7c741dd07b0a4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    defaults \u003d set(logging.get_default_log_levels())"},{"line_number":96,"context_line":"    log_level_defaults \u003d log_level_defaults or []"},{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"},{"line_number":100,"context_line":"            EXTRA_LOG_LEVEL_DEFAULTS.append(log_level_default)"},{"line_number":101,"context_line":"    return EXTRA_LOG_LEVEL_DEFAULTS"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_f57af275","line":98,"in_reply_to":"9a89bdaa_c85491cb","updated":"2016-09-08 15:09:43.000000000","message":"I might have made a mistake, and I\u0027ll look closer, but if I didn\u0027t then I could add duplicates down a line 111","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    defaults \u003d set(logging.get_default_log_levels())"},{"line_number":96,"context_line":"    log_level_defaults \u003d log_level_defaults or []"},{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"},{"line_number":100,"context_line":"            EXTRA_LOG_LEVEL_DEFAULTS.append(log_level_default)"},{"line_number":101,"context_line":"    return EXTRA_LOG_LEVEL_DEFAULTS"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_9de5570a","line":98,"in_reply_to":"9a89bdaa_c85491cb","updated":"2016-09-08 13:02:53.000000000","message":"agreed.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"},{"line_number":100,"context_line":"            EXTRA_LOG_LEVEL_DEFAULTS.append(log_level_default)"},{"line_number":101,"context_line":"    return EXTRA_LOG_LEVEL_DEFAULTS"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_fdf02369","line":100,"updated":"2016-09-08 13:02:53.000000000","message":"what will happen if multiple users will try to set default level for the same logger?","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e2b972c83a7bd5ee3285d7a505d91269b933ab71","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"},{"line_number":100,"context_line":"            EXTRA_LOG_LEVEL_DEFAULTS.append(log_level_default)"},{"line_number":101,"context_line":"    return EXTRA_LOG_LEVEL_DEFAULTS"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_189b0b67","line":100,"in_reply_to":"9a89bdaa_f5f11202","updated":"2016-09-08 15:23:46.000000000","message":"I would actually be ok with central hardcoded list. That should also be a tad less complex to reason about.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b0ca1289d62f53e738ed14eb6b7c741dd07b0a4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    for log_level_default in log_level_defaults:"},{"line_number":98,"context_line":"        # Add the default log level, only if not overruled by the user"},{"line_number":99,"context_line":"        if log_level_default not in defaults:"},{"line_number":100,"context_line":"            EXTRA_LOG_LEVEL_DEFAULTS.append(log_level_default)"},{"line_number":101,"context_line":"    return EXTRA_LOG_LEVEL_DEFAULTS"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_f5f11202","line":100,"in_reply_to":"9a89bdaa_fdf02369","updated":"2016-09-08 15:09:43.000000000","message":"last write wins, to avoid this, the other option is to statically centralize all of the extra log levels and forget about this.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # that Neutron needs."},{"line_number":109,"context_line":"    extra_log_level_defaults \u003d ("},{"line_number":110,"context_line":"        set_neutron_log_level_defaults(extra_log_level_defaults))"},{"line_number":111,"context_line":"    logging.set_defaults("},{"line_number":112,"context_line":"        default_log_levels\u003dlogging.get_default_log_levels() +"},{"line_number":113,"context_line":"        extra_log_level_defaults)"},{"line_number":114,"context_line":"    logging.setup(cfg.CONF, product_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_1da787bd","line":111,"updated":"2016-09-08 13:02:53.000000000","message":"nit: probably makes sense to reset only when extra_log_level_defaults is bool() \u003d\u003d True.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c9ca4c8ac5123cb322550536cbf92ba9df1a9ff2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # Reset worker in case SIGHUP is called."},{"line_number":124,"context_line":"    # Note that this is called only in case a service is running in"},{"line_number":125,"context_line":"    # daemon mode."},{"line_number":126,"context_line":"    setup_logging(EXTRA_LOG_LEVEL_DEFAULTS)"},{"line_number":127,"context_line":"    set_config_defaults()"},{"line_number":128,"context_line":"    policy.refresh()"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_a894ad8a","line":126,"range":{"start_line":126,"start_character":18,"end_line":126,"end_character":42},"updated":"2016-09-08 08:29:00.000000000","message":"doesn\u0027t this double EXTRA_LOG_LEVEL_DEFAULTS?","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # Reset worker in case SIGHUP is called."},{"line_number":124,"context_line":"    # Note that this is called only in case a service is running in"},{"line_number":125,"context_line":"    # daemon mode."},{"line_number":126,"context_line":"    setup_logging(EXTRA_LOG_LEVEL_DEFAULTS)"},{"line_number":127,"context_line":"    set_config_defaults()"},{"line_number":128,"context_line":"    policy.refresh()"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_5d002f66","line":126,"range":{"start_line":126,"start_character":18,"end_line":126,"end_character":42},"in_reply_to":"9a89bdaa_a894ad8a","updated":"2016-09-08 13:02:53.000000000","message":"not sure I follow the comment.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"}],"neutron/plugins/ml2/drivers/openvswitch/agent/main.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2d16099b588f869600049abbe940155ae0a6600b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    mod \u003d importutils.import_module(mod_name)"},{"line_number":47,"context_line":"    mod.init_config()"},{"line_number":48,"context_line":"    extra_default_log_levels \u003d []"},{"line_number":49,"context_line":"    if cfg.CONF.OVS.of_interface \u003d\u003d \u0027native\u0027:"},{"line_number":50,"context_line":"        extra_default_log_levels \u003d ["},{"line_number":51,"context_line":"            \u0027ryu.controller.controller\u003dINFO\u0027,"},{"line_number":52,"context_line":"            \u0027ryu.base.app_manager\u003dINFO\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_42ef821d","line":49,"updated":"2016-09-08 07:42:54.000000000","message":"I prefer this to be folded into mod.init_config above.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c9ca4c8ac5123cb322550536cbf92ba9df1a9ff2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    mod \u003d importutils.import_module(mod_name)"},{"line_number":47,"context_line":"    mod.init_config()"},{"line_number":48,"context_line":"    extra_default_log_levels \u003d []"},{"line_number":49,"context_line":"    if cfg.CONF.OVS.of_interface \u003d\u003d \u0027native\u0027:"},{"line_number":50,"context_line":"        extra_default_log_levels \u003d ["},{"line_number":51,"context_line":"            \u0027ryu.controller.controller\u003dINFO\u0027,"},{"line_number":52,"context_line":"            \u0027ryu.base.app_manager\u003dINFO\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_6884650a","line":49,"in_reply_to":"9a89bdaa_42ef821d","updated":"2016-09-08 08:29:00.000000000","message":"+1","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b0ca1289d62f53e738ed14eb6b7c741dd07b0a4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    mod \u003d importutils.import_module(mod_name)"},{"line_number":47,"context_line":"    mod.init_config()"},{"line_number":48,"context_line":"    extra_default_log_levels \u003d []"},{"line_number":49,"context_line":"    if cfg.CONF.OVS.of_interface \u003d\u003d \u0027native\u0027:"},{"line_number":50,"context_line":"        extra_default_log_levels \u003d ["},{"line_number":51,"context_line":"            \u0027ryu.controller.controller\u003dINFO\u0027,"},{"line_number":52,"context_line":"            \u0027ryu.base.app_manager\u003dINFO\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_b5078ac8","line":49,"in_reply_to":"9a89bdaa_42ef821d","updated":"2016-09-08 15:09:43.000000000","message":"Yeah, I was thinking the same thing.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12ec369e81b4c59c11c63e160e5894af244f5f06","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    mod \u003d importutils.import_module(mod_name)"},{"line_number":47,"context_line":"    mod.init_config()"},{"line_number":48,"context_line":"    extra_default_log_levels \u003d []"},{"line_number":49,"context_line":"    if cfg.CONF.OVS.of_interface \u003d\u003d \u0027native\u0027:"},{"line_number":50,"context_line":"        extra_default_log_levels \u003d ["},{"line_number":51,"context_line":"            \u0027ryu.controller.controller\u003dINFO\u0027,"},{"line_number":52,"context_line":"            \u0027ryu.base.app_manager\u003dINFO\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_9d3d572d","line":49,"in_reply_to":"9a89bdaa_6884650a","updated":"2016-09-08 13:02:53.000000000","message":"+, it will isolate the setup into native driver.","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a9555aad4b295996c32f092f951203432971e87","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \u0027OFPHandler\u003dINFO\u0027,"},{"line_number":54,"context_line":"            \u0027OfctlService\u003dINFO\u0027"},{"line_number":55,"context_line":"        ]"},{"line_number":56,"context_line":"    common_config.setup_logging(extra_default_log_levels)"},{"line_number":57,"context_line":"    n_utils.log_opt_values(LOG)"},{"line_number":58,"context_line":"    profiler.setup(\"neutron-ovs-agent\", cfg.CONF.host)"},{"line_number":59,"context_line":"    mod.main()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_54f1d793","line":56,"updated":"2016-09-08 17:57:44.000000000","message":"you could also have a custom setup_logging here that would set it just for the agent. Whatever makes you happy (c).","commit_id":"c394b3c676721dd3763ac999a22e57fc8436bc02"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/main.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cf775a7f6bc652d9a749f1e5c70cd6a92cd6277b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    ryu_cfg.CONF.default_log_level \u003d logging.INFO"},{"line_number":36,"context_line":"    ryu_cfg.CONF.verbose \u003d False"},{"line_number":37,"context_line":"    ryu_log.init_log()"},{"line_number":38,"context_line":"    ryu_log.early_init_log(logging.INFO)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def main():"},{"line_number":41,"context_line":"    app_manager.AppManager.run_apps(["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_0ea96e7b","line":38,"updated":"2016-09-07 03:54:18.000000000","message":"you want to suppress DEBUG logs from ryu modules while keeping DEBUG for the rest of ovs-agent, right?\ni\u0027m afraid there\u0027s no convenient way to do so currently.\n\ni think you can suppress majority of ryu DEBUG logs with:\n\n    import logging\n    for app in [\u0027ryu.base.app_manager\u0027, \u0027OFPHandler\u0027, \u0027OfctlService\u0027]:\n        logger \u003d logging.getLogger(app)\n        logger.setLevel(logging.INFO)","commit_id":"5293364c45d26d45475bc31df2ecb22ad760882c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"07312e9dbe08887d50bbe4f7f760f27db2111865","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    ryu_cfg.CONF.default_log_level \u003d logging.INFO"},{"line_number":36,"context_line":"    ryu_cfg.CONF.verbose \u003d False"},{"line_number":37,"context_line":"    ryu_log.init_log()"},{"line_number":38,"context_line":"    ryu_log.early_init_log(logging.INFO)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def main():"},{"line_number":41,"context_line":"    app_manager.AppManager.run_apps(["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2e339215","line":38,"in_reply_to":"9a89bdaa_0ea96e7b","updated":"2016-09-07 04:18:55.000000000","message":"ack. Thanks, I figured this was going to be my last resort :)","commit_id":"5293364c45d26d45475bc31df2ecb22ad760882c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3767673e6b310ee42ab9dfaee5a897643f4a3d9c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ryu_cfg.CONF(project\u003d\u0027ryu\u0027, args\u003d[])"},{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_listen_host \u003d cfg.CONF.OVS.of_listen_address"},{"line_number":32,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":33,"context_line":"    for app in [\u0027ryu.base.app_manager\u0027, \u0027OFPHandler\u0027, \u0027OfctlService\u0027]:"},{"line_number":34,"context_line":"        logger \u003d logging.getLogger(app)"},{"line_number":35,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_071cf168","line":33,"updated":"2016-09-07 05:47:51.000000000","message":"I would only do this if the current log level is at DEBUG. Otherwise this could cause INFO to leak when verbose \u003d\u003d False.","commit_id":"95003faf569bdbc03a9133163a18ac74b2d95133"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6db05ac3b709e5684d4d7976ed9b9bc001b68165","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ryu_cfg.CONF(project\u003d\u0027ryu\u0027, args\u003d[])"},{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_listen_host \u003d cfg.CONF.OVS.of_listen_address"},{"line_number":32,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":33,"context_line":"    for app in [\u0027ryu.base.app_manager\u0027, \u0027OFPHandler\u0027, \u0027OfctlService\u0027]:"},{"line_number":34,"context_line":"        logger \u003d logging.getLogger(app)"},{"line_number":35,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_67321d61","line":33,"in_reply_to":"9a89bdaa_071cf168","updated":"2016-09-07 06:10:21.000000000","message":"ack","commit_id":"95003faf569bdbc03a9133163a18ac74b2d95133"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7af858d16479b8212f1022ccf6de7aff3d4b7d58","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ryu_cfg.CONF(project\u003d\u0027ryu\u0027, args\u003d[])"},{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_listen_host \u003d cfg.CONF.OVS.of_listen_address"},{"line_number":32,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":33,"context_line":"    for app in [\u0027ryu.base.app_manager\u0027, \u0027OFPHandler\u0027, \u0027OfctlService\u0027]:"},{"line_number":34,"context_line":"        logger \u003d logging.getLogger(app)"},{"line_number":35,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c24d973f","line":33,"in_reply_to":"9a89bdaa_67321d61","updated":"2016-09-07 06:25:46.000000000","message":"Would prefer it was set here if we would.\n\nhttps://github.com/openstack/neutron/blob/750fdb7b223d84d9798acba6317548f1dfc4f1f8/neutron/common/config.py#L92","commit_id":"95003faf569bdbc03a9133163a18ac74b2d95133"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ec8e31f4652dfa7c3b09d83911fd97870afc7f10","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ryu_cfg.CONF(project\u003d\u0027ryu\u0027, args\u003d[])"},{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_listen_host \u003d cfg.CONF.OVS.of_listen_address"},{"line_number":32,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":33,"context_line":"    for app in [\u0027ryu.base.app_manager\u0027, \u0027OFPHandler\u0027, \u0027OfctlService\u0027]:"},{"line_number":34,"context_line":"        logger \u003d logging.getLogger(app)"},{"line_number":35,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_5d06c61d","line":33,"in_reply_to":"9a89bdaa_a25b33f5","updated":"2016-09-07 06:46:07.000000000","message":"+1 for default_log_levels","commit_id":"95003faf569bdbc03a9133163a18ac74b2d95133"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"93d992b36bbcf01bfc7e6cc9d94a74797fd2c9b7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ryu_cfg.CONF(project\u003d\u0027ryu\u0027, args\u003d[])"},{"line_number":31,"context_line":"    ryu_cfg.CONF.ofp_listen_host \u003d cfg.CONF.OVS.of_listen_address"},{"line_number":32,"context_line":"    ryu_cfg.CONF.ofp_tcp_listen_port \u003d cfg.CONF.OVS.of_listen_port"},{"line_number":33,"context_line":"    for app in [\u0027ryu.base.app_manager\u0027, \u0027OFPHandler\u0027, \u0027OfctlService\u0027]:"},{"line_number":34,"context_line":"        logger \u003d logging.getLogger(app)"},{"line_number":35,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_a25b33f5","line":33,"in_reply_to":"9a89bdaa_c24d973f","updated":"2016-09-07 06:27:03.000000000","message":"here is what the format of those levels looks like.\n\nhttps://github.com/openstack/oslo.log/blob/master/oslo_log/_options.py#L19-L29\n\n\nThat way people can override this in the config still.","commit_id":"95003faf569bdbc03a9133163a18ac74b2d95133"}]}
