)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6849b5024e375552288b24aab0c4f47ebdb9524b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"recent code review. We should provide a path to accessing this"},{"line_number":11,"context_line":"variable that is less prone to human errors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint vlan-aware-vms"},{"line_number":14,"context_line":"Change-Id: If2bbfa47927323b66d73d163a1c7161443157409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_c724770e","line":13,"updated":"2016-09-08 11:22:21.000000000","message":"Is it here just to get it in in rc? :)","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"99d32f9d5bfa3088703a3a8037eeb8eba51e1cbf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"recent code review. We should provide a path to accessing this"},{"line_number":11,"context_line":"variable that is less prone to human errors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint vlan-aware-vms"},{"line_number":14,"context_line":"Change-Id: If2bbfa47927323b66d73d163a1c7161443157409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_11b3eb0a","line":13,"in_reply_to":"9a89bdaa_c724770e","updated":"2016-09-08 16:44:43.000000000","message":"sorta :)","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a9c5f8154dc0deb1d1329f11cc9e6ce1dd695690","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"br_int or int_br may lead to confusion as witnessed during a"},{"line_number":10,"context_line":"recent code review. We should provide a path to accessing this"},{"line_number":11,"context_line":"variable that is less prone to human errors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch turns int_br into a private attribute of the OVS"},{"line_number":14,"context_line":"agent class and introduces properties in preparation of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba5da102_3b8186fc","line":11,"updated":"2016-11-04 19:42:24.000000000","message":"https://xkcd.com/927/","commit_id":"f461d1a6f49803116e4e770409c0f86aa890049a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c5f045ba1c056f9d986d877a0e462830abaf191f","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d agent_conf.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @property"},{"line_number":297,"context_line":"    def integration_bridge(self):"},{"line_number":298,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":299,"context_line":"        return self._int_br"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @debtcollector.removals.removed_property("},{"line_number":302,"context_line":"        version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_67c9ebab","line":299,"range":{"start_line":296,"start_character":0,"end_line":299,"end_character":27},"updated":"2016-09-08 11:16:03.000000000","message":"If my below conclusion is incorrect, why do you need this part?","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"c5f045ba1c056f9d986d877a0e462830abaf191f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":299,"context_line":"        return self._int_br"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @debtcollector.removals.removed_property("},{"line_number":302,"context_line":"        version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"},{"line_number":303,"context_line":"    def int_br(self):"},{"line_number":304,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":305,"context_line":"        # TODO(armax): replaces self.int_br with self._int_br when"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_47a147f7","line":302,"range":{"start_line":301,"start_character":0,"end_line":302,"end_character":50},"updated":"2016-09-08 11:16:03.000000000","message":"Are you sure about this removal? You didn\u0027t provide any other option to access `self._int_br`\nCorrect me, if I\u0027m wrong, but wasn\u0027t your intention to point everyone to new propert `integration_bridge`?\nIn this case it would be `moved_function` warning.","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6849b5024e375552288b24aab0c4f47ebdb9524b","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":299,"context_line":"        return self._int_br"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @debtcollector.removals.removed_property("},{"line_number":302,"context_line":"        version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"},{"line_number":303,"context_line":"    def int_br(self):"},{"line_number":304,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":305,"context_line":"        # TODO(armax): replaces self.int_br with self._int_br when"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_a7d4d3eb","line":302,"range":{"start_line":301,"start_character":0,"end_line":302,"end_character":50},"in_reply_to":"9a89bdaa_47a147f7","updated":"2016-09-08 11:22:21.000000000","message":"That\u0027s a good point. It should be moved_property or deprecate() function with message that integration_bridge should be used instead.","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6849b5024e375552288b24aab0c4f47ebdb9524b","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"},{"line_number":303,"context_line":"    def int_br(self):"},{"line_number":304,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":305,"context_line":"        # TODO(armax): replaces self.int_br with self._int_br when"},{"line_number":306,"context_line":"        # this property is no longer required."},{"line_number":307,"context_line":"        return self._int_br"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_272e03fb","line":305,"range":{"start_line":305,"start_character":23,"end_line":305,"end_character":61},"updated":"2016-09-08 11:22:21.000000000","message":"Should it be \"replace self._int_br with self.integration_bridge\" ?","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"61e86cbce0baa16753f2db18cf1b4f2eec0324ad","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"},{"line_number":303,"context_line":"    def int_br(self):"},{"line_number":304,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":305,"context_line":"        # TODO(armax): replaces self.int_br with self._int_br when"},{"line_number":306,"context_line":"        # this property is no longer required."},{"line_number":307,"context_line":"        return self._int_br"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_f38118c5","line":305,"range":{"start_line":305,"start_character":23,"end_line":305,"end_character":61},"in_reply_to":"9a89bdaa_272e03fb","updated":"2016-09-08 21:46:35.000000000","message":"I didn\u0027t think the extra level of indirection was warranted here.","commit_id":"9b6ef0c8444fbc21980f52e920c55cb6b78ff37e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"71cb5608c968dd47ce4e1d0e3c906e49aece3b5f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d agent_conf.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @property"},{"line_number":297,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":298,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":299,"context_line":"    def integration_bridge(self):"},{"line_number":300,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":301,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_2e994020","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":60},"updated":"2016-09-09 09:28:53.000000000","message":"If I understood it correctly, the idea is to provide new name `integration_bridge` instead of `int_br`. So, this debtcollector should be applied to `int_br` not here [1]\n\n[1] http://docs.openstack.org/developer/debtcollector/examples.html#moving-a-property","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3114335b9fa0bcc926251d9b09261cba99effbdf","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d agent_conf.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @property"},{"line_number":297,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":298,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":299,"context_line":"    def integration_bridge(self):"},{"line_number":300,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":301,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_73bb1a0f","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":60},"in_reply_to":"9a89bdaa_2e994020","updated":"2016-09-09 15:11:54.000000000","message":"I swear I read the the documentation!! :)\n\nIt\u0027s been a very stressful time lately!","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f003ec7c27a4e58a580f9fbdee1574a9c2d919ec","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d agent_conf.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @property"},{"line_number":297,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":298,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":299,"context_line":"    def integration_bridge(self):"},{"line_number":300,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":301,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_4eb5a47c","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":60},"in_reply_to":"9a89bdaa_2e994020","updated":"2016-09-09 09:29:59.000000000","message":"Yep, also you don\u0027t need the @property decorator on L296 (future L303) as it\u0027s included in the moved_property itself.","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3114335b9fa0bcc926251d9b09261cba99effbdf","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d agent_conf.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @property"},{"line_number":297,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":298,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":299,"context_line":"    def integration_bridge(self):"},{"line_number":300,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":301,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_134bae2c","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":60},"in_reply_to":"9a89bdaa_4eb5a47c","updated":"2016-09-09 15:11:54.000000000","message":"I followed the doc example there :)","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"16dc66c70880c53a9b2abc62ce3537e7ce19bf45","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d agent_conf.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @property"},{"line_number":297,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":298,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":299,"context_line":"    def integration_bridge(self):"},{"line_number":300,"context_line":"        \"\"\"The integration bridge.\"\"\""},{"line_number":301,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_d60e94e4","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":60},"in_reply_to":"9a89bdaa_73bb1a0f","updated":"2016-09-09 15:31:35.000000000","message":"No worries, we\u0027re here to help!","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5579ede965ca954e5fc90d302a26b0cf3384911b","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        return self._int_br"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @property"},{"line_number":304,"context_line":"    def int_br(self):"},{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_6e5ee877","line":304,"updated":"2016-09-09 09:26:59.000000000","message":"Can we call this something less confusing like \u0027Eyjafjallajökull\u0027?","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3114335b9fa0bcc926251d9b09261cba99effbdf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        return self._int_br"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @property"},{"line_number":304,"context_line":"    def int_br(self):"},{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_b36202ac","line":304,"in_reply_to":"9a89bdaa_6e5ee877","updated":"2016-09-09 15:11:54.000000000","message":"no, because that vulcano got me stranded and I am still upset when I read about it.","commit_id":"92956b87139edb97162351ef36e892f6dc408f61"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"7574d3d984ee81d3fb72530cd856eb14f2eaf582","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @property"},{"line_number":302,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":303,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":304,"context_line":"    def int_br(self):"},{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_09b40d33","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":16},"updated":"2016-09-12 15:41:31.000000000","message":"Please forgive my being an asshole, but currently, you\u0027re telling, that user shouldn\u0027t use \u0027int_br\u0027 and instead use \u0027int_br\u0027.\nThis one should be pointed to \u0027integration_bridge\u0027","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0db5c6d6e0eaee743539468068a87289efd25f8e","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @property"},{"line_number":302,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":303,"context_line":"        \"int_br\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":304,"context_line":"    def int_br(self):"},{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_b8eda990","line":303,"range":{"start_line":303,"start_character":8,"end_line":303,"end_character":16},"in_reply_to":"9a89bdaa_09b40d33","updated":"2016-09-13 19:34:01.000000000","message":"far from it. It\u0027s me who is not putting enough attention into this patch, because my head is clearly somewhere else.","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2e31cb0bc9fc00c83f2d122702d367d6d3090b37","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @int_br.setter"},{"line_number":309,"context_line":"    def int_br(self, value):"},{"line_number":310,"context_line":"        self._int_br \u003d value"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_679b2673","line":308,"updated":"2016-09-12 07:03:27.000000000","message":"why do we need the setter and deleter?","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"94d93572342ceb8cbe754a0e1ce6876079a56f85","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @int_br.setter"},{"line_number":309,"context_line":"    def int_br(self, value):"},{"line_number":310,"context_line":"        self._int_br \u003d value"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_f2ddf7e0","line":308,"in_reply_to":"7a8ec9b2_720727ca","updated":"2016-09-16 07:11:14.000000000","message":"IWAMOTO, hmm.. it looks like, you\u0027re right. Nowhere else int_br is assigned, except completely not related classes (where probably this change also should be applied).","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c8bf084fa8cdbb3ca5aaedb9f0d517f4353dad9f","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @int_br.setter"},{"line_number":309,"context_line":"    def int_br(self, value):"},{"line_number":310,"context_line":"        self._int_br \u003d value"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_fd884e73","line":308,"in_reply_to":"7a8ec9b2_f2ddf7e0","updated":"2016-09-16 15:09:01.000000000","message":"tests","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"9b89efc6d1b5f427e9b7468cf5a3c23609211706","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @int_br.setter"},{"line_number":309,"context_line":"    def int_br(self, value):"},{"line_number":310,"context_line":"        self._int_br \u003d value"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_720727ca","line":308,"in_reply_to":"9a89bdaa_295f11e6","updated":"2016-09-16 06:48:05.000000000","message":"Aren\u0027t we fine without a setter if nobody tries to assign OVSNeutronAgent.int_br?\n\nL170 assigns to _int_br. Anywhere else?","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"7574d3d984ee81d3fb72530cd856eb14f2eaf582","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":306,"context_line":"        return self._int_br"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @int_br.setter"},{"line_number":309,"context_line":"    def int_br(self, value):"},{"line_number":310,"context_line":"        self._int_br \u003d value"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_295f11e6","line":308,"in_reply_to":"9a89bdaa_679b2673","updated":"2016-09-12 15:41:31.000000000","message":"Gary, we need to assign property to _int_br.","commit_id":"d77ac82ca8c068f4d330edef08e9d2cbe8ecfaee"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"d832f4b23ae68c7dfbf451ee79e083dea212f27b","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @property"},{"line_number":313,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":314,"context_line":"        \"integration_bridge\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":315,"context_line":"    def int_br(self):"},{"line_number":316,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":317,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_5216abf1","line":314,"updated":"2016-09-16 06:50:22.000000000","message":"Are we going to do s/int_br/integration_bridge/ throughout the tree?","commit_id":"f461d1a6f49803116e4e770409c0f86aa890049a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1e79e1c8c22b59e255252c4e6f5df321951ec0aa","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @property"},{"line_number":313,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":314,"context_line":"        \"integration_bridge\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":315,"context_line":"    def int_br(self):"},{"line_number":316,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":317,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_daab21d5","line":314,"in_reply_to":"7a8ec9b2_122503c0","updated":"2016-11-04 22:56:46.000000000","message":"Changes to these can be handled as separate patches though, as they are orthogonal to this one.","commit_id":"f461d1a6f49803116e4e770409c0f86aa890049a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"f0f4f216f888040597de6e5311aecb8d4b728054","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @property"},{"line_number":313,"context_line":"    @debtcollector.moves.moved_property("},{"line_number":314,"context_line":"        \"integration_bridge\", version\u003d\"Newton\", removal_version\u003d\"Ocata\")"},{"line_number":315,"context_line":"    def int_br(self):"},{"line_number":316,"context_line":"        \"\"\"Provide backward compatibility with int_br attribute.\"\"\""},{"line_number":317,"context_line":"        return self._int_br"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_122503c0","line":314,"in_reply_to":"7a8ec9b2_5216abf1","updated":"2016-09-16 07:17:18.000000000","message":"I\u0027ve found couple different places where self.int_br is referenced, plus OVSDVRNeutronAgent and OVSFirewallDriver where it\u0027s created.\nProbably, for consistency, this change should also be applied there.","commit_id":"f461d1a6f49803116e4e770409c0f86aa890049a"}]}