)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4a131bccd5afb1202aa05ae3e7634f4e0e8c32dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"block detection led to lots of log noise whenever we"},{"line_number":11,"context_line":"would encounter a deadlock because the savepoint would"},{"line_number":12,"context_line":"go missing. Additionally, since this would happen inside"},{"line_number":13,"context_line":"of another transaction, we couldn\u0027t be guarunteed until"},{"line_number":14,"context_line":"the final commit that this was unique anyway so the whole"},{"line_number":15,"context_line":"transaction could throw a duplicate exception."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_79b6fdf9","line":13,"updated":"2016-09-08 06:51:14.000000000","message":"typo","commit_id":"13336dfd42bf641ded47f49d5bb016ccd8251077"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"806d91cd27876e364cad4c3f0c06a2278bf55b67","unresolved":false,"context_lines":[{"line_number":10,"context_line":"block detection led to lots of log noise whenever we"},{"line_number":11,"context_line":"would encounter a deadlock because the savepoint would"},{"line_number":12,"context_line":"go missing. Additionally, since this would happen inside"},{"line_number":13,"context_line":"of another transaction, we couldn\u0027t be guarunteed until"},{"line_number":14,"context_line":"the final commit that this was unique anyway so the whole"},{"line_number":15,"context_line":"transaction could throw a duplicate exception."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_3de60be8","line":13,"in_reply_to":"9a89bdaa_79b6fdf9","updated":"2016-09-08 13:00:24.000000000","message":"Done","commit_id":"13336dfd42bf641ded47f49d5bb016ccd8251077"}],"neutron/db/provisioning_blocks.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4a131bccd5afb1202aa05ae3e7634f4e0e8c32dc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    _RESOURCE_TO_MODEL_MAP[resource] \u003d model"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def add_provisioning_component(context, object_id, object_type, entity):"},{"line_number":51,"context_line":"    \"\"\"Adds a provisioning block by an entity to a given object."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Adds a provisioning block to the DB for object_id with an identifier"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_d92e29a4","line":50,"updated":"2016-09-08 06:51:14.000000000","message":"Aren\u0027t you assuming that there is going to be an outer transaction somewhere now? Should we add a comment saying that this method must be called like:\n\n  with session.begin(subtransactions\u003dTrue):\n    # foo\n    add_provisioning_component(...)","commit_id":"13336dfd42bf641ded47f49d5bb016ccd8251077"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"806d91cd27876e364cad4c3f0c06a2278bf55b67","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    _RESOURCE_TO_MODEL_MAP[resource] \u003d model"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def add_provisioning_component(context, object_id, object_type, entity):"},{"line_number":51,"context_line":"    \"\"\"Adds a provisioning block by an entity to a given object."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Adds a provisioning block to the DB for object_id with an identifier"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_7d7fb314","line":50,"in_reply_to":"9a89bdaa_d92e29a4","updated":"2016-09-08 13:00:24.000000000","message":"no, it doesn\u0027t require an outer transaction.","commit_id":"13336dfd42bf641ded47f49d5bb016ccd8251077"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"991b5b80d5454877e707cec91a1ab0542e31cb7c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    of the entity that is doing the provisioning. While an object has these"},{"line_number":55,"context_line":"    provisioning blocks present, this module will not emit any callback events"},{"line_number":56,"context_line":"    indicating that provisioning has completed. Any logic that depends on"},{"line_number":57,"context_line":"    multiple disjoint components use these blocks and subscribe to the"},{"line_number":58,"context_line":"    PROVISIONING_COMPLETE event to know when all components have completed."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_f6bdaf02","line":57,"range":{"start_line":57,"start_character":33,"end_line":57,"end_character":36},"updated":"2016-09-08 10:35:39.000000000","message":"If you respin can you change this to \"must use\"?","commit_id":"13336dfd42bf641ded47f49d5bb016ccd8251077"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"806d91cd27876e364cad4c3f0c06a2278bf55b67","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    of the entity that is doing the provisioning. While an object has these"},{"line_number":55,"context_line":"    provisioning blocks present, this module will not emit any callback events"},{"line_number":56,"context_line":"    indicating that provisioning has completed. Any logic that depends on"},{"line_number":57,"context_line":"    multiple disjoint components use these blocks and subscribe to the"},{"line_number":58,"context_line":"    PROVISIONING_COMPLETE event to know when all components have completed."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_5db2efe5","line":57,"range":{"start_line":57,"start_character":33,"end_line":57,"end_character":36},"in_reply_to":"9a89bdaa_f6bdaf02","updated":"2016-09-08 13:00:24.000000000","message":"i think it\u0027s actually supposed to be \u0027may\u0027. :)","commit_id":"13336dfd42bf641ded47f49d5bb016ccd8251077"}]}
