)]}'
{"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"186f93205083572db468dc013cdb758f067d2557","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            seconds\u003dagent_dead_limit)"},{"line_number":197,"context_line":"        return cutoff"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @db_api.retry_db_errors"},{"line_number":200,"context_line":"    def reschedule_resources_from_down_agents(self, agent_type,"},{"line_number":201,"context_line":"                                              get_down_bindings,"},{"line_number":202,"context_line":"                                              agent_id_attr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_4e42ca3f","line":199,"updated":"2016-09-15 00:29:33.000000000","message":"are you sure that these methods are worth retrying? I fear these can be very very expensive.","commit_id":"9a84a3e7899420fe2e9ae59fd42299f679aaf2ab"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1d07c2008455dd804cf8e11e3d8da88f5bd208a7","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            seconds\u003dagent_dead_limit)"},{"line_number":197,"context_line":"        return cutoff"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @db_api.retry_db_errors"},{"line_number":200,"context_line":"    def reschedule_resources_from_down_agents(self, agent_type,"},{"line_number":201,"context_line":"                                              get_down_bindings,"},{"line_number":202,"context_line":"                                              agent_id_attr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_e1a487ba","line":199,"in_reply_to":"7a8ec9b2_21e10fff","updated":"2016-09-15 01:18:44.000000000","message":"these are run on a periodic interval. if we don\u0027t retry, we dump an ugly exception into the logs and then miss until next interval","commit_id":"9a84a3e7899420fe2e9ae59fd42299f679aaf2ab"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"be637015b7feb0777966713c9d7ae2761e9f0ba7","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            seconds\u003dagent_dead_limit)"},{"line_number":197,"context_line":"        return cutoff"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @db_api.retry_db_errors"},{"line_number":200,"context_line":"    def reschedule_resources_from_down_agents(self, agent_type,"},{"line_number":201,"context_line":"                                              get_down_bindings,"},{"line_number":202,"context_line":"                                              agent_id_attr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_ae450eb4","line":199,"in_reply_to":"7a8ec9b2_4e42ca3f","updated":"2016-09-15 00:50:09.000000000","message":"yes, we want to try to keep the correct rescheduling interval","commit_id":"9a84a3e7899420fe2e9ae59fd42299f679aaf2ab"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f88ddb65920d742736a9d3fcf88ef9113cef3a0a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            seconds\u003dagent_dead_limit)"},{"line_number":197,"context_line":"        return cutoff"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @db_api.retry_db_errors"},{"line_number":200,"context_line":"    def reschedule_resources_from_down_agents(self, agent_type,"},{"line_number":201,"context_line":"                                              get_down_bindings,"},{"line_number":202,"context_line":"                                              agent_id_attr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_21e10fff","line":199,"in_reply_to":"7a8ec9b2_ae450eb4","updated":"2016-09-15 01:17:12.000000000","message":"not sure I understand what you mean.","commit_id":"9a84a3e7899420fe2e9ae59fd42299f679aaf2ab"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cb133958e1f15c3217d96514b1cf95b7dc541288","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            seconds\u003dagent_dead_limit)"},{"line_number":197,"context_line":"        return cutoff"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @db_api.retry_db_errors"},{"line_number":200,"context_line":"    def reschedule_resources_from_down_agents(self, agent_type,"},{"line_number":201,"context_line":"                                              get_down_bindings,"},{"line_number":202,"context_line":"                                              agent_id_attr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_81ae6383","line":199,"in_reply_to":"7a8ec9b2_e1a487ba","updated":"2016-09-15 01:24:23.000000000","message":"which is what happens now. This is not a fix to the bug reported.","commit_id":"9a84a3e7899420fe2e9ae59fd42299f679aaf2ab"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"186f93205083572db468dc013cdb758f067d2557","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                # because underlying row is removed, just ignore this issue"},{"line_number":371,"context_line":"                LOG.debug(\"binding was removed concurrently, skipping it\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    @db_api.retry_db_errors"},{"line_number":374,"context_line":"    def remove_networks_from_down_agents(self):"},{"line_number":375,"context_line":"        \"\"\"Remove networks from down DHCP agents if admin state is up."},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_ae47ce49","line":373,"updated":"2016-09-15 00:29:33.000000000","message":"ditto","commit_id":"9a84a3e7899420fe2e9ae59fd42299f679aaf2ab"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"735af28c17ce596b043c726a26c45fe7dd1deea6","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \"\"\"Add a l3 agent to host a router.\"\"\""},{"line_number":218,"context_line":"        if not self.router_supports_scheduling(context, router_id):"},{"line_number":219,"context_line":"            raise l3agentscheduler.RouterDoesntSupportScheduling("},{"line_number":220,"context_line":"                router_id\u003drouter_id)"},{"line_number":221,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":222,"context_line":"            router \u003d self.get_router(context, router_id)"},{"line_number":223,"context_line":"            agent \u003d self._get_agent(context, agent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c31aaac5","side":"PARENT","line":220,"updated":"2016-09-08 11:37:22.000000000","message":"Did you mean to remove this?","commit_id":"d55041daf08b51087859fee6c86d5adaebadefcc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"fea5c0330e7bacca1b788b45e8e119eae157e4cd","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \"\"\"Add a l3 agent to host a router.\"\"\""},{"line_number":218,"context_line":"        if not self.router_supports_scheduling(context, router_id):"},{"line_number":219,"context_line":"            raise l3agentscheduler.RouterDoesntSupportScheduling("},{"line_number":220,"context_line":"                router_id\u003drouter_id)"},{"line_number":221,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":222,"context_line":"            router \u003d self.get_router(context, router_id)"},{"line_number":223,"context_line":"            agent \u003d self._get_agent(context, agent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_1d3dc78e","side":"PARENT","line":220,"in_reply_to":"9a89bdaa_c31aaac5","updated":"2016-09-08 12:53:44.000000000","message":"nope!","commit_id":"d55041daf08b51087859fee6c86d5adaebadefcc"}]}