)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a6dc9ba7c0a59e3b40a9416b8979bb673c349e61","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-08 16:34:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbid importing neutron.tests.* from outside tests subtree"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron-sanity-check tool was importing neutron.tests.base module, which"},{"line_number":10,"context_line":"may be not present on some systems (f.e. RDO splits neutron/tests/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_6db8ce11","line":7,"updated":"2016-09-08 19:03:15.000000000","message":"isn\u0027t tests out of tree technically out of the test subtree? I haven\u0027t looked deeper but I imagine that this has no effect on out of tree code?","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fad19290f52f8738659baeb79349e557b3d3bb59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-08 16:34:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbid importing neutron.tests.* from outside tests subtree"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron-sanity-check tool was importing neutron.tests.base module, which"},{"line_number":10,"context_line":"may be not present on some systems (f.e. RDO splits neutron/tests/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_e8d20cd0","line":7,"in_reply_to":"9a89bdaa_6db8ce11","updated":"2016-09-08 19:39:31.000000000","message":"Not \"out of tree code\" but \"outside of neutron.tests subtree\"","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"72d008c6d6e1dd523c1c3dfa5de63502a2d4e094","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-08 16:34:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Forbid importing neutron.tests.* from outside tests subtree"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron-sanity-check tool was importing neutron.tests.base module, which"},{"line_number":10,"context_line":"may be not present on some systems (f.e. RDO splits neutron/tests/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_e61066ae","line":7,"in_reply_to":"9a89bdaa_6db8ce11","updated":"2016-09-09 08:06:18.000000000","message":"Not sure I grasp the comment intent fully.\n\nBut speaking of out of tree code, I guess it would be safer to provide deprecation proxies for the old locations of the code.","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5637dae9035244149bced0838b12791767176445","unresolved":false,"context_lines":[{"line_number":14,"context_line":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d1374282"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is not the first time when we by mistake import from"},{"line_number":17,"context_line":"neutron.tests.* and break distributions. It\u0027s time to stop it by"},{"line_number":18,"context_line":"proactively forbidding that pattern via a new hacking check."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some functions were moved from neutron.tests.base to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a8ec9b2_863ebcb6","line":17,"updated":"2016-09-14 04:02:32.000000000","message":"Aren\u0027t distributions breaking themselves by splitting apart what we ship? I agree with avoiding importing from tests for sane development, but I don\u0027t think upstream devs should have to care much about packagers breaking apart the repo in ways we don\u0027t test in the gate.","commit_id":"261fc6145afb5e40f9b5ba461141d41c7277bc44"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"61dafa1be86f273401334ad18bf02647f62aa058","unresolved":false,"context_lines":[{"line_number":14,"context_line":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d1374282"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is not the first time when we by mistake import from"},{"line_number":17,"context_line":"neutron.tests.* and break distributions. It\u0027s time to stop it by"},{"line_number":18,"context_line":"proactively forbidding that pattern via a new hacking check."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some functions were moved from neutron.tests.base to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a8ec9b2_42573902","line":17,"in_reply_to":"7a8ec9b2_863ebcb6","updated":"2016-09-14 07:58:19.000000000","message":"You can say that way too. If that\u0027s the stance of the community, let\u0027s document it, and then RDO and others will need to adopt their packaging for the new knowledge.\n\nThough if you agree with enforcing no imports from tests.* in production code, then I am not sure there is value in forcing the change on distros if it will effectively still work.","commit_id":"261fc6145afb5e40f9b5ba461141d41c7277bc44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ff1a0aac42a9843089d4fdacb95db0977d1d7830","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some functions were moved from neutron.tests.base to"},{"line_number":21,"context_line":"neutron.common.utils to fulfill the need requirement. They were moved"},{"line_number":22,"context_line":"using debtcollector, no current consumers should be affected."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1621782"},{"line_number":25,"context_line":"Change-Id: I790777ddcbd1b02218b3db54ae3d5c931d72d4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_542f7387","line":22,"updated":"2016-09-13 01:40:02.000000000","message":"That\u0027s an awful lot of changes for just the sanity check script being affected in the prod code. The magnitude of the changes affecting the test tree and the production tree makes me wonder whether we\u0027d be better off simply making the sanity check do something different when performing the checks or relocating it altogether under. I can totally get behind the hacking check though.","commit_id":"261fc6145afb5e40f9b5ba461141d41c7277bc44"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a1dc072656d67c64c3bee71dc9202831dcc83338","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some functions were moved from neutron.tests.base to"},{"line_number":21,"context_line":"neutron.common.utils to fulfill the need requirement. They were moved"},{"line_number":22,"context_line":"using debtcollector, no current consumers should be affected."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1621782"},{"line_number":25,"context_line":"Change-Id: I790777ddcbd1b02218b3db54ae3d5c931d72d4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a8ec9b2_c764544b","line":22,"in_reply_to":"9a89bdaa_207ffae0","updated":"2016-09-13 18:33:44.000000000","message":"I think that perhaps the sanity checks affected do not necessarily need to follow the strict naming guidelines required by our prod code to see if certain capabilities are available. You could potentially hard code relatively unique names in the check and that will allow to to break the tie. Or am I barking up at the wrong tree?","commit_id":"261fc6145afb5e40f9b5ba461141d41c7277bc44"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"57e556d52f96861e3e44a09c1f65371363c0f1d1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some functions were moved from neutron.tests.base to"},{"line_number":21,"context_line":"neutron.common.utils to fulfill the need requirement. They were moved"},{"line_number":22,"context_line":"using debtcollector, no current consumers should be affected."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1621782"},{"line_number":25,"context_line":"Change-Id: I790777ddcbd1b02218b3db54ae3d5c931d72d4fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_207ffae0","line":22,"in_reply_to":"9a89bdaa_542f7387","updated":"2016-09-13 10:18:12.000000000","message":"Sanity check is not a testing code, so it would be unwise to move it under neutron.tests.* (the latter also has looser quality control, eg. with pylint checks completely disabled).\n\nI understand it would be better if we could handle the case in some less invasive way. But that would also mean duplicating the code in sanity-check tool, which is also not ideal.\n\nRuntime impact of the change does not scare me much because the only visible effect for 3parties should be deprecation warnings if they rely on those moved functions. If you think it\u0027s not worth it that late in the cycle, we could remove warnings for now and introduce them in Ocata. Though since it\u0027s testing code, I don\u0027t care much about a bunch of warnings in 3party test logs, and I would better use this opportunity to be able to kill them in Ocata rather than Pike.\n\nTell me if you think code duplication is justified.","commit_id":"261fc6145afb5e40f9b5ba461141d41c7277bc44"}],"HACKING.rst":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5bf947b2185c71b42bd6d0f06aee293e989d01a8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"- [N340] Check usage of \u003cmodule\u003e.i18n (and neutron.i18n)"},{"line_number":30,"context_line":"- [N341] Check usage of _ from python builtins"},{"line_number":31,"context_line":"- [N342] String interpolation should be delayed at logging calls."},{"line_number":32,"context_line":"- [N343] production code must not import from neutron.tests.*"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Creating Unit Tests"},{"line_number":35,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_f865911d","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":10},"updated":"2016-09-08 13:20:54.000000000","message":"Nit: Capital P","commit_id":"99b2cdf2b66dd69cae02ea00d9205df1b78ada35"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"981b48ea2e1ddce88fd7437e45590bae270954cb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"- [N340] Check usage of \u003cmodule\u003e.i18n (and neutron.i18n)"},{"line_number":30,"context_line":"- [N341] Check usage of _ from python builtins"},{"line_number":31,"context_line":"- [N342] String interpolation should be delayed at logging calls."},{"line_number":32,"context_line":"- [N343] production code must not import from neutron.tests.*"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Creating Unit Tests"},{"line_number":35,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_4f44f448","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":10},"in_reply_to":"9a89bdaa_f865911d","updated":"2016-09-08 13:36:07.000000000","message":"Done","commit_id":"99b2cdf2b66dd69cae02ea00d9205df1b78ada35"}],"neutron/common/utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8e5fe5b8b9f2a9752fdee95d637c88c1c67b600d","unresolved":false,"context_lines":[{"line_number":755,"context_line":"    if max_length:"},{"line_number":756,"context_line":"        length \u003d max_length - max(len(p) for p in prefixes)"},{"line_number":757,"context_line":"        if length \u003c\u003d 0:"},{"line_number":758,"context_line":"            raise ValueError(\"\u0027max_length\u0027 must be longer than all prefixes\")"},{"line_number":759,"context_line":"    else:"},{"line_number":760,"context_line":"        length \u003d 8"},{"line_number":761,"context_line":"    rndchrs \u003d get_random_string(length)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_eae689ae","line":758,"updated":"2016-09-08 17:44:39.000000000","message":"please add in translation","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8aa82683cd31448a338fb878bf21012efd9884eb","unresolved":false,"context_lines":[{"line_number":755,"context_line":"    if max_length:"},{"line_number":756,"context_line":"        length \u003d max_length - max(len(p) for p in prefixes)"},{"line_number":757,"context_line":"        if length \u003c\u003d 0:"},{"line_number":758,"context_line":"            raise ValueError(\"\u0027max_length\u0027 must be longer than all prefixes\")"},{"line_number":759,"context_line":"    else:"},{"line_number":760,"context_line":"        length \u003d 8"},{"line_number":761,"context_line":"    rndchrs \u003d get_random_string(length)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_176bd1b7","line":758,"in_reply_to":"9a89bdaa_eae689ae","updated":"2016-09-08 18:08:14.000000000","message":"Strictly speaking, I should not need to do it as part of this patch because the message was not translated before. So I will send a follow up adding the marker.","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"}],"neutron/hacking/checks.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5bf947b2185c71b42bd6d0f06aee293e989d01a8","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"@flake8ext"},{"line_number":389,"context_line":"def check_no_imports_from_tests(logical_line, filename, noqa):"},{"line_number":390,"context_line":"    \"\"\"N343 production code must not import from neutron.tests.*"},{"line_number":391,"context_line":"    \"\"\""},{"line_number":392,"context_line":"    msg \u003d (\"N343 production code must not import from neutron.tests.*\")"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_6c11c651","line":390,"range":{"start_line":390,"start_character":7,"end_line":390,"end_character":13},"updated":"2016-09-08 13:20:54.000000000","message":"I\u0027d go with \"N343 - P\" to match all other docs. I know L368 has it like this is but IIRC there is a regexp in pyflakes that fetches these numbers from docstrings, so it would be good to be consistent.","commit_id":"99b2cdf2b66dd69cae02ea00d9205df1b78ada35"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"981b48ea2e1ddce88fd7437e45590bae270954cb","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"@flake8ext"},{"line_number":389,"context_line":"def check_no_imports_from_tests(logical_line, filename, noqa):"},{"line_number":390,"context_line":"    \"\"\"N343 production code must not import from neutron.tests.*"},{"line_number":391,"context_line":"    \"\"\""},{"line_number":392,"context_line":"    msg \u003d (\"N343 production code must not import from neutron.tests.*\")"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_af458043","line":390,"range":{"start_line":390,"start_character":7,"end_line":390,"end_character":13},"in_reply_to":"9a89bdaa_6c11c651","updated":"2016-09-08 13:36:07.000000000","message":"Done","commit_id":"99b2cdf2b66dd69cae02ea00d9205df1b78ada35"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"d6752be4e0da11706da24f5eac16f3bdb463349c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        return"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    if \u0027neutron/tests/\u0027 in filename:"},{"line_number":398,"context_line":"        return"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    for regex in tests_imports_dot, tests_imports_from1, tests_imports_from2:"},{"line_number":401,"context_line":"        if re.match(regex, logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_420f6b36","line":398,"updated":"2016-09-08 14:04:57.000000000","message":"Some of the tests for neutron-fwaas/tests import from neutron/tests... wouldn\u0027t this hacking rule, when applied to neutron-fwaas, invalidate those?  \n\nThis list was created by running the following command from within the neutron-fwaas repository:\n    \ngrep -r import neutron_fwaas | cut -f2 -d: | grep neutron.tests | egrep -v \u0027neutron_fwaas|neutron_lib\u0027 | sort | uniq -c | sort -rn\n\n     Count   Imports from neutron                                              \n    \u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n         10 from neutron.tests import base                                  \n          4 from neutron.tests.unit.api.v2 import test_base as test_api_v2\n          2 from neutron.tests.unit.extensions import test_l3 as test_l3_plugin\n          2 from neutron.tests.unit.extensions import base as test_api_v2_extension\n          2 from neutron.tests.unit.db import test_db_base_plugin_v2\n          1 from neutron.tests import fake_notifier                                \n          1 from neutron.tests import base as n_base                           \n          1 from neutron.tests.functional import base","commit_id":"99b2cdf2b66dd69cae02ea00d9205df1b78ada35"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ee080fdd7122d381f8de9f6f90ded23f6a6fe4c3","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        return"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    if \u0027neutron/tests/\u0027 in filename:"},{"line_number":398,"context_line":"        return"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    for regex in tests_imports_dot, tests_imports_from1, tests_imports_from2:"},{"line_number":401,"context_line":"        if re.match(regex, logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_e09dd7bc","line":398,"in_reply_to":"9a89bdaa_420f6b36","updated":"2016-09-08 14:15:50.000000000","message":"fwaas does not rely on hacking checks from neutron repo: https://github.com/openstack/neutron-fwaas/blob/master/tox.ini#L103","commit_id":"99b2cdf2b66dd69cae02ea00d9205df1b78ada35"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"17e0daad6e9b0f82826bd59fded859617d1f7bc6","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"@flake8ext"},{"line_number":389,"context_line":"def check_no_imports_from_tests(logical_line, filename, noqa):"},{"line_number":390,"context_line":"    \"\"\"N343 Production code must not import from neutron.tests.*"},{"line_number":391,"context_line":"    \"\"\""},{"line_number":392,"context_line":"    msg \u003d (\"N343 Production code must not import from neutron.tests.*\")"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_af7bc0bc","line":390,"updated":"2016-09-08 13:48:28.000000000","message":"I meant to put the dash but I think this is also fine :)","commit_id":"142f1666f564d62b6395a9f7da1617798c87a507"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0f4e28154bc1356f2afbb8b99af76d462238217e","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"@flake8ext"},{"line_number":389,"context_line":"def check_no_imports_from_tests(logical_line, filename, noqa):"},{"line_number":390,"context_line":"    \"\"\"N343 Production code must not import from neutron.tests.*"},{"line_number":391,"context_line":"    \"\"\""},{"line_number":392,"context_line":"    msg \u003d (\"N343 Production code must not import from neutron.tests.*\")"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e2307f58","line":390,"in_reply_to":"9a89bdaa_af7bc0bc","updated":"2016-09-08 13:55:33.000000000","message":"There seems to be no single style. I guess I will add to entropy some more.","commit_id":"142f1666f564d62b6395a9f7da1617798c87a507"}],"neutron/tests/functional/agent/linux/base.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ac9f3889b1c9461634ba51b9d78944e8a228c554","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ICMP_BLOCK_RULE \u003d \u0027-p icmp -j DROP\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"get_rand_name \u003d moves.moved_function("},{"line_number":31,"context_line":"    utils.get_rand_name, \u0027get_rand_name\u0027, __name__,"},{"line_number":32,"context_line":"    message\u003d\u0027use \"neutron.common.utils.get_rand_name\" instead\u0027,"},{"line_number":33,"context_line":"    version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_4115f03d","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":37},"updated":"2016-09-16 09:38:07.000000000","message":"wondering why can\u0027t be just \u0027get_rand_name \u003d utils.get_rand_name\u0027","commit_id":"31e1aeb66b2d8abb0d8424e9550693fad6f37c1c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6b5a5d72a06e6937b33afe8a35a6bc1bb842091","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ICMP_BLOCK_RULE \u003d \u0027-p icmp -j DROP\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"get_rand_name \u003d moves.moved_function("},{"line_number":31,"context_line":"    utils.get_rand_name, \u0027get_rand_name\u0027, __name__,"},{"line_number":32,"context_line":"    message\u003d\u0027use \"neutron.common.utils.get_rand_name\" instead\u0027,"},{"line_number":33,"context_line":"    version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_0cdb1f50","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":37},"in_reply_to":"7a8ec9b2_4115f03d","updated":"2016-09-16 09:54:21.000000000","message":"Eventually I would like to have a single place to use the function from.","commit_id":"31e1aeb66b2d8abb0d8424e9550693fad6f37c1c"}],"neutron/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"44449e9506da4dea4d019178541163df172434f0","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                                        \"neutron/common/rpc.py\", dummy_noqa))))"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def test_check_log_warn_deprecated(self):"},{"line_number":338,"context_line":"        bad \u003d \"LOG.warn(_LW(\u0027i am zlatan!\u0027))\""},{"line_number":339,"context_line":"        self.assertEqual("},{"line_number":340,"context_line":"            1, len(list(checks.check_log_warn_deprecated(bad, \u0027f\u0027))))"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_bdc3fb36","line":338,"range":{"start_line":338,"start_character":29,"end_line":338,"end_character":40},"updated":"2016-09-08 12:59:50.000000000","message":":D","commit_id":"64d0455396e77abf4e6427ab6a869dff0de56815"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8ba224174ea1ab8d6b2c15116dc9f1d9ee8f1147","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.assertEqual("},{"line_number":340,"context_line":"            1, len(list(checks.check_log_warn_deprecated(bad, \u0027f\u0027))))"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_check_no_imports_from_tests(self):"},{"line_number":343,"context_line":"        fail_codes \u003d (\u0027from neutron import tests\u0027,"},{"line_number":344,"context_line":"                      \u0027from neutron.tests import base\u0027,"},{"line_number":345,"context_line":"                      \u0027import neutron.tests.base\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_ef105b5b","line":342,"updated":"2016-09-08 16:44:12.000000000","message":"Another check we could add would be to forbid importing from neutron.cmd.sanity_checks / neutron.cmd.sanity. Someone the other day created a sanity check and then started running it at runtime which is exactly the thing sanity checks were designed to prevent.","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eb884d601e5719e55ce419be995920d38dbc5afb","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.assertEqual("},{"line_number":340,"context_line":"            1, len(list(checks.check_log_warn_deprecated(bad, \u0027f\u0027))))"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_check_no_imports_from_tests(self):"},{"line_number":343,"context_line":"        fail_codes \u003d (\u0027from neutron import tests\u0027,"},{"line_number":344,"context_line":"                      \u0027from neutron.tests import base\u0027,"},{"line_number":345,"context_line":"                      \u0027import neutron.tests.base\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_6af19994","line":342,"in_reply_to":"9a89bdaa_ef105b5b","updated":"2016-09-08 16:58:07.000000000","message":"Patches welcome :)","commit_id":"1e2b546c62152532b2ce43e1ddf80b3ed2c457c3"}]}
