)]}'
{"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_eswitch_manager.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"5d405df069a650d534a43470c1047367f7c5ce4d","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            clear_rate_mock.assert_called_once_with(self.PCI_SLOT,"},{"line_number":262,"context_line":"                                                    self.MIN_RATE)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _test_clear_rate(self, rate_type, pci_slot, passed, mac_address):"},{"line_number":265,"context_line":"        with mock.patch(\u0027neutron.plugins.ml2.drivers.mech_sriov.agent.\u0027"},{"line_number":266,"context_line":"                        \u0027eswitch_manager.EmbSwitch.set_device_rate\u0027) \\"},{"line_number":267,"context_line":"                as set_rate_mock, \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_a968f888","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":24},"updated":"2016-09-27 21:21:40.000000000","message":"This is now supposed to be _test__clear_rate. For example this function [1] and its test [2].\n\n1. http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/l3_agentschedulers_db.py#n359\n2. http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/functional/services/l3_router/test_l3_dvr_ha_router_plugin.py#n418","commit_id":"13808567ab4dffd9c408f17235a446feeceb8b12"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"bd26ae3d00313dd8411f5f58ace0513a93e6b565","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            clear_rate_mock.assert_called_once_with(self.PCI_SLOT,"},{"line_number":262,"context_line":"                                                    self.MIN_RATE)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _test_clear_rate(self, rate_type, pci_slot, passed, mac_address):"},{"line_number":265,"context_line":"        with mock.patch(\u0027neutron.plugins.ml2.drivers.mech_sriov.agent.\u0027"},{"line_number":266,"context_line":"                        \u0027eswitch_manager.EmbSwitch.set_device_rate\u0027) \\"},{"line_number":267,"context_line":"                as set_rate_mock, \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_1c3a0a37","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":24},"in_reply_to":"3a98d1f4_dc6c2d0b","updated":"2016-09-28 15:15:16.000000000","message":"I wasn\u0027t concerned about the guidelines, I was just thinking about how one would look up the function for this test. When I see \"test_\u003cfunction name\u003e\" I can search for the function by using \u003cfunction name\u003e, now that the \u0027_\u0027 in the front is missing I will incorrectly assume this is testing \"clear_rate\" instead of \"_clear_rate\". Silly, I know :)\n\nI\u0027m left +0 comment because the comment is not that important and I won\u0027t hold the patch back for it, just something I thought to comment on.","commit_id":"13808567ab4dffd9c408f17235a446feeceb8b12"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7dae80eab78b313885266259c7c426a7cd9d2a71","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            clear_rate_mock.assert_called_once_with(self.PCI_SLOT,"},{"line_number":262,"context_line":"                                                    self.MIN_RATE)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def _test_clear_rate(self, rate_type, pci_slot, passed, mac_address):"},{"line_number":265,"context_line":"        with mock.patch(\u0027neutron.plugins.ml2.drivers.mech_sriov.agent.\u0027"},{"line_number":266,"context_line":"                        \u0027eswitch_manager.EmbSwitch.set_device_rate\u0027) \\"},{"line_number":267,"context_line":"                as set_rate_mock, \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_dc6c2d0b","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":24},"in_reply_to":"5a8bc5a2_a968f888","updated":"2016-09-28 12:32:32.000000000","message":"This is private function, used in test_clear_rate_max_rate_* and test_clear_rate_min_tx_rate_* functions. There is no naming convention for private auxiliary functions.","commit_id":"13808567ab4dffd9c408f17235a446feeceb8b12"}]}