)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4e835bf83acbdd12336fd02f2fb6f4daca9e1ba0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Allocation/Endpoints OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrates the Oslo-Versioned Objects created for VlanAllocation,"},{"line_number":10,"context_line":"VxlanAllocation, VxlanEndpoints, GreAllocation, GreEndpoints,"},{"line_number":11,"context_line":"GeneveAllocation and GeneveEndpoints into the code base."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"3a461143_6c2b4234","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":76},"updated":"2017-02-02 17:24:36.000000000","message":"nit: this word exceeds the limit of the characters for the description","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e56576c30324b23b83b0b57400afaa94a3b231f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Allocation/Endpoints OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrates the Oslo-Versioned Objects created for VlanAllocation,"},{"line_number":10,"context_line":"VxlanAllocation, VxlanEndpoints, GreAllocation, GreEndpoints,"},{"line_number":11,"context_line":"GeneveAllocation and GeneveEndpoints into the code base."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"3a461143_240f8a89","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":76},"in_reply_to":"3a461143_6c2b4234","updated":"2017-02-02 19:28:43.000000000","message":"Done","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"}],"neutron/objects/plugins/ml2/vlanallocation.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4e835bf83acbdd12336fd02f2fb6f4daca9e1ba0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027, \u0027vlan_id\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __eq__(self, other):"},{"line_number":39,"context_line":"        print(\"test\", self.vlan_id)"},{"line_number":40,"context_line":"        return ((self.physical_network, self.vlan_id) \u003d\u003d ("},{"line_number":41,"context_line":"            other.physical_network, other.vlan_id))"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_acdc4a47","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":35},"updated":"2017-02-02 17:24:36.000000000","message":"This was used for testing purposes right?","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e56576c30324b23b83b0b57400afaa94a3b231f2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027, \u0027vlan_id\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __eq__(self, other):"},{"line_number":39,"context_line":"        print(\"test\", self.vlan_id)"},{"line_number":40,"context_line":"        return ((self.physical_network, self.vlan_id) \u003d\u003d ("},{"line_number":41,"context_line":"            other.physical_network, other.vlan_id))"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_18f2f49a","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":35},"in_reply_to":"3a461143_acdc4a47","updated":"2017-02-02 19:28:43.000000000","message":"Done","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4e835bf83acbdd12336fd02f2fb6f4daca9e1ba0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __eq__(self, other):"},{"line_number":39,"context_line":"        print(\"test\", self.vlan_id)"},{"line_number":40,"context_line":"        return ((self.physical_network, self.vlan_id) \u003d\u003d ("},{"line_number":41,"context_line":"            other.physical_network, other.vlan_id))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __hash__(self):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_8c086e93","line":40,"updated":"2017-02-02 17:24:36.000000000","message":"Shouldn\u0027t you use `isinstance` builtin checker?","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e56576c30324b23b83b0b57400afaa94a3b231f2","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __eq__(self, other):"},{"line_number":39,"context_line":"        print(\"test\", self.vlan_id)"},{"line_number":40,"context_line":"        return ((self.physical_network, self.vlan_id) \u003d\u003d ("},{"line_number":41,"context_line":"            other.physical_network, other.vlan_id))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __hash__(self):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_c487a610","line":40,"in_reply_to":"3a461143_8c086e93","updated":"2017-02-02 19:28:43.000000000","message":"As per our discussion keeping it as is for now","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6cb7c2709c7d78daee179140219006107bffa9cc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        return hash((self.physical_network, self.vlan_id))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def get_objects_with_lockmode(cls, context):"},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        Get VlanAllocation object locked for update"},{"line_number":49,"context_line":"        :param context: DB context"}],"source_content_type":"text/x-python","patch_set":34,"id":"fa31d9ce_080eff3a","line":46,"updated":"2017-02-13 12:09:05.000000000","message":"lock-mode should not be supported for OVO, we should use compare and swap. More info in patch:\nhttps://review.openstack.org/#/c/423581/","commit_id":"1cf91cb5158a020d10f403c5c671b80f445c725b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9aaeb75519e02556ad361624709411e9a0b010e4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param context: DB context"},{"line_number":50,"context_line":"        :return: VlanAllocation list"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        db_objs \u003d context.session.query(cls.db_model).with_lockmode(\u0027update\u0027)"},{"line_number":53,"context_line":"        return [cls._load_object(context, db_obj) for db_obj in db_objs]"}],"source_content_type":"text/x-python","patch_set":36,"id":"ffe62b97_6adbbd1a","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":77},"updated":"2017-03-27 15:30:02.000000000","message":"that definitely is not needed, the code no longer uses locks.","commit_id":"f3dc00e6a89dd62dd09ff816b80617553d728500"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c6fa04e18713f0721d43f73cd277e0738321a81b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param context: DB context"},{"line_number":50,"context_line":"        :return: VlanAllocation list"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        db_objs \u003d context.session.query(cls.db_model).with_lockmode(\u0027update\u0027)"},{"line_number":53,"context_line":"        return [cls._load_object(context, db_obj) for db_obj in db_objs]"}],"source_content_type":"text/x-python","patch_set":36,"id":"ffe62b97_e670e10a","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":77},"in_reply_to":"ffe62b97_6adbbd1a","updated":"2017-03-28 20:58:58.000000000","message":"removed it","commit_id":"f3dc00e6a89dd62dd09ff816b80617553d728500"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b0da05f8a384826e2a998a12c51a6f6724f7f9c4","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_487c0171","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":61},"updated":"2017-03-29 23:44:43.000000000","message":"can you please explain why code in this method has been moved from  neutron/plugins/ml2/drivers/type_vlan.py ?","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4f9c94dc8da4f5bfef5e0ac9b06d6e0c013e8625","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"dfeb2761_cb38cfd4","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":61},"in_reply_to":"dfeb2761_7f03c643","updated":"2017-03-31 20:35:01.000000000","message":"Which call do you envision?","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ed5e2f01d5eabc0a0707952a7757a369e227fbe9","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"dfeb2761_aaad4f89","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":61},"in_reply_to":"dfeb2761_cb38cfd4","updated":"2017-04-03 18:48:53.000000000","message":"proposed change in nova lock-free quota implementation [1] made sense to me. \n\"The UPDATE statement will include a WHERE condition that will ensure that the rows are only updated in the table IFF the current row values are what the thread thought they were when previously reading the rows with the SELECT statement\"\nAfaik, UPDATE WHERE is in the process of being implemented in [2]\n\n[1] https://github.com/openstack/nova-specs/blob/master/specs/kilo/approved/lock-free-quota-management.rst\n\n[2] https://review.openstack.org/#/c/452266/","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"08de28364c5fb2a76244bf42d8c1ff16859460c9","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"dfeb2761_7f03c643","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":61},"in_reply_to":"ffe62b97_39aa15d2","updated":"2017-03-31 17:58:30.000000000","message":"As you mentioned this method used to have with_lockmode(\u0027update\u0027) and according to [1] it seems that logic for removing with_lockmode(\u0027update\u0027)  has already been committed.\n\nWhat is confusing to me is that why these sqlalchemy queries can\u0027t be replaced by ovo calls.\n\n[1] https://github.com/openstack/neutron/commit/e53ebfc4f140c03a7d94a75f44c49e8fcfe54f7c#diff-441e123742581c5d1da67bf722508f1b","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_39aa15d2","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":61},"in_reply_to":"ffe62b97_487c0171","updated":"2017-03-30 16:09:48.000000000","message":"Moved it as class method because this method used to have lock\n_mode with update which is replaced by line","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_1953d1e4","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":61},"in_reply_to":"ffe62b97_487c0171","updated":"2017-03-30 16:09:48.000000000","message":"This method used to have with_lockmode(\u0027update\u0027) which is handled by the lines 89-92. So converting all the queries to use objects was making it complicated and causing test failures. So IMHO it\u0027s safe to move this as a class method instead of breaking the functionality","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"811e58037e1b78da58831ae27c172d35ed44673f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"},{"line_number":49,"context_line":"            allocations \u003d dict()"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_da57bb25","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":43},"updated":"2017-03-29 23:02:53.000000000","message":"meh","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    @db_api.retry_db_errors"},{"line_number":45,"context_line":"    def sync_vlan_allocations(cls, ctx, network_vlan_ranges):"},{"line_number":46,"context_line":"        # ctx \u003d context.get_admin_context()"},{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"},{"line_number":49,"context_line":"            allocations \u003d dict()"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_9907e119","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":43},"in_reply_to":"ffe62b97_da57bb25","updated":"2017-03-30 16:09:48.000000000","message":"Done","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b0da05f8a384826e2a998a12c51a6f6724f7f9c4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"},{"line_number":49,"context_line":"            allocations \u003d dict()"},{"line_number":50,"context_line":"            allocs \u003d ctx.session.query(vlan_alloc_model.VlanAllocation)"},{"line_number":51,"context_line":"            for alloc in allocs:"},{"line_number":52,"context_line":"                if alloc.physical_network not in allocations:"},{"line_number":53,"context_line":"                    allocations[alloc.physical_network] \u003d set()"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_882a097c","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":70},"updated":"2017-03-29 23:44:43.000000000","message":"Also can\u0027t this be replaced by get_objects method, given that this patch does integration for VlanAllocation?","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":48,"context_line":"            # get existing allocations for all physical networks"},{"line_number":49,"context_line":"            allocations \u003d dict()"},{"line_number":50,"context_line":"            allocs \u003d ctx.session.query(vlan_alloc_model.VlanAllocation)"},{"line_number":51,"context_line":"            for alloc in allocs:"},{"line_number":52,"context_line":"                if alloc.physical_network not in allocations:"},{"line_number":53,"context_line":"                    allocations[alloc.physical_network] \u003d set()"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_995801fb","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":70},"in_reply_to":"ffe62b97_882a097c","updated":"2017-03-30 16:09:48.000000000","message":"As explained above","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b0da05f8a384826e2a998a12c51a6f6724f7f9c4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                        physical_network\u003dphysical_network,"},{"line_number":101,"context_line":"                        vlan_id\u003dvlan_id,"},{"line_number":102,"context_line":"                        allocated\u003dFalse)"},{"line_number":103,"context_line":"                    ctx.session.add(alloc)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # remove from table unallocated vlans for any unconfigured"},{"line_number":106,"context_line":"            # physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_48cac1a0","line":103,"range":{"start_line":103,"start_character":2,"end_line":103,"end_character":42},"updated":"2017-03-29 23:44:43.000000000","message":"ditto","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                        physical_network\u003dphysical_network,"},{"line_number":101,"context_line":"                        vlan_id\u003dvlan_id,"},{"line_number":102,"context_line":"                        allocated\u003dFalse)"},{"line_number":103,"context_line":"                    ctx.session.add(alloc)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # remove from table unallocated vlans for any unconfigured"},{"line_number":106,"context_line":"            # physical networks"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_f9682d88","line":103,"range":{"start_line":103,"start_character":2,"end_line":103,"end_character":42},"in_reply_to":"ffe62b97_48cac1a0","updated":"2017-03-30 16:09:48.000000000","message":"As explained above","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b0da05f8a384826e2a998a12c51a6f6724f7f9c4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                  {\u0027vlan_id\u0027: alloc.vlan_id,"},{"line_number":113,"context_line":"                                   \u0027physical_network\u0027:"},{"line_number":114,"context_line":"                                   alloc.physical_network})"},{"line_number":115,"context_line":"                        ctx.session.delete(alloc)"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_08c839a3","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":49},"updated":"2017-03-29 23:44:43.000000000","message":"ditto","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                  {\u0027vlan_id\u0027: alloc.vlan_id,"},{"line_number":113,"context_line":"                                   \u0027physical_network\u0027:"},{"line_number":114,"context_line":"                                   alloc.physical_network})"},{"line_number":115,"context_line":"                        ctx.session.delete(alloc)"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_190191b0","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":49},"in_reply_to":"ffe62b97_08c839a3","updated":"2017-03-30 16:09:48.000000000","message":"As explained above","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"}],"neutron/plugins/ml2/drivers/helpers.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class SegmentTypeDriverOVO(BaseTypeDriver):"},{"line_number":164,"context_line":"    \"\"\"SegmentTypeDriver for segment allocation for OVO."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    Provide methods helping to perform segment allocation fully or partially"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_e3079dc7","line":163,"updated":"2016-10-03 23:00:15.000000000","message":"I don\u0027t think we need this extra class, we can modify the original class to handle this appropriately by doing this:\n\n1) Modify original __init__ method to do what you\u0027re doing on L173.\n2) Decorate the allocate_fully_specified_segment and allocate_partially_specified_segment methods with a wrapper that will turn a session passed in to a Context while logging that the session argument is deprecated.\n3) Create patches in any external to neutron repos that call these methods to use context instead of session and depends-on to this patch.\n\nI believe that should take care of the issues.","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"565701d2bb6bc6d47e6f0576fdf0cb6120023aae","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def __init__(self, model):"},{"line_number":60,"context_line":"        super(SegmentTypeDriver, self).__init__()"},{"line_number":61,"context_line":"        if issubclass(model, base_obj.NeutronDbObject):"},{"line_number":62,"context_line":"            self.obj \u003d model"},{"line_number":63,"context_line":"            self.model \u003d model.db_model"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            self.model \u003d model"}],"source_content_type":"text/x-python","patch_set":38,"id":"dfeb2761_ff0476c8","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":28},"updated":"2017-03-31 17:47:19.000000000","message":"is it used anywhere?","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class EndpointTunnelTypeDriver(TunnelTypeDriver):"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def __init__(self, segment_model, endpoint_model):"},{"line_number":265,"context_line":"        super(EndpointTunnelTypeDriver, self).__init__(segment_model)"},{"line_number":266,"context_line":"        self.endpoint_model \u003d endpoint_model"},{"line_number":267,"context_line":"        self.segmentation_key \u003d next(iter(self.primary_keys))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_e3bcfddd","line":264,"updated":"2016-10-03 23:00:15.000000000","message":"we can change this to be endpoint_object and any code taht is instantiating this needs to be updated to use the object instead of model.  Currently, this causes a dependency on GreEndpoints, GeneveEndpoints, and VxlanEndpoints objects which are in separate reviews, so this particular patch won\u0027t be complete until it has access to the code in thsoe patches.","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def get_endpoint_by_host(self, host):"},{"line_number":270,"context_line":"        LOG.debug(\"get_endpoint_by_host() called for host %s\", host)"},{"line_number":271,"context_line":"        session \u003d db_api.get_session()"},{"line_number":272,"context_line":"        return (session.query(self.endpoint_model)."},{"line_number":273,"context_line":"                filter_by(host\u003dhost).first())"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_6398ed78","line":271,"updated":"2016-10-03 23:00:15.000000000","message":"I think you can get away with just instatiating neutron.context.Context() and passing that into self.endpoint_object.get_objects method you will be changing L272 to.\n\nShould be able to do that for all instances in this code where a session is retrieved by calling db_api.get_session().","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":428,"context_line":"class TunnelTypeDriverOVO(helpers.SegmentTypeDriverOVO):"},{"line_number":429,"context_line":"    \"\"\"Define stable abstract interface for ML2 type drivers for OVO."},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    tunnel type networks rely on tunnel endpoints. This class defines abstract"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_e32ebd41","line":428,"updated":"2016-10-03 23:00:15.000000000","message":"I don\u0027t think we need this new interface either.","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        pass"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"class EndpointTunnelTypeDriverOVO(TunnelTypeDriverOVO):"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def __init__(self, segment_obj, endpoint_obj):"},{"line_number":524,"context_line":"        super(EndpointTunnelTypeDriverOVO, self).__init__(segment_obj)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_831ed909","line":521,"updated":"2016-10-03 23:00:15.000000000","message":"Or this new class.","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"8fd15bdc9ab04221533626ff9b864c58af68215e","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        super(EndpointTunnelTypeDriver, self).__init__(segment_model)"},{"line_number":267,"context_line":"        self.endpoint_model \u003d endpoint_model"},{"line_number":268,"context_line":"        self.segmentation_key \u003d next(iter(self.primary_keys))"},{"line_number":269,"context_line":"        self.ctx \u003d context.Context()"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def get_endpoint_by_host(self, host):"},{"line_number":272,"context_line":"        LOG.debug(\"get_endpoint_by_host() called for host %s\", host)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa6399be_1ca39c50","line":269,"updated":"2016-10-12 16:00:43.000000000","message":"This is the problem here.  This makes you use the same session in every method below whereas the previous code got a new session for every method.  You should just create a new context in every method instead.","commit_id":"94fa9171a00ae4bf993f5bb9f9041225095fbc5b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4e835bf83acbdd12336fd02f2fb6f4daca9e1ba0","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def _add_endpoint(self, ip, host, **kwargs):"},{"line_number":384,"context_line":"        LOG.debug(\"_add_endpoint() called for ip %s\", ip)"},{"line_number":385,"context_line":"        session \u003d db_api.get_writer_session()"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        try:"},{"line_number":388,"context_line":"            endpoint \u003d self.endpoint_model(ip_address\u003dip, host\u003dhost, **kwargs)"},{"line_number":389,"context_line":"            endpoint.save(session)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_0c5b9e55","line":386,"updated":"2017-02-02 17:24:36.000000000","message":"meh","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e56576c30324b23b83b0b57400afaa94a3b231f2","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def _add_endpoint(self, ip, host, **kwargs):"},{"line_number":384,"context_line":"        LOG.debug(\"_add_endpoint() called for ip %s\", ip)"},{"line_number":385,"context_line":"        session \u003d db_api.get_writer_session()"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        try:"},{"line_number":388,"context_line":"            endpoint \u003d self.endpoint_model(ip_address\u003dip, host\u003dhost, **kwargs)"},{"line_number":389,"context_line":"            endpoint.save(session)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_3846d0bf","line":386,"in_reply_to":"3a461143_0c5b9e55","updated":"2017-02-02 19:28:43.000000000","message":"Done","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"565701d2bb6bc6d47e6f0576fdf0cb6120023aae","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    def __init__(self, segment_model, endpoint_model):"},{"line_number":341,"context_line":"        super(EndpointTunnelTypeDriver, self).__init__(segment_model)"},{"line_number":342,"context_line":"        if issubclass(endpoint_model, base_obj.NeutronDbObject):"},{"line_number":343,"context_line":"            self.endpoint_obj \u003d endpoint_model"},{"line_number":344,"context_line":"            self.endpoint_model \u003d endpoint_model.db_model"},{"line_number":345,"context_line":"        else:"},{"line_number":346,"context_line":"            self.endpoint_model \u003d endpoint_model"}],"source_content_type":"text/x-python","patch_set":38,"id":"dfeb2761_bf0eeee2","line":343,"range":{"start_line":343,"start_character":12,"end_line":343,"end_character":46},"updated":"2017-03-31 17:47:19.000000000","message":"is it used?","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"}],"neutron/plugins/ml2/drivers/type_vlan.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4e835bf83acbdd12336fd02f2fb6f4daca9e1ba0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":71,"context_line":"            # get existing allocations for all physical networks"},{"line_number":72,"context_line":"            allocations \u003d dict()"},{"line_number":73,"context_line":"            allocs \u003d vlan_alloc_obj.VlanAllocation.get_objects_with_lockmode("},{"line_number":74,"context_line":"                ctx)"},{"line_number":75,"context_line":"            for alloc in allocs:"},{"line_number":76,"context_line":"                if alloc.physical_network not in allocations:"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_ec0bb229","line":73,"range":{"start_line":73,"start_character":51,"end_line":73,"end_character":76},"updated":"2017-02-02 17:24:36.000000000","message":"+1","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e56576c30324b23b83b0b57400afaa94a3b231f2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        with db_api.context_manager.writer.using(ctx):"},{"line_number":71,"context_line":"            # get existing allocations for all physical networks"},{"line_number":72,"context_line":"            allocations \u003d dict()"},{"line_number":73,"context_line":"            allocs \u003d vlan_alloc_obj.VlanAllocation.get_objects_with_lockmode("},{"line_number":74,"context_line":"                ctx)"},{"line_number":75,"context_line":"            for alloc in allocs:"},{"line_number":76,"context_line":"                if alloc.physical_network not in allocations:"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_b88720d6","line":73,"range":{"start_line":73,"start_character":51,"end_line":73,"end_character":76},"in_reply_to":"3a461143_ec0bb229","updated":"2017-02-02 19:28:43.000000000","message":"Done","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"811e58037e1b78da58831ae27c172d35ed44673f","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        ranges \u003d self.network_vlan_ranges.get(physical_network, [])"},{"line_number":144,"context_line":"        inside \u003d any(lo \u003c\u003d vlan_id \u003c\u003d hi for lo, hi in ranges)"},{"line_number":145,"context_line":"        count \u003d False"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":148,"context_line":"            alloc \u003d vlan_alloc_obj.VlanAllocation.get_object("}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_fde39903","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":13},"updated":"2017-03-29 23:02:53.000000000","message":"nit: this could be renamed as \"modified\" or something that makes more sense","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        ranges \u003d self.network_vlan_ranges.get(physical_network, [])"},{"line_number":144,"context_line":"        inside \u003d any(lo \u003c\u003d vlan_id \u003c\u003d hi for lo, hi in ranges)"},{"line_number":145,"context_line":"        count \u003d False"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":148,"context_line":"            alloc \u003d vlan_alloc_obj.VlanAllocation.get_object("}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_39f57584","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":13},"in_reply_to":"ffe62b97_fde39903","updated":"2017-03-30 16:09:48.000000000","message":"I was retaining the original variable name as I didn\u0027t want to introduce any unrelated change in line 167. Thoughts?","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd777a525b2ccc84dad426be2bdc29b49d9ed298","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @db_api.retry_db_errors"},{"line_number":63,"context_line":"    def _sync_vlan_allocations(self):"},{"line_number":64,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":65,"context_line":"        vlan_alloc_obj.VlanAllocation.sync_vlan_allocations("},{"line_number":66,"context_line":"            ctx, self.network_vlan_ranges.items())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get_type(self):"}],"source_content_type":"text/x-python","patch_set":38,"id":"7ffa3b31_4bedf1ed","line":65,"updated":"2017-04-16 01:40:15.000000000","message":"+1. I don\u0027t think the sync logic should be in the allocation OVO object.","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"565701d2bb6bc6d47e6f0576fdf0cb6120023aae","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @db_api.retry_db_errors"},{"line_number":63,"context_line":"    def _sync_vlan_allocations(self):"},{"line_number":64,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":65,"context_line":"        vlan_alloc_obj.VlanAllocation.sync_vlan_allocations("},{"line_number":66,"context_line":"            ctx, self.network_vlan_ranges.items())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get_type(self):"}],"source_content_type":"text/x-python","patch_set":38,"id":"dfeb2761_ff2d9646","line":65,"updated":"2017-03-31 17:47:19.000000000","message":"I am not too happy about moving the code around. I would like to explore exposing filter_by().update() semantics in OVO instead: https://review.openstack.org/#/c/452266/","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f9860b1ef6c104ca93851bb77047050e3dd2a591","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @db_api.retry_db_errors"},{"line_number":63,"context_line":"    def _sync_vlan_allocations(self):"},{"line_number":64,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":65,"context_line":"        vlan_alloc_obj.VlanAllocation.sync_vlan_allocations("},{"line_number":66,"context_line":"            ctx, self.network_vlan_ranges.items())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get_type(self):"}],"source_content_type":"text/x-python","patch_set":38,"id":"5ff73747_8305427d","line":65,"in_reply_to":"7ffa3b31_4bedf1ed","updated":"2017-04-21 23:40:41.000000000","message":"Agreed. Marking the patch with workflow -1 till this patch [1] is merged.\n\n[1] https://review.openstack.org/#/c/452266/","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"}],"neutron/plugins/ml2/drivers/type_vxlan.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self):"},{"line_number":51,"context_line":"        super(VxlanTypeDriver, self).__init__("},{"line_number":52,"context_line":"            vxlan_model.VxlanAllocation, vxlan_model.VxlanEndpoints)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_type(self):"},{"line_number":55,"context_line":"        return p_const.TYPE_VXLAN"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_4384d109","line":52,"range":{"start_line":52,"start_character":41,"end_line":52,"end_character":67},"updated":"2016-10-03 23:00:15.000000000","message":"as i know you know, this would need to be changed to use the object instead of the model.","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7c606d5748e2f006418fb6addec8bb606adcddf3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return mtu - p_const.VXLAN_ENCAP_OVERHEAD if mtu else 0"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class VxlanTypeDriverOVO(type_tunnel.EndpointTunnelTypeDriverOVO):"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __init__(self):"},{"line_number":84,"context_line":"        super(VxlanTypeDriverOVO, self).__init__("}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_238185fb","line":81,"updated":"2016-10-03 23:00:15.000000000","message":"i don\u0027t think you\u0027ll need this with the changes suggested inthe other modules.","commit_id":"549c25b4cf8faeb592b6ef02571f1f210f2c54a4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4e835bf83acbdd12336fd02f2fb6f4daca9e1ba0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        mtu \u003d super(VxlanTypeDriver, self).get_mtu()"},{"line_number":66,"context_line":"        return mtu - p_const.VXLAN_ENCAP_OVERHEAD if mtu else 0"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_ff3d12bc","line":68,"updated":"2017-02-02 17:24:36.000000000","message":"meh","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e56576c30324b23b83b0b57400afaa94a3b231f2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        mtu \u003d super(VxlanTypeDriver, self).get_mtu()"},{"line_number":66,"context_line":"        return mtu - p_const.VXLAN_ENCAP_OVERHEAD if mtu else 0"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a461143_c4a086a8","line":68,"in_reply_to":"3a461143_ff3d12bc","updated":"2017-02-02 19:28:43.000000000","message":"Done","commit_id":"6bf0f673c31cf0be2fc925dc35f667c38b3ff6dd"}],"neutron/tests/unit/plugins/ml2/drivers/test_type_vlan.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"811e58037e1b78da58831ae27c172d35ed44673f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            self.assertRaises(SystemExit,"},{"line_number":62,"context_line":"                              self.driver._parse_network_vlan_ranges)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_allocation(self, context, segment):"},{"line_number":65,"context_line":"        vlan_alloc \u003d vlan_alloc_obj.VlanAllocation.get_objects("},{"line_number":66,"context_line":"            context, physical_network\u003dsegment[api.PHYSICAL_NETWORK],"},{"line_number":67,"context_line":"            vlan_id\u003dsegment[api.SEGMENTATION_ID])"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_fdccb989","line":64,"updated":"2017-03-29 23:02:53.000000000","message":"You can use a pager to limit the number of objects","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3ee6607fece7afc00a98c15440f084e0f841fcc0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            self.assertRaises(SystemExit,"},{"line_number":62,"context_line":"                              self.driver._parse_network_vlan_ranges)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_allocation(self, context, segment):"},{"line_number":65,"context_line":"        vlan_alloc \u003d vlan_alloc_obj.VlanAllocation.get_objects("},{"line_number":66,"context_line":"            context, physical_network\u003dsegment[api.PHYSICAL_NETWORK],"},{"line_number":67,"context_line":"            vlan_id\u003dsegment[api.SEGMENTATION_ID])"}],"source_content_type":"text/x-python","patch_set":37,"id":"ffe62b97_ca9fc563","line":64,"in_reply_to":"ffe62b97_fdccb989","updated":"2017-03-30 16:09:48.000000000","message":"Done","commit_id":"0c7b919f791b34f1da0fd98d0ce5472409b2d9dd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"565701d2bb6bc6d47e6f0576fdf0cb6120023aae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    PROVIDER_NET: [],"},{"line_number":38,"context_line":"    TENANT_NET: [(VLAN_MIN + 5, VLAN_MAX + 5)],"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":"CORE_PLUGIN \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class VlanTypeTest(testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":38,"id":"dfeb2761_5f1ec20c","line":40,"updated":"2017-03-31 17:47:19.000000000","message":"actually since it\u0027s ml2 test, probably makes sense to register ml2 instead.","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"565701d2bb6bc6d47e6f0576fdf0cb6120023aae","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_allocation(self, context, segment):"},{"line_number":66,"context_line":"        pager \u003d base_obj.Pager(limit\u003d1)"},{"line_number":67,"context_line":"        vlan_alloc \u003d vlan_alloc_obj.VlanAllocation.get_objects("},{"line_number":68,"context_line":"            context, _pager\u003dpager, physical_network\u003dsegment["},{"line_number":69,"context_line":"                api.PHYSICAL_NETWORK],"},{"line_number":70,"context_line":"            vlan_id\u003dsegment[api.SEGMENTATION_ID])"}],"source_content_type":"text/x-python","patch_set":38,"id":"dfeb2761_1f183a1b","line":67,"updated":"2017-03-31 17:47:19.000000000","message":"can\u0027t we use get_object here?","commit_id":"f18916c79b8e761988f3451281a59112b2c68487"}]}
