)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23061,"name":"Trinath Somanchi","username":"strinath","inactive":true},"change_message_id":"7bf23ed482382addc4cf82bb6d58d02fc9b6c7f8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently it is possible to assign multiple"},{"line_number":10,"context_line":"gateway ports to a router. This patch tries"},{"line_number":11,"context_line":"to prevent this from happening."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1430345"},{"line_number":14,"context_line":"Change-Id: I0579792aa816df6c512e9b3f45cbc4e2450e8db4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a71b18c_b082e892","line":12,"updated":"2016-12-02 08:49:52.000000000","message":"Can you also describe what functionality is being leveraged with this effort? Also what is misleading with the current behavior? This helps in understanding the implementation easy.","commit_id":"a35658c0edb7bd900decafbedcd2aafedfff86bc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd4f3d4ddb8b05eb731a0c03a9d9d573af920fed","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently it is possible to assign multiple"},{"line_number":10,"context_line":"gateway ports to a router. This patch tries"},{"line_number":11,"context_line":"to prevent this from happening."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1430345"},{"line_number":14,"context_line":"Change-Id: I0579792aa816df6c512e9b3f45cbc4e2450e8db4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a3905b3_a7b95a17","line":12,"in_reply_to":"3a71b18c_b082e892","updated":"2017-01-23 07:14:13.000000000","message":"Done","commit_id":"a35658c0edb7bd900decafbedcd2aafedfff86bc"}],"neutron/db/l3_db.py":[{"author":{"_account_id":23061,"name":"Trinath Somanchi","username":"strinath","inactive":true},"change_message_id":"7bf23ed482382addc4cf82bb6d58d02fc9b6c7f8","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            if ( router.gw_port and"},{"line_number":782,"context_line":"                 port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW):"},{"line_number":783,"context_line":"                msg \u003d _(\"Router already has a gateway port\")"},{"line_number":784,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":785,"context_line":"            revert_value \u003d {\u0027device_id\u0027: \u0027\u0027,"},{"line_number":786,"context_line":"                            \u0027device_owner\u0027: port[\u0027device_owner\u0027]}"},{"line_number":787,"context_line":"            with p_utils.update_port_on_error("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_2b210da0","line":784,"updated":"2016-12-02 08:49:52.000000000","message":"Does this require a testcase ?","commit_id":"a35658c0edb7bd900decafbedcd2aafedfff86bc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9743a88b821e9ce3c199297d1ef7b7274c4a7c6d","unresolved":false,"context_lines":[{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        if add_by_port:"},{"line_number":815,"context_line":"            port_id \u003d interface_info[\u0027port_id\u0027]"},{"line_number":816,"context_line":"            port \u003d self._check_router_port(context, port_id, \u0027\u0027)"},{"line_number":817,"context_line":"            if (router.gw_port and"},{"line_number":818,"context_line":"                port[\u0027device_owner\u0027] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW):"},{"line_number":819,"context_line":"                msg \u003d _(\"Router already has a gateway port\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_fbe66442","line":816,"updated":"2017-01-24 06:26:39.000000000","message":"This code path isn\u0027t adding another gateway port, it\u0027s adding a regular interface. The _add_interface_by_port method will change the device owner to \u0027network:router_interface\u0027 anyway so it doesn\u0027t matter if someone has already set a device owner to something else.\n\nI don\u0027t think the bug in the commit message is even valid anymore. That behavior was implicitly fixed a long time ago by enforcing the device owner in the port update on L826.","commit_id":"67cb6eec5e8e5615abb5e2a1c7d5cd0aad1781ec"}]}