)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_tun.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"074d1dbc38048f8543dd1e8be4635115ebb6ccd4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d12),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_e8b383e7","line":101,"range":{"start_line":101,"start_character":32,"end_line":101,"end_character":41},"updated":"2016-09-12 08:20:39.000000000","message":"16?","commit_id":"4999bd8594ea11694d090b1d5d31f69c6f14144f"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"3a6b4f030bfef7e0ab8d1e44f544122af11cee64","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d12),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_d9857ccf","line":101,"range":{"start_line":101,"start_character":32,"end_line":101,"end_character":41},"in_reply_to":"9a89bdaa_e8b383e7","updated":"2016-09-13 01:28:21.000000000","message":"OMG\n\nthanks.","commit_id":"4999bd8594ea11694d090b1d5d31f69c6f14144f"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"9db0195f3de7554f0c589f14a9d11fa413efa273","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        flow_specs \u003d ["},{"line_number":93,"context_line":"            ofpp.NXFlowSpecMatch(src\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":94,"context_line":"                                 dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":95,"context_line":"                                 n_bits\u003d12),"},{"line_number":96,"context_line":"            ofpp.NXFlowSpecMatch(src\u003d(\u0027eth_src\u0027, 0),"},{"line_number":97,"context_line":"                                 dst\u003d(\u0027eth_dst\u0027, 0),"},{"line_number":98,"context_line":"                                 n_bits\u003d48),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_0994c888","line":95,"updated":"2016-09-13 15:53:48.000000000","message":"should also be 16","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"927009531f344838ae38d6dfc1f88561745ff568","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        flow_specs \u003d ["},{"line_number":93,"context_line":"            ofpp.NXFlowSpecMatch(src\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":94,"context_line":"                                 dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":95,"context_line":"                                 n_bits\u003d12),"},{"line_number":96,"context_line":"            ofpp.NXFlowSpecMatch(src\u003d(\u0027eth_src\u0027, 0),"},{"line_number":97,"context_line":"                                 dst\u003d(\u0027eth_dst\u0027, 0),"},{"line_number":98,"context_line":"                                 n_bits\u003d48),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_eee580a8","line":95,"in_reply_to":"7a8ec9b2_cf90dfef","updated":"2016-09-14 12:32:33.000000000","message":"Ah.. yeah, you\u0027re right. I think I may have tested this with both set to 16, so I had better go back and check that this works with 12. Thanks.","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"4243e8e097b4c62936cd78ff6e8cfd274d8a2e58","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        flow_specs \u003d ["},{"line_number":93,"context_line":"            ofpp.NXFlowSpecMatch(src\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":94,"context_line":"                                 dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":95,"context_line":"                                 n_bits\u003d12),"},{"line_number":96,"context_line":"            ofpp.NXFlowSpecMatch(src\u003d(\u0027eth_src\u0027, 0),"},{"line_number":97,"context_line":"                                 dst\u003d(\u0027eth_dst\u0027, 0),"},{"line_number":98,"context_line":"                                 n_bits\u003d48),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_cf90dfef","line":95,"in_reply_to":"9a89bdaa_0994c888","updated":"2016-09-14 01:36:27.000000000","message":"To match with ovs-ofctl driver, it should be 12.\n\nAnd I don\u0027t think we need to filter on PCP values, do you?","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"4bc0e1c79b7a9704babce82a9e82802496518f24","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_d4f37e71","line":101,"updated":"2016-09-13 06:11:18.000000000","message":"vlan_vid with n_bits\u003d13 might also work.","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"6c8e39f9539f8fe994fb1da72b71066ac33e5e4f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_ffb21b95","line":101,"in_reply_to":"9a89bdaa_5fcce788","updated":"2016-09-13 06:37:00.000000000","message":"Search the openflow spec for 12+1, but n_bits\u003d13 seems to generate an ovs error.","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"c88d9d241a81e3e1a9be0b7ed30abfdeffd0bfcf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_f93ceee2","line":101,"in_reply_to":"9a89bdaa_9763b319","updated":"2016-09-13 09:56:52.000000000","message":"While I wish n_bits\u003d13 worked, but it is NX_LEARN specific and openflow spec doesn\u0027t really apply.\n\nIt looks strange and I assume this isn\u0027t intended, though.","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1bfea12ae1137baba490212860d82936f1364991","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_5fcce788","line":101,"in_reply_to":"9a89bdaa_d4f37e71","updated":"2016-09-13 06:30:56.000000000","message":"isn\u0027t vlan_vid 12 bit field?","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"4243e8e097b4c62936cd78ff6e8cfd274d8a2e58","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_b24bfa58","line":101,"in_reply_to":"9a89bdaa_e9dfa466","updated":"2016-09-14 01:36:27.000000000","message":"NX_LEARN actions can generate flows whose actions are load and/or output.\n\nNX_LEARN\u0027s trick is to interpret loading 0 to a VLAN CFI bit as a pop_vlan action. It is described in OVS comment.","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"9db0195f3de7554f0c589f14a9d11fa413efa273","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e9dfa466","line":101,"in_reply_to":"9a89bdaa_f93ceee2","updated":"2016-09-13 15:53:48.000000000","message":"While a vlan ID *is* 12 bits, it is my understanding that vlan_tci field is a 16 bit value. 3 bit for priority, 1 bit flag for canonical (?) format identifier, and 12 bits for  the vlan id.","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d0ce6957084a7960cf7bb1629686227ebce6b428","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 n_bits\u003d48),"},{"line_number":99,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d0,"},{"line_number":100,"context_line":"                                dst\u003d(\u0027vlan_tci\u0027, 0),"},{"line_number":101,"context_line":"                                n_bits\u003d16),"},{"line_number":102,"context_line":"            ofpp.NXFlowSpecLoad(src\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":103,"context_line":"                                dst\u003d(\u0027tunnel_id\u0027, 0),"},{"line_number":104,"context_line":"                                n_bits\u003d64),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_9763b319","line":101,"in_reply_to":"9a89bdaa_ffb21b95","updated":"2016-09-13 08:32:53.000000000","message":"you mean ovs bug?","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_ryuapp.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5e0cca7e9f09b900b822e5382924156f4b9f58f1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # Start Ryu event loop thread"},{"line_number":50,"context_line":"        super(OVSNeutronAgentRyuApp, self).start()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # patch ryu"},{"line_number":53,"context_line":"        ofproto_v1_3.oxm_types.append("},{"line_number":54,"context_line":"            oxm_fields.NiciraExtended0(\u0027vlan_tci\u0027, 4, type_desc.Int2))"},{"line_number":55,"context_line":"        oxm_fields.generate(ofproto_v1_3.__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_aeff8bff","line":52,"updated":"2016-09-13 03:56:18.000000000","message":"better to have TODO/REVISIT comment","commit_id":"4361f7543f984cf5f09c0c7070ac6b0f22f3b6b1"}]}