)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"747c482f316e86e6d1dd0d1d897774112a435432","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The previous condition was mistakenly using -le (less or equal) where"},{"line_number":10,"context_line":"strict -lt (less than) condition is needed, making all 4.x matching."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note: it\u0027s the third version of the condition. Reviewers, please"},{"line_number":13,"context_line":"actually review. :)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I34d832ec762f30de16e148ba5bea4888a0606c92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_3cee8cb4","line":12,"updated":"2016-09-12 08:36:16.000000000","message":"IIRC I did ask for a test... :)","commit_id":"3a58bb1cf512040aeacf4637b9b83b7bd1342718"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d053aec5fb30246a04dd3c38ee25b16df81207b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The previous condition was mistakenly using -le (less or equal) where"},{"line_number":10,"context_line":"strict -lt (less than) condition is needed, making all 4.x matching."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note: it\u0027s the third version of the condition. Reviewers, please"},{"line_number":13,"context_line":"actually review. :)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I34d832ec762f30de16e148ba5bea4888a0606c92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_7c7c94eb","line":12,"in_reply_to":"9a89bdaa_3cee8cb4","updated":"2016-09-12 08:37:01.000000000","message":":)))","commit_id":"3a58bb1cf512040aeacf4637b9b83b7bd1342718"}],"devstack/lib/ovs":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"fef786192b9f54faef4018bcdb4ff97acb7f2577","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#                                   supports only kernels up to 4.3.x, function"},{"line_number":36,"context_line":"#                                   determines whether compilation from source"},{"line_number":37,"context_line":"#                                   will succeed on this machine"},{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -lt 4 -o $minor -le 3 ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a89bdaa_fc07c41a","line":38,"updated":"2016-09-12 08:41:39.000000000","message":"The buildability depends on specific ovs version (OVS_BRANCH variable in gate_hook.sh) and it\u0027s a bit strange to have these things scattered in two files.","commit_id":"3a58bb1cf512040aeacf4637b9b83b7bd1342718"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"d255f35feae5d142bbb6925419cc416eaaa92f82","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#                                   supports only kernels up to 4.3.x, function"},{"line_number":36,"context_line":"#                                   determines whether compilation from source"},{"line_number":37,"context_line":"#                                   will succeed on this machine"},{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -lt 4 -o $minor -le 3 ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a89bdaa_59edecb5","line":38,"in_reply_to":"9a89bdaa_bf0fee86","updated":"2016-09-13 01:24:35.000000000","message":"Even on branch-2.5, supported kernel versions aren\u0027t constant.\nIf someone fixes build for kernel 4.4, we need to touch these two files.","commit_id":"3a58bb1cf512040aeacf4637b9b83b7bd1342718"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b6d2f7e086266439e924875bc25bf1bd8df3754f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#                                   supports only kernels up to 4.3.x, function"},{"line_number":36,"context_line":"#                                   determines whether compilation from source"},{"line_number":37,"context_line":"#                                   will succeed on this machine"},{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -lt 4 -o $minor -le 3 ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a89bdaa_bf0fee86","line":38,"in_reply_to":"9a89bdaa_fc07c41a","updated":"2016-09-12 08:52:25.000000000","message":"That\u0027s why the function is ovs25 specific.","commit_id":"3a58bb1cf512040aeacf4637b9b83b7bd1342718"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4925051e5c5ca19093ddd22e3525056139bcf473","unresolved":false,"context_lines":[{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -lt 4 -o $minor -le 3 ]; then"},{"line_number":42,"context_line":"        return 0"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a89bdaa_da1725a1","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":37},"updated":"2016-09-13 06:58:25.000000000","message":"So how about 5.3 ? :) I would expect we return 1","commit_id":"3a58bb1cf512040aeacf4637b9b83b7bd1342718"}]}
