)]}'
{"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"34bdf5e30678929c948921ee5e00bab0dae898b4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        agents \u003d context.host_agents(self.agent_type)"},{"line_number":97,"context_line":"        if not agents:"},{"line_number":98,"context_line":"            LOG.debug(\"Port %(pid)s on network %(network)s not bound, \""},{"line_number":99,"context_line":"                      \"no agent of type %(at)s registered on host %(host)s\","},{"line_number":100,"context_line":"                      {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":101,"context_line":"                       \u0027at\u0027: self.agent_type,"},{"line_number":102,"context_line":"                       \u0027network\u0027: context.network.current[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_58c09c50","line":99,"range":{"start_line":99,"start_character":23,"end_line":99,"end_character":75},"updated":"2016-09-12 16:11:46.000000000","message":"I would only suggest to remove the redundancy of agent in \"no agent of type Linux bridge agent\", where %(at)s \u003d\u003d \"Linux bridge agent\" so if we can check self.agent_type.endswith(\u0027agent\u0027) and remove it then it would look better, (unless Linux bridge agent is the official type name), but that may be too much effort for little gain.","commit_id":"7ff0a50ed9ea0de2b8bfb0821a4ae83ac6ac8ddd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a6a7af67f1e9f7ef9e64670c0f92e94d039d6be9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        agents \u003d context.host_agents(self.agent_type)"},{"line_number":97,"context_line":"        if not agents:"},{"line_number":98,"context_line":"            LOG.debug(\"Port %(pid)s on network %(network)s not bound, \""},{"line_number":99,"context_line":"                      \"no agent of type %(at)s registered on host %(host)s\","},{"line_number":100,"context_line":"                      {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":101,"context_line":"                       \u0027at\u0027: self.agent_type,"},{"line_number":102,"context_line":"                       \u0027network\u0027: context.network.current[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_6ad49d1f","line":99,"range":{"start_line":99,"start_character":23,"end_line":99,"end_character":75},"in_reply_to":"9a89bdaa_58c09c50","updated":"2016-09-12 20:11:58.000000000","message":"The suggestion is correct, but this is just a debug message. IMHO I don\u0027t think we need such a tweak in debug message.","commit_id":"7ff0a50ed9ea0de2b8bfb0821a4ae83ac6ac8ddd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a6a7af67f1e9f7ef9e64670c0f92e94d039d6be9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            LOG.debug(\"Port %(pid)s on network %(network)s not bound, \""},{"line_number":99,"context_line":"                      \"no agent of type %(at)s registered on host %(host)s\","},{"line_number":100,"context_line":"                      {\u0027pid\u0027: context.current[\u0027id\u0027],"},{"line_number":101,"context_line":"                       \u0027at\u0027: self.agent_type,"},{"line_number":102,"context_line":"                       \u0027network\u0027: context.network.current[\u0027id\u0027],"},{"line_number":103,"context_line":"                       \u0027host\u0027: context.host})"},{"line_number":104,"context_line":"        for agent in agents:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2ac61568","line":101,"range":{"start_line":101,"start_character":24,"end_line":101,"end_character":26},"updated":"2016-09-12 20:11:58.000000000","message":"super nit: Perhaps \u0027at\u0027 means \u0027agent type\u0027, but it is not easy to understand. I prefer to \u0027type\u0027 or \u0027agent_type\u0027.","commit_id":"7ff0a50ed9ea0de2b8bfb0821a4ae83ac6ac8ddd"}]}
