)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fccffe8508975348b9dbd7d7bda57db9810d3a20","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            subnet_prefixlen \u003d netaddr.IPNetwork(s[\u0027cidr\u0027]).prefixlen"},{"line_number":476,"context_line":"            error_message \u003d _(\"Subnet has a prefix length that is \""},{"line_number":477,"context_line":"                              \"incompatible with DHCP service enabled.\")"},{"line_number":478,"context_line":"            if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or"},{"line_number":479,"context_line":"                (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):"},{"line_number":480,"context_line":"                    raise exc.InvalidInput(error_message\u003derror_message)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            net \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_5ba7b6bc","side":"PARENT","line":479,"range":{"start_line":478,"start_character":12,"end_line":479,"end_character":58},"updated":"2016-09-12 16:26:43.000000000","message":"isn\u0027t this more readable?","commit_id":"4bfc1d58975cd75d15b812eb67197f2c16bcfc4f"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b120584ab837987fd886ca948c91f453fca2172b","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            subnet_prefixlen \u003d netaddr.IPNetwork(s[\u0027cidr\u0027]).prefixlen"},{"line_number":476,"context_line":"            error_message \u003d _(\"Subnet has a prefix length that is \""},{"line_number":477,"context_line":"                              \"incompatible with DHCP service enabled.\")"},{"line_number":478,"context_line":"            if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or"},{"line_number":479,"context_line":"                (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):"},{"line_number":480,"context_line":"                    raise exc.InvalidInput(error_message\u003derror_message)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            net \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_87e39cd8","side":"PARENT","line":479,"range":{"start_line":478,"start_character":12,"end_line":479,"end_character":58},"in_reply_to":"9a89bdaa_0c6096ce","updated":"2016-09-12 19:52:04.000000000","message":"For me, this one is more readable. It\u0027s easily visible, what\u0027s and how\u0027s happening.","commit_id":"4bfc1d58975cd75d15b812eb67197f2c16bcfc4f"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"bffb7ab2137acdcabc8b0c3d1dbec1c4e84dccf8","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            subnet_prefixlen \u003d netaddr.IPNetwork(s[\u0027cidr\u0027]).prefixlen"},{"line_number":476,"context_line":"            error_message \u003d _(\"Subnet has a prefix length that is \""},{"line_number":477,"context_line":"                              \"incompatible with DHCP service enabled.\")"},{"line_number":478,"context_line":"            if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or"},{"line_number":479,"context_line":"                (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):"},{"line_number":480,"context_line":"                    raise exc.InvalidInput(error_message\u003derror_message)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            net \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_711d7b61","side":"PARENT","line":479,"range":{"start_line":478,"start_character":12,"end_line":479,"end_character":58},"in_reply_to":"9a89bdaa_5ba7b6bc","updated":"2016-09-12 16:55:59.000000000","message":"In my opinion, both version is good, but I\u0027d prefer the new version. Let us wait for others.","commit_id":"4bfc1d58975cd75d15b812eb67197f2c16bcfc4f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"66a16be99370248524410563ac87c15427181a5a","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            subnet_prefixlen \u003d netaddr.IPNetwork(s[\u0027cidr\u0027]).prefixlen"},{"line_number":476,"context_line":"            error_message \u003d _(\"Subnet has a prefix length that is \""},{"line_number":477,"context_line":"                              \"incompatible with DHCP service enabled.\")"},{"line_number":478,"context_line":"            if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or"},{"line_number":479,"context_line":"                (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):"},{"line_number":480,"context_line":"                    raise exc.InvalidInput(error_message\u003derror_message)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            net \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_0c6096ce","side":"PARENT","line":479,"range":{"start_line":478,"start_character":12,"end_line":479,"end_character":58},"in_reply_to":"9a89bdaa_711d7b61","updated":"2016-09-12 17:18:07.000000000","message":"yep, sure","commit_id":"4bfc1d58975cd75d15b812eb67197f2c16bcfc4f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"504e7b9c46c4251a9c9e7f6e5320937db2bd5e49","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                              \"incompatible with DHCP service enabled.\")"},{"line_number":489,"context_line":"            if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or"},{"line_number":490,"context_line":"                (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):"},{"line_number":491,"context_line":"                raise exc.InvalidInput(error_message\u003derror_message)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            net \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"},{"line_number":494,"context_line":"            if net.is_multicast():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_9b700774","line":491,"updated":"2016-10-10 12:19:54.000000000","message":"Another valid option would be:\n\n           if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or\n                    (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):\n                raise exc.InvalidInput(error_message\u003derror_message)","commit_id":"1628fb72f8fbac15110713530728a03e8e4bd0f5"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"6e5ac5d15366af52e6e6512f477fe75190be590c","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                              \"incompatible with DHCP service enabled.\")"},{"line_number":489,"context_line":"            if ((ip_ver \u003d\u003d 4 and subnet_prefixlen \u003e 30) or"},{"line_number":490,"context_line":"                (ip_ver \u003d\u003d 6 and subnet_prefixlen \u003e 126)):"},{"line_number":491,"context_line":"                raise exc.InvalidInput(error_message\u003derror_message)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"            net \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"},{"line_number":494,"context_line":"            if net.is_multicast():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_567e566a","line":491,"in_reply_to":"1a95cdbc_9b700774","updated":"2016-10-10 15:26:56.000000000","message":"Hello Miguel,\n\nThanks for the idea. I did it in patchset 1, and got downvoted, you can check here:\nhttps://review.openstack.org/#/c/368812/1/neutron/db/db_base_plugin_v2.py","commit_id":"1628fb72f8fbac15110713530728a03e8e4bd0f5"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b120584ab837987fd886ca948c91f453fca2172b","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":125,"context_line":"        cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":126,"context_line":"        return (context.session.query(RouterL3AgentBinding)."},{"line_number":127,"context_line":"                join(agents_db.Agent)."},{"line_number":128,"context_line":"                filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":129,"context_line":"                agents_db.Agent.admin_state_up)."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c785a4cf","line":126,"updated":"2016-09-12 19:52:04.000000000","message":"probably better idea is to wrap it to new line.","commit_id":"902f16a07f8411a24865085a9f83c15978e5ed9d"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b120584ab837987fd886ca948c91f453fca2172b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        return (context.session.query(RouterL3AgentBinding)."},{"line_number":127,"context_line":"                join(agents_db.Agent)."},{"line_number":128,"context_line":"                filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":129,"context_line":"                agents_db.Agent.admin_state_up)."},{"line_number":130,"context_line":"                outerjoin(l3_attrs_db.RouterExtraAttributes,"},{"line_number":131,"context_line":"                l3_attrs_db.RouterExtraAttributes.router_id \u003d\u003d"},{"line_number":132,"context_line":"                RouterL3AgentBinding.router_id).filter("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_474434b6","line":129,"updated":"2016-09-12 19:52:04.000000000","message":"for readability, this one should be indented","commit_id":"902f16a07f8411a24865085a9f83c15978e5ed9d"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b120584ab837987fd886ca948c91f453fca2172b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":129,"context_line":"                agents_db.Agent.admin_state_up)."},{"line_number":130,"context_line":"                outerjoin(l3_attrs_db.RouterExtraAttributes,"},{"line_number":131,"context_line":"                l3_attrs_db.RouterExtraAttributes.router_id \u003d\u003d"},{"line_number":132,"context_line":"                RouterL3AgentBinding.router_id).filter("},{"line_number":133,"context_line":"                sa.or_("},{"line_number":134,"context_line":"                    l3_attrs_db.RouterExtraAttributes.ha \u003d\u003d sql.false(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c70e848b","line":131,"updated":"2016-09-12 19:52:04.000000000","message":"ditto","commit_id":"902f16a07f8411a24865085a9f83c15978e5ed9d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"417bc10033123cf689402f4e6bc1da0b2867f1fc","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":125,"context_line":"        cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return (context.session.query(RouterL3AgentBinding)."},{"line_number":128,"context_line":"                join(agents_db.Agent)."},{"line_number":129,"context_line":"                filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_272a0d7f","line":126,"updated":"2016-09-14 19:26:52.000000000","message":"Is this additional line required.","commit_id":"f89b05840caee6e4fc86fb5955617408fbea8baf"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"653752a5d9414cbbd2610c5004053f8d97fd93f1","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":125,"context_line":"        cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return (context.session.query(RouterL3AgentBinding)."},{"line_number":128,"context_line":"                join(agents_db.Agent)."},{"line_number":129,"context_line":"                filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_6a821996","line":126,"in_reply_to":"7a8ec9b2_272a0d7f","updated":"2016-09-14 21:12:48.000000000","message":"+1","commit_id":"f89b05840caee6e4fc86fb5955617408fbea8baf"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"cdf00ffa9311b4c76cfca1c0ddf8c3e30a4bedef","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":125,"context_line":"        cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return (context.session.query(RouterL3AgentBinding)."},{"line_number":128,"context_line":"                join(agents_db.Agent)."},{"line_number":129,"context_line":"                filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_701bdf1b","line":126,"in_reply_to":"7a8ec9b2_6a821996","updated":"2016-09-15 10:00:50.000000000","message":"That was requested in the previous patchset...","commit_id":"f89b05840caee6e4fc86fb5955617408fbea8baf"}]}
