)]}'
{"neutron/services/metering/drivers/iptables/iptables_driver.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"ccd189e3df6f2ffb0f8de07b449846158b0b2db8","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if not rm:"},{"line_number":285,"context_line":"            return"},{"line_number":286,"context_line":"        ex_gw_port \u003d rm.router.get(\u0027gw_port_id\u0027)"},{"line_number":287,"context_line":"        if not ex_gw_port:"},{"line_number":288,"context_line":"            return"},{"line_number":289,"context_line":"        ext_dev \u003d self.get_external_device_name(ex_gw_port)"},{"line_number":290,"context_line":"        if not ext_dev:"},{"line_number":291,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ac85eacf","line":288,"range":{"start_line":287,"start_character":8,"end_line":288,"end_character":18},"updated":"2016-09-12 17:52:58.000000000","message":"This is enough to fix the type error.","commit_id":"d1397ff3b2dc91f1175e0594e7b7846a0b3d5e84"}],"neutron/tests/unit/services/metering/drivers/test_iptables.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"ccd189e3df6f2ffb0f8de07b449846158b0b2db8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            router[\u0027gw_port_id\u0027] \u003d None"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.metering.add_metering_label(None, routers)"},{"line_number":175,"context_line":"        self.metering.add_metering_label_rule(None, routers)"},{"line_number":176,"context_line":"        self.metering.remove_metering_label_rule(None, routers)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        calls \u003d [mock.call.add_chain(\u0027neutron-meter-l-c5df2fe5-c60\u0027,"},{"line_number":179,"context_line":"                                     wrap\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_67c05d51","line":176,"range":{"start_line":175,"start_character":8,"end_line":176,"end_character":63},"updated":"2016-09-12 17:52:58.000000000","message":"Are you removing because this label_rule is unwanted? To test the code change only the add call is required.","commit_id":"d1397ff3b2dc91f1175e0594e7b7846a0b3d5e84"},{"author":{"_account_id":17133,"name":"Kengo Hobo","email":"hobo.kengo@jp.fujitsu.com","username":"hobo.kengo"},"change_message_id":"ed5f9dbd16ca3ce094fc00afad2203c079a12679","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            router[\u0027gw_port_id\u0027] \u003d None"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.metering.add_metering_label(None, routers)"},{"line_number":175,"context_line":"        self.metering.add_metering_label_rule(None, routers)"},{"line_number":176,"context_line":"        self.metering.remove_metering_label_rule(None, routers)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        calls \u003d [mock.call.add_chain(\u0027neutron-meter-l-c5df2fe5-c60\u0027,"},{"line_number":179,"context_line":"                                     wrap\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_8eef6786","line":176,"range":{"start_line":175,"start_character":8,"end_line":176,"end_character":63},"in_reply_to":"9a89bdaa_67c05d51","updated":"2016-09-15 08:40:55.000000000","message":"I want to check that TypeError is not occurred when removing meter label rule is called. \nCode that is passed through is same as that of adding meter label rule case.\nHowever, I assume that it is more safe for us to call both(add and remove) method because rpc method is different.","commit_id":"d1397ff3b2dc91f1175e0594e7b7846a0b3d5e84"}]}
