)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nachi Ueno \u003cnachi@ntti3.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-12 12:21:46 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race confition in l3-agent and improve performance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I boot 10 vm, and assign 10 floatings ips,"},{"line_number":10,"context_line":"only about half of it will be configured in 60 sec."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FswI%3D","line":7,"updated":"2013-07-12 20:18:10.000000000","message":"confition? What do you mean?","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nachi Ueno \u003cnachi@ntti3.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-12 12:21:46 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race confition in l3-agent and improve performance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I boot 10 vm, and assign 10 floatings ips,"},{"line_number":10,"context_line":"only about half of it will be configured in 60 sec."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fsqs%3D","line":7,"in_reply_to":"AAAAP3%2F%2FswI%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race confition in l3-agent and improve performance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I boot 10 vm, and assign 10 floatings ips,"},{"line_number":10,"context_line":"only about half of it will be configured in 60 sec."},{"line_number":11,"context_line":"There is some timing issue and perfomances issues."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FswE%3D","line":9,"updated":"2013-07-12 20:18:10.000000000","message":"vm -\u003e vms","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix race confition in l3-agent and improve performance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I boot 10 vm, and assign 10 floatings ips,"},{"line_number":10,"context_line":"only about half of it will be configured in 60 sec."},{"line_number":11,"context_line":"There is some timing issue and perfomances issues."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fsqo%3D","line":9,"in_reply_to":"AAAAP3%2F%2FswE%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I boot 10 vm, and assign 10 floatings ips,"},{"line_number":10,"context_line":"only about half of it will be configured in 60 sec."},{"line_number":11,"context_line":"There is some timing issue and perfomances issues."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Current l3-agent will not execute rpc"},{"line_number":14,"context_line":"call by order which has been called. This will lose"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fsv8%3D","line":11,"updated":"2013-07-12 20:18:10.000000000","message":"is -\u003e are","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When I boot 10 vm, and assign 10 floatings ips,"},{"line_number":10,"context_line":"only about half of it will be configured in 60 sec."},{"line_number":11,"context_line":"There is some timing issue and perfomances issues."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Current l3-agent will not execute rpc"},{"line_number":14,"context_line":"call by order which has been called. This will lose"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fsqk%3D","line":11,"in_reply_to":"AAAAP3%2F%2Fsv8%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Current l3-agent will not execute rpc"},{"line_number":14,"context_line":"call by order which has been called. This will lose"},{"line_number":15,"context_line":"some configrations"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- iptables apply is a heavy operation."},{"line_number":18,"context_line":"But it is used in several places."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fsv4%3D","line":15,"updated":"2013-07-12 20:18:10.000000000","message":"configrations -\u003e configurations\n\n(also check paragraph grammar)","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Current l3-agent will not execute rpc"},{"line_number":14,"context_line":"call by order which has been called. This will lose"},{"line_number":15,"context_line":"some configrations"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- iptables apply is a heavy operation."},{"line_number":18,"context_line":"But it is used in several places."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsqU%3D","line":15,"in_reply_to":"AAAAP3%2F%2Fsv4%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"51307e0f557ea40fd10d2690b5f0e000a8322eb0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- iptables apply is a heavy operation."},{"line_number":18,"context_line":"But it is used in several places."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- Sometimes RPC stucks."},{"line_number":21,"context_line":"so let\u0027s say we got 10 floating ip update rpc request"},{"line_number":22,"context_line":"for a server during processsing routers."},{"line_number":23,"context_line":"In this case, it is enough to process the last call."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsvM%3D","line":20,"updated":"2013-07-12 20:03:15.000000000","message":"Sometimes RPC will temporarily block for unexpectedly long periods","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- iptables apply is a heavy operation."},{"line_number":18,"context_line":"But it is used in several places."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- Sometimes RPC stucks."},{"line_number":21,"context_line":"so let\u0027s say we got 10 floating ip update rpc request"},{"line_number":22,"context_line":"for a server during processsing routers."},{"line_number":23,"context_line":"In this case, it is enough to process the last call."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsqI%3D","line":20,"in_reply_to":"AAAAP3%2F%2FsvM%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":22,"context_line":"for a server during processsing routers."},{"line_number":23,"context_line":"In this case, it is enough to process the last call."},{"line_number":24,"context_line":"However current implementation will process all requests."},{"line_number":25,"context_line":"This will delayed 10th floating ip configrations."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Each router run is executed in batch way."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsvU%3D","line":25,"updated":"2013-07-12 20:18:10.000000000","message":"same typo on configrations","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"for a server during processsing routers."},{"line_number":23,"context_line":"In this case, it is enough to process the last call."},{"line_number":24,"context_line":"However current implementation will process all requests."},{"line_number":25,"context_line":"This will delayed 10th floating ip configrations."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Each router run is executed in batch way."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsqE%3D","line":25,"in_reply_to":"AAAAP3%2F%2FsvU%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Each router run is executed in batch way."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In this patch, I took very simple and safe strategy."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- Any update rpc call will simply set fullsync\u003dtrue"},{"line_number":32,"context_line":"- rpcloop will check the fullsync for each sec, then"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsvI%3D","line":29,"updated":"2013-07-12 20:18:10.000000000","message":"Sorry for the extreme pedantry, but this is a commit message, not a post on the mailing list - use 3rd person","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Each router run is executed in batch way."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In this patch, I took very simple and safe strategy."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- Any update rpc call will simply set fullsync\u003dtrue"},{"line_number":32,"context_line":"- rpcloop will check the fullsync for each sec, then"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fspk%3D","line":29,"in_reply_to":"AAAAP3%2F%2FsvI%3D","updated":"2013-07-12 20:32:22.000000000","message":"No, apologies from my side. I should check commit message more carefully,, \nsince this is critical problem, I hurried up to push..","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"51307e0f557ea40fd10d2690b5f0e000a8322eb0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"This patch will increases requests for servers,"},{"line_number":40,"context_line":"however this could be future work."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"I expect this patch fixes bug 1194026."},{"line_number":43,"context_line":"fixes 1200749"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Change-Id: I0978d1c38ac5c38c4548e5b1877857bb5cac3b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2FsvE%3D","line":42,"updated":"2013-07-12 20:03:15.000000000","message":"Go ahead and say it fixes bug 1194026 and 1200749","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"This patch will increases requests for servers,"},{"line_number":40,"context_line":"however this could be future work."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"I expect this patch fixes bug 1194026."},{"line_number":43,"context_line":"fixes 1200749"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Change-Id: I0978d1c38ac5c38c4548e5b1877857bb5cac3b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2Fspg%3D","line":42,"in_reply_to":"AAAAP3%2F%2FsvE%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":169,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":170,"context_line":"                   default\u003d1,"},{"line_number":171,"context_line":"                   help\u003d_(\"rpc loop intervali which executes rpc messages\")),"},{"line_number":172,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":173,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""},{"line_number":174,"context_line":"                          \"by the agents.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fsus%3D","line":171,"updated":"2013-07-12 20:18:10.000000000","message":"intervali -\u003e interval","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":169,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":170,"context_line":"                   default\u003d1,"},{"line_number":171,"context_line":"                   help\u003d_(\"rpc loop intervali which executes rpc messages\")),"},{"line_number":172,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":173,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""},{"line_number":174,"context_line":"                          \"by the agents.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fspc%3D","line":171,"in_reply_to":"AAAAP3%2F%2Fsus%3D","updated":"2013-07-12 20:32:22.000000000","message":"Done","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            pool.spawn_n(self.process_router, ri)"},{"line_number":653,"context_line":"        # identify and remove routers that no longer exist"},{"line_number":654,"context_line":"        for router_id in prev_router_ids - cur_router_ids:"},{"line_number":655,"context_line":"            pool.spawn_n(self._router_removed, router_id)"},{"line_number":656,"context_line":"        pool.waitall()"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def _rpc_loop(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FstU%3D","line":655,"updated":"2013-07-12 20:18:10.000000000","message":"Yeah this adds some parallelism - but those are still greenthreads.\n\nI wonder if there might be any impact on iptablemanager.apply, like if two routers are processed concurrently, then one overwrites the changes of the other.","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            pool.spawn_n(self.process_router, ri)"},{"line_number":653,"context_line":"        # identify and remove routers that no longer exist"},{"line_number":654,"context_line":"        for router_id in prev_router_ids - cur_router_ids:"},{"line_number":655,"context_line":"            pool.spawn_n(self._router_removed, router_id)"},{"line_number":656,"context_line":"        pool.waitall()"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def _rpc_loop(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FspI%3D","line":655,"in_reply_to":"AAAAP3%2F%2FstU%3D","updated":"2013-07-12 20:32:22.000000000","message":"sometimes rpc call will stop processing routers because it will be considered in the same thread.\nso I think move it for different thread.\n\niptablemanager is per namespace (router) basis, so no problem for this case.","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        if self.fullsync:"},{"line_number":660,"context_line":"            # We may get new sync request after this,"},{"line_number":661,"context_line":"            # so we need to update this value first"},{"line_number":662,"context_line":"            self.fullsync \u003d False"},{"line_number":663,"context_line":"            self._sync_routers_task(self.context)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fsug%3D","line":662,"updated":"2013-07-12 20:18:10.000000000","message":"Why do not synchronize setting of this flag too then?","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        if self.fullsync:"},{"line_number":660,"context_line":"            # We may get new sync request after this,"},{"line_number":661,"context_line":"            # so we need to update this value first"},{"line_number":662,"context_line":"            self.fullsync \u003d False"},{"line_number":663,"context_line":"            self._sync_routers_task(self.context)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fsoo%3D","line":662,"in_reply_to":"AAAAP3%2F%2Fsug%3D","updated":"2013-07-12 20:32:22.000000000","message":"fullsync should be updated randomly.\nBut I think i can improve this code.","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f6d49e2dc05620f14339d928adf97f0da1b9019","unresolved":false,"context_lines":[{"line_number":674,"context_line":"            routers \u003d self.plugin_rpc.get_routers("},{"line_number":675,"context_line":"                context, router_id)"},{"line_number":676,"context_line":"            LOG.debug(_(\u0027Full sync for :%r\u0027), routers)"},{"line_number":677,"context_line":"            self._process_routers(routers, all_routers\u003dTrue)"},{"line_number":678,"context_line":"        except Exception:"},{"line_number":679,"context_line":"            LOG.exception(_(\"Failed synchronizing routers\"))"},{"line_number":680,"context_line":"            self.fullsync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fsro%3D","line":677,"updated":"2013-07-12 20:18:10.000000000","message":"ugh.\nThis does not sound a great idea at scale.\nIt probably solves the sync issue, but it introduces some non-negligible technical debt","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5d19074348d53e84e09ea00d5e23790b8a356dc3","unresolved":false,"context_lines":[{"line_number":674,"context_line":"            routers \u003d self.plugin_rpc.get_routers("},{"line_number":675,"context_line":"                context, router_id)"},{"line_number":676,"context_line":"            LOG.debug(_(\u0027Full sync for :%r\u0027), routers)"},{"line_number":677,"context_line":"            self._process_routers(routers, all_routers\u003dTrue)"},{"line_number":678,"context_line":"        except Exception:"},{"line_number":679,"context_line":"            LOG.exception(_(\"Failed synchronizing routers\"))"},{"line_number":680,"context_line":"            self.fullsync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fsog%3D","line":677,"in_reply_to":"AAAAP3%2F%2Fsro%3D","updated":"2013-07-12 20:32:22.000000000","message":"I have talked this point with Mark.\nMark said, let\u0027s start from simple and improve it.\nHe also said he has server side improvement code.","commit_id":"63910bed1eca7b76ace128175e9d9a600adf191b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5502a20810baf85e16c19fc71c6bc45d7ac9a6af","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    default\u003dTrue,"},{"line_number":168,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":169,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":170,"context_line":"                   default\u003d1,"},{"line_number":171,"context_line":"                   help\u003d_(\"rpc loop intervali which executes rpc messages\")),"},{"line_number":172,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":173,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2Fskw%3D","line":170,"updated":"2013-07-12 20:50:29.000000000","message":"this seems somewhat aggressive, can this be higher?","commit_id":"2acf25dfc4e67ea7be62664c6030e66fdae316a5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f22982c4280c41db748b8ae8dc2e16e6b9b58593","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"},{"line_number":603,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""},{"line_number":604,"context_line":"        LOG.debug(_(\u0027Got rotuers updated notify :%s\u0027), routers)"},{"line_number":605,"context_line":"        self.updated_routers.update([router[\u0027id\u0027] for router in routers])"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def router_removed_from_agent(self, context, payload):"},{"line_number":608,"context_line":"        LOG.debug(_(\u0027Got router removed from agent :%r\u0027), payload)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2Fr3o%3D","line":605,"updated":"2013-07-13 08:05:46.000000000","message":"The routers parameter contains all of the information that is needed for l3_agent. just using the id is ..., so if we need to change the server side to just feed the agent the ids?","commit_id":"4ec27018131553d8bec4c7a12f809769317e88c8"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"7ee00643cd8918490f7b517840ba3a46b4b25b38","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"},{"line_number":603,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""},{"line_number":604,"context_line":"        LOG.debug(_(\u0027Got rotuers updated notify :%s\u0027), routers)"},{"line_number":605,"context_line":"        self.updated_routers.update([router[\u0027id\u0027] for router in routers])"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def router_removed_from_agent(self, context, payload):"},{"line_number":608,"context_line":"        LOG.debug(_(\u0027Got router removed from agent :%r\u0027), payload)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2FrgQ%3D","line":605,"in_reply_to":"AAAAP3%2F%2Fr3o%3D","updated":"2013-07-13 15:26:02.000000000","message":"the router data could be outdated. The outdated data can be executed after new one. so we cannot rely on data which the server pushed. i will update server side also","commit_id":"4ec27018131553d8bec4c7a12f809769317e88c8"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f22982c4280c41db748b8ae8dc2e16e6b9b58593","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    def _rpc_loop(self):"},{"line_number":661,"context_line":"        if not self.sync_progress and ("},{"line_number":662,"context_line":"                self.updated_routers or self.deleted_rotuers):"},{"line_number":663,"context_line":"            self._sync_routers_task(self.context)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    @periodic_task.periodic_task"},{"line_number":666,"context_line":"    @lockutils.synchronized(\u0027l3-agent\u0027, \u0027neutron-\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2FrnQ%3D","line":663,"updated":"2013-07-13 08:05:46.000000000","message":"_sync_routers_task is already decorated by @periodic_task.periodic_task","commit_id":"4ec27018131553d8bec4c7a12f809769317e88c8"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"7ee00643cd8918490f7b517840ba3a46b4b25b38","unresolved":false,"context_lines":[{"line_number":660,"context_line":"    def _rpc_loop(self):"},{"line_number":661,"context_line":"        if not self.sync_progress and ("},{"line_number":662,"context_line":"                self.updated_routers or self.deleted_rotuers):"},{"line_number":663,"context_line":"            self._sync_routers_task(self.context)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    @periodic_task.periodic_task"},{"line_number":666,"context_line":"    @lockutils.synchronized(\u0027l3-agent\u0027, \u0027neutron-\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2Frg0%3D","line":663,"in_reply_to":"AAAAP3%2F%2FrnQ%3D","updated":"2013-07-13 15:26:02.000000000","message":"duration is different . this loop is per 1 sec. periodic task is per 40 sec","commit_id":"4ec27018131553d8bec4c7a12f809769317e88c8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd2c175d8e2a3468d15f788d8015eddfd5f3a95d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        port[\u0027ip_cidr\u0027] \u003d \"%s/%s\" % (ips[0][\u0027ip_address\u0027], prefixlen)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def process_router(self, ri):"},{"line_number":334,"context_line":"        ri.iptables_manager.defer_apply_on()"},{"line_number":335,"context_line":"        ex_gw_port \u003d self._get_ex_gw_port(ri)"},{"line_number":336,"context_line":"        internal_ports \u003d ri.router.get(l3_constants.INTERFACE_KEY, [])"},{"line_number":337,"context_line":"        existing_port_ids \u003d set([p[\u0027id\u0027] for p in ri.internal_ports])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAP3%2F%2Fq8M%3D","line":334,"updated":"2013-07-14 11:35:50.000000000","message":"At this stage it might be worth considering transforming these \u0027process\u0027 function in \u0027synchronize\u0027 actions, which basically recreate the whole configuration everytime a router is updated.\n\nThis is just a forward-looking statement, does not have to addressed in this patch.","commit_id":"0a721d3434c83a9f67636ac76a9deeaabda4b56f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4fabecfb391c62ab2682f4a182768cc105ff4a55","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        port[\u0027ip_cidr\u0027] \u003d \"%s/%s\" % (ips[0][\u0027ip_address\u0027], prefixlen)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def process_router(self, ri):"},{"line_number":334,"context_line":"        ri.iptables_manager.defer_apply_on()"},{"line_number":335,"context_line":"        ex_gw_port \u003d self._get_ex_gw_port(ri)"},{"line_number":336,"context_line":"        internal_ports \u003d ri.router.get(l3_constants.INTERFACE_KEY, [])"},{"line_number":337,"context_line":"        existing_port_ids \u003d set([p[\u0027id\u0027] for p in ri.internal_ports])"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAP3%2F%2Fq2o%3D","line":334,"in_reply_to":"AAAAP3%2F%2Fq8M%3D","updated":"2013-07-14 15:13:54.000000000","message":"I agree. These function should be refactored when we go to service agent kind of thinks.","commit_id":"0a721d3434c83a9f67636ac76a9deeaabda4b56f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd2c175d8e2a3468d15f788d8015eddfd5f3a95d","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        try:"},{"line_number":663,"context_line":"            if self.updated_routers:"},{"line_number":664,"context_line":"                router_ids \u003d list(self.updated_routers)"},{"line_number":665,"context_line":"                self.updated_routers.clear()"},{"line_number":666,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":667,"context_line":"                    self.context, router_ids)"},{"line_number":668,"context_line":"                self._process_routers(routers)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAP3%2F%2Fq8Q%3D","line":665,"updated":"2013-07-14 11:35:50.000000000","message":"I would clear this set before sending the rpc to the server.\nShould the rpc fail inded the information that you need to update these routers is lost forever, and there won\u0027t be a retry at the next call of _rpc_loop","commit_id":"0a721d3434c83a9f67636ac76a9deeaabda4b56f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4fabecfb391c62ab2682f4a182768cc105ff4a55","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        try:"},{"line_number":663,"context_line":"            if self.updated_routers:"},{"line_number":664,"context_line":"                router_ids \u003d list(self.updated_routers)"},{"line_number":665,"context_line":"                self.updated_routers.clear()"},{"line_number":666,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":667,"context_line":"                    self.context, router_ids)"},{"line_number":668,"context_line":"                self._process_routers(routers)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAP3%2F%2Fq2w%3D","line":665,"in_reply_to":"AAAAP3%2F%2Fq8Q%3D","updated":"2013-07-14 15:13:54.000000000","message":"In that case, fullsync is set True. so it is OK.\nif we move this after rpc call, we can lost some routers which is added after L664 - to L666","commit_id":"0a721d3434c83a9f67636ac76a9deeaabda4b56f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f4877a8bcc7994b706d75b673bea8e266a7bb4c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.call(context,"},{"line_number":72,"context_line":"                         self.make_msg(\u0027sync_routers\u0027, host\u003dself.host,"},{"line_number":73,"context_line":"                                       fullsync\u003dfullsync,"},{"line_number":74,"context_line":"                                       router_ids\u003drouter_ids),"},{"line_number":75,"context_line":"                         topic\u003dself.topic)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_external_network_id(self, context):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fn18%3D","line":74,"updated":"2013-07-15 18:56:25.000000000","message":"The corresponding callback method in L3 callback mixin does not check router_ids parameter. I think we need to update sync_routers in L3CallbackMixin to check \u0027router_ids\u0027 instead of \u0027router_id\u0027.","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c53d7444a44618115026b0cdaedb57264d2a405d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.call(context,"},{"line_number":72,"context_line":"                         self.make_msg(\u0027sync_routers\u0027, host\u003dself.host,"},{"line_number":73,"context_line":"                                       fullsync\u003dfullsync,"},{"line_number":74,"context_line":"                                       router_ids\u003drouter_ids),"},{"line_number":75,"context_line":"                         topic\u003dself.topic)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_external_network_id(self, context):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2FnuE%3D","line":74,"in_reply_to":"AAAAP3%2F%2Fn18%3D","updated":"2013-07-15 19:10:34.000000000","message":"I agree.  However this is another bug, so I reported it \nhttps://bugs.launchpad.net/neutron/+bug/1201553","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f4877a8bcc7994b706d75b673bea8e266a7bb4c","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def router_deleted(self, context, router_id):"},{"line_number":598,"context_line":"        \"\"\"Deal with router deletion RPC message.\"\"\""},{"line_number":599,"context_line":"        LOG.debug(_(\u0027Got rotuer deleted notify for %s\u0027), router_id)"},{"line_number":600,"context_line":"        self.removed_routers.add(router_id)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fnvk%3D","line":599,"updated":"2013-07-15 18:56:25.000000000","message":"nofity -\u003e notification","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c53d7444a44618115026b0cdaedb57264d2a405d","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def router_deleted(self, context, router_id):"},{"line_number":598,"context_line":"        \"\"\"Deal with router deletion RPC message.\"\"\""},{"line_number":599,"context_line":"        LOG.debug(_(\u0027Got rotuer deleted notify for %s\u0027), router_id)"},{"line_number":600,"context_line":"        self.removed_routers.add(router_id)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fnt4%3D","line":599,"in_reply_to":"AAAAP3%2F%2Fnvk%3D","updated":"2013-07-15 19:10:34.000000000","message":"Done","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f4877a8bcc7994b706d75b673bea8e266a7bb4c","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        try:"},{"line_number":663,"context_line":"            if self.updated_routers:"},{"line_number":664,"context_line":"                router_ids \u003d list(self.updated_routers)"},{"line_number":665,"context_line":"                self.updated_routers.clear()"},{"line_number":666,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":667,"context_line":"                    self.context, router_ids)"},{"line_number":668,"context_line":"                self._process_routers(routers)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fnv0%3D","line":665,"updated":"2013-07-15 18:56:25.000000000","message":"update_routers.clear() is called in two places. Both methods are wrapped with synchronized, so no data is lost but it is better to add a comment to describe it.","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c53d7444a44618115026b0cdaedb57264d2a405d","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        try:"},{"line_number":663,"context_line":"            if self.updated_routers:"},{"line_number":664,"context_line":"                router_ids \u003d list(self.updated_routers)"},{"line_number":665,"context_line":"                self.updated_routers.clear()"},{"line_number":666,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":667,"context_line":"                    self.context, router_ids)"},{"line_number":668,"context_line":"                self._process_routers(routers)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fnt0%3D","line":665,"in_reply_to":"AAAAP3%2F%2Fnv0%3D","updated":"2013-07-15 19:10:34.000000000","message":"added comment","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e57371903d16dc49b019d4ff0f9464d5fb594169","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":168,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":169,"context_line":"                   default\u003d1,"},{"line_number":170,"context_line":"                   help\u003d_(\"rpc loop interval which executes rpc messages\")),"},{"line_number":171,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":172,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""},{"line_number":173,"context_line":"                          \"by the agents.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnDo%3D","line":170,"updated":"2013-07-15 21:19:54.000000000","message":"Is this really something that needs to be exposed to administrators in the config file?","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"61ae33d54f89c23121e5d91438cd5bea12d409dc","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":168,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":169,"context_line":"                   default\u003d1,"},{"line_number":170,"context_line":"                   help\u003d_(\"rpc loop interval which executes rpc messages\")),"},{"line_number":171,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":172,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""},{"line_number":173,"context_line":"                          \"by the agents.\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2Fm7E%3D","line":170,"in_reply_to":"AAAAP3%2F%2FnDo%3D","updated":"2013-07-15 21:47:09.000000000","message":"Yes. it should be configurable like the other intervals.","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebe854cb4ef4d52854676a04134c9d0eba468645","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def router_deleted(self, context, router_id):"},{"line_number":598,"context_line":"        \"\"\"Deal with router deletion RPC message.\"\"\""},{"line_number":599,"context_line":"        LOG.debug(_(\u0027Got rotuer deleted notification for %s\u0027), router_id)"},{"line_number":600,"context_line":"        self.removed_routers.add(router_id)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnFI%3D","line":599,"updated":"2013-07-15 21:17:22.000000000","message":"rotuer \u003d\u003e router","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c108ea3616d5d92e1d5e1470c0ef1951b5488fff","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def router_deleted(self, context, router_id):"},{"line_number":598,"context_line":"        \"\"\"Deal with router deletion RPC message.\"\"\""},{"line_number":599,"context_line":"        LOG.debug(_(\u0027Got rotuer deleted notification for %s\u0027), router_id)"},{"line_number":600,"context_line":"        self.removed_routers.add(router_id)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnC8%3D","line":599,"in_reply_to":"AAAAP3%2F%2FnFI%3D","updated":"2013-07-15 21:34:35.000000000","message":"Done","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebe854cb4ef4d52854676a04134c9d0eba468645","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"},{"line_number":603,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""},{"line_number":604,"context_line":"        LOG.debug(_(\u0027Got rotuers updated notification :%s\u0027), routers)"},{"line_number":605,"context_line":"        self.updated_routers.update(routers)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def router_removed_from_agent(self, context, payload):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnFA%3D","line":604,"updated":"2013-07-15 21:17:22.000000000","message":"rotuer \u003d\u003e router","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c108ea3616d5d92e1d5e1470c0ef1951b5488fff","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def routers_updated(self, context, routers):"},{"line_number":603,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""},{"line_number":604,"context_line":"        LOG.debug(_(\u0027Got rotuers updated notification :%s\u0027), routers)"},{"line_number":605,"context_line":"        self.updated_routers.update(routers)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def router_removed_from_agent(self, context, payload):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnDA%3D","line":604,"in_reply_to":"AAAAP3%2F%2FnFA%3D","updated":"2013-07-15 21:34:35.000000000","message":"Done","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebe854cb4ef4d52854676a04134c9d0eba468645","unresolved":false,"context_lines":[{"line_number":684,"context_line":"    def _router_ids(self):"},{"line_number":685,"context_line":"        if not self.conf.use_namespaces:"},{"line_number":686,"context_line":"            return self.conf.router_id"},{"line_number":687,"context_line":"        elif self.fullsync:"},{"line_number":688,"context_line":"            return None"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnEY%3D","line":687,"updated":"2013-07-15 21:17:22.000000000","message":"are lines 687 and 688 needed?","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c108ea3616d5d92e1d5e1470c0ef1951b5488fff","unresolved":false,"context_lines":[{"line_number":684,"context_line":"    def _router_ids(self):"},{"line_number":685,"context_line":"        if not self.conf.use_namespaces:"},{"line_number":686,"context_line":"            return self.conf.router_id"},{"line_number":687,"context_line":"        elif self.fullsync:"},{"line_number":688,"context_line":"            return None"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnCk%3D","line":687,"in_reply_to":"AAAAP3%2F%2FnEY%3D","updated":"2013-07-15 21:34:35.000000000","message":"Done","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cbf4b1b52146a4bca7bd623670738d0a99b439e1","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class L3NATAgent(manager.Manager):"},{"line_number":142,"context_line":"    \"\"\"RPC history"},{"line_number":143,"context_line":"        history"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        1.0 initial Version"},{"line_number":146,"context_line":"        1.1 support router_ids in the notification"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2Fmug%3D","line":143,"updated":"2013-07-15 22:54:00.000000000","message":"RPC history history?\n\nI guess just removed the second line?","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8ad73d6b079a5fd7acb6f581838fb51d984866e9","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class L3NATAgent(manager.Manager):"},{"line_number":142,"context_line":"    \"\"\"RPC history"},{"line_number":143,"context_line":"        history"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        1.0 initial Version"},{"line_number":146,"context_line":"        1.1 support router_ids in the notification"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2Fmks%3D","line":143,"in_reply_to":"AAAAP3%2F%2Fmug%3D","updated":"2013-07-15 23:27:42.000000000","message":"Done","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cbf4b1b52146a4bca7bd623670738d0a99b439e1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        history"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        1.0 initial Version"},{"line_number":146,"context_line":"        1.1 support router_ids in the notification"},{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2Fmt0%3D","line":146,"updated":"2013-07-15 22:54:00.000000000","message":"I don\u0027t think this is specific enough.  How about something like this:\n\n    1.1 changed the type of the routers parameter to the routers_updated method. It was previously a list of routers in dict format.  It is now a list of router IDs only.  Per rpc versioning rules, it is backwards compatible.","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8ad73d6b079a5fd7acb6f581838fb51d984866e9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        history"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        1.0 initial Version"},{"line_number":146,"context_line":"        1.1 support router_ids in the notification"},{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2Fmkk%3D","line":146,"in_reply_to":"AAAAP3%2F%2Fmt0%3D","updated":"2013-07-15 23:27:42.000000000","message":"Thanks!!","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cbf4b1b52146a4bca7bd623670738d0a99b439e1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":175,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":176,"context_line":"                   default\u003d1,"},{"line_number":177,"context_line":"                   help\u003d_(\"rpc loop interval which executes rpc messages\")),"},{"line_number":178,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":179,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""},{"line_number":180,"context_line":"                          \"by the agents.\")),"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2Fmts%3D","line":177,"updated":"2013-07-15 22:54:00.000000000","message":"I commented before and you thought it did need to be configurable.  I guess I\u0027ll ask it another way.  Do you actually expect administrators to change this?  Why would you change it?  What are some reasonable values?\n\nIf it remains as a configuration option (which i would argue this sort of thing shouldn\u0027t be), then I think the help text needs to be more detailed to give administrators a better idea of what this is and why they might want to change it.","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8ad73d6b079a5fd7acb6f581838fb51d984866e9","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    help\u003d_(\"Agent should implement routers with no gateway\")),"},{"line_number":175,"context_line":"        cfg.IntOpt(\u0027rpc_loop_interval\u0027,"},{"line_number":176,"context_line":"                   default\u003d1,"},{"line_number":177,"context_line":"                   help\u003d_(\"rpc loop interval which executes rpc messages\")),"},{"line_number":178,"context_line":"        cfg.StrOpt(\u0027gateway_external_network_id\u0027, default\u003d\u0027\u0027,"},{"line_number":179,"context_line":"                   help\u003d_(\"UUID of external network for routers implemented \""},{"line_number":180,"context_line":"                          \"by the agents.\")),"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2FmkU%3D","line":177,"in_reply_to":"AAAAP3%2F%2Fmts%3D","updated":"2013-07-15 23:27:42.000000000","message":"You are right. I can\u0027t write doc for admin for configuring this value, since 1 is best value..\nI\u0027ll drop this from config","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cbf4b1b52146a4bca7bd623670738d0a99b439e1","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""},{"line_number":611,"context_line":"        LOG.debug(_(\u0027Got routers updated notification :%s\u0027), routers)"},{"line_number":612,"context_line":"        if routers:"},{"line_number":613,"context_line":"            # This is neede for backward compatiblity"},{"line_number":614,"context_line":"            if type(routers[0]) \u003d\u003d \u0027dict\u0027:"},{"line_number":615,"context_line":"                routers \u003d [router[\u0027id\u0027] for router in routers]"},{"line_number":616,"context_line":"            self.updated_routers.update(routers)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2FmtE%3D","line":613,"updated":"2013-07-15 22:54:00.000000000","message":"typo, s/neede/needed/","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8ad73d6b079a5fd7acb6f581838fb51d984866e9","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        \"\"\"Deal with routers modification and creation RPC message.\"\"\""},{"line_number":611,"context_line":"        LOG.debug(_(\u0027Got routers updated notification :%s\u0027), routers)"},{"line_number":612,"context_line":"        if routers:"},{"line_number":613,"context_line":"            # This is neede for backward compatiblity"},{"line_number":614,"context_line":"            if type(routers[0]) \u003d\u003d \u0027dict\u0027:"},{"line_number":615,"context_line":"                routers \u003d [router[\u0027id\u0027] for router in routers]"},{"line_number":616,"context_line":"            self.updated_routers.update(routers)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2FmkQ%3D","line":613,"in_reply_to":"AAAAP3%2F%2FmtE%3D","updated":"2013-07-15 23:27:42.000000000","message":"Done","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cbf4b1b52146a4bca7bd623670738d0a99b439e1","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        LOG.debug(_(\u0027Got routers updated notification :%s\u0027), routers)"},{"line_number":612,"context_line":"        if routers:"},{"line_number":613,"context_line":"            # This is neede for backward compatiblity"},{"line_number":614,"context_line":"            if type(routers[0]) \u003d\u003d \u0027dict\u0027:"},{"line_number":615,"context_line":"                routers \u003d [router[\u0027id\u0027] for router in routers]"},{"line_number":616,"context_line":"            self.updated_routers.update(routers)"},{"line_number":617,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2FmsM%3D","line":614,"updated":"2013-07-15 22:54:00.000000000","message":"I think isinstance() is more appropriate here.\n\n    if isinstance(routers[0], dict)","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8ad73d6b079a5fd7acb6f581838fb51d984866e9","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        LOG.debug(_(\u0027Got routers updated notification :%s\u0027), routers)"},{"line_number":612,"context_line":"        if routers:"},{"line_number":613,"context_line":"            # This is neede for backward compatiblity"},{"line_number":614,"context_line":"            if type(routers[0]) \u003d\u003d \u0027dict\u0027:"},{"line_number":615,"context_line":"                routers \u003d [router[\u0027id\u0027] for router in routers]"},{"line_number":616,"context_line":"            self.updated_routers.update(routers)"},{"line_number":617,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2FmkM%3D","line":614,"in_reply_to":"AAAAP3%2F%2FmsM%3D","updated":"2013-07-15 23:27:42.000000000","message":"Done","commit_id":"dea0c237bc7b71e4f3eaaa3ed00173ac3d216082"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9657607c788b7ae1e7b21eecd11c6b5377da8405","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.call(context,"},{"line_number":72,"context_line":"                         self.make_msg(\u0027sync_routers\u0027, host\u003dself.host,"},{"line_number":73,"context_line":"                                       fullsync\u003dfullsync,"},{"line_number":74,"context_line":"                                       router_ids\u003drouter_ids),"},{"line_number":75,"context_line":"                         topic\u003dself.topic)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_external_network_id(self, context):"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmXk%3D","line":74,"updated":"2013-07-16 01:02:11.000000000","message":"We need to change \"router_id\" in L3RpcCallbackMixin.sync_routers(). None is passed to router_id(s) if namespace is used, but a specific value is passed when namespace is not used. See L.708.\n\nThe current code breaks non-namespace deployment.","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"f4cbc56dede2f8f5f835ede7a02bacecd53685a7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return self.call(context,"},{"line_number":72,"context_line":"                         self.make_msg(\u0027sync_routers\u0027, host\u003dself.host,"},{"line_number":73,"context_line":"                                       fullsync\u003dfullsync,"},{"line_number":74,"context_line":"                                       router_ids\u003drouter_ids),"},{"line_number":75,"context_line":"                         topic\u003dself.topic)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_external_network_id(self, context):"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmWc%3D","line":74,"in_reply_to":"AAAAP3%2F%2FmXk%3D","updated":"2013-07-16 01:10:56.000000000","message":"Will fix next patch","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b2f68ac9fbf15a73a7ecae56c9bee4d18fa4538e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          *args, action\u003dself._snat_action)"},{"line_number":138,"context_line":"        self._snat_action \u003d None"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"RPC_LOOP_INTERVAL \u003d 1"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class L3NATAgent(manager.Manager):"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmZ8%3D","line":140,"updated":"2013-07-16 00:48:33.000000000","message":"wouldn\u0027t be better to move line 140 to 51?\nwe would keep all variables together","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"f8d5b747fb5deae09d6dabad2403f38cc9e1d926","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          *args, action\u003dself._snat_action)"},{"line_number":138,"context_line":"        self._snat_action \u003d None"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"RPC_LOOP_INTERVAL \u003d 1"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class L3NATAgent(manager.Manager):"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmYM%3D","line":140,"in_reply_to":"AAAAP3%2F%2FmZ8%3D","updated":"2013-07-16 00:50:59.000000000","message":"Thanks I\u0027ll fix this in next patch","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b2f68ac9fbf15a73a7ecae56c9bee4d18fa4538e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            It is now a list of router IDs only."},{"line_number":152,"context_line":"            Per rpc versioning rules,  it is backwards compatible."},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    OPTS \u003d ["},{"line_number":157,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmZA%3D","line":154,"updated":"2013-07-16 00:48:33.000000000","message":"I just want to understand how you will use this variable in the code, is this needed for something else but in this section? I am probably missing something here!!  :-)","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"f8d5b747fb5deae09d6dabad2403f38cc9e1d926","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            It is now a list of router IDs only."},{"line_number":152,"context_line":"            Per rpc versioning rules,  it is backwards compatible."},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    OPTS \u003d ["},{"line_number":157,"context_line":"        cfg.StrOpt(\u0027external_network_bridge\u0027, default\u003d\u0027br-ex\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmYI%3D","line":154,"in_reply_to":"AAAAP3%2F%2FmZA%3D","updated":"2013-07-16 00:50:59.000000000","message":"This is needed to specify rpc server version.\n(see manager.Manager) :)","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9657607c788b7ae1e7b21eecd11c6b5377da8405","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def _router_ids(self):"},{"line_number":699,"context_line":"        if not self.conf.use_namespaces:"},{"line_number":700,"context_line":"            return self.conf.router_id"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @periodic_task.periodic_task"},{"line_number":703,"context_line":"    @lockutils.synchronized(\u0027l3-agent\u0027, \u0027neutron-\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmXM%3D","line":700,"updated":"2013-07-16 01:02:11.000000000","message":"This method should return a list of router IDs but it returns an ID.","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"f4cbc56dede2f8f5f835ede7a02bacecd53685a7","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def _router_ids(self):"},{"line_number":699,"context_line":"        if not self.conf.use_namespaces:"},{"line_number":700,"context_line":"            return self.conf.router_id"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @periodic_task.periodic_task"},{"line_number":703,"context_line":"    @lockutils.synchronized(\u0027l3-agent\u0027, \u0027neutron-\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmWk%3D","line":700,"in_reply_to":"AAAAP3%2F%2FmXM%3D","updated":"2013-07-16 01:10:56.000000000","message":"You are right.\nThank you for your catching this!","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1631e7b22a9e4cefee8880f1a5691360107c779c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            self._destroy_router_namespaces(self.conf.router_id)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        self.rpc_loop \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":217,"context_line":"            self._rpc_loop)"},{"line_number":218,"context_line":"        self.rpc_loop.start(interval\u003dRPC_LOOP_INTERVAL)"},{"line_number":219,"context_line":"        super(L3NATAgent, self).__init__(host\u003dself.conf.host)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fkv8%3D","line":217,"updated":"2013-07-16 12:12:31.000000000","message":"i liked the first option where there was the configuration variable. do you think that someone may want to change the value? if not then i am fine with it. i think that having an option to tune things is very important but not critical","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"95342214bd286f949ac6e8eb310992a847898c55","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            self._destroy_router_namespaces(self.conf.router_id)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        self.rpc_loop \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":217,"context_line":"            self._rpc_loop)"},{"line_number":218,"context_line":"        self.rpc_loop.start(interval\u003dRPC_LOOP_INTERVAL)"},{"line_number":219,"context_line":"        super(L3NATAgent, self).__init__(host\u003dself.conf.host)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fkhk%3D","line":217,"in_reply_to":"AAAAP3%2F%2Fkv8%3D","updated":"2013-07-16 13:17:21.000000000","message":"This is the discussion with Russel.\nhttps://review.openstack.org/#/c/36890/18/neutron/agent/l3_agent.py","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f985b034ddc913f96c32f9f66aa8ce3c92208358","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            pool.spawn_n(self.process_router, ri)"},{"line_number":668,"context_line":"        # identify and remove routers that no longer exist"},{"line_number":669,"context_line":"        for router_id in prev_router_ids - cur_router_ids:"},{"line_number":670,"context_line":"            pool.spawn_n(self._router_removed, router_id)"},{"line_number":671,"context_line":"        pool.waitall()"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    @lockutils.synchronized(\u0027l3-agent\u0027, \u0027neutron-\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FlKQ%3D","line":670,"updated":"2013-07-16 10:00:18.000000000","message":"process_router called iptables.apply, router_removed() also calls iptables.apply, don\u0027t they make mess into iptables if they run at the same time?","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"95342214bd286f949ac6e8eb310992a847898c55","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            pool.spawn_n(self.process_router, ri)"},{"line_number":668,"context_line":"        # identify and remove routers that no longer exist"},{"line_number":669,"context_line":"        for router_id in prev_router_ids - cur_router_ids:"},{"line_number":670,"context_line":"            pool.spawn_n(self._router_removed, router_id)"},{"line_number":671,"context_line":"        pool.waitall()"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    @lockutils.synchronized(\u0027l3-agent\u0027, \u0027neutron-\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FkiU%3D","line":670,"in_reply_to":"AAAAP3%2F%2FlKQ%3D","updated":"2013-07-16 13:17:21.000000000","message":"iptables is per router namespace basis, so we can\u0027t do that","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0c0647f8e75851b16f52855d5afbe1ac6e9b6b09","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                router_ids \u003d list(self.updated_routers)"},{"line_number":682,"context_line":"                self.updated_routers.clear()"},{"line_number":683,"context_line":"                routers \u003d self.plugin_rpc.get_routers("},{"line_number":684,"context_line":"                    self.context, router_ids)"},{"line_number":685,"context_line":"                self._process_routers(routers)"},{"line_number":686,"context_line":"            self._process_router_delete()"},{"line_number":687,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FmAc%3D","line":684,"updated":"2013-07-16 04:17:37.000000000","message":"Due to the bug https://bugs.launchpad.net/neutron/+bug/1201553, plugin_rpc.get_routers() always retrieves information of all routers on this agent. It means always fullsync\u003dTrue.\n\nIt does not break the behavior, but it is not ideal from the point of performance.\n\nI will look more. It seems l3_agent_scheduler needs to be fixed.","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f985b034ddc913f96c32f9f66aa8ce3c92208358","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    def _process_router_delete(self):"},{"line_number":692,"context_line":"        current_removed_routers \u003d list(self.removed_routers)"},{"line_number":693,"context_line":"        for router_id in current_removed_routers:"},{"line_number":694,"context_line":"            self.router_deleted(context, router_id)"},{"line_number":695,"context_line":"            self.removed_routers.remove(router_id)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def _router_ids(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FlKs%3D","line":694,"updated":"2013-07-16 10:00:18.000000000","message":"should be _router_removed()?","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"95342214bd286f949ac6e8eb310992a847898c55","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    def _process_router_delete(self):"},{"line_number":692,"context_line":"        current_removed_routers \u003d list(self.removed_routers)"},{"line_number":693,"context_line":"        for router_id in current_removed_routers:"},{"line_number":694,"context_line":"            self.router_deleted(context, router_id)"},{"line_number":695,"context_line":"            self.removed_routers.remove(router_id)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def _router_ids(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FkiM%3D","line":694,"in_reply_to":"AAAAP3%2F%2FlKs%3D","updated":"2013-07-16 13:17:21.000000000","message":"Thanks! I\u0027ll update","commit_id":"b43e9df93dec273fb53b96f724873ec9578be7e1"}],"neutron/api/rpc/agentnotifiers/l3_rpc_agent_api.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f4877a8bcc7994b706d75b673bea8e266a7bb4c","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def router_deleted(self, context, router_id):"},{"line_number":100,"context_line":"        self._notification_fanout(context, \u0027router_deleted\u0027, router_id)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def routers_updated(self, context, routers, operation\u003dNone, data\u003dNone):"},{"line_number":103,"context_line":"        if routers:"},{"line_number":104,"context_line":"            self._notification(context, \u0027routers_updated\u0027, routers,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fn7Q%3D","line":101,"updated":"2013-07-15 18:56:25.000000000","message":"It is better to rename \"routers\" to \"router_ids\" since it takes a list of router IDs now.","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c53d7444a44618115026b0cdaedb57264d2a405d","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def router_deleted(self, context, router_id):"},{"line_number":100,"context_line":"        self._notification_fanout(context, \u0027router_deleted\u0027, router_id)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def routers_updated(self, context, routers, operation\u003dNone, data\u003dNone):"},{"line_number":103,"context_line":"        if routers:"},{"line_number":104,"context_line":"            self._notification(context, \u0027routers_updated\u0027, routers,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fnqo%3D","line":101,"in_reply_to":"AAAAP3%2F%2Fn7Q%3D","updated":"2013-07-15 19:10:34.000000000","message":"Done","commit_id":"110e9dcbc0568234100cf136c68ec752761f9411"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e57371903d16dc49b019d4ff0f9464d5fb594169","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027method\u0027: method})"},{"line_number":61,"context_line":"                self.cast("},{"line_number":62,"context_line":"                    context, self.make_msg(method,"},{"line_number":63,"context_line":"                                           routers\u003d[router_id]),"},{"line_number":64,"context_line":"                    topic\u003d\u0027%s.%s\u0027 % (l3_agent.topic, l3_agent.host))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _notification(self, context, method, router_ids, operation, data):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnDE%3D","line":63,"updated":"2013-07-15 21:19:54.000000000","message":"This looks like a non-backwards compatible change to the message format.  This should be versioned unless I\u0027m missing something...","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c108ea3616d5d92e1d5e1470c0ef1951b5488fff","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027method\u0027: method})"},{"line_number":61,"context_line":"                self.cast("},{"line_number":62,"context_line":"                    context, self.make_msg(method,"},{"line_number":63,"context_line":"                                           routers\u003d[router_id]),"},{"line_number":64,"context_line":"                    topic\u003d\u0027%s.%s\u0027 % (l3_agent.topic, l3_agent.host))"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _notification(self, context, method, router_ids, operation, data):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2Fm90%3D","line":63,"in_reply_to":"AAAAP3%2F%2FnDE%3D","updated":"2013-07-15 21:34:35.000000000","message":"Thanks! fixed","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f602b8ba0bd32125e5aba40321063daac99dc7ab","unresolved":false,"context_lines":[{"line_number":32,"context_line":"       1.1 Remove sync data from notification"},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, topic\u003dtopics.L3_AGENT):"},{"line_number":38,"context_line":"        super(L3AgentNotifyAPI, self).__init__("}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAP3%2F%2Fm8I%3D","line":35,"updated":"2013-07-15 21:45:04.000000000","message":"This isn\u0027t right.  This should stay at 1.0.  You should specify in the specific message that it requires at least 1.1.","commit_id":"99228521848ecff20de70ae395b8eb7d69e9d1ce"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"dbc6506f60585cc5849e3837b0d9be3fed03983e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"       1.1 Remove sync data from notification"},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.1\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, topic\u003dtopics.L3_AGENT):"},{"line_number":38,"context_line":"        super(L3AgentNotifyAPI, self).__init__("}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAP3%2F%2Fm1Q%3D","line":35,"in_reply_to":"AAAAP3%2F%2Fm8I%3D","updated":"2013-07-15 22:02:41.000000000","message":"Done","commit_id":"99228521848ecff20de70ae395b8eb7d69e9d1ce"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f602b8ba0bd32125e5aba40321063daac99dc7ab","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                self.cast("},{"line_number":68,"context_line":"                    context, self.make_msg(method,"},{"line_number":69,"context_line":"                                           routers\u003d[router_id]),"},{"line_number":70,"context_line":"                    topic\u003d\u0027%s.%s\u0027 % (l3_agent.topic, l3_agent.host))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _notification(self, context, method, router_ids, operation, data):"},{"line_number":73,"context_line":"        \"\"\"Notify all the agents that are hosting the routers.\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAP3%2F%2Fm78%3D","line":70,"updated":"2013-07-15 21:45:04.000000000","message":"You specify the version here.\n\nAnd actually, just adding a version here isn\u0027t sufficient.  You\u0027ve changed the meaning of an existing parameter, so it\u0027s not backwards compatible on the server side.\n\nYou should make the server side be able to handle either routers or router_ids, and dynamically adjust its behavior based on what it recieves.  Then it would be able to handle both 1.0 and 1.1 messages.\n\nI also don\u0027t see the change on the server side to support 1.1, so I suspect this rev of the patch doesn\u0027t work at all.","commit_id":"99228521848ecff20de70ae395b8eb7d69e9d1ce"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"dbc6506f60585cc5849e3837b0d9be3fed03983e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                self.cast("},{"line_number":68,"context_line":"                    context, self.make_msg(method,"},{"line_number":69,"context_line":"                                           routers\u003d[router_id]),"},{"line_number":70,"context_line":"                    topic\u003d\u0027%s.%s\u0027 % (l3_agent.topic, l3_agent.host))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _notification(self, context, method, router_ids, operation, data):"},{"line_number":73,"context_line":"        \"\"\"Notify all the agents that are hosting the routers.\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAP3%2F%2Fm1U%3D","line":70,"in_reply_to":"AAAAP3%2F%2Fm78%3D","updated":"2013-07-15 22:02:41.000000000","message":"Thank you for your pointing this!\nI\u0027ll fix the code, and l3-agent backward compatible","commit_id":"99228521848ecff20de70ae395b8eb7d69e9d1ce"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cbf4b1b52146a4bca7bd623670738d0a99b439e1","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class L3AgentNotifyAPI(proxy.RpcProxy):"},{"line_number":28,"context_line":"    \"\"\"API for plugin to notify L3 agent.\"\"\""},{"line_number":29,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, topic\u003dtopics.L3_AGENT):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2FmtY%3D","side":"PARENT","line":28,"updated":"2013-07-15 22:54:00.000000000","message":"You removed a docstring here.  I would put it back.","commit_id":"bd18990d787b6c8b2e762bc9ec60d26714c2e1cb"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8ad73d6b079a5fd7acb6f581838fb51d984866e9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class L3AgentNotifyAPI(proxy.RpcProxy):"},{"line_number":28,"context_line":"    \"\"\"API for plugin to notify L3 agent.\"\"\""},{"line_number":29,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, topic\u003dtopics.L3_AGENT):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAP3%2F%2Fmk0%3D","side":"PARENT","line":28,"in_reply_to":"AAAAP3%2F%2FmtY%3D","updated":"2013-07-15 23:27:42.000000000","message":"Done","commit_id":"bd18990d787b6c8b2e762bc9ec60d26714c2e1cb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9657607c788b7ae1e7b21eecd11c6b5377da8405","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def router_added_to_agent(self, context, router_ids, host):"},{"line_number":113,"context_line":"        self._notification_host(context, \u0027router_added_to_agent\u0027,"},{"line_number":114,"context_line":"                                router_ids, host)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"L3AgentNotify \u003d L3AgentNotifyAPI()"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmZM%3D","line":114,"updated":"2013-07-16 01:02:11.000000000","message":"The 3rd argument \"routers\" should not be renamed to \"router_ids\". add_router_to_l3_agent in db/agentschedulers_db.py calls this method and in add_router_to_l3_agent the return value from get_sync_data() is passed to the 3rd argument. get_sync_data() returns a more complex value instead of a list of router IDs.","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"f4cbc56dede2f8f5f835ede7a02bacecd53685a7","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def router_added_to_agent(self, context, router_ids, host):"},{"line_number":113,"context_line":"        self._notification_host(context, \u0027router_added_to_agent\u0027,"},{"line_number":114,"context_line":"                                router_ids, host)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"L3AgentNotify \u003d L3AgentNotifyAPI()"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAP3%2F%2FmVY%3D","line":114,"in_reply_to":"AAAAP3%2F%2FmZM%3D","updated":"2013-07-16 01:10:56.000000000","message":"It looks like I should update db/agentschedulers_db.py.","commit_id":"b86e67d098ce03fdf90ba17875378f90ce2b82a1"}],"neutron/db/l3_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd2c175d8e2a3468d15f788d8015eddfd5f3a95d","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        if \u0027port_id\u0027 in interface_info:"},{"line_number":338,"context_line":"            # make sure port update is commited"},{"line_number":339,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":340,"context_line":"                if \u0027subnet_id\u0027 in interface_info:"},{"line_number":341,"context_line":"                    msg \u003d _(\"Cannot specify both subnet-id and port-id\")"},{"line_number":342,"context_line":"                    raise q_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAP3%2F%2Fq8Y%3D","line":339,"updated":"2013-07-14 11:35:50.000000000","message":"This change appears to fix something which was previously overlooked, but unrelated to this patch. \nIf this is correct, please add a note for it in the commit message.","commit_id":"0a721d3434c83a9f67636ac76a9deeaabda4b56f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4fabecfb391c62ab2682f4a182768cc105ff4a55","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        if \u0027port_id\u0027 in interface_info:"},{"line_number":338,"context_line":"            # make sure port update is commited"},{"line_number":339,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":340,"context_line":"                if \u0027subnet_id\u0027 in interface_info:"},{"line_number":341,"context_line":"                    msg \u003d _(\"Cannot specify both subnet-id and port-id\")"},{"line_number":342,"context_line":"                    raise q_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAP3%2F%2Fq2k%3D","line":339,"in_reply_to":"AAAAP3%2F%2Fq8Y%3D","updated":"2013-07-14 15:13:54.000000000","message":"In previous code, add_router_interface function calls get router sync data func, so this context is not needed.\nHowever this method stop working after get router sync function, so this change is needed for this patch.\nI\u0027ll mention this also in commit message.","commit_id":"0a721d3434c83a9f67636ac76a9deeaabda4b56f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebe854cb4ef4d52854676a04134c9d0eba468645","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            raise q_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        if \u0027port_id\u0027 in interface_info:"},{"line_number":338,"context_line":"            # make sure port update is commited"},{"line_number":339,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":340,"context_line":"                if \u0027subnet_id\u0027 in interface_info:"},{"line_number":341,"context_line":"                    msg \u003d _(\"Cannot specify both subnet-id and port-id\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnEI%3D","line":338,"updated":"2013-07-15 21:17:22.000000000","message":"commited \u003d\u003e  committed","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c108ea3616d5d92e1d5e1470c0ef1951b5488fff","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            raise q_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        if \u0027port_id\u0027 in interface_info:"},{"line_number":338,"context_line":"            # make sure port update is commited"},{"line_number":339,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":340,"context_line":"                if \u0027subnet_id\u0027 in interface_info:"},{"line_number":341,"context_line":"                    msg \u003d _(\"Cannot specify both subnet-id and port-id\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAP3%2F%2FnB8%3D","line":338,"in_reply_to":"AAAAP3%2F%2FnEI%3D","updated":"2013-07-15 21:34:35.000000000","message":"Done","commit_id":"b7753f778d5a9def7ff39302ee329268cde8c488"}]}
