)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7218e037eb34761dd209d41fe3db6806abfb71db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: the last fix of is_kernel_supported_for_ovs25 condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously we didn\u0027t consider kernels higher than 4. This patch returns"},{"line_number":10,"context_line":"True right away if the verions is lesser than 4. If it is 4, then it must"},{"line_number":11,"context_line":"be lesser or equal to 3 to return True. All other versions are not"},{"line_number":12,"context_line":"supported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_48e50a07","line":9,"updated":"2016-09-13 09:10:45.000000000","message":"yeah, I considered it a known bug in the code, but if like, we can fix it now.","commit_id":"2944d69c830d72c7e98496ca66b6557f67eb6c08"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"12e84495ac3454e09bfe9a63ead64c3641bfd619","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: the last fix of is_kernel_supported_for_ovs25 condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously we didn\u0027t consider kernels higher than 4. This patch returns"},{"line_number":10,"context_line":"True right away if the verions is lesser than 4. If it is 4, then it must"},{"line_number":11,"context_line":"be lesser or equal to 3 to return True. All other versions are not"},{"line_number":12,"context_line":"supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e9fa088d7cb9cfecbe7670c84a051e15be2a3a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_14b1618f","line":11,"range":{"start_line":9,"start_character":53,"end_line":11,"end_character":39},"updated":"2016-09-13 08:15:26.000000000","message":"This is a bit confusing. Should this be \"False\" instead of \"True\"? 4.3 is this minimum version supporting OVS 2.5, right?","commit_id":"2944d69c830d72c7e98496ca66b6557f67eb6c08"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9032be9bae39803a5621a1889da350cf2ff437cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: the last fix of is_kernel_supported_for_ovs25 condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously we didn\u0027t consider kernels higher than 4. This patch returns"},{"line_number":10,"context_line":"True right away if the verions is lesser than 4. If it is 4, then it must"},{"line_number":11,"context_line":"be lesser or equal to 3 to return True. All other versions are not"},{"line_number":12,"context_line":"supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3e9fa088d7cb9cfecbe7670c84a051e15be2a3a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_284c4641","line":11,"range":{"start_line":9,"start_character":53,"end_line":11,"end_character":39},"in_reply_to":"9a89bdaa_14b1618f","updated":"2016-09-13 09:08:48.000000000","message":"4.3 should still return True. So all lesser or equal return True","commit_id":"2944d69c830d72c7e98496ca66b6557f67eb6c08"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7587b2db911f2130f1468912194bb8e2c5d5e08d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-13 11:21:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: the last fix of is_kernel_supported_for_ovs25 condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously we didn\u0027t consider kernels higher than 4. This patch returns"},{"line_number":10,"context_line":"True right away if the verions is lesser than 4. If it is 4, then it must"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_00191688","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":18},"updated":"2016-09-13 10:20:06.000000000","message":"I DON\u0027T BELIEVE YOU!!","commit_id":"c8de31cc36f1875396aa2059e236df3d04bedb91"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6355e29f74ee8da37597de0925a6c5c308e573fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-13 11:21:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: the last fix of is_kernel_supported_for_ovs25 condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously we didn\u0027t consider kernels higher than 4. This patch returns"},{"line_number":10,"context_line":"True right away if the verions is lesser than 4. If it is 4, then it must"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_8373707f","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":18},"in_reply_to":"9a89bdaa_00191688","updated":"2016-09-13 10:22:54.000000000","message":"This \u0027verion\u0027 of patch is armoured, bulletproof, undestroyable and immortal.","commit_id":"c8de31cc36f1875396aa2059e236df3d04bedb91"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7587b2db911f2130f1468912194bb8e2c5d5e08d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"devstack: the last fix of is_kernel_supported_for_ovs25 condition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously we didn\u0027t consider kernels higher than 4. This patch returns"},{"line_number":10,"context_line":"True right away if the verions is lesser than 4. If it is 4, then it must"},{"line_number":11,"context_line":"be lesser or equal to 3 to return True. All other versions are not"},{"line_number":12,"context_line":"supported."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_400f9e38","line":10,"updated":"2016-09-13 10:20:06.000000000","message":"version","commit_id":"c8de31cc36f1875396aa2059e236df3d04bedb91"}],"devstack/lib/ovs":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7218e037eb34761dd209d41fe3db6806abfb71db","unresolved":false,"context_lines":[{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -lt 4 -o $major -eq 4 -a $minor -le 3 ]; then"},{"line_number":42,"context_line":"        return 0"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a89bdaa_48934a5b","line":41,"updated":"2016-09-13 09:10:45.000000000","message":"I suggest we split the condition to have separate branches for 2-3.x, 4.x, and all other versions. That will be easier to reason about than those three operators.","commit_id":"2944d69c830d72c7e98496ca66b6557f67eb6c08"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e101256930b2cc7055851b6e5441f32ea1eabd99","unresolved":false,"context_lines":[{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -lt 4 -o $major -eq 4 -a $minor -le 3 ]; then"},{"line_number":42,"context_line":"        return 0"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a89bdaa_43496d30","line":41,"in_reply_to":"9a89bdaa_48934a5b","updated":"2016-09-13 09:22:09.000000000","message":"Done","commit_id":"2944d69c830d72c7e98496ca66b6557f67eb6c08"}]}