)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5a264e5ad648a3e4803095c933bf6f07800d5493","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                            self,"},{"line_number":720,"context_line":"                            context\u003dcontext,"},{"line_number":721,"context_line":"                            router_id\u003drouter_id,"},{"line_number":722,"context_line":"                            network_id\u003dnetwork_id"},{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"                # raise the underlying exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_eaa09644","line":722,"updated":"2016-09-13 08:47:30.000000000","message":"Although not strictly necessary, it would be good to include the subnet_id in the notification.\n\nIt is easy to include in the _add_interface_by_subnet case.\nIn the _add_interface_by_port case, a db query is required to find the subnet_id from the port (Port/IPAllocation relation).","commit_id":"36cd9ac62b9e4419ced2a18970c9257e50c1a894"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"872c122c4d51c69fb691a744ee9d71662b31a40f","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                            self,"},{"line_number":720,"context_line":"                            context\u003dcontext,"},{"line_number":721,"context_line":"                            router_id\u003drouter_id,"},{"line_number":722,"context_line":"                            network_id\u003dnetwork_id"},{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"                # raise the underlying exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_cdd92c58","line":722,"in_reply_to":"9a89bdaa_eaa09644","updated":"2016-09-13 08:56:18.000000000","message":"As you said, for now, nobody needs it. So my opnion is to code it once somebody needs it.","commit_id":"36cd9ac62b9e4419ced2a18970c9257e50c1a894"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5a264e5ad648a3e4803095c933bf6f07800d5493","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        # Update owner before actual process in order to avoid the"},{"line_number":730,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":731,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":732,"context_line":"        port \u003d self._check_router_port(context, port_id, \u0027\u0027)"},{"line_number":733,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":734,"context_line":"                                         port[\u0027network_id\u0027])"},{"line_number":735,"context_line":"        prev_owner \u003d port[\u0027device_owner\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ea8416d4","line":732,"range":{"start_line":732,"start_character":15,"end_line":732,"end_character":60},"updated":"2016-09-13 08:47:30.000000000","message":"This call is already done by add_router_interface, the only caller of _add_interface_by_port. It would be more efficient to avoid calling it twice by passing \u0027port\u0027 instead of port_id to _add_interface_by_port.","commit_id":"36cd9ac62b9e4419ced2a18970c9257e50c1a894"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"872c122c4d51c69fb691a744ee9d71662b31a40f","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        # Update owner before actual process in order to avoid the"},{"line_number":730,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":731,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":732,"context_line":"        port \u003d self._check_router_port(context, port_id, \u0027\u0027)"},{"line_number":733,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":734,"context_line":"                                         port[\u0027network_id\u0027])"},{"line_number":735,"context_line":"        prev_owner \u003d port[\u0027device_owner\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ed10b002","line":732,"range":{"start_line":732,"start_character":15,"end_line":732,"end_character":60},"in_reply_to":"9a89bdaa_ea8416d4","updated":"2016-09-13 08:56:18.000000000","message":"+1, my mistake!","commit_id":"36cd9ac62b9e4419ced2a18970c9257e50c1a894"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0ac3b24177434acddc4286cb8e9e1a5b30f96b18","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def _add_interface_by_subnet(self, context, router, subnet_id, owner):"},{"line_number":752,"context_line":"        subnet \u003d self._core_plugin.get_subnet(context, subnet_id)"},{"line_number":753,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":754,"context_line":"                                         subnet[\u0027network_id\u0027])"},{"line_number":755,"context_line":"        if not subnet[\u0027gateway_ip\u0027]:"},{"line_number":756,"context_line":"            msg \u003d _(\u0027Subnet for router interface must have a gateway IP\u0027)"},{"line_number":757,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_66275512","line":754,"range":{"start_line":753,"start_character":8,"end_line":754,"end_character":62},"updated":"2016-09-13 12:00:55.000000000","message":"why not notify once in add_router_interface()?","commit_id":"274747eb01153d48cc2096e0e4c4dfdbeea6ddb9"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"43a17640df98f219ea974af4d67df7030eef5574","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def _add_interface_by_subnet(self, context, router, subnet_id, owner):"},{"line_number":752,"context_line":"        subnet \u003d self._core_plugin.get_subnet(context, subnet_id)"},{"line_number":753,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":754,"context_line":"                                         subnet[\u0027network_id\u0027])"},{"line_number":755,"context_line":"        if not subnet[\u0027gateway_ip\u0027]:"},{"line_number":756,"context_line":"            msg \u003d _(\u0027Subnet for router interface must have a gateway IP\u0027)"},{"line_number":757,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_3f146c4b","line":754,"range":{"start_line":753,"start_character":8,"end_line":754,"end_character":62},"in_reply_to":"9a89bdaa_1fb16801","updated":"2016-09-13 12:41:15.000000000","message":"I\u0027d add the notification to both here and l3_dvr_db.add_router_interface then. It will be more clear and easier to find","commit_id":"274747eb01153d48cc2096e0e4c4dfdbeea6ddb9"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"428b6b2e921d95ae632073c14765352eabae1f1d","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def _add_interface_by_subnet(self, context, router, subnet_id, owner):"},{"line_number":752,"context_line":"        subnet \u003d self._core_plugin.get_subnet(context, subnet_id)"},{"line_number":753,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":754,"context_line":"                                         subnet[\u0027network_id\u0027])"},{"line_number":755,"context_line":"        if not subnet[\u0027gateway_ip\u0027]:"},{"line_number":756,"context_line":"            msg \u003d _(\u0027Subnet for router interface must have a gateway IP\u0027)"},{"line_number":757,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_6b00f634","line":754,"range":{"start_line":753,"start_character":8,"end_line":754,"end_character":62},"in_reply_to":"9a89bdaa_3f146c4b","updated":"2016-09-13 13:31:06.000000000","message":"Done","commit_id":"274747eb01153d48cc2096e0e4c4dfdbeea6ddb9"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fdcf2ddc77be4017786a216e56211f6c9d1e801f","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def _add_interface_by_subnet(self, context, router, subnet_id, owner):"},{"line_number":752,"context_line":"        subnet \u003d self._core_plugin.get_subnet(context, subnet_id)"},{"line_number":753,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":754,"context_line":"                                         subnet[\u0027network_id\u0027])"},{"line_number":755,"context_line":"        if not subnet[\u0027gateway_ip\u0027]:"},{"line_number":756,"context_line":"            msg \u003d _(\u0027Subnet for router interface must have a gateway IP\u0027)"},{"line_number":757,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_1fb16801","line":754,"range":{"start_line":753,"start_character":8,"end_line":754,"end_character":62},"in_reply_to":"9a89bdaa_66275512","updated":"2016-09-13 12:36:10.000000000","message":"That was my initial intention, but I figured out that l3_db.add_router_interface was not called by the L3RouterPlugin. The plugin is using l3_dvr_db.add_router_interface instead.\n\nBoth methods are using l3_db._add_interface_by_subnet or l3_db._add_interface_by_port, so I ended up putting the code there to cover any case.","commit_id":"274747eb01153d48cc2096e0e4c4dfdbeea6ddb9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d72ea2dc584a7fbb77cd5d6baf362b3c7c29b6a6","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                            network_id\u003dnetwork_id"},{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"                # raise the underlying exception"},{"line_number":726,"context_line":"                raise e.errors[0].error"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _add_interface_by_port(self, context, router, port, owner):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_fb6a0f19","line":725,"updated":"2016-09-13 14:24:18.000000000","message":"indentation","commit_id":"719e44146e82bffed8d99f26043b63ac5211b0b7"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"289294e7aa0db5817e46a87211dd635ac69e2d1f","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                            network_id\u003dnetwork_id"},{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"                # raise the underlying exception"},{"line_number":726,"context_line":"                raise e.errors[0].error"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _add_interface_by_port(self, context, router, port, owner):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_a1a3fafe","line":725,"in_reply_to":"9a89bdaa_fb6a0f19","updated":"2016-09-13 14:52:47.000000000","message":"Done","commit_id":"719e44146e82bffed8d99f26043b63ac5211b0b7"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ca900b39ec2d5d819df5c676eec4095676a4a0fc","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"                # raise the underlying exception"},{"line_number":726,"context_line":"                raise e.errors[0].error"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _add_interface_by_port(self, context, router, port, owner):"},{"line_number":729,"context_line":"        # Update owner before actual process in order to avoid the"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_93c52e5d","line":726,"updated":"2016-09-13 19:52:24.000000000","message":"for new error conditions we should not assume that only a single error be present.","commit_id":"719e44146e82bffed8d99f26043b63ac5211b0b7"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"e96ab8f967da5fa2f39625545ba8e877bbee7e52","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"                # raise the underlying exception"},{"line_number":726,"context_line":"                raise e.errors[0].error"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _add_interface_by_port(self, context, router, port, owner):"},{"line_number":729,"context_line":"        # Update owner before actual process in order to avoid the"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_1eeda28b","line":726,"in_reply_to":"7a8ec9b2_93c52e5d","updated":"2016-09-13 21:33:15.000000000","message":"good point. I copied how other \"BEFORE\" callbacks errors were reraised :\n\nhttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/external_net_db.py#n138\nhttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/external_net_db.py#n155\n\nDo you want to raise a dedicated exception instead?","commit_id":"719e44146e82bffed8d99f26043b63ac5211b0b7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"05b9ddb892807cbb09fbf96af00e40a9c5c9d768","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":731,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":732,"context_line":"        self._core_plugin.update_port("},{"line_number":733,"context_line":"            context, port[\u0027id\u0027], {\u0027port\u0027: {\u0027device_id\u0027: router.id,"},{"line_number":734,"context_line":"                                           \u0027device_owner\u0027: owner}})"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"        return self._validate_router_port_info(context, router, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c1b1dee1","line":733,"range":{"start_line":733,"start_character":21,"end_line":733,"end_character":31},"updated":"2016-09-13 14:49:33.000000000","message":"no need to pass port now, port_id is fine","commit_id":"719e44146e82bffed8d99f26043b63ac5211b0b7"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"289294e7aa0db5817e46a87211dd635ac69e2d1f","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":731,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":732,"context_line":"        self._core_plugin.update_port("},{"line_number":733,"context_line":"            context, port[\u0027id\u0027], {\u0027port\u0027: {\u0027device_id\u0027: router.id,"},{"line_number":734,"context_line":"                                           \u0027device_owner\u0027: owner}})"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"        return self._validate_router_port_info(context, router, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e160a203","line":733,"range":{"start_line":733,"start_character":21,"end_line":733,"end_character":31},"in_reply_to":"9a89bdaa_c1b1dee1","updated":"2016-09-13 14:52:47.000000000","message":"I was trying to be consistent with the _add_interface_by_subnet signature, where subnet is needed.","commit_id":"719e44146e82bffed8d99f26043b63ac5211b0b7"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a7ba19554458beb0b80662927e570a1804d48071","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"            # raise the underlying exception"},{"line_number":726,"context_line":"            raise e.errors[0].error"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _add_interface_by_port(self, context, router, port_id, owner):"},{"line_number":729,"context_line":"        # Update owner before actual process in order to avoid the"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_858228c7","line":726,"updated":"2016-09-19 22:24:30.000000000","message":"please do not reraise like this, because if there are multiple exceptions you\u0027re only reporting one, which makes no sense. Have you considered raising [1]?\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/exceptions.py#L190","commit_id":"2b6226aacc0514ede5a5fd4ac343b634bff055c3"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f8225a2ff66582677e964bc59f185646e5654121","unresolved":false,"context_lines":[{"line_number":723,"context_line":"                            )"},{"line_number":724,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":725,"context_line":"            # raise the underlying exception"},{"line_number":726,"context_line":"            raise e.errors[0].error"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _add_interface_by_port(self, context, router, port_id, owner):"},{"line_number":729,"context_line":"        # Update owner before actual process in order to avoid the"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_d3114c5f","line":726,"in_reply_to":"7a8ec9b2_858228c7","updated":"2016-09-20 08:13:14.000000000","message":"I agree on that.\n\nI feel like we cannot consider that the attachment is forbidden because the \"subnet is in use\". We cannot bet on the reason why a third party code is raising an exception when a requesting is asking for an attachment. \n\nSo I would be more comfortable with introducing a more generic Exception.\n\nThoughts?","commit_id":"2b6226aacc0514ede5a5fd4ac343b634bff055c3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a7ba19554458beb0b80662927e570a1804d48071","unresolved":false,"context_lines":[{"line_number":746,"context_line":"            if p[\u0027network_id\u0027] \u003d\u003d net_id and self._port_has_ipv6_address(p):"},{"line_number":747,"context_line":"                return port"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    def _add_interface_by_subnet(self, context, router, subnet, owner):"},{"line_number":750,"context_line":"        if not subnet[\u0027gateway_ip\u0027]:"},{"line_number":751,"context_line":"            msg \u003d _(\u0027Subnet for router interface must have a gateway IP\u0027)"},{"line_number":752,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_657d1ce7","line":749,"updated":"2016-09-19 22:24:30.000000000","message":"please do not change the signatures of private methods at this time of the cycle.","commit_id":"2b6226aacc0514ede5a5fd4ac343b634bff055c3"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f8225a2ff66582677e964bc59f185646e5654121","unresolved":false,"context_lines":[{"line_number":746,"context_line":"            if p[\u0027network_id\u0027] \u003d\u003d net_id and self._port_has_ipv6_address(p):"},{"line_number":747,"context_line":"                return port"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    def _add_interface_by_subnet(self, context, router, subnet, owner):"},{"line_number":750,"context_line":"        if not subnet[\u0027gateway_ip\u0027]:"},{"line_number":751,"context_line":"            msg \u003d _(\u0027Subnet for router interface must have a gateway IP\u0027)"},{"line_number":752,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_8eb4fcd1","line":749,"in_reply_to":"7a8ec9b2_657d1ce7","updated":"2016-09-20 08:13:14.000000000","message":"In this case, it would make sense to get back to PS1 like patch, where the notification were triggered in methods _add_interface_by_subnet and _add_interface_by_port","commit_id":"2b6226aacc0514ede5a5fd4ac343b634bff055c3"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"97460caaacf4d2a446ecd6fd84fbc031dc40d226","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        # Update owner before actual process in order to avoid the"},{"line_number":732,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":733,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":734,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":735,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":736,"context_line":"                                         port[\u0027network_id\u0027])"},{"line_number":737,"context_line":"        self._core_plugin.update_port("}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_8a2a21e6","line":734,"range":{"start_line":734,"start_character":14,"end_line":734,"end_character":41},"updated":"2016-09-20 09:33:20.000000000","message":"To avoid changing the signature of _add_interface_by_port, I need to call get_port from the plugin here.\n\nIt is already done in _check_router, but unfortunately, I don\u0027t have the router_id in this method, so I can\u0027t trigger the notification in it.","commit_id":"6d054ff1d3a04e1b2d67be51e2ae4f0251175f9a"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"449bfc54325429ea478089eade19665d1efd06f2","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        # Update owner before actual process in order to avoid the"},{"line_number":732,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":733,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":734,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":735,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":736,"context_line":"                                         port[\u0027network_id\u0027])"},{"line_number":737,"context_line":"        self._core_plugin.update_port("}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_a6a7474e","line":734,"range":{"start_line":734,"start_character":14,"end_line":734,"end_character":41},"in_reply_to":"7a8ec9b2_26d9cc57","updated":"2016-09-22 08:36:57.000000000","message":"great! It will save a plugin.get_port call","commit_id":"6d054ff1d3a04e1b2d67be51e2ae4f0251175f9a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3deda1e4689904334e68cc61e4e060559c922a16","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        # Update owner before actual process in order to avoid the"},{"line_number":732,"context_line":"        # case where a port might get attached to a router without the"},{"line_number":733,"context_line":"        # owner successfully updating due to an unavailable backend."},{"line_number":734,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":735,"context_line":"        self._notify_attaching_interface(context, router.id,"},{"line_number":736,"context_line":"                                         port[\u0027network_id\u0027])"},{"line_number":737,"context_line":"        self._core_plugin.update_port("}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_26d9cc57","line":734,"range":{"start_line":734,"start_character":14,"end_line":734,"end_character":41},"in_reply_to":"7a8ec9b2_8a2a21e6","updated":"2016-09-21 23:46:34.000000000","message":"you could modify _check_router_port in a bw fashion by passing router_id\u003dNone, have you considered this?","commit_id":"6d054ff1d3a04e1b2d67be51e2ae4f0251175f9a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0deea58697dd54b22c0bbb60a798f373446d327e","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        return port_id_specified, subnet_id_specified"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def _check_router_port(self, context, port_id, device_id,"},{"line_number":668,"context_line":"                           notify_router\u003dNone):"},{"line_number":669,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":670,"context_line":"        if notify_router is not None:"},{"line_number":671,"context_line":"            self._notify_attaching_interface(context, notify_router,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_250c0094","line":668,"updated":"2016-09-22 12:36:52.000000000","message":"notify_router is a lousy name, router_id is much better :)\n\nIn the process please add a docstring.","commit_id":"70c23d39598ec85e41f87a84fdd519b8f2932db0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"3eda9db9ce59a518750f457b33dd647f60d06314","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        return port_id_specified, subnet_id_specified"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def _check_router_port(self, context, port_id, device_id,"},{"line_number":668,"context_line":"                           notify_router\u003dNone):"},{"line_number":669,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":670,"context_line":"        if notify_router is not None:"},{"line_number":671,"context_line":"            self._notify_attaching_interface(context, notify_router,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_a06c7e9d","line":668,"in_reply_to":"5a8bc5a2_250c0094","updated":"2016-09-22 12:44:42.000000000","message":"I hesitated, but It was redundant with the device_id, that might also be the router_id, as here : \n\nhttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/l3_db.py#n683\n\nBut I\u0027ll move to router_id if you find it more relevant, and I\u0027ll add a docstring too.","commit_id":"70c23d39598ec85e41f87a84fdd519b8f2932db0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4b6b01224a4361369a35bf3f0980725e23f70617","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        return port_id_specified, subnet_id_specified"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def _check_router_port(self, context, port_id, device_id,"},{"line_number":668,"context_line":"                           notify_router\u003dNone):"},{"line_number":669,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":670,"context_line":"        if notify_router is not None:"},{"line_number":671,"context_line":"            self._notify_attaching_interface(context, notify_router,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_b4a04392","line":668,"in_reply_to":"5a8bc5a2_a06c7e9d","updated":"2016-09-22 13:00:52.000000000","message":"the meaning is different though. Hence the docstring is due.","commit_id":"70c23d39598ec85e41f87a84fdd519b8f2932db0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c73a0eed2e9ce5335846cd71181093bd037c9660","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        :param context: The context of the request."},{"line_number":672,"context_line":"        :param port_id: The port to be attached."},{"line_number":673,"context_line":"        :param device_id: The device id the port must have."},{"line_number":674,"context_line":"        :param router_id: The router id used to notify third party code that"},{"line_number":675,"context_line":"        a router attachment is occurring."},{"line_number":676,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":677,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_8404d67e","line":674,"range":{"start_line":674,"start_character":15,"end_line":674,"end_character":24},"updated":"2016-09-22 21:38:48.000000000","message":"What is the difference between device_id and router_id? router.id is passed to device_id when _check_router_port is called, so this hits me this question. If there is a meaningful difference, more description and argument naming are required.","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        :param context: The context of the request."},{"line_number":672,"context_line":"        :param port_id: The port to be attached."},{"line_number":673,"context_line":"        :param device_id: The device id the port must have."},{"line_number":674,"context_line":"        :param router_id: The router id used to notify third party code that"},{"line_number":675,"context_line":"        a router attachment is occurring."},{"line_number":676,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":677,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_eadd5315","line":674,"range":{"start_line":674,"start_character":15,"end_line":674,"end_character":24},"in_reply_to":"5a8bc5a2_8404d67e","updated":"2016-09-23 07:11:27.000000000","message":"actually, in some contexts (L831 at least), device_id is an empty string.\n\nthe device_id and the router_id don\u0027t play the same role. I\u0027ll be more explicit in the docstring.","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c73a0eed2e9ce5335846cd71181093bd037c9660","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        a router attachment is occurring."},{"line_number":676,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":677,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."},{"line_number":678,"context_line":"        :raises: BadRequest if the port has no fixed IP."},{"line_number":679,"context_line":"        \"\"\""},{"line_number":680,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":681,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_c4ab3e88","line":678,"updated":"2016-09-22 21:38:48.000000000","message":"nit: _notify_attaching_interface can raise RouterInterfaceAttachmentConflict as well.","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        a router attachment is occurring."},{"line_number":676,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":677,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."},{"line_number":678,"context_line":"        :raises: BadRequest if the port has no fixed IP."},{"line_number":679,"context_line":"        \"\"\""},{"line_number":680,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":681,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_aa218bfd","line":678,"in_reply_to":"5a8bc5a2_b109112f","updated":"2016-09-23 07:11:27.000000000","message":"Ok for adding another docstring. I agree  with manjeet here, it makes more sense to me to have the raise statement in the docstring of the method that actually raise the exception.","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"426f59fe6cfaef7b3717910349a75a4533ab10de","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        a router attachment is occurring."},{"line_number":676,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":677,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."},{"line_number":678,"context_line":"        :raises: BadRequest if the port has no fixed IP."},{"line_number":679,"context_line":"        \"\"\""},{"line_number":680,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":681,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_b109112f","line":678,"in_reply_to":"5a8bc5a2_c4ab3e88","updated":"2016-09-23 00:15:09.000000000","message":"instead of adding it here, a docstring to newly added method can also be added and better put raises RouterInterfaceAttachmentConflict there, I am fine either way","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"426f59fe6cfaef7b3717910349a75a4533ab10de","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":728,"context_line":"            return port, subnets"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def _notify_attaching_interface(self, context, router_id, network_id):"},{"line_number":731,"context_line":"        try:"},{"line_number":732,"context_line":"            registry.notify(resources.ROUTER_INTERFACE,"},{"line_number":733,"context_line":"                            events.BEFORE_CREATE,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_f113995a","line":730,"range":{"start_line":730,"start_character":4,"end_line":730,"end_character":74},"updated":"2016-09-23 00:15:09.000000000","message":"check comment on line 678","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c2bb488a030512c837ab0a1ad1847b9ea16b8c5f","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":682,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."},{"line_number":683,"context_line":"        :raises: BadRequest if the port has no fixed IP."},{"line_number":684,"context_line":"        :raises: RouterInterfaceAttachmentConflict if a third party code"},{"line_number":685,"context_line":"        prevents the port to be attached to the router."},{"line_number":686,"context_line":"        \"\"\""},{"line_number":687,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":688,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_2e864fb9","line":685,"range":{"start_line":684,"start_character":17,"end_line":685,"end_character":55},"updated":"2016-09-23 16:27:21.000000000","message":"why do you need it to say twice I think it is covered in the docstring of method below","commit_id":"d484b3d4857ae3986d6b50baeb6cf7873bc2851d"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f3f8ae5f030dc4587ab31605ed4693a3fda300ca","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        :returns: The port description returned by the core plugin."},{"line_number":682,"context_line":"        :raises: PortInUse if the device_id is not the same as the port\u0027s one."},{"line_number":683,"context_line":"        :raises: BadRequest if the port has no fixed IP."},{"line_number":684,"context_line":"        :raises: RouterInterfaceAttachmentConflict if a third party code"},{"line_number":685,"context_line":"        prevents the port to be attached to the router."},{"line_number":686,"context_line":"        \"\"\""},{"line_number":687,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":688,"context_line":"        if router_id is not None:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_f0e0ae98","line":685,"range":{"start_line":684,"start_character":17,"end_line":685,"end_character":55},"in_reply_to":"5a8bc5a2_2e864fb9","updated":"2016-09-24 19:50:38.000000000","message":"Done","commit_id":"d484b3d4857ae3986d6b50baeb6cf7873bc2851d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"6127f23a9ef966a16030ddc33049cb419ebd1e81","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        prevents the port to be attached to the router."},{"line_number":686,"context_line":"        \"\"\""},{"line_number":687,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":688,"context_line":"        if router_id is not None:"},{"line_number":689,"context_line":"            self._notify_attaching_interface(context, router_id,"},{"line_number":690,"context_line":"                                             port[\u0027network_id\u0027])"},{"line_number":691,"context_line":"        if port[\u0027device_id\u0027] !\u003d device_id:"},{"line_number":692,"context_line":"            raise n_exc.PortInUse(net_id\u003dport[\u0027network_id\u0027],"},{"line_number":693,"context_line":"                                  port_id\u003dport[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_da1bd219","line":690,"range":{"start_line":688,"start_character":0,"end_line":690,"end_character":64},"updated":"2016-09-24 12:10:51.000000000","message":"Wouldn\u0027t it be better to send the notification only after the checks at lines 691-697 have confirmed that the router interface can be added ?","commit_id":"d484b3d4857ae3986d6b50baeb6cf7873bc2851d"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f3f8ae5f030dc4587ab31605ed4693a3fda300ca","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        prevents the port to be attached to the router."},{"line_number":686,"context_line":"        \"\"\""},{"line_number":687,"context_line":"        port \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":688,"context_line":"        if router_id is not None:"},{"line_number":689,"context_line":"            self._notify_attaching_interface(context, router_id,"},{"line_number":690,"context_line":"                                             port[\u0027network_id\u0027])"},{"line_number":691,"context_line":"        if port[\u0027device_id\u0027] !\u003d device_id:"},{"line_number":692,"context_line":"            raise n_exc.PortInUse(net_id\u003dport[\u0027network_id\u0027],"},{"line_number":693,"context_line":"                                  port_id\u003dport[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_10f0ba66","line":690,"range":{"start_line":688,"start_character":0,"end_line":690,"end_character":64},"in_reply_to":"5a8bc5a2_da1bd219","updated":"2016-09-24 19:50:38.000000000","message":"Done","commit_id":"d484b3d4857ae3986d6b50baeb6cf7873bc2851d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4aeb23d9e889a8aae64f087d36497b0f3a665423","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        \"\"\""},{"line_number":746,"context_line":"        try:"},{"line_number":747,"context_line":"            registry.notify(resources.ROUTER_INTERFACE,"},{"line_number":748,"context_line":"                            events.BEFORE_CREATE,"},{"line_number":749,"context_line":"                            self,"},{"line_number":750,"context_line":"                            context\u003dcontext,"},{"line_number":751,"context_line":"                            router_id\u003drouter_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_ee0ef039","line":748,"updated":"2016-09-26 10:36:50.000000000","message":"Right, the resource is ROUTER_INTERFACE so BEFORE_CREATE is appropriate.","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c66ac1a25e9ff4ab84a994ff70768347dbffc30","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        \"\"\""},{"line_number":746,"context_line":"        try:"},{"line_number":747,"context_line":"            registry.notify(resources.ROUTER_INTERFACE,"},{"line_number":748,"context_line":"                            events.BEFORE_CREATE,"},{"line_number":749,"context_line":"                            self,"},{"line_number":750,"context_line":"                            context\u003dcontext,"},{"line_number":751,"context_line":"                            router_id\u003drouter_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_b312b055","line":748,"updated":"2016-09-24 20:25:01.000000000","message":"should we consider adding a new event - BEFORE_ATTACH?\nthe router has already been created","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"449d73bff160ac227b8d9b08fe8b17b359c1ed75","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        \"\"\""},{"line_number":746,"context_line":"        try:"},{"line_number":747,"context_line":"            registry.notify(resources.ROUTER_INTERFACE,"},{"line_number":748,"context_line":"                            events.BEFORE_CREATE,"},{"line_number":749,"context_line":"                            self,"},{"line_number":750,"context_line":"                            context\u003dcontext,"},{"line_number":751,"context_line":"                            router_id\u003drouter_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_d3757cfa","line":748,"in_reply_to":"5a8bc5a2_b312b055","updated":"2016-09-24 22:17:12.000000000","message":"BEFORE_CREATE is consistent with the already generated AFTER_CREATE event (line 894 below)\n\n(it\u0027s generated on a ROUTER_INTERFACE resource, not on a ROUTER resource)","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c66ac1a25e9ff4ab84a994ff70768347dbffc30","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                            )"},{"line_number":754,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":755,"context_line":"            # raise the underlying exception"},{"line_number":756,"context_line":"            reason \u003d (_(\u0027cannot perform router interface attachment\u0027"},{"line_number":757,"context_line":"                        \u0027 due to %(reason)s\u0027) % {\u0027reason\u0027: e})"},{"line_number":758,"context_line":"            raise l3.RouterInterfaceAttachmentConflict(reason\u003dreason)"},{"line_number":759,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_1328c485","line":756,"updated":"2016-09-24 20:25:01.000000000","message":"please put the space at the end of the sentence","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5a2db7898b77c64066a2cbd627daafdc601d9e77","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                            )"},{"line_number":754,"context_line":"        except exceptions.CallbackFailure as e:"},{"line_number":755,"context_line":"            # raise the underlying exception"},{"line_number":756,"context_line":"            reason \u003d (_(\u0027cannot perform router interface attachment\u0027"},{"line_number":757,"context_line":"                        \u0027 due to %(reason)s\u0027) % {\u0027reason\u0027: e})"},{"line_number":758,"context_line":"            raise l3.RouterInterfaceAttachmentConflict(reason\u003dreason)"},{"line_number":759,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_113ee0d9","line":756,"in_reply_to":"5a8bc5a2_1328c485","updated":"2016-09-26 11:04:58.000000000","message":"Done","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"10cf3997fa9f168efa11ac6384206591e93ee70b","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            with p_utils.update_port_on_error("},{"line_number":326,"context_line":"                    self._core_plugin, context, port_id, revert_value):"},{"line_number":327,"context_line":"                port, subnets \u003d self._add_interface_by_port("},{"line_number":328,"context_line":"                    context, router, port, device_owner)"},{"line_number":329,"context_line":"        elif add_by_sub:"},{"line_number":330,"context_line":"            subnet \u003d self._core_plugin.get_subnet(context,"},{"line_number":331,"context_line":"                                                  interface_info[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_fe018b6b","line":328,"range":{"start_line":328,"start_character":37,"end_line":328,"end_character":41},"updated":"2016-09-14 22:56:23.000000000","message":"is this change necessary for this patch.","commit_id":"19c0f0613c15c8c462d3778a2c34acb94edbfd81"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"5a40d901e7f028d33280a0eb5a748dd58d4b88cc","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            with p_utils.update_port_on_error("},{"line_number":326,"context_line":"                    self._core_plugin, context, port_id, revert_value):"},{"line_number":327,"context_line":"                port, subnets \u003d self._add_interface_by_port("},{"line_number":328,"context_line":"                    context, router, port, device_owner)"},{"line_number":329,"context_line":"        elif add_by_sub:"},{"line_number":330,"context_line":"            subnet \u003d self._core_plugin.get_subnet(context,"},{"line_number":331,"context_line":"                                                  interface_info[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_ddd5abb9","line":328,"range":{"start_line":328,"start_character":37,"end_line":328,"end_character":41},"in_reply_to":"7a8ec9b2_fe018b6b","updated":"2016-09-15 07:23:53.000000000","message":"as mentioned in other PS comments, I wanted to keep a \"common\" signature between _add_interface_by_port and _add_interface_by_subnet, where we need the subnet, not only the id. So I use port and not port_id here.\n\nBut I\u0027ll move back to port_id usage, since you and oleg don\u0027t seem to agree.","commit_id":"19c0f0613c15c8c462d3778a2c34acb94edbfd81"}],"neutron/extensions/l3.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4aeb23d9e889a8aae64f087d36497b0f3a665423","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"more floating IPs.\")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class RouterInterfaceAttachmentConflict(nexception.Conflict):"},{"line_number":84,"context_line":"    message \u003d _(\"Error %(reason)s while attempting the operation.\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_0e0cfc3f","line":83,"updated":"2016-09-26 10:36:50.000000000","message":"Presumably the callback error would have the details.","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c66ac1a25e9ff4ab84a994ff70768347dbffc30","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"more floating IPs.\")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class RouterInterfaceAttachmentConflict(nexception.Conflict):"},{"line_number":84,"context_line":"    message \u003d _(\"Error %(reason)s while attempting the operation.\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_332dc095","line":83,"updated":"2016-09-24 20:25:01.000000000","message":"The message here is very generic - it should be more specific","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"6f51553dfdfec4ef3f294fea296a2b7e92ddbf9a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"more floating IPs.\")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class RouterInterfaceAttachmentConflict(nexception.Conflict):"},{"line_number":84,"context_line":"    message \u003d _(\"Error %(reason)s while attempting the operation.\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_f19c1410","line":83,"in_reply_to":"5a8bc5a2_0e0cfc3f","updated":"2016-09-26 11:03:46.000000000","message":"exactly, as you can see in openstack/neutron/neutron/db/l3_db.py:753","commit_id":"884b691394bcd9b5d8688bf99712ef516aee2c40"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aebdd39a7ac8b9bbb24db1baf86554f9c3e1699f","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"                    {\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027]})"},{"line_number":1550,"context_line":"            kwargs \u003d {\u0027context\u0027: self.context, \u0027router_id\u0027: router[\u0027id\u0027],"},{"line_number":1551,"context_line":"                      \u0027network_id\u0027: net[\u0027network\u0027][\u0027id\u0027]}"},{"line_number":1552,"context_line":"            notif_handler.callback.assert_called_with("},{"line_number":1553,"context_line":"                resources.ROUTER_INTERFACE, events.BEFORE_CREATE,"},{"line_number":1554,"context_line":"                mock.ANY, **kwargs)"},{"line_number":1555,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_14fb68c2","line":1552,"range":{"start_line":1552,"start_character":35,"end_line":1552,"end_character":53},"updated":"2016-09-15 09:08:14.000000000","message":"assert_called_once_with","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"39d8522e92add164c38e75d6a6ee921b5dd24ae4","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"                    {\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027]})"},{"line_number":1550,"context_line":"            kwargs \u003d {\u0027context\u0027: self.context, \u0027router_id\u0027: router[\u0027id\u0027],"},{"line_number":1551,"context_line":"                      \u0027network_id\u0027: net[\u0027network\u0027][\u0027id\u0027]}"},{"line_number":1552,"context_line":"            notif_handler.callback.assert_called_with("},{"line_number":1553,"context_line":"                resources.ROUTER_INTERFACE, events.BEFORE_CREATE,"},{"line_number":1554,"context_line":"                mock.ANY, **kwargs)"},{"line_number":1555,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_e4cf277d","line":1552,"range":{"start_line":1552,"start_character":35,"end_line":1552,"end_character":53},"in_reply_to":"7a8ec9b2_14fb68c2","updated":"2016-09-15 10:03:45.000000000","message":"Done","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aebdd39a7ac8b9bbb24db1baf86554f9c3e1699f","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                    {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]})"},{"line_number":1568,"context_line":"            kwargs \u003d {\u0027context\u0027: self.context, \u0027router_id\u0027: router[\u0027id\u0027],"},{"line_number":1569,"context_line":"                      \u0027network_id\u0027: net[\u0027network\u0027][\u0027id\u0027]}"},{"line_number":1570,"context_line":"            notif_handler.callback.assert_called_with("},{"line_number":1571,"context_line":"                resources.ROUTER_INTERFACE, events.BEFORE_CREATE,"},{"line_number":1572,"context_line":"                mock.ANY, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_5405f0b9","line":1570,"range":{"start_line":1570,"start_character":35,"end_line":1570,"end_character":53},"updated":"2016-09-15 09:08:14.000000000","message":"ditto","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"39d8522e92add164c38e75d6a6ee921b5dd24ae4","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                    {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]})"},{"line_number":1568,"context_line":"            kwargs \u003d {\u0027context\u0027: self.context, \u0027router_id\u0027: router[\u0027id\u0027],"},{"line_number":1569,"context_line":"                      \u0027network_id\u0027: net[\u0027network\u0027][\u0027id\u0027]}"},{"line_number":1570,"context_line":"            notif_handler.callback.assert_called_with("},{"line_number":1571,"context_line":"                resources.ROUTER_INTERFACE, events.BEFORE_CREATE,"},{"line_number":1572,"context_line":"                mock.ANY, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_04cb3373","line":1570,"range":{"start_line":1570,"start_character":35,"end_line":1570,"end_character":53},"in_reply_to":"7a8ec9b2_5405f0b9","updated":"2016-09-15 10:03:45.000000000","message":"Done","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c73a0eed2e9ce5335846cd71181093bd037c9660","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"                           resources.ROUTER_INTERFACE,"},{"line_number":1543,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":1544,"context_line":"        router \u003d self._create_router()"},{"line_number":1545,"context_line":"        with self.network() as net,\\"},{"line_number":1546,"context_line":"                self.subnet(network\u003dnet) as subnet:"},{"line_number":1547,"context_line":"            self.l3_plugin.add_router_interface("},{"line_number":1548,"context_line":"                    self.context, router[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_0427e612","line":1545,"range":{"start_line":1545,"start_character":34,"end_line":1545,"end_character":36},"updated":"2016-09-22 21:38:48.000000000","message":"In most cases, we place a space before a backslash.","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"                           resources.ROUTER_INTERFACE,"},{"line_number":1543,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":1544,"context_line":"        router \u003d self._create_router()"},{"line_number":1545,"context_line":"        with self.network() as net,\\"},{"line_number":1546,"context_line":"                self.subnet(network\u003dnet) as subnet:"},{"line_number":1547,"context_line":"            self.l3_plugin.add_router_interface("},{"line_number":1548,"context_line":"                    self.context, router[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_ca1c17c4","line":1545,"range":{"start_line":1545,"start_character":34,"end_line":1545,"end_character":36},"in_reply_to":"5a8bc5a2_0427e612","updated":"2016-09-23 07:11:27.000000000","message":"Done","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c73a0eed2e9ce5335846cd71181093bd037c9660","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"                           resources.ROUTER_INTERFACE,"},{"line_number":1560,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":1561,"context_line":"        router \u003d self._create_router()"},{"line_number":1562,"context_line":"        with self.network() as net,\\"},{"line_number":1563,"context_line":"                self.subnet(network\u003dnet) as subnet,\\"},{"line_number":1564,"context_line":"                self.port(subnet\u003dsubnet) as port:"},{"line_number":1565,"context_line":"            self.l3_plugin.add_router_interface("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_2424e20b","line":1562,"range":{"start_line":1562,"start_character":34,"end_line":1562,"end_character":36},"updated":"2016-09-22 21:38:48.000000000","message":"ditto","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"                           resources.ROUTER_INTERFACE,"},{"line_number":1560,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":1561,"context_line":"        router \u003d self._create_router()"},{"line_number":1562,"context_line":"        with self.network() as net,\\"},{"line_number":1563,"context_line":"                self.subnet(network\u003dnet) as subnet,\\"},{"line_number":1564,"context_line":"                self.port(subnet\u003dsubnet) as port:"},{"line_number":1565,"context_line":"            self.l3_plugin.add_router_interface("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_ea79d3fd","line":1562,"range":{"start_line":1562,"start_character":34,"end_line":1562,"end_character":36},"in_reply_to":"5a8bc5a2_2424e20b","updated":"2016-09-23 07:11:27.000000000","message":"Done","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c73a0eed2e9ce5335846cd71181093bd037c9660","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":1561,"context_line":"        router \u003d self._create_router()"},{"line_number":1562,"context_line":"        with self.network() as net,\\"},{"line_number":1563,"context_line":"                self.subnet(network\u003dnet) as subnet,\\"},{"line_number":1564,"context_line":"                self.port(subnet\u003dsubnet) as port:"},{"line_number":1565,"context_line":"            self.l3_plugin.add_router_interface("},{"line_number":1566,"context_line":"                    self.context, router[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_4421eefa","line":1563,"range":{"start_line":1563,"start_character":50,"end_line":1563,"end_character":52},"updated":"2016-09-22 21:38:48.000000000","message":"ditto","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"                           events.BEFORE_CREATE)"},{"line_number":1561,"context_line":"        router \u003d self._create_router()"},{"line_number":1562,"context_line":"        with self.network() as net,\\"},{"line_number":1563,"context_line":"                self.subnet(network\u003dnet) as subnet,\\"},{"line_number":1564,"context_line":"                self.port(subnet\u003dsubnet) as port:"},{"line_number":1565,"context_line":"            self.l3_plugin.add_router_interface("},{"line_number":1566,"context_line":"                    self.context, router[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_eac71310","line":1563,"range":{"start_line":1563,"start_character":50,"end_line":1563,"end_character":52},"in_reply_to":"5a8bc5a2_4421eefa","updated":"2016-09-23 07:11:27.000000000","message":"Done","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"}],"neutron/tests/unit/db/test_l3_dvr_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2cb27802c37c421f93caa0b3e2e634642a95eb8d","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            mock_notify.assert_called_once_with("},{"line_number":650,"context_line":"                \u0027router\u0027, \u0027before_update\u0027, self.mixin, **kwargs)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def test_validate_add_router_interface_notify_advanced_services(self):"},{"line_number":653,"context_line":"        router \u003d {\u0027name\u0027: \u0027foo_router\u0027, \u0027admin_state_up\u0027: False}"},{"line_number":654,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":655,"context_line":"        with self.network() as net,\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_f0e9c81b","line":652,"updated":"2016-09-14 17:09:35.000000000","message":"It would be great if you could add a functional test in /neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py","commit_id":"7536183d80a1243d257b24f96c65a0f1c7548512"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"ced85aef4c8e01f4a7cc808fa9a8b6c114e99eec","unresolved":false,"context_lines":[{"line_number":649,"context_line":"            mock_notify.assert_called_once_with("},{"line_number":650,"context_line":"                \u0027router\u0027, \u0027before_update\u0027, self.mixin, **kwargs)"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def test_validate_add_router_interface_notify_advanced_services(self):"},{"line_number":653,"context_line":"        router \u003d {\u0027name\u0027: \u0027foo_router\u0027, \u0027admin_state_up\u0027: False}"},{"line_number":654,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":655,"context_line":"        with self.network() as net,\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_67c97278","line":652,"in_reply_to":"7a8ec9b2_f0e9c81b","updated":"2016-09-14 20:42:17.000000000","message":"Done","commit_id":"7536183d80a1243d257b24f96c65a0f1c7548512"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aebdd39a7ac8b9bbb24db1baf86554f9c3e1699f","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                                            interface_info)"},{"line_number":668,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":669,"context_line":"                                                sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":670,"context_line":"            mock_notify.reset()"},{"line_number":671,"context_line":"            interface_info \u003d {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":672,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":673,"context_line":"                                                port[\u0027port\u0027][\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_94d1385a","line":670,"range":{"start_line":670,"start_character":24,"end_line":670,"end_character":29},"updated":"2016-09-15 09:08:14.000000000","message":"reset_mock()","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"39d8522e92add164c38e75d6a6ee921b5dd24ae4","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                                            interface_info)"},{"line_number":668,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":669,"context_line":"                                                sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":670,"context_line":"            mock_notify.reset()"},{"line_number":671,"context_line":"            interface_info \u003d {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":672,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":673,"context_line":"                                                port[\u0027port\u0027][\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_41736d4d","line":670,"range":{"start_line":670,"start_character":24,"end_line":670,"end_character":29},"in_reply_to":"7a8ec9b2_94d1385a","updated":"2016-09-15 10:03:45.000000000","message":"Done","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aebdd39a7ac8b9bbb24db1baf86554f9c3e1699f","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                                sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":670,"context_line":"            mock_notify.reset()"},{"line_number":671,"context_line":"            interface_info \u003d {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":672,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":673,"context_line":"                                                port[\u0027port\u0027][\u0027network_id\u0027])"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def _test_update_arp_entry_for_dvr_service_port("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_d4590000","line":672,"range":{"start_line":672,"start_character":12,"end_line":672,"end_character":47},"updated":"2016-09-15 09:08:14.000000000","message":"seems you\u0027ve forgotten to actually add_router_interface() before asserting. Interestingly the test passes because wrong (non existent) method were used for mock.","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"39d8522e92add164c38e75d6a6ee921b5dd24ae4","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                                sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":670,"context_line":"            mock_notify.reset()"},{"line_number":671,"context_line":"            interface_info \u003d {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":672,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":673,"context_line":"                                                port[\u0027port\u0027][\u0027network_id\u0027])"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def _test_update_arp_entry_for_dvr_service_port("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_2178212a","line":672,"range":{"start_line":672,"start_character":12,"end_line":672,"end_character":47},"in_reply_to":"7a8ec9b2_d4590000","updated":"2016-09-15 10:03:45.000000000","message":"Oooops.... Done","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3ad997d954fa07e5d35e120d4e39d3881efcad02","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                                sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":670,"context_line":"            mock_notify.reset()"},{"line_number":671,"context_line":"            interface_info \u003d {\u0027port_id\u0027: port[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":672,"context_line":"            mock_notify.assert_called_once_with(self.ctx, router_db.id,"},{"line_number":673,"context_line":"                                                port[\u0027port\u0027][\u0027network_id\u0027])"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def _test_update_arp_entry_for_dvr_service_port("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_b48c7436","line":672,"range":{"start_line":672,"start_character":12,"end_line":672,"end_character":47},"in_reply_to":"7a8ec9b2_d4590000","updated":"2016-09-15 09:09:48.000000000","message":"for mock -\u003e to reset mock","commit_id":"1301e9e85512c1e678ef87ba363c9bc8e5d12402"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"426f59fe6cfaef7b3717910349a75a4533ab10de","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        self):"},{"line_number":658,"context_line":"        router \u003d {\u0027name\u0027: \u0027foo_router\u0027, \u0027admin_state_up\u0027: False}"},{"line_number":659,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":660,"context_line":"        with self.network() as net,\\"},{"line_number":661,"context_line":"                self.subnet(network\u003d{\u0027network\u0027: net[\u0027network\u0027]}) as sub,\\"},{"line_number":662,"context_line":"                mock.patch.object("},{"line_number":663,"context_line":"                    self.mixin,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_71c78912","line":660,"range":{"start_line":660,"start_character":35,"end_line":660,"end_character":36},"updated":"2016-09-23 00:15:09.000000000","message":"same comment https://review.openstack.org/#/c/369221/12/neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py@1545 from amotoki, for reminder if you change it in other file","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        self):"},{"line_number":658,"context_line":"        router \u003d {\u0027name\u0027: \u0027foo_router\u0027, \u0027admin_state_up\u0027: False}"},{"line_number":659,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":660,"context_line":"        with self.network() as net,\\"},{"line_number":661,"context_line":"                self.subnet(network\u003d{\u0027network\u0027: net[\u0027network\u0027]}) as sub,\\"},{"line_number":662,"context_line":"                mock.patch.object("},{"line_number":663,"context_line":"                    self.mixin,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_2ad2dbd2","line":660,"range":{"start_line":660,"start_character":35,"end_line":660,"end_character":36},"in_reply_to":"5a8bc5a2_71c78912","updated":"2016-09-23 07:11:27.000000000","message":"Done","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"426f59fe6cfaef7b3717910349a75a4533ab10de","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        self):"},{"line_number":673,"context_line":"        router \u003d {\u0027name\u0027: \u0027foo_router\u0027, \u0027admin_state_up\u0027: False}"},{"line_number":674,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":675,"context_line":"        with self.network() as net,\\"},{"line_number":676,"context_line":"                self.subnet(network\u003d{\u0027network\u0027: net[\u0027network\u0027]}) as sub,\\"},{"line_number":677,"context_line":"                self.port(subnet\u003dsub) as port,\\"},{"line_number":678,"context_line":"                mock.patch.object("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_ec3adccc","line":675,"range":{"start_line":675,"start_character":35,"end_line":675,"end_character":36},"updated":"2016-09-23 00:15:09.000000000","message":"same","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        self):"},{"line_number":673,"context_line":"        router \u003d {\u0027name\u0027: \u0027foo_router\u0027, \u0027admin_state_up\u0027: False}"},{"line_number":674,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":675,"context_line":"        with self.network() as net,\\"},{"line_number":676,"context_line":"                self.subnet(network\u003d{\u0027network\u0027: net[\u0027network\u0027]}) as sub,\\"},{"line_number":677,"context_line":"                self.port(subnet\u003dsub) as port,\\"},{"line_number":678,"context_line":"                mock.patch.object("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_4ad567b7","line":675,"range":{"start_line":675,"start_character":35,"end_line":675,"end_character":36},"in_reply_to":"5a8bc5a2_ec3adccc","updated":"2016-09-23 07:11:27.000000000","message":"Done","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"426f59fe6cfaef7b3717910349a75a4533ab10de","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":675,"context_line":"        with self.network() as net,\\"},{"line_number":676,"context_line":"                self.subnet(network\u003d{\u0027network\u0027: net[\u0027network\u0027]}) as sub,\\"},{"line_number":677,"context_line":"                self.port(subnet\u003dsub) as port,\\"},{"line_number":678,"context_line":"                mock.patch.object("},{"line_number":679,"context_line":"                    self.mixin,"},{"line_number":680,"context_line":"                    \u0027_notify_attaching_interface\u0027) as mock_notify:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_2c35a4d9","line":677,"range":{"start_line":677,"start_character":46,"end_line":677,"end_character":47},"updated":"2016-09-23 00:15:09.000000000","message":"same","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"fecf4f6fbd5fe9e6b7c016b39fd56be2cdda5a2e","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        router_db \u003d self._create_router(router)"},{"line_number":675,"context_line":"        with self.network() as net,\\"},{"line_number":676,"context_line":"                self.subnet(network\u003d{\u0027network\u0027: net[\u0027network\u0027]}) as sub,\\"},{"line_number":677,"context_line":"                self.port(subnet\u003dsub) as port,\\"},{"line_number":678,"context_line":"                mock.patch.object("},{"line_number":679,"context_line":"                    self.mixin,"},{"line_number":680,"context_line":"                    \u0027_notify_attaching_interface\u0027) as mock_notify:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_6adce3e4","line":677,"range":{"start_line":677,"start_character":46,"end_line":677,"end_character":47},"in_reply_to":"5a8bc5a2_2c35a4d9","updated":"2016-09-23 07:11:27.000000000","message":"Done","commit_id":"e43bed42f3d399fa416b174005fa09e0547b42b0"}]}
