)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"741374ead3658d62b99095a2af931abeee02189a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if self._enabled_netfilter_for_bridges:"},{"line_number":102,"context_line":"            return"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            self._enabled_netfilter_for_bridges \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # These proc values ensure that netfilter is enabled on"},{"line_number":107,"context_line":"        # bridges; essential for enforcing security groups rules with"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c64666bf","side":"PARENT","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":54},"updated":"2016-09-13 10:42:29.000000000","message":"Won\u0027t removing this cause a debug message on L124 per iptables firewall call?","commit_id":"dedb632ba50e3df395fed33dcc70a2529b43524e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0a0845be87be9dd6c6de00e4bde33cb3a1a0d616","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if self._enabled_netfilter_for_bridges:"},{"line_number":102,"context_line":"            return"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            self._enabled_netfilter_for_bridges \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # These proc values ensure that netfilter is enabled on"},{"line_number":107,"context_line":"        # bridges; essential for enforcing security groups rules with"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_df638018","side":"PARENT","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":54},"in_reply_to":"9a89bdaa_c64666bf","updated":"2016-09-13 12:43:04.000000000","message":"You mean on the right side? :?","commit_id":"dedb632ba50e3df395fed33dcc70a2529b43524e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6fa28477825c89d88c91e86adaae620ace835714","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if self._enabled_netfilter_for_bridges:"},{"line_number":102,"context_line":"            return"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            self._enabled_netfilter_for_bridges \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # These proc values ensure that netfilter is enabled on"},{"line_number":107,"context_line":"        # bridges; essential for enforcing security groups rules with"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_1a32565e","side":"PARENT","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":54},"in_reply_to":"9a89bdaa_df638018","updated":"2016-09-13 12:50:07.000000000","message":"Yeah, first I thought it\u0027s not required. Then I was like \"why not\", it\u0027s just one more debug message...","commit_id":"dedb632ba50e3df395fed33dcc70a2529b43524e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0a0845be87be9dd6c6de00e4bde33cb3a1a0d616","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        except RuntimeError as e:"},{"line_number":122,"context_line":"            if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            LOG.debug(\"bridge-nf-call sysctl values not available to set\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @property"},{"line_number":127,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_1aa256fc","line":124,"updated":"2016-09-13 12:43:04.000000000","message":"I guess here we assume that eventually prepare_port_filter will be called again, and _enable_netfilter_for_bridges will fix it.\n\nBut what if only one port is created, the calls fail, and no more filters are manipulated?\n\nMay we make this more complicated by adding a timer to retry until it\u0027s possible?","commit_id":"6c56614fde48ae8f2c83e7e4f58622154b2b7345"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"18a0909fe23a149af7ca09c03f423fce5039842e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        except RuntimeError as e:"},{"line_number":122,"context_line":"            if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            LOG.debug(\"bridge-nf-call sysctl values not available to set\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @property"},{"line_number":127,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_b8e7503f","line":124,"in_reply_to":"7a8ec9b2_d3b96530","updated":"2016-09-14 08:31:53.000000000","message":"The module is called br_netfilter, not nf_bridge :)","commit_id":"6c56614fde48ae8f2c83e7e4f58622154b2b7345"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6fa28477825c89d88c91e86adaae620ace835714","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        except RuntimeError as e:"},{"line_number":122,"context_line":"            if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            LOG.debug(\"bridge-nf-call sysctl values not available to set\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @property"},{"line_number":127,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_faf3f270","line":124,"in_reply_to":"9a89bdaa_1aa256fc","updated":"2016-09-13 12:50:07.000000000","message":"The issue is that newer kernel versions split bridge module to bridge and nf_bridge. To get these kernel options available you need to load nf_bridge module, which is not necessary for physdev-is-bridged iptables extension. Though it sounds weird you don\u0027t need nf_bridge to have netfilter...\n\nSo that said, we will never be successful in calling these sysctl on newer boxes.","commit_id":"6c56614fde48ae8f2c83e7e4f58622154b2b7345"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"691a3654bb6637b10b5038ea72cfc11ddc696097","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        except RuntimeError as e:"},{"line_number":122,"context_line":"            if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            LOG.debug(\"bridge-nf-call sysctl values not available to set\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @property"},{"line_number":127,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_84627f3c","line":124,"in_reply_to":"9a89bdaa_44e6b744","updated":"2016-09-13 16:09:49.000000000","message":"To the best of my knowledge, the module is not needed on new boxes and so those sysctl commands above.","commit_id":"6c56614fde48ae8f2c83e7e4f58622154b2b7345"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1961430afbb81f940823db246ced62b978f50345","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        except RuntimeError as e:"},{"line_number":122,"context_line":"            if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            LOG.debug(\"bridge-nf-call sysctl values not available to set\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @property"},{"line_number":127,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d3b96530","line":124,"in_reply_to":"9a89bdaa_84627f3c","updated":"2016-09-14 05:33:58.000000000","message":"I\u0027m missing something, I\u0027ll ping you on IRC later.\n\nSo, those settings are \"enabled\" by default and we don\u0027t even need to call them at all on newer kernels?","commit_id":"6c56614fde48ae8f2c83e7e4f58622154b2b7345"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2703b34653c21b7473e23123331c3d270bf60ec7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        except RuntimeError as e:"},{"line_number":122,"context_line":"            if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            LOG.debug(\"bridge-nf-call sysctl values not available to set\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @property"},{"line_number":127,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_44e6b744","line":124,"in_reply_to":"9a89bdaa_faf3f270","updated":"2016-09-13 16:03:56.000000000","message":"But then that\u0027s more of a devstack issue to load the module, right?","commit_id":"6c56614fde48ae8f2c83e7e4f58622154b2b7345"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3262dcdfc94fd76166f8cd9928e5ddc5723ce455","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"},{"line_number":115,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":116,"context_line":"            except RuntimeError as e:"},{"line_number":117,"context_line":"                if \u0027No such file or directory\u0027 not in str(e):"},{"line_number":118,"context_line":"                    raise"},{"line_number":119,"context_line":"                LOG.debug(\"Sysctl value %s not present on this system.\","},{"line_number":120,"context_line":"                          sysctl_value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_cf461fbf","line":117,"updated":"2016-09-14 01:18:03.000000000","message":"could this be prone to l10n?","commit_id":"c41eb4811a12fc186d51924f6174f4c3aa39bdf1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"24f52f55b14e34906a4b7a0f6c88e084dbb4d3c6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # enabled by default or not (Ubuntu - yes, Redhat - no, for"},{"line_number":108,"context_line":"        # example)."},{"line_number":109,"context_line":"        LOG.debug(\"Enabling netfilter for bridges\")"},{"line_number":110,"context_line":"        entries \u003d utils.execute([\u0027sysctl\u0027, \u0027-N\u0027, \u0027net.bridge\u0027],"},{"line_number":111,"context_line":"                                run_as_root\u003dTrue).splitlines()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for sysctl_value in (\u0027net.bridge.bridge-nf-call-arptables\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_b803d0b7","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":60},"updated":"2016-09-14 08:33:27.000000000","message":"The whole net.bridge is missing in case br_netfilter is not loaded. So it should be just \u0027net\u0027, otherwise I still get:\n\n[root@devstack ~]# sysctl -N net.bridge\nsysctl: cannot stat /proc/sys/net/bridge: No such file or directory","commit_id":"7e918e70b24eb235e691369c3be1d94b16eba3b5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7d99645c9dc20e868ac821c3126455dc2fc646c0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        # enabled by default or not (Ubuntu - yes, Redhat - no, for"},{"line_number":108,"context_line":"        # example)."},{"line_number":109,"context_line":"        LOG.debug(\"Enabling netfilter for bridges\")"},{"line_number":110,"context_line":"        entries \u003d utils.execute([\u0027sysctl\u0027, \u0027-N\u0027, \u0027net.bridge\u0027],"},{"line_number":111,"context_line":"                                run_as_root\u003dTrue).splitlines()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for sysctl_value in (\u0027net.bridge.bridge-nf-call-arptables\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_0b38d0d2","line":110,"range":{"start_line":110,"start_character":50,"end_line":110,"end_character":60},"in_reply_to":"7a8ec9b2_b803d0b7","updated":"2016-09-14 15:10:52.000000000","message":"Done","commit_id":"7e918e70b24eb235e691369c3be1d94b16eba3b5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8440b5e3eae5e2b4d04877a4c9baad531effc200","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                             \u0027net.bridge.bridge-nf-call-ip6tables\u0027,"},{"line_number":115,"context_line":"                             \u0027net.bridge.bridge-nf-call-iptables\u0027):"},{"line_number":116,"context_line":"            if sysctl_value not in entries:"},{"line_number":117,"context_line":"                LOG.debug(\"Sysctl value %s not present on this system.\","},{"line_number":118,"context_line":"                          sysctl_value)"},{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_44c0f47c","line":117,"updated":"2016-09-14 20:12:40.000000000","message":"if this is not enabled on the system, what\u0027s the reason behind it? And can we expect security groups to work as expected? The note on line 106 says these are enabled by default on Ubuntu, but that\u0027s the distro we\u0027re using to test in the gate and yet they are missing?\n\nHave we drilled down into why this is really happening? I fear we\u0027re simply masking a deployment or timing issue.","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e0762b9fb03e56ca9da40963721263bf94ffb798","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                             \u0027net.bridge.bridge-nf-call-ip6tables\u0027,"},{"line_number":115,"context_line":"                             \u0027net.bridge.bridge-nf-call-iptables\u0027):"},{"line_number":116,"context_line":"            if sysctl_value not in entries:"},{"line_number":117,"context_line":"                LOG.debug(\"Sysctl value %s not present on this system.\","},{"line_number":118,"context_line":"                          sysctl_value)"},{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_4f2aa87f","line":117,"in_reply_to":"7a8ec9b2_44c0f47c","updated":"2016-09-15 14:04:43.000000000","message":"Maybe worth putting it in the comment. IIUC we have this patch to mitigate failures we see on Xenial boxes, where \u0027bridge\u0027 module was split to \u0027bridge\u0027 and \u0027br_netfilter\u0027. Options above are present in the latter module. As per tests running without setting these values, we don\u0027t need to set them on boxes that use the split modules (e.g. Xenial).","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92cdf34b48af1eca34ee34244060abc5269533e4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                             \u0027net.bridge.bridge-nf-call-ip6tables\u0027,"},{"line_number":115,"context_line":"                             \u0027net.bridge.bridge-nf-call-iptables\u0027):"},{"line_number":116,"context_line":"            if sysctl_value not in entries:"},{"line_number":117,"context_line":"                LOG.debug(\"Sysctl value %s not present on this system.\","},{"line_number":118,"context_line":"                          sysctl_value)"},{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_cf5a3850","line":117,"in_reply_to":"7a8ec9b2_4f2aa87f","updated":"2016-09-15 14:18:12.000000000","message":"OK, got it. But will anything later load br_netfilter for us? I am afraid we may actually hit a case of firewall not being applied here. Though then security groups tests would probably fail? Is that the \u0027tests\u0027 you refer to?","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1525202647b14c4c0d7d74fd5d902578d43c15f6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                             \u0027net.bridge.bridge-nf-call-ip6tables\u0027,"},{"line_number":115,"context_line":"                             \u0027net.bridge.bridge-nf-call-iptables\u0027):"},{"line_number":116,"context_line":"            if sysctl_value not in entries:"},{"line_number":117,"context_line":"                LOG.debug(\"Sysctl value %s not present on this system.\","},{"line_number":118,"context_line":"                          sysctl_value)"},{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_e8e8ca12","line":117,"in_reply_to":"7a8ec9b2_52becfd4","updated":"2016-09-15 14:52:44.000000000","message":"OK, so I am reading this:\n\nhttp://ebtables.netfilter.org/documentation/bridge-nf.html\n\nIt says that unless we load the module, we won\u0027t have the options AND filtering available to us.","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75a30b8cc7b5d50025e27cbfdf829be281c2b02e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                             \u0027net.bridge.bridge-nf-call-ip6tables\u0027,"},{"line_number":115,"context_line":"                             \u0027net.bridge.bridge-nf-call-iptables\u0027):"},{"line_number":116,"context_line":"            if sysctl_value not in entries:"},{"line_number":117,"context_line":"                LOG.debug(\"Sysctl value %s not present on this system.\","},{"line_number":118,"context_line":"                          sysctl_value)"},{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_52becfd4","line":117,"in_reply_to":"7a8ec9b2_cf5a3850","updated":"2016-09-15 14:29:12.000000000","message":"See in syslog: http://logs.openstack.org/50/369250/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4a3398b/logs/syslog.txt.gz#_Sep_14_15_29_22\n\n\"Sep 14 15:29:22 ubuntu-xenial-rax-ord-4285122 kernel: bridge: automatic filtering via arp/ip/ip6tables has been deprecated. Update your scripts to load br_netfilter if you need this.\"\n\nSomething tells me the message indicates the module is not really loaded by anything. So filters won\u0027t work. But... how come we don\u0027t catch it with tempest?\n\nIt happens before we try to set the config options: http://logs.openstack.org/50/369250/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4a3398b/logs/screen-q-agt.txt.gz#_2016-09-14_15_43_16_332","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e0762b9fb03e56ca9da40963721263bf94ffb798","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"},{"line_number":121,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":122,"context_line":"        self._enabled_netfilter_for_bridges \u003d True"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @property"},{"line_number":125,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_7d6e4102","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":43},"updated":"2016-09-15 14:04:43.000000000","message":"We should think about what do we expect here. If setting values fail, why do we try until we succeed? Do we expect operator to insert the kernel module while agent is running?","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92cdf34b48af1eca34ee34244060abc5269533e4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"},{"line_number":121,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":122,"context_line":"        self._enabled_netfilter_for_bridges \u003d True"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @property"},{"line_number":125,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_cf2158b6","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":43},"in_reply_to":"7a8ec9b2_7d6e4102","updated":"2016-09-15 14:18:12.000000000","message":"Your comment suggests that the kernel module (br_netfilter) is never inserted in gate? Isn\u0027t it an issue that we should not ignore?","commit_id":"08a231701197c981db5ebe32c100168c07737be5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"54e8219ef3dcf610357b93e8a2bfb9abdfae8ddb","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                continue"},{"line_number":120,"context_line":"            utils.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027%s\u003d1\u0027 % sysctl_value],"},{"line_number":121,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":122,"context_line":"        self._enabled_netfilter_for_bridges \u003d True"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @property"},{"line_number":125,"context_line":"    def ports(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_ef4ff4ba","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":43},"in_reply_to":"7a8ec9b2_7d6e4102","updated":"2016-09-15 14:14:25.000000000","message":"we don\u0027t keep trying if it\u0027s not present. We do keep trying and failing loudly if it is present and something else is failing, which is what i think we should do.","commit_id":"08a231701197c981db5ebe32c100168c07737be5"}]}