)]}'
{"neutron/db/common_db_mixin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"fd140faedd5bf0b59175b38a4a30689f4a02641e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            if isinstance(filter_hook, six.string_types):"},{"line_number":119,"context_line":"                filter_hook \u003d getattr(self, filter_hook, None)"},{"line_number":120,"context_line":"            if filter_hook:"},{"line_number":121,"context_line":"                # seems the place from where apply_tag_filters is being called"},{"line_number":122,"context_line":"                query_filter \u003d filter_hook(context, model, query_filter)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # NOTE(salvatore-orlando): \u0027if query_filter\u0027 will try to evaluate the"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_797fbf14","line":121,"range":{"start_line":121,"start_character":18,"end_line":121,"end_character":23},"updated":"2016-12-06 21:01:15.000000000","message":"nit: this should have your irc name on it","commit_id":"3eba419472177d421ad3552a5e45426d60ab434f"}],"neutron/services/tag/tag_plugin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"fd140faedd5bf0b59175b38a4a30689f4a02641e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def _get_resource(self, context, resource, resource_id):"},{"line_number":48,"context_line":"        resource_ovo \u003d resource_model_map[resource]"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            return self._get_by_id(context, resource_ovo.db_model,"},{"line_number":51,"context_line":"                                   resource_id)"},{"line_number":52,"context_line":"        except exc.NoResultFound:"},{"line_number":53,"context_line":"            raise tag_ext.TagResourceNotFound(resource\u003dresource,"},{"line_number":54,"context_line":"                                              resource_id\u003dresource_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_79fb3f79","line":51,"range":{"start_line":50,"start_character":19,"end_line":51,"end_character":47},"updated":"2016-12-06 21:01:15.000000000","message":"you can use the OVO get_object method here","commit_id":"3eba419472177d421ad3552a5e45426d60ab434f"}],"neutron/tests/unit/extensions/test_timestamp.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"c2c12f14fdd1458757160f0f98d751e3f7f5a6b3","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    def _save_tag(self, tags, standard_attr_id):"},{"line_number":256,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":257,"context_line":"        for tag in tags:"},{"line_number":258,"context_line":"            tag_data \u003d obj_tag.Tag(ctx, standard_attr_id\u003dstandard_attr_id,"},{"line_number":259,"context_line":"                                 tag\u003dtag)"},{"line_number":260,"context_line":"            tag_data.create()"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_update_timpestamp(self):"},{"line_number":263,"context_line":"        network_id \u003d \"foo_network_id\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_d13d1fde","line":260,"range":{"start_line":258,"start_character":0,"end_line":260,"end_character":28},"updated":"2016-11-11 01:28:22.000000000","message":"This doesn\u0027t require to have a variable\n\n            obj_tag.Tag(ctx, standard_attr_id\u003dstandard_attr_id,\n                                 tag\u003dtag).create()","commit_id":"0be5515780752e0ebe7fb343e7fb98ac285c714e"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ae361d3a1a02f063f1427f72d5b8d7fa37bb74af","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    def _save_tag(self, tags, standard_attr_id):"},{"line_number":256,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":257,"context_line":"        for tag in tags:"},{"line_number":258,"context_line":"            tag_data \u003d obj_tag.Tag(ctx, standard_attr_id\u003dstandard_attr_id,"},{"line_number":259,"context_line":"                                 tag\u003dtag)"},{"line_number":260,"context_line":"            tag_data.create()"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_update_timpestamp(self):"},{"line_number":263,"context_line":"        network_id \u003d \"foo_network_id\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_bf909744","line":260,"range":{"start_line":258,"start_character":0,"end_line":260,"end_character":28},"in_reply_to":"9a629dbe_d13d1fde","updated":"2016-11-17 16:59:27.000000000","message":"Done, changes can be found in Tag OVO creation patch. https://review.openstack.org/#/c/356825/.\n\nStandardAttribute and Tag joins are in  [1]. \nafaik solution for handling joins is to pick an object which is of more relevance, in this case StandardAttribute and then isolate model interrelationship into neutron/objects. \nCreation of StandardAttribute OVO is under discussion[2].\n\nOne of the solution i can think of is to make this patch dependent on [2]. Please suggest and feel free to take this patch.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/tag_db.py#L30-L92\n[2] https://review.openstack.org/#/c/383842/","commit_id":"0be5515780752e0ebe7fb343e7fb98ac285c714e"}]}
