)]}'
{"neutron/db/dns_db.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"489504a4da53284233e54b811cde9df0ff6f7648","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                context, floatingip_data, req_data))"},{"line_number":97,"context_line":"        dns_actions_data \u003d None"},{"line_number":98,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":99,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":100,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":101,"context_line":"                dns_name\u003dreq_data[dns.DNSNAME],"},{"line_number":102,"context_line":"                dns_domain\u003dreq_data[dns.DNSDOMAIN],"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_2601d86a","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":18},"updated":"2016-09-26 13:04:50.000000000","message":"nit: fip_dns","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8d78cb7485bdd4b02cb0e3d626357ed453c4400a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                context, floatingip_data, req_data))"},{"line_number":97,"context_line":"        dns_actions_data \u003d None"},{"line_number":98,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":99,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":100,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":101,"context_line":"                dns_name\u003dreq_data[dns.DNSNAME],"},{"line_number":102,"context_line":"                dns_domain\u003dreq_data[dns.DNSDOMAIN],"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_e53fceb1","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":18},"in_reply_to":"5a8bc5a2_2601d86a","updated":"2016-09-26 18:30:06.000000000","message":"variable name not a big deal i am fine with both names, will rename in next revision","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"489504a4da53284233e54b811cde9df0ff6f7648","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            else:"},{"line_number":155,"context_line":"                return"},{"line_number":156,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":157,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":158,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":159,"context_line":"                dns_name\u003d\u0027\u0027,"},{"line_number":160,"context_line":"                dns_domain\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_2638f83c","line":157,"range":{"start_line":157,"start_character":12,"end_line":157,"end_character":18},"updated":"2016-09-26 13:04:50.000000000","message":"nit: fip_dns","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dea11246aaa5b0f7054adf7d0f578654634a8bc2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    dns_actions_data.current_dns_name \u003d current_dns_name"},{"line_number":153,"context_line":"                    dns_actions_data.current_dns_domain \u003d current_dns_domain"},{"line_number":154,"context_line":"                else:"},{"line_number":155,"context_line":"                    context.session.delete(dns_data_db)"},{"line_number":156,"context_line":"                return dns_actions_data"},{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a95cdbc_e4eb2711","line":155,"range":{"start_line":155,"start_character":20,"end_line":155,"end_character":55},"updated":"2016-10-10 14:23:58.000000000","message":"dns_data_db.delete()","commit_id":"ff09518abf2f6988daba7ea4ab6d0ffd122832e4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"f693f96dbaebd6c894bb0cbbf660632dff9b6e5a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                context, floatingip_data, req_data))"},{"line_number":100,"context_line":"        dns_actions_data \u003d None"},{"line_number":101,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":102,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":103,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":104,"context_line":"                dns_name\u003dreq_data[dns.DNSNAME],"},{"line_number":105,"context_line":"                dns_domain\u003dreq_data[dns.DNSDOMAIN],"},{"line_number":106,"context_line":"                published_dns_name\u003dcurrent_dns_name,"},{"line_number":107,"context_line":"                published_dns_domain\u003dcurrent_dns_domain)"},{"line_number":108,"context_line":"            fipdns.create()"},{"line_number":109,"context_line":"            dns_actions_data \u003d DNSActionsData("},{"line_number":110,"context_line":"                current_dns_name\u003dcurrent_dns_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_f97701d2","line":107,"range":{"start_line":102,"start_character":21,"end_line":107,"end_character":56},"updated":"2016-10-11 21:48:43.000000000","message":"no need to store the instance.\n\ndns_obj.FloatingIPDNS(context,\n                floatingip_id\u003dfloatingip_data[\u0027id\u0027],\n                dns_name\u003dreq_data[dns.DNSNAME],\n                dns_domain\u003dreq_data[dns.DNSDOMAIN],\n                published_dns_name\u003dcurrent_dns_name,\n                published_dns_domain\u003dcurrent_dns_domain).create()","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7c9e91bd766158e63acf450f3831c6b7d8864bec","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                context, floatingip_data, req_data))"},{"line_number":100,"context_line":"        dns_actions_data \u003d None"},{"line_number":101,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":102,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":103,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":104,"context_line":"                dns_name\u003dreq_data[dns.DNSNAME],"},{"line_number":105,"context_line":"                dns_domain\u003dreq_data[dns.DNSDOMAIN],"},{"line_number":106,"context_line":"                published_dns_name\u003dcurrent_dns_name,"},{"line_number":107,"context_line":"                published_dns_domain\u003dcurrent_dns_domain)"},{"line_number":108,"context_line":"            fipdns.create()"},{"line_number":109,"context_line":"            dns_actions_data \u003d DNSActionsData("},{"line_number":110,"context_line":"                current_dns_name\u003dcurrent_dns_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_41fea4ae","line":107,"range":{"start_line":102,"start_character":21,"end_line":107,"end_character":56},"in_reply_to":"fa6399be_f97701d2","updated":"2016-10-14 14:46:19.000000000","message":"+1","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"f693f96dbaebd6c894bb0cbbf660632dff9b6e5a","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                return"},{"line_number":159,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":160,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":161,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":162,"context_line":"                dns_name\u003d\u0027\u0027,"},{"line_number":163,"context_line":"                dns_domain\u003d\u0027\u0027,"},{"line_number":164,"context_line":"                published_dns_name\u003dcurrent_dns_name,"},{"line_number":165,"context_line":"                published_dns_domain\u003dcurrent_dns_domain)"},{"line_number":166,"context_line":"            fipdns.create()"},{"line_number":167,"context_line":"            return DNSActionsData(current_dns_name\u003dcurrent_dns_name,"},{"line_number":168,"context_line":"                                  current_dns_domain\u003dcurrent_dns_domain)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_eb13a45a","line":166,"range":{"start_line":160,"start_character":11,"end_line":166,"end_character":27},"updated":"2016-10-11 21:48:43.000000000","message":"same as L102-107","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8b995457bfef90787ebde1d9cbd8daabf78e4391","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                return"},{"line_number":159,"context_line":"        if current_dns_name and current_dns_domain:"},{"line_number":160,"context_line":"            fipdns \u003d dns_obj.FloatingIPDNS(context,"},{"line_number":161,"context_line":"                floatingip_id\u003dfloatingip_data[\u0027id\u0027],"},{"line_number":162,"context_line":"                dns_name\u003d\u0027\u0027,"},{"line_number":163,"context_line":"                dns_domain\u003d\u0027\u0027,"},{"line_number":164,"context_line":"                published_dns_name\u003dcurrent_dns_name,"},{"line_number":165,"context_line":"                published_dns_domain\u003dcurrent_dns_domain)"},{"line_number":166,"context_line":"            fipdns.create()"},{"line_number":167,"context_line":"            return DNSActionsData(current_dns_name\u003dcurrent_dns_name,"},{"line_number":168,"context_line":"                                  current_dns_domain\u003dcurrent_dns_domain)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_f0857d59","line":166,"range":{"start_line":160,"start_character":11,"end_line":166,"end_character":27},"in_reply_to":"fa6399be_eb13a45a","updated":"2016-10-17 18:20:42.000000000","message":"Done","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"}],"neutron/tests/unit/objects/test_dns.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"489504a4da53284233e54b811cde9df0ff6f7648","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class FloatingIPDNSIfaceObjectTestcase("},{"line_number":46,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _test_class \u003d dns.FloatingIPDNS"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_babc1cbc","line":46,"updated":"2016-09-26 13:04:50.000000000","message":"why this change?","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"404e309645b57f925bf0696f779189b570baf8d7","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class FloatingIPDNSIfaceObjectTestcase("},{"line_number":46,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _test_class \u003d dns.FloatingIPDNS"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_dc32b20f","line":46,"in_reply_to":"5a8bc5a2_babc1cbc","updated":"2016-09-26 18:02:35.000000000","message":"It seems like only changed the indentation","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8d78cb7485bdd4b02cb0e3d626357ed453c4400a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class FloatingIPDNSIfaceObjectTestcase("},{"line_number":46,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _test_class \u003d dns.FloatingIPDNS"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_6d5d6646","line":46,"in_reply_to":"5a8bc5a2_dc32b20f","updated":"2016-09-26 18:30:06.000000000","message":"It was over indented which i fixed it,","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"404e309645b57f925bf0696f779189b570baf8d7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":67,"context_line":"        self._create_test_network()"},{"line_number":68,"context_line":"        self._create_test_port(self._network)"},{"line_number":69,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":70,"context_line":"        # once it is implemented"},{"line_number":71,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":72,"context_line":"            self.context,"},{"line_number":73,"context_line":"            ext_net_db.ExternalNetwork,"},{"line_number":74,"context_line":"            {\u0027network_id\u0027: self._network[\u0027id\u0027]})"},{"line_number":75,"context_line":"        fip \u003d obj_db_api.create_object("},{"line_number":76,"context_line":"            self.context,"},{"line_number":77,"context_line":"            l3_db.FloatingIP,"},{"line_number":78,"context_line":"            {\u0027floating_ip_address\u0027: fake_fip,"},{"line_number":79,"context_line":"             \u0027floating_network_id\u0027: ext_net[\u0027network_id\u0027],"},{"line_number":80,"context_line":"             \u0027floating_port_id\u0027: self._port[\u0027id\u0027]})"},{"line_number":81,"context_line":"        return fip"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_178155c3","line":80,"range":{"start_line":65,"start_character":1,"end_line":80,"end_character":51},"updated":"2016-09-26 18:02:35.000000000","message":"This method should be placed in the base class","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8d78cb7485bdd4b02cb0e3d626357ed453c4400a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":67,"context_line":"        self._create_test_network()"},{"line_number":68,"context_line":"        self._create_test_port(self._network)"},{"line_number":69,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":70,"context_line":"        # once it is implemented"},{"line_number":71,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":72,"context_line":"            self.context,"},{"line_number":73,"context_line":"            ext_net_db.ExternalNetwork,"},{"line_number":74,"context_line":"            {\u0027network_id\u0027: self._network[\u0027id\u0027]})"},{"line_number":75,"context_line":"        fip \u003d obj_db_api.create_object("},{"line_number":76,"context_line":"            self.context,"},{"line_number":77,"context_line":"            l3_db.FloatingIP,"},{"line_number":78,"context_line":"            {\u0027floating_ip_address\u0027: fake_fip,"},{"line_number":79,"context_line":"             \u0027floating_network_id\u0027: ext_net[\u0027network_id\u0027],"},{"line_number":80,"context_line":"             \u0027floating_port_id\u0027: self._port[\u0027id\u0027]})"},{"line_number":81,"context_line":"        return fip"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_a50b0623","line":80,"range":{"start_line":65,"start_character":1,"end_line":80,"end_character":51},"in_reply_to":"5a8bc5a2_178155c3","updated":"2016-09-26 18:30:06.000000000","message":"I\u0027ll add a note to move but it is not needed in base atm,\nonce we hit a situation where this would be needed this can be moved to base,","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a8fb06c65f231d14d7a14946c281de2b32d17096","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":67,"context_line":"        self._create_test_network()"},{"line_number":68,"context_line":"        self._create_test_port(self._network)"},{"line_number":69,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":70,"context_line":"        # once it is implemented"},{"line_number":71,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":72,"context_line":"            self.context,"},{"line_number":73,"context_line":"            ext_net_db.ExternalNetwork,"},{"line_number":74,"context_line":"            {\u0027network_id\u0027: self._network[\u0027id\u0027]})"},{"line_number":75,"context_line":"        fip \u003d obj_db_api.create_object("},{"line_number":76,"context_line":"            self.context,"},{"line_number":77,"context_line":"            l3_db.FloatingIP,"},{"line_number":78,"context_line":"            {\u0027floating_ip_address\u0027: fake_fip,"},{"line_number":79,"context_line":"             \u0027floating_network_id\u0027: ext_net[\u0027network_id\u0027],"},{"line_number":80,"context_line":"             \u0027floating_port_id\u0027: self._port[\u0027id\u0027]})"},{"line_number":81,"context_line":"        return fip"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_5e69918a","line":80,"range":{"start_line":65,"start_character":1,"end_line":80,"end_character":51},"in_reply_to":"5a8bc5a2_a50b0623","updated":"2016-09-29 20:22:21.000000000","message":"I\u0027d prefer to move it and added a note there.  We have several methods with similar TODO notes.  ITOH, having this in the base case can help others to consume it instead of accidentally duplicate code.","commit_id":"f711d23bcebc8ca90da3956170121a0b2848c696"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"a321a65b7d6167b6b180420594bd3c035f4ef621","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":67,"context_line":"        self._create_test_network()"},{"line_number":68,"context_line":"        self._create_test_port(self._network)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_db3a73e7","line":65,"updated":"2016-10-04 14:12:14.000000000","message":"Is the test just creating the object?","commit_id":"b784f759f79f5fcd8ec55213d54d8f54d095c6a5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e98cf6ff72af2ec4c2c363ae45474ba97d47ed06","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":67,"context_line":"        self._create_test_network()"},{"line_number":68,"context_line":"        self._create_test_port(self._network)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_1a5f6c73","line":65,"in_reply_to":"1a95cdbc_db3a73e7","updated":"2016-10-04 16:30:30.000000000","message":"first it is not any test, its a helper method i named create_test_ext_network_and_fip thought would be clear from name to create external network and fip for test. tests for this would be inherited from base class this is just needed in setup() before actual tests from base test framework are fired.","commit_id":"b784f759f79f5fcd8ec55213d54d8f54d095c6a5"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"a0c2ca2570ba55fce92cddb9a0822818b647461c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self._create_test_port(self._network)"},{"line_number":69,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":70,"context_line":"        # once it is implemented"},{"line_number":71,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":72,"context_line":"            self.context,"},{"line_number":73,"context_line":"            ext_net_db.ExternalNetwork,"},{"line_number":74,"context_line":"            {\u0027network_id\u0027: self._network[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_f69494e9","line":71,"updated":"2016-10-04 19:39:06.000000000","message":"What is the reason for not doing this in objects/test_base.py ?","commit_id":"b784f759f79f5fcd8ec55213d54d8f54d095c6a5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"46435ac0cee4bad127b189a7d6f9cc22967c077a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self._create_test_port(self._network)"},{"line_number":69,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":70,"context_line":"        # once it is implemented"},{"line_number":71,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":72,"context_line":"            self.context,"},{"line_number":73,"context_line":"            ext_net_db.ExternalNetwork,"},{"line_number":74,"context_line":"            {\u0027network_id\u0027: self._network[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a95cdbc_c1c19430","line":71,"in_reply_to":"1a95cdbc_f69494e9","updated":"2016-10-04 19:57:58.000000000","message":"as i explained earlier, it is just needed for this test case and base.py is already so convoluted and long file,\nI\u0027m happy to move this method if multiple test modules are going to use this.","commit_id":"b784f759f79f5fcd8ec55213d54d8f54d095c6a5"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dea11246aaa5b0f7054adf7d0f578654634a8bc2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.db import external_net_db as ext_net_db"},{"line_number":17,"context_line":"from neutron.db import l3_db"},{"line_number":18,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":19,"context_line":"from neutron.objects import dns"},{"line_number":20,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a95cdbc_a4611fd5","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":27},"updated":"2016-10-10 14:23:58.000000000","message":"In db.models, there is external_net and l3 models now merged in master.","commit_id":"ff09518abf2f6988daba7ea4ab6d0ffd122832e4"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"0245a8eb7ef02cd4ae41541088ffed1d97d57c38","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class FloatingIPDNSIfaceObjectTestcase("},{"line_number":46,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _test_class \u003d dns.FloatingIPDNS"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a95cdbc_f58b21c1","line":46,"updated":"2016-10-07 11:03:11.000000000","message":"Extra indentation seems to be the norm for cases like this (including with L25 above), so I\u0027d prefer not to have this change.","commit_id":"ff09518abf2f6988daba7ea4ab6d0ffd122832e4"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dea11246aaa5b0f7054adf7d0f578654634a8bc2","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class FloatingIPDNSIfaceObjectTestcase("},{"line_number":46,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _test_class \u003d dns.FloatingIPDNS"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a95cdbc_29288832","line":46,"in_reply_to":"1a95cdbc_bd1ece6d","updated":"2016-10-10 14:23:58.000000000","message":"For me this change is not looking ok.","commit_id":"ff09518abf2f6988daba7ea4ab6d0ffd122832e4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4f711a1f1da10662576382db14cf327f9cda3afd","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class FloatingIPDNSIfaceObjectTestcase("},{"line_number":46,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _test_class \u003d dns.FloatingIPDNS"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a95cdbc_bd1ece6d","line":46,"in_reply_to":"1a95cdbc_f58b21c1","updated":"2016-10-07 17:09:59.000000000","message":"I\u0027m fine both ways, lets see what other reviewers thinks about it,","commit_id":"ff09518abf2f6988daba7ea4ab6d0ffd122832e4"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"dcba26269323186861a7c622a76699010c29e64a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        # Note(manjeets) move this method to test_base"},{"line_number":67,"context_line":"        # if any other test module needs it"},{"line_number":68,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_982c1104","line":65,"updated":"2016-10-12 18:32:06.000000000","message":"Can we move the creation of external_network and floating_ip to base.py instead of adding it to the specific ovo test file? This will avoid duplication in case when it\u0027s needed by other test_modules. Also, it will be consistent with the existing structure of base.py and other ovo test files. \n\nAlso, it would be nice to have 2 separate create methods one for external network and the other for floating ip.","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7c9e91bd766158e63acf450f3831c6b7d8864bec","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            obj_field[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        # Note(manjeets) move this method to test_base"},{"line_number":67,"context_line":"        # if any other test module needs it"},{"line_number":68,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_01e66c14","line":65,"in_reply_to":"fa6399be_982c1104","updated":"2016-10-14 14:46:19.000000000","message":"+1","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7c9e91bd766158e63acf450f3831c6b7d8864bec","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        # Note(manjeets) move this method to test_base"},{"line_number":67,"context_line":"        # if any other test module needs it"},{"line_number":68,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":69,"context_line":"        self._create_test_network()"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_21f1b0cd","line":66,"range":{"start_line":66,"start_character":10,"end_line":66,"end_character":14},"updated":"2016-10-14 14:46:19.000000000","message":"nit: s/Note/TODO","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8b995457bfef90787ebde1d9cbd8daabf78e4391","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_test_ext_network_and_fip(self):"},{"line_number":66,"context_line":"        # Note(manjeets) move this method to test_base"},{"line_number":67,"context_line":"        # if any other test module needs it"},{"line_number":68,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":69,"context_line":"        self._create_test_network()"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_d0e79944","line":66,"range":{"start_line":66,"start_character":10,"end_line":66,"end_character":14},"in_reply_to":"fa6399be_21f1b0cd","updated":"2016-10-17 18:20:42.000000000","message":"Done","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7c9e91bd766158e63acf450f3831c6b7d8864bec","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":69,"context_line":"        self._create_test_network()"},{"line_number":70,"context_line":"        self._create_test_port(self._network)"},{"line_number":71,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":72,"context_line":"        # once it is implemented"},{"line_number":73,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":74,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_01cd8c84","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":14},"updated":"2016-10-14 14:46:19.000000000","message":"nit: s/NOTE/TODO","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8b995457bfef90787ebde1d9cbd8daabf78e4391","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        fake_fip \u003d \u0027172.23.3.0\u0027"},{"line_number":69,"context_line":"        self._create_test_network()"},{"line_number":70,"context_line":"        self._create_test_port(self._network)"},{"line_number":71,"context_line":"        # NOTE(manjeets) replace this with ext_net ovo"},{"line_number":72,"context_line":"        # once it is implemented"},{"line_number":73,"context_line":"        ext_net \u003d obj_db_api.create_object("},{"line_number":74,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_50946943","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":14},"in_reply_to":"fa6399be_01cd8c84","updated":"2016-10-17 18:20:42.000000000","message":"Done","commit_id":"b233b1d32bedd7d6b34d07a961b16bd6df7b9503"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"97b3373587441f1e381008580b6882c567e3de84","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def setUp(self):"},{"line_number":54,"context_line":"        super(FloatingIPDNSDbObjectTestcase, self).setUp()"},{"line_number":55,"context_line":"        for db_obj, obj_field, obj in zip(self.db_objs,"},{"line_number":56,"context_line":"                self.obj_fields, self.objs):"},{"line_number":57,"context_line":"            fip \u003d self._create_test_fip()"},{"line_number":58,"context_line":"            db_obj[\u0027floatingip_id\u0027] \u003d fip[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5da102_ced1a3fd","line":55,"range":{"start_line":55,"start_character":42,"end_line":55,"end_character":55},"updated":"2016-10-27 14:51:40.000000000","message":"nit: this argument should be in the next line with others, like \n\n        for db_obj, obj_field, obj in zip(\n                self.db_objs, self.obj_fields, self.objs):","commit_id":"186c3c04d537c45d95e516a43db23cf42758766d"}]}