)]}'
{"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c27cfc48ead5b354e63f27cf8499450b93ba86f9","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                if \u0027fixed_ips\u0027 in new_port:"},{"line_number":350,"context_line":"                    ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":351,"context_line":"                    if not ipam_driver.needs_rollback():"},{"line_number":352,"context_line":"                        return"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"                    LOG.debug(\"An exception occurred during port update.\")"},{"line_number":355,"context_line":"                    if changes.add:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_cc8614b9","line":352,"updated":"2016-09-14 11:09:45.000000000","message":"Perhaps unrelated, but is the intention to reraise here? Should we disable reraise before returning?","commit_id":"0cd4736606d70a68eae867cc39cb95e664a45cc7"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dfb2f3e7fca8e4ee8b786c2b7a355b5a027fd321","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                    ipam_allocator \u003d ipam_driver.get_allocator(subnets)"},{"line_number":121,"context_line":"                    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":122,"context_line":"                      # NOTE(kevinbenton): we use a subtransaction to force"},{"line_number":123,"context_line":"                      # a flush here so we can capture DBReferenceErrors due"},{"line_number":124,"context_line":"                      # to concurrent subnet deletions."},{"line_number":125,"context_line":"                      ip_address, subnet_id \u003d ipam_allocator.allocate("},{"line_number":126,"context_line":"                          ip_request)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_4b6e3c30","line":123,"updated":"2016-09-15 00:17:55.000000000","message":"commit","commit_id":"045b0d9e4d613006933bf7555782dfbd9e1d0fcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"fb9e87e1fe582cd4c4a7a82ce4c4e5e397265280","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                    ipam_allocator \u003d ipam_driver.get_allocator(subnets)"},{"line_number":121,"context_line":"                    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":122,"context_line":"                      # NOTE(kevinbenton): we use a subtransaction to force"},{"line_number":123,"context_line":"                      # a flush here so we can capture DBReferenceErrors due"},{"line_number":124,"context_line":"                      # to concurrent subnet deletions."},{"line_number":125,"context_line":"                      ip_address, subnet_id \u003d ipam_allocator.allocate("},{"line_number":126,"context_line":"                          ip_request)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_ce9b3ac8","line":123,"in_reply_to":"7a8ec9b2_4b6e3c30","updated":"2016-09-15 00:29:12.000000000","message":"no, it\u0027s not a commit if we are in a subtransaction (which ipam always is). just a flush","commit_id":"045b0d9e4d613006933bf7555782dfbd9e1d0fcb"}],"neutron/ipam/drivers/neutrondb_ipam/driver.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e1300fbf1af58683d8a0711da5a8b944f6d9aafb","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def allocate(self, address_request):"},{"line_number":185,"context_line":"        # NOTE(pbondar): Ipam driver is always called in context of already"},{"line_number":186,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":187,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":188,"context_line":"        # should not create new nested transaction blocks."},{"line_number":189,"context_line":"        session \u003d self._context.session"},{"line_number":190,"context_line":"        all_pool_id \u003d None"},{"line_number":191,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_f26d1b99","line":188,"range":{"start_line":187,"start_character":60,"end_line":188,"end_character":57},"updated":"2016-09-15 15:20:50.000000000","message":"I don\u0027t remember what prompted this comment but it is in conflict with this change.","commit_id":"a397792ff7ac03f4f021e8d7df62d04d6641aa14"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e1ed269815e15187e053b0e40546c40d9f7bc9ca","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def allocate(self, address_request):"},{"line_number":185,"context_line":"        # NOTE(pbondar): Ipam driver is always called in context of already"},{"line_number":186,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":187,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":188,"context_line":"        # should not create new nested transaction blocks."},{"line_number":189,"context_line":"        session \u003d self._context.session"},{"line_number":190,"context_line":"        all_pool_id \u003d None"},{"line_number":191,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_99c5da8f","line":188,"range":{"start_line":187,"start_character":60,"end_line":188,"end_character":57},"in_reply_to":"7a8ec9b2_3e8cac34","updated":"2016-09-15 15:37:39.000000000","message":"I guess a SAVEPOINT might be a problem here but I can\u0027t see how the non-transactional delimiting nature of a sub-transaction could be a problem.\n\nHonestly, I still mix the two up in my head since both kind of have a \"nested\" nature to me, just in different ways. But, reading the sqlalchemy docs, it is clearer to me now.","commit_id":"a397792ff7ac03f4f021e8d7df62d04d6641aa14"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"72745816cbb0348c3bbd5d4f9457948a833aa89c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def allocate(self, address_request):"},{"line_number":185,"context_line":"        # NOTE(pbondar): Ipam driver is always called in context of already"},{"line_number":186,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":187,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":188,"context_line":"        # should not create new nested transaction blocks."},{"line_number":189,"context_line":"        session \u003d self._context.session"},{"line_number":190,"context_line":"        all_pool_id \u003d None"},{"line_number":191,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_3e8cac34","line":188,"range":{"start_line":187,"start_character":60,"end_line":188,"end_character":57},"in_reply_to":"7a8ec9b2_f26d1b99","updated":"2016-09-15 15:27:28.000000000","message":"well maybe he meant begin_nested style","commit_id":"a397792ff7ac03f4f021e8d7df62d04d6641aa14"}]}
