)]}'
{"neutron/tests/unit/objects/test_subnet.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e517967fdb423fbd3175584fb8e49e0bceeb1243","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":73,"context_line":"        self._create_dnsnameservers()"},{"line_number":74,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":75,"context_line":"        fields_sorted \u003d sorted([obj[\u0027order\u0027] for obj in self.obj_fields])"},{"line_number":76,"context_line":"        self.assertEqual(fields_sorted, [obj.order for obj in objs])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_get_objects_sort_by_order_desc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ddcb2071","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":31},"updated":"2016-09-14 11:46:26.000000000","message":"How about getting rid of this sorted stuff and call assertItemsEqual on L76?","commit_id":"565fd649b1eea4528c92310824e3d63f1faca414"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"87da8357a7799574e7d509a69de9e73c30d87a4f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":73,"context_line":"        self._create_dnsnameservers()"},{"line_number":74,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":75,"context_line":"        fields_sorted \u003d sorted([obj[\u0027order\u0027] for obj in self.obj_fields])"},{"line_number":76,"context_line":"        self.assertEqual(fields_sorted, [obj.order for obj in objs])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_get_objects_sort_by_order_desc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d635ba46","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":31},"in_reply_to":"7a8ec9b2_4e1754a3","updated":"2016-09-14 13:10:41.000000000","message":"@Ihar, because it will always pass! :)","commit_id":"565fd649b1eea4528c92310824e3d63f1faca414"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"221669771582992a17df75a3ada14c0d4f44b29c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":73,"context_line":"        self._create_dnsnameservers()"},{"line_number":74,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":75,"context_line":"        fields_sorted \u003d sorted([obj[\u0027order\u0027] for obj in self.obj_fields])"},{"line_number":76,"context_line":"        self.assertEqual(fields_sorted, [obj.order for obj in objs])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_get_objects_sort_by_order_desc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_10964a4c","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":31},"in_reply_to":"7a8ec9b2_4e1754a3","updated":"2016-09-14 12:41:20.000000000","message":"Shame on me. :) I\u0027ll go through the patch more carefully","commit_id":"565fd649b1eea4528c92310824e3d63f1faca414"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1a576a6268bb9b6a890bbd84dd09b1d259909301","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":73,"context_line":"        self._create_dnsnameservers()"},{"line_number":74,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":75,"context_line":"        fields_sorted \u003d sorted([obj[\u0027order\u0027] for obj in self.obj_fields])"},{"line_number":76,"context_line":"        self.assertEqual(fields_sorted, [obj.order for obj in objs])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_get_objects_sort_by_order_desc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f672b6e4","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":31},"in_reply_to":"7a8ec9b2_d635ba46","updated":"2016-09-14 13:13:15.000000000","message":"Oh right... wait...","commit_id":"565fd649b1eea4528c92310824e3d63f1faca414"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fa772ef9de231bdfae9da005c7afa273eb4462db","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":73,"context_line":"        self._create_dnsnameservers()"},{"line_number":74,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":75,"context_line":"        fields_sorted \u003d sorted([obj[\u0027order\u0027] for obj in self.obj_fields])"},{"line_number":76,"context_line":"        self.assertEqual(fields_sorted, [obj.order for obj in objs])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_get_objects_sort_by_order_desc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_4e1754a3","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":31},"in_reply_to":"7a8ec9b2_ddade032","updated":"2016-09-14 12:29:22.000000000","message":"How is it good if we VALIDATE the ordering? :)","commit_id":"565fd649b1eea4528c92310824e3d63f1faca414"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"dd99669f1076c75ffde5f642ad30f6740412918b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_get_objects_sort_by_order_asc(self):"},{"line_number":73,"context_line":"        self._create_dnsnameservers()"},{"line_number":74,"context_line":"        objs \u003d self._test_class.get_objects(self.context)"},{"line_number":75,"context_line":"        fields_sorted \u003d sorted([obj[\u0027order\u0027] for obj in self.obj_fields])"},{"line_number":76,"context_line":"        self.assertEqual(fields_sorted, [obj.order for obj in objs])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_get_objects_sort_by_order_desc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ddade032","line":75,"range":{"start_line":75,"start_character":24,"end_line":75,"end_character":31},"in_reply_to":"7a8ec9b2_ddcb2071","updated":"2016-09-14 11:55:49.000000000","message":"Good idea, but probably this could be an issue [1]. Py2.7 has assertItemsEqual [2], when Py3 has assertCountEqual [3]. So the question is, do we support it, and which version.\n\n\n[1] https://bugs.python.org/issue17866\n[2] https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertItemsEqual\n[3] https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertCountEqual","commit_id":"565fd649b1eea4528c92310824e3d63f1faca414"}]}