)]}'
{"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9b20891ac4b88f1ac2b7808996b1685dc8851892","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def safe_delete_ha_network(self, context, ha_network, tenant_id):"},{"line_number":599,"context_line":"        try:"},{"line_number":600,"context_line":"            net_id \u003d ha_network.network_id"},{"line_number":601,"context_line":"            self._delete_ha_network(context, ha_network)"},{"line_number":602,"context_line":"        except (n_exc.NetworkNotFound,"},{"line_number":603,"context_line":"                orm.exc.ObjectDeletedError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_8bf652f7","line":600,"updated":"2016-09-15 18:59:14.000000000","message":"Someone\u0027s going to look at this and be tempted to inline it.","commit_id":"33a9a1507c18ef84d5094a3b0e8500cfff1d296d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ec81c279b780437e75edf11a208591f9dfc97cf9","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def safe_delete_ha_network(self, context, ha_network, tenant_id):"},{"line_number":599,"context_line":"        try:"},{"line_number":600,"context_line":"            net_id \u003d ha_network.network_id"},{"line_number":601,"context_line":"            self._delete_ha_network(context, ha_network)"},{"line_number":602,"context_line":"        except (n_exc.NetworkNotFound,"},{"line_number":603,"context_line":"                orm.exc.ObjectDeletedError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_eefa8442","line":600,"in_reply_to":"7a8ec9b2_8bf652f7","updated":"2016-09-15 19:30:25.000000000","message":"will note it","commit_id":"33a9a1507c18ef84d5094a3b0e8500cfff1d296d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9b20891ac4b88f1ac2b7808996b1685dc8851892","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                \"HA network for tenant %s was already deleted.\", tenant_id)"},{"line_number":606,"context_line":"        except sa.exc.InvalidRequestError:"},{"line_number":607,"context_line":"            LOG.info(_LI(\"HA network %s can not be deleted.\"),"},{"line_number":608,"context_line":"                     ha_network.network_id)"},{"line_number":609,"context_line":"        except n_exc.NetworkInUse:"},{"line_number":610,"context_line":"            # network is still in use, this is normal so we don\u0027t"},{"line_number":611,"context_line":"            # log anything"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_6b074618","line":608,"updated":"2016-09-15 18:59:14.000000000","message":"Should we use it here too? I suspect this reference could be problematic too.","commit_id":"33a9a1507c18ef84d5094a3b0e8500cfff1d296d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ec81c279b780437e75edf11a208591f9dfc97cf9","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                \"HA network for tenant %s was already deleted.\", tenant_id)"},{"line_number":606,"context_line":"        except sa.exc.InvalidRequestError:"},{"line_number":607,"context_line":"            LOG.info(_LI(\"HA network %s can not be deleted.\"),"},{"line_number":608,"context_line":"                     ha_network.network_id)"},{"line_number":609,"context_line":"        except n_exc.NetworkInUse:"},{"line_number":610,"context_line":"            # network is still in use, this is normal so we don\u0027t"},{"line_number":611,"context_line":"            # log anything"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_ae04fc49","line":608,"in_reply_to":"7a8ec9b2_6b074618","updated":"2016-09-15 19:30:25.000000000","message":"yes","commit_id":"33a9a1507c18ef84d5094a3b0e8500cfff1d296d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9b20891ac4b88f1ac2b7808996b1685dc8851892","unresolved":false,"context_lines":[{"line_number":614,"context_line":"            LOG.info(_LI(\"HA network %(network)s was deleted as \""},{"line_number":615,"context_line":"                         \"no HA routers are present in tenant \""},{"line_number":616,"context_line":"                         \"%(tenant)s.\"),"},{"line_number":617,"context_line":"                     {\u0027network\u0027: net_id, \u0027tenant\u0027: tenant_id})"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":620,"context_line":"    def delete_router(self, context, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_8b0c923c","line":617,"updated":"2016-09-15 18:59:14.000000000","message":"Looks familiar [1]. These errors are difficult to spot because they look so innocent. You just don\u0027t expect the object\u0027s data to be flushed away.\n\n [1] https://review.openstack.org/#/c/333601/2/neutron/plugins/ml2/plugin.py","commit_id":"33a9a1507c18ef84d5094a3b0e8500cfff1d296d"}]}
