)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"change_message_id":"80614b1afbcb90f5eec867427d8a7ddaec49e39d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        LOG.debug(\"Preparing device (%s) filter\", port[\u0027device\u0027])"},{"line_number":165,"context_line":"        self._remove_chains()"},{"line_number":166,"context_line":"        self._set_ports(port)"},{"line_number":167,"context_line":"        if self._enabled_netfilter_for_bridges:"},{"line_number":168,"context_line":"            self._enable_netfilter_for_bridges()"},{"line_number":169,"context_line":"        # each security group has it own chains"},{"line_number":170,"context_line":"        self._setup_chains()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_74343749","line":167,"range":{"start_line":167,"start_character":9,"end_line":167,"end_character":47},"updated":"2016-09-18 02:59:11.000000000","message":"This line should be \"if not ...\"？","commit_id":"c6543ac0b293787b37b2542e7bca01bf09f1b434"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3e22b916cc370c1a87c60a22b7cc69058495c233","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        LOG.debug(\"Preparing device (%s) filter\", port[\u0027device\u0027])"},{"line_number":165,"context_line":"        self._remove_chains()"},{"line_number":166,"context_line":"        self._set_ports(port)"},{"line_number":167,"context_line":"        if not self._enabled_netfilter_for_bridges:"},{"line_number":168,"context_line":"            self._enable_netfilter_for_bridges()"},{"line_number":169,"context_line":"        # each security group has it own chains"},{"line_number":170,"context_line":"        self._setup_chains()"},{"line_number":171,"context_line":"        return self.iptables.apply()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_45bce3ba","line":168,"range":{"start_line":167,"start_character":0,"end_line":168,"end_character":48},"updated":"2016-09-18 07:35:21.000000000","message":"The change is too trivial. In the old code, _enable_netfilter_for_bridges will just return if _enabled_netfilter_for_bridges is True. Your change here seems almost the same as the old code. You just move the shortcut code here. I don\u0027t see much value of this change.","commit_id":"a1b92d431002c3acfe8486c216d46a4f4a6700f0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"841f8022facf1426096806e9f8b881eb83b598ec","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        LOG.debug(\"Preparing device (%s) filter\", port[\u0027device\u0027])"},{"line_number":165,"context_line":"        self._remove_chains()"},{"line_number":166,"context_line":"        self._set_ports(port)"},{"line_number":167,"context_line":"        if not self._enabled_netfilter_for_bridges:"},{"line_number":168,"context_line":"            self._enable_netfilter_for_bridges()"},{"line_number":169,"context_line":"        # each security group has it own chains"},{"line_number":170,"context_line":"        self._setup_chains()"},{"line_number":171,"context_line":"        return self.iptables.apply()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_f3913648","line":168,"range":{"start_line":167,"start_character":0,"end_line":168,"end_character":48},"in_reply_to":"7a8ec9b2_45bce3ba","updated":"2016-09-18 15:21:56.000000000","message":"I think it also makes more sense for the test to be inside the function. That way, if it is called from somewhere else, the condition doesn\u0027t have to be tested there as well.","commit_id":"a1b92d431002c3acfe8486c216d46a4f4a6700f0"}],"neutron/tests/unit/agent/test_securitygroups_rpc.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3e22b916cc370c1a87c60a22b7cc69058495c233","unresolved":false,"context_lines":[{"line_number":2794,"context_line":"            self.assertThat(kwargs[\u0027process_input\u0027],"},{"line_number":2795,"context_line":"                            matchers.MatchesRegex(expected_regex))"},{"line_number":2796,"context_line":""},{"line_number":2797,"context_line":"        expected \u003d [\u0027net.bridge.bridge-nf-call-arptables\u003d1\u0027,"},{"line_number":2798,"context_line":"                    \u0027net.bridge.bridge-nf-call-ip6tables\u003d1\u0027,"},{"line_number":2799,"context_line":"                    \u0027net.bridge.bridge-nf-call-iptables\u003d1\u0027]"},{"line_number":2800,"context_line":"        for e in expected:"},{"line_number":2801,"context_line":"            self.utils_exec.assert_any_call([\u0027sysctl\u0027, \u0027-w\u0027, e],"},{"line_number":2802,"context_line":"                                            run_as_root\u003dTrue)"},{"line_number":2803,"context_line":"        self.assertEqual(exp_fw_sg_updated_call,"},{"line_number":2804,"context_line":"                         self.agent.firewall.security_group_updated.called)"},{"line_number":2805,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_4595c330","side":"PARENT","line":2802,"range":{"start_line":2797,"start_character":0,"end_line":2802,"end_character":61},"updated":"2016-09-18 07:35:21.000000000","message":"Why remove the code here? I try it locally, the UT can still pass with your change in this patch and also with this code in UT.","commit_id":"2fc9c3e75fe2fb8f53cd6ca2ff27318f1a4d09a4"}]}
