)]}'
{"neutron/agent/l3_agent.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4272fc9c82afd60611d3215eda69b15d0432f5c2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":68,"context_line":"        self.host \u003d host"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get_routers(self, context, router_ids\u003dNone, fullsync\u003dTrue):"},{"line_number":71,"context_line":"        \"\"\"Make a remote process call to retrieve the sync data for routers.\"\"\""},{"line_number":72,"context_line":"        return self.call(context,"},{"line_number":73,"context_line":"                         self.make_msg(\u0027sync_routers\u0027, host\u003dself.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlZU%3D","line":70,"updated":"2013-07-16 08:42:30.000000000","message":"fullsync is still not used.","commit_id":"6514339c0049485aecd9f995cd1d1ac83373cbde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e68d149790816f3e5c930f82849484005dc481d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":68,"context_line":"        self.host \u003d host"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get_routers(self, context, router_ids\u003dNone, fullsync\u003dTrue):"},{"line_number":71,"context_line":"        \"\"\"Make a remote process call to retrieve the sync data for routers.\"\"\""},{"line_number":72,"context_line":"        return self.call(context,"},{"line_number":73,"context_line":"                         self.make_msg(\u0027sync_routers\u0027, host\u003dself.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlWc%3D","line":70,"in_reply_to":"AAAAP3%2F%2FlZU%3D","updated":"2013-07-16 09:06:52.000000000","message":"fullsync is not used anywhere, so I removed it.\nIt does not change the RPC signature so we need to change the RPC version.","commit_id":"6514339c0049485aecd9f995cd1d1ac83373cbde"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9acd80dc6b00fd410796acd6beaba844d5965ced","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        if not router_ids:"},{"line_number":179,"context_line":"            pass"},{"line_number":180,"context_line":"        elif len(router_ids) \u003e 1:"},{"line_number":181,"context_line":"            query \u003d query.filter("},{"line_number":182,"context_line":"                RouterL3AgentBinding.router_id.in_(router_ids))"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            query \u003d query.filter(RouterL3AgentBinding.router_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlYg%3D","line":181,"updated":"2013-07-16 08:53:30.000000000","message":"won\u0027t this filter work when len(router_ids) \u003d\u003d 1?","commit_id":"6514339c0049485aecd9f995cd1d1ac83373cbde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e68d149790816f3e5c930f82849484005dc481d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        if not router_ids:"},{"line_number":179,"context_line":"            pass"},{"line_number":180,"context_line":"        elif len(router_ids) \u003e 1:"},{"line_number":181,"context_line":"            query \u003d query.filter("},{"line_number":182,"context_line":"                RouterL3AgentBinding.router_id.in_(router_ids))"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            query \u003d query.filter(RouterL3AgentBinding.router_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlU4%3D","line":181,"in_reply_to":"AAAAP3%2F%2FlYg%3D","updated":"2013-07-16 09:06:52.000000000","message":"Both of them work. I just reused the similar logic around L.200. I am sure there is visible performance difference between them. Which is better? I prefer to simpler code and like your suggestion.","commit_id":"6514339c0049485aecd9f995cd1d1ac83373cbde"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4272fc9c82afd60611d3215eda69b15d0432f5c2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                LOG.warn(_(\u0027L3 agent %s is not active\u0027), l3_agent.id)"},{"line_number":63,"context_line":"            # check if each of the specified routers is hosted"},{"line_number":64,"context_line":"            if router_ids:"},{"line_number":65,"context_line":"                unschd_router_ids \u003d []"},{"line_number":66,"context_line":"                for router_id in router_ids:"},{"line_number":67,"context_line":"                    l3_agents \u003d plugin.get_l3_agents_hosting_routers("},{"line_number":68,"context_line":"                        context, [router_id], admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlZ8%3D","line":65,"updated":"2013-07-16 08:42:30.000000000","message":"nit: i prefer uncheduled_router_ids","commit_id":"6514339c0049485aecd9f995cd1d1ac83373cbde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e68d149790816f3e5c930f82849484005dc481d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                LOG.warn(_(\u0027L3 agent %s is not active\u0027), l3_agent.id)"},{"line_number":63,"context_line":"            # check if each of the specified routers is hosted"},{"line_number":64,"context_line":"            if router_ids:"},{"line_number":65,"context_line":"                unschd_router_ids \u003d []"},{"line_number":66,"context_line":"                for router_id in router_ids:"},{"line_number":67,"context_line":"                    l3_agents \u003d plugin.get_l3_agents_hosting_routers("},{"line_number":68,"context_line":"                        context, [router_id], admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlWo%3D","line":65,"in_reply_to":"AAAAP3%2F%2FlZ8%3D","updated":"2013-07-16 09:06:52.000000000","message":"Done","commit_id":"6514339c0049485aecd9f995cd1d1ac83373cbde"}]}
