)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"5b59644a44d59dd0574cb1fa3ad096965d92bf2f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Neutron server was not compatible with member actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Register a new extension into Neutron server, and this extension"},{"line_number":10,"context_line":"contains a member action.if new member action contains the \"update\""},{"line_number":11,"context_line":"string. As a result, Neutron server check the target whether contains"},{"line_number":12,"context_line":"\"ATTRIBUTES_TO_UPDATE\". Because this is a member action so that neutron"},{"line_number":13,"context_line":"server will not go \"_update\" method normally. It will go \"_handle_action\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_c4f33809","line":10,"updated":"2016-10-11 18:08:43.000000000","message":"nit: Missing whitespace","commit_id":"00afaf9181e6ae631bbfa68cf6bc74020ae607fd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ff28280442dd79f5fc45211c44e01ef0b4615850","unresolved":false,"context_lines":[{"line_number":10,"context_line":"contains a member action. if new member action contains the \"update\""},{"line_number":11,"context_line":"string. As a result, Neutron server check the target whether contains"},{"line_number":12,"context_line":"\"ATTRIBUTES_TO_UPDATE\". Because this is a member action so that neutron"},{"line_number":13,"context_line":"server will not go \"_update\" method normally. It will go \"_handle_action\""},{"line_number":14,"context_line":"method. So the exception happens KeyError: \u0027attributes_to_update\u0027."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie8bb7b9af42a82aada28d2bcdfd5b0e573ad9778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa6399be_38094532","line":13,"updated":"2016-10-12 18:40:45.000000000","message":"nit: line exceeds 72 characters","commit_id":"57988cbb63624df9f2b603ed07f638775077bc11"}],"neutron/policy.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"eb443db92b86ff7f1afc936e3abeb80475032206","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _is_attribute_explicitly_set(attribute_name, resource, target, action):"},{"line_number":87,"context_line":"    \"\"\"Verify that an attribute is present and is explicitly set.\"\"\""},{"line_number":88,"context_line":"    if \u0027update\u0027 in action and target.get(const.ATTRIBUTES_TO_UPDATE):"},{"line_number":89,"context_line":"        # In the case of update, the function should not pay attention to a"},{"line_number":90,"context_line":"        # default value of an attribute, but check whether it was explicitly"},{"line_number":91,"context_line":"        # marked as being updated instead."}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_075719cb","line":88,"updated":"2016-11-21 12:22:47.000000000","message":"Is there any purpose in checking for \u0027update\u0027 in the action anymore? Doesn\u0027t the second part of the conditional always tell us there is something to update?","commit_id":"18031a36f2a17e09d0b45ac027fe30330a952a68"},{"author":{"_account_id":24856,"name":"zhang ping","email":"ping.zhang@easystack.cn","username":"zp860905"},"change_message_id":"784db700c119f610f61b7da457598b89e6ec2a65","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _is_attribute_explicitly_set(attribute_name, resource, target, action):"},{"line_number":87,"context_line":"    \"\"\"Verify that an attribute is present and is explicitly set.\"\"\""},{"line_number":88,"context_line":"    if \u0027update\u0027 in action and target.get(const.ATTRIBUTES_TO_UPDATE):"},{"line_number":89,"context_line":"        # In the case of update, the function should not pay attention to a"},{"line_number":90,"context_line":"        # default value of an attribute, but check whether it was explicitly"},{"line_number":91,"context_line":"        # marked as being updated instead."}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_276c5d34","line":88,"in_reply_to":"7a77a97e_075719cb","updated":"2017-01-18 02:10:28.000000000","message":"Done","commit_id":"18031a36f2a17e09d0b45ac027fe30330a952a68"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b16a4912184c3d832337baf5a63db00019414e26","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _is_attribute_explicitly_set(attribute_name, resource, target, action):"},{"line_number":87,"context_line":"    \"\"\"Verify that an attribute is present and is explicitly set.\"\"\""},{"line_number":88,"context_line":"    if target.get(const.ATTRIBUTES_TO_UPDATE):"},{"line_number":89,"context_line":"        # In the case of update, the function should not pay attention to a"},{"line_number":90,"context_line":"        # default value of an attribute, but check whether it was explicitly"},{"line_number":91,"context_line":"        # marked as being updated instead."}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_27541fca","line":88,"updated":"2017-04-15 00:20:45.000000000","message":"I recommended \"\u0027update\u0027 in action\" be removed since I don\u0027t think we can match the second half of this without that always being true.","commit_id":"daa8e1b1b0c2ec5353b20aae155cea668c637ffc"},{"author":{"_account_id":19999,"name":"Trinath Somanchi","email":"trinaths.dev@gmail.com","username":"trinath-somanchi"},"change_message_id":"fe856229fbeee1b4477a4104fd8ed4647a807303","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _is_attribute_explicitly_set(attribute_name, resource, target, action):"},{"line_number":87,"context_line":"    \"\"\"Verify that an attribute is present and is explicitly set.\"\"\""},{"line_number":88,"context_line":"    if target.get(const.ATTRIBUTES_TO_UPDATE):"},{"line_number":89,"context_line":"        # In the case of update, the function should not pay attention to a"},{"line_number":90,"context_line":"        # default value of an attribute, but check whether it was explicitly"},{"line_number":91,"context_line":"        # marked as being updated instead."}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_a49f18b3","line":88,"updated":"2017-03-24 08:12:12.000000000","message":"if \u0027update\u0027 in action and target.get(const.ATTRIBUTES_TO_UPDATE):","commit_id":"daa8e1b1b0c2ec5353b20aae155cea668c637ffc"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dbe347f6839037e493bb752709863a5c17ce71d","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _is_attribute_explicitly_set(attribute_name, resource, target, action):"},{"line_number":87,"context_line":"    \"\"\"Verify that an attribute is present and is explicitly set.\"\"\""},{"line_number":88,"context_line":"    if target.get(const.ATTRIBUTES_TO_UPDATE):"},{"line_number":89,"context_line":"        # In the case of update, the function should not pay attention to a"},{"line_number":90,"context_line":"        # default value of an attribute, but check whether it was explicitly"},{"line_number":91,"context_line":"        # marked as being updated instead."}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_7ba8e68a","line":88,"in_reply_to":"7ffa3b31_27541fca","updated":"2017-04-21 05:04:00.000000000","message":"agree","commit_id":"daa8e1b1b0c2ec5353b20aae155cea668c637ffc"}]}
