)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"50522a4b3dc70694d5acd8d7b085e85e6fbeba0c","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"                  \u0027last_known_router_id\u0027: previous_router_id}"},{"line_number":1184,"context_line":"        if \u0027description\u0027 in fip:"},{"line_number":1185,"context_line":"            update[\u0027description\u0027] \u003d fip[\u0027description\u0027]"},{"line_number":1186,"context_line":"        floatingip_db.update(update)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    def _notify_floating_ip_update("},{"line_number":1189,"context_line":"            self, context, fip, previous_router_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ee0db28f","line":1186,"updated":"2016-09-19 11:50:15.000000000","message":"Would keeping a pre-commit event be interesting? In case someone registered to the old AFTER_UPDATE event was counting on still holding the transaction?","commit_id":"11cdd1658b9999379f457a4c4491d2459c683634"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"880f9020e855e092f9b80f1f486ffd4fab0f9578","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"                  \u0027last_known_router_id\u0027: previous_router_id}"},{"line_number":1184,"context_line":"        if \u0027description\u0027 in fip:"},{"line_number":1185,"context_line":"            update[\u0027description\u0027] \u003d fip[\u0027description\u0027]"},{"line_number":1186,"context_line":"        floatingip_db.update(update)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    def _notify_floating_ip_update("},{"line_number":1189,"context_line":"            self, context, fip, previous_router_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d3fe93ad","line":1186,"in_reply_to":"7a8ec9b2_3b3fc5d7","updated":"2016-09-20 13:45:23.000000000","message":"Ryan,\n\nthank you for taking care of networking-midonet.\ncurrently it doesn\u0027t use this notification. (it does never advertise FIP host routes.)\nnor have a plan to use this in foreseeable future.","commit_id":"11cdd1658b9999379f457a4c4491d2459c683634"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"435734f6c8a2338b357a1ef8d94fec15ce0083ec","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"                  \u0027last_known_router_id\u0027: previous_router_id}"},{"line_number":1184,"context_line":"        if \u0027description\u0027 in fip:"},{"line_number":1185,"context_line":"            update[\u0027description\u0027] \u003d fip[\u0027description\u0027]"},{"line_number":1186,"context_line":"        floatingip_db.update(update)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    def _notify_floating_ip_update("},{"line_number":1189,"context_line":"            self, context, fip, previous_router_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3b3fc5d7","line":1186,"in_reply_to":"7a8ec9b2_ee0db28f","updated":"2016-09-19 17:39:56.000000000","message":"I\u0027m thinking the way we emit this is actually buggy. neutron-dynamic-routing has been assuming that the transaction was committed before it was getting this notification. While the reference implementation does refresh its RIB every 60 seconds, this can still lead to a stray advertisement. As far as I know the only other consumer of this notification would be the Midonet plugin. I would think they would be looking for an \"after_commit\" notification as well, but someone who understands the Midonet plugin would have to confirm.\n\n+1 to the idea of having a notification that fires after the transaction completes. I would prefer that neutron-dynamic-routing subscribe to an \"after_commit\" notification.","commit_id":"11cdd1658b9999379f457a4c4491d2459c683634"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3817b69a03dd6def74d373cf2b0887fc550dc6e2","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"                  \u0027last_known_router_id\u0027: previous_router_id}"},{"line_number":1184,"context_line":"        if \u0027description\u0027 in fip:"},{"line_number":1185,"context_line":"            update[\u0027description\u0027] \u003d fip[\u0027description\u0027]"},{"line_number":1186,"context_line":"        floatingip_db.update(update)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    def _notify_floating_ip_update("},{"line_number":1189,"context_line":"            self, context, fip, previous_router_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_2466d9ec","line":1186,"in_reply_to":"7a8ec9b2_ee0db28f","updated":"2016-09-19 12:16:47.000000000","message":"That may need another patch.","commit_id":"11cdd1658b9999379f457a4c4491d2459c683634"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"50522a4b3dc70694d5acd8d7b085e85e6fbeba0c","unresolved":false,"context_lines":[{"line_number":1300,"context_line":""},{"line_number":1301,"context_line":"    def _update_floatingip(self, context, id, floatingip):"},{"line_number":1302,"context_line":"        fip \u003d floatingip[\u0027floatingip\u0027]"},{"line_number":1303,"context_line":"        previous_router_id \u003d None"},{"line_number":1304,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1305,"context_line":"            floatingip_db \u003d self._get_floatingip(context, id)"},{"line_number":1306,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ee36924f","line":1303,"updated":"2016-09-19 11:50:15.000000000","message":"I don\u0027t think you need to define previous_router_id here. It will always be defined on line 1307.","commit_id":"11cdd1658b9999379f457a4c4491d2459c683634"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3817b69a03dd6def74d373cf2b0887fc550dc6e2","unresolved":false,"context_lines":[{"line_number":1300,"context_line":""},{"line_number":1301,"context_line":"    def _update_floatingip(self, context, id, floatingip):"},{"line_number":1302,"context_line":"        fip \u003d floatingip[\u0027floatingip\u0027]"},{"line_number":1303,"context_line":"        previous_router_id \u003d None"},{"line_number":1304,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1305,"context_line":"            floatingip_db \u003d self._get_floatingip(context, id)"},{"line_number":1306,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_89918849","line":1303,"in_reply_to":"7a8ec9b2_ee36924f","updated":"2016-09-19 12:16:47.000000000","message":"Done, thanks.","commit_id":"11cdd1658b9999379f457a4c4491d2459c683634"}]}
