)]}'
{"neutron/tests/tempest/scenario/test_trunk.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cee234335dbcc7ba81f1617c3d2ace09ff5f14e7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":50,"context_line":"            image_ref\u003dCONF.compute.image_ref,"},{"line_number":51,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.network[\u0027id\u0027],"},{"line_number":53,"context_line":"                       \u0027port\u0027: port[\u0027id\u0027]}])[\u0027server\u0027]"},{"line_number":54,"context_line":"        self.addCleanup(self._detach_and_delete_trunk, server, trunk)"},{"line_number":55,"context_line":"        return {\u0027port\u0027: port, \u0027trunk\u0027: trunk, \u0027fip\u0027: fip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_224b0ab2","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":49},"updated":"2016-09-19 22:09:28.000000000","message":"I don\u0027t think you need to specify the network id, since you are specifying the port id, unless there is something new with trunks that I don\u0027t know of :-)","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"06eca3efd2a2411e14188e37df8a5b51fcde0f79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":50,"context_line":"            image_ref\u003dCONF.compute.image_ref,"},{"line_number":51,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.network[\u0027id\u0027],"},{"line_number":53,"context_line":"                       \u0027port\u0027: port[\u0027id\u0027]}])[\u0027server\u0027]"},{"line_number":54,"context_line":"        self.addCleanup(self._detach_and_delete_trunk, server, trunk)"},{"line_number":55,"context_line":"        return {\u0027port\u0027: port, \u0027trunk\u0027: trunk, \u0027fip\u0027: fip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e585acad","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":49},"in_reply_to":"7a8ec9b2_224b0ab2","updated":"2016-09-19 22:35:43.000000000","message":"No, there\u0027s isn\u0027t.","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0d235e59ea5b4095ae9bba329bc108b995bf09b8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":50,"context_line":"            image_ref\u003dCONF.compute.image_ref,"},{"line_number":51,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            networks\u003d[{\u0027uuid\u0027: self.network[\u0027id\u0027],"},{"line_number":53,"context_line":"                       \u0027port\u0027: port[\u0027id\u0027]}])[\u0027server\u0027]"},{"line_number":54,"context_line":"        self.addCleanup(self._detach_and_delete_trunk, server, trunk)"},{"line_number":55,"context_line":"        return {\u0027port\u0027: port, \u0027trunk\u0027: trunk, \u0027fip\u0027: fip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_72990b6e","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":49},"in_reply_to":"7a8ec9b2_e585acad","updated":"2016-09-21 08:45:31.000000000","message":"Ah, I had just copied that from another test that specifies a port.","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cee234335dbcc7ba81f1617c3d2ace09ff5f14e7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        utils.wait_until_true(is_port_detached)"},{"line_number":68,"context_line":"        self.client.delete_trunk(trunk[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _port_active(self, port_id):"},{"line_number":71,"context_line":"        p \u003d self.client.show_port(port_id)[\u0027port\u0027]"},{"line_number":72,"context_line":"        return p[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_227eaaae","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":20},"updated":"2016-09-19 22:09:28.000000000","message":"_is_port_active maybe?","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0d235e59ea5b4095ae9bba329bc108b995bf09b8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        utils.wait_until_true(is_port_detached)"},{"line_number":68,"context_line":"        self.client.delete_trunk(trunk[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _port_active(self, port_id):"},{"line_number":71,"context_line":"        p \u003d self.client.show_port(port_id)[\u0027port\u0027]"},{"line_number":72,"context_line":"        return p[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d2c57f3d","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":20},"in_reply_to":"7a8ec9b2_227eaaae","updated":"2016-09-21 08:45:31.000000000","message":"Done","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cee234335dbcc7ba81f1617c3d2ace09ff5f14e7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        p \u003d self.client.show_port(port_id)[\u0027port\u0027]"},{"line_number":72,"context_line":"        return p[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _trunk_active(self, trunk_id):"},{"line_number":75,"context_line":"        t \u003d self.client.show_trunk(trunk_id)[\u0027trunk\u0027]"},{"line_number":76,"context_line":"        return t[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_8243fe6b","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":21},"updated":"2016-09-19 22:09:28.000000000","message":"_is_trunk_active maybe?","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0d235e59ea5b4095ae9bba329bc108b995bf09b8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        p \u003d self.client.show_port(port_id)[\u0027port\u0027]"},{"line_number":72,"context_line":"        return p[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _trunk_active(self, trunk_id):"},{"line_number":75,"context_line":"        t \u003d self.client.show_trunk(trunk_id)[\u0027trunk\u0027]"},{"line_number":76,"context_line":"        return t[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_12c0c729","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":21},"in_reply_to":"7a8ec9b2_8243fe6b","updated":"2016-09-21 08:45:31.000000000","message":"Done","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"06eca3efd2a2411e14188e37df8a5b51fcde0f79","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # move subports over to other server"},{"line_number":120,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":122,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":123,"context_line":"        utils.wait_until_true(lambda: self._trunk_active(t1))"},{"line_number":124,"context_line":"        utils.wait_until_true(lambda: self._trunk_active(t2))"},{"line_number":125,"context_line":"        # ensure subports come up on other trunk"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_252cf4aa","line":122,"updated":"2016-09-19 22:35:43.000000000","message":"want to check the right bindings for the subports too?","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0d235e59ea5b4095ae9bba329bc108b995bf09b8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # move subports over to other server"},{"line_number":120,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":122,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":123,"context_line":"        utils.wait_until_true(lambda: self._trunk_active(t1))"},{"line_number":124,"context_line":"        utils.wait_until_true(lambda: self._trunk_active(t2))"},{"line_number":125,"context_line":"        # ensure subports come up on other trunk"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_b2955341","line":122,"in_reply_to":"7a8ec9b2_252cf4aa","updated":"2016-09-21 08:45:31.000000000","message":"nah, that will require admin creds, not a huge deal but nothing else does. also in most tests the host ID will be the same on both because it\u0027s single node.","commit_id":"7eb2f133e747b6c32e1fcfb3fbd01ecd0d6d3f2b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @test.requires_ext(extension\u003d\"trunk\", service\u003d\"network\")"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(TrunkTest, cls).resource_setup()"},{"line_number":36,"context_line":"        cls._trunks \u003d []"},{"line_number":37,"context_line":"        # setup basic topology for servers we can log into"},{"line_number":38,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":39,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_354e7f6f","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":24},"updated":"2016-09-21 12:00:24.000000000","message":"Unused?","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @test.requires_ext(extension\u003d\"trunk\", service\u003d\"network\")"},{"line_number":34,"context_line":"    def resource_setup(cls):"},{"line_number":35,"context_line":"        super(TrunkTest, cls).resource_setup()"},{"line_number":36,"context_line":"        cls._trunks \u003d []"},{"line_number":37,"context_line":"        # setup basic topology for servers we can log into"},{"line_number":38,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":39,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_3a9ca6bf","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":24},"in_reply_to":"7a8ec9b2_354e7f6f","updated":"2016-09-21 13:26:19.000000000","message":"yeah, leftover from a different cleanup i started with.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_server_with_trunk_port(self):"},{"line_number":45,"context_line":"        port \u003d self.create_port(self.network)"},{"line_number":46,"context_line":"        trunk \u003d self.client.create_trunk(port[\u0027id\u0027], subports\u003d[])[\u0027trunk\u0027]"},{"line_number":47,"context_line":"        fip \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":48,"context_line":"        server \u003d self.create_server("},{"line_number":49,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_f14fd231","line":46,"range":{"start_line":46,"start_character":52,"end_line":46,"end_character":64},"updated":"2016-09-21 12:00:24.000000000","message":"do you need to pass empty list to api?","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ed3b51a4d485b79d25b13a7679893d79226b3dfb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_server_with_trunk_port(self):"},{"line_number":45,"context_line":"        port \u003d self.create_port(self.network)"},{"line_number":46,"context_line":"        trunk \u003d self.client.create_trunk(port[\u0027id\u0027], subports\u003d[])[\u0027trunk\u0027]"},{"line_number":47,"context_line":"        fip \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":48,"context_line":"        server \u003d self.create_server("},{"line_number":49,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_da3d822c","line":46,"range":{"start_line":46,"start_character":52,"end_line":46,"end_character":64},"in_reply_to":"7a8ec9b2_e47aa323","updated":"2016-09-21 14:00:33.000000000","message":"Which means \"no\"? :) Looking at https://github.com/openstack/neutron/blob/409ca39f016d89f961a78f0b9e4653454dfe1426/neutron/tests/tempest/services/network/json/network_client.py#L719\n\nMaybe we should default it to None? (not related to this patch)","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _create_server_with_trunk_port(self):"},{"line_number":45,"context_line":"        port \u003d self.create_port(self.network)"},{"line_number":46,"context_line":"        trunk \u003d self.client.create_trunk(port[\u0027id\u0027], subports\u003d[])[\u0027trunk\u0027]"},{"line_number":47,"context_line":"        fip \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":48,"context_line":"        server \u003d self.create_server("},{"line_number":49,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e47aa323","line":46,"range":{"start_line":46,"start_character":52,"end_line":46,"end_character":64},"in_reply_to":"7a8ec9b2_f14fd231","updated":"2016-09-21 13:26:19.000000000","message":"https://github.com/openstack/neutron/blob/409ca39f016d89f961a78f0b9e4653454dfe1426/neutron/tests/tempest/services/network/json/network_client.py#L710","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        def is_port_detached():"},{"line_number":64,"context_line":"            p \u003d self.client.show_port(trunk[\u0027port_id\u0027])[\u0027port\u0027]"},{"line_number":65,"context_line":"            return p[\u0027device_id\u0027] \u003d\u003d \u0027\u0027"},{"line_number":66,"context_line":"        utils.wait_until_true(is_port_detached)"},{"line_number":67,"context_line":"        self.client.delete_trunk(trunk[\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _is_port_active(self, port_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_91de8e6b","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":47},"updated":"2016-09-21 12:00:24.000000000","message":"We should raise some meaningful exception like \"Port %(port_id)s hasn\u0027t been detached in 60 seconds\". Makes debugging easier. Applies for all usage of wait_until_true","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        def is_port_detached():"},{"line_number":64,"context_line":"            p \u003d self.client.show_port(trunk[\u0027port_id\u0027])[\u0027port\u0027]"},{"line_number":65,"context_line":"            return p[\u0027device_id\u0027] \u003d\u003d \u0027\u0027"},{"line_number":66,"context_line":"        utils.wait_until_true(is_port_detached)"},{"line_number":67,"context_line":"        self.client.delete_trunk(trunk[\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _is_port_active(self, port_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_ba6996c0","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":47},"in_reply_to":"7a8ec9b2_91de8e6b","updated":"2016-09-21 13:26:19.000000000","message":"It should be immediately obvious in the traceback, but sure.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ed3b51a4d485b79d25b13a7679893d79226b3dfb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        def is_port_detached():"},{"line_number":64,"context_line":"            p \u003d self.client.show_port(trunk[\u0027port_id\u0027])[\u0027port\u0027]"},{"line_number":65,"context_line":"            return p[\u0027device_id\u0027] \u003d\u003d \u0027\u0027"},{"line_number":66,"context_line":"        utils.wait_until_true(is_port_detached)"},{"line_number":67,"context_line":"        self.client.delete_trunk(trunk[\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _is_port_active(self, port_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_5af4125a","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":47},"in_reply_to":"7a8ec9b2_ba6996c0","updated":"2016-09-21 14:00:33.000000000","message":"Yeah, I mean in the traceback you usually see \"Timeout 60 seconds\" and then you need to go back to see what failed.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self.check_connectivity(server[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":97,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":98,"context_line":"                                    self.keypair[\u0027private_key\u0027])"},{"line_number":99,"context_line":"        t1, t2 \u003d server1[\u0027trunk\u0027][\u0027id\u0027], server2[\u0027trunk\u0027][\u0027id\u0027]"},{"line_number":100,"context_line":"        # trunks should transition to ACTIVE without any subports"},{"line_number":101,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":102,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t2))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e39c606c","line":99,"range":{"start_line":99,"start_character":8,"end_line":99,"end_character":14},"updated":"2016-09-21 12:00:24.000000000","message":"Nit: Maybe trunk_id1 and trunk_id2 would make more sense.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self.check_connectivity(server[\u0027fip\u0027][\u0027floating_ip_address\u0027],"},{"line_number":97,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":98,"context_line":"                                    self.keypair[\u0027private_key\u0027])"},{"line_number":99,"context_line":"        t1, t2 \u003d server1[\u0027trunk\u0027][\u0027id\u0027], server2[\u0027trunk\u0027][\u0027id\u0027]"},{"line_number":100,"context_line":"        # trunks should transition to ACTIVE without any subports"},{"line_number":101,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":102,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t2))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a485fbcf","line":99,"range":{"start_line":99,"start_character":8,"end_line":99,"end_character":14},"in_reply_to":"7a8ec9b2_e39c606c","updated":"2016-09-21 13:26:19.000000000","message":"Done","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                    for seg_id in range(3, 7)]"},{"line_number":107,"context_line":"        # add all subports to server1"},{"line_number":108,"context_line":"        self.client.add_subports(t1, subports)"},{"line_number":109,"context_line":"        # ensure trunk transitions to ACTIVE"},{"line_number":110,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":111,"context_line":"        # ensure all underlying subports transitioned to ACTIVE"},{"line_number":112,"context_line":"        for s in subports:"},{"line_number":113,"context_line":"            utils.wait_until_true(lambda: self._is_port_active(s[\u0027port_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_63da104d","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":64},"updated":"2016-09-21 12:00:24.000000000","message":"Would this make more sense to check after we waited for all subports to become active. I\u0027m thinking about situation where trunk is in ACTIVE, we pass this validation, but then it gets DOWN.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ed3b51a4d485b79d25b13a7679893d79226b3dfb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                    for seg_id in range(3, 7)]"},{"line_number":107,"context_line":"        # add all subports to server1"},{"line_number":108,"context_line":"        self.client.add_subports(t1, subports)"},{"line_number":109,"context_line":"        # ensure trunk transitions to ACTIVE"},{"line_number":110,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":111,"context_line":"        # ensure all underlying subports transitioned to ACTIVE"},{"line_number":112,"context_line":"        for s in subports:"},{"line_number":113,"context_line":"            utils.wait_until_true(lambda: self._is_port_active(s[\u0027port_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_5a509232","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":64},"in_reply_to":"7a8ec9b2_44c8b722","updated":"2016-09-21 14:00:33.000000000","message":"I meant if there could be a race where you query API before trunk was changed from ACTIVE to DOWN due to adding subports.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                    for seg_id in range(3, 7)]"},{"line_number":107,"context_line":"        # add all subports to server1"},{"line_number":108,"context_line":"        self.client.add_subports(t1, subports)"},{"line_number":109,"context_line":"        # ensure trunk transitions to ACTIVE"},{"line_number":110,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":111,"context_line":"        # ensure all underlying subports transitioned to ACTIVE"},{"line_number":112,"context_line":"        for s in subports:"},{"line_number":113,"context_line":"            utils.wait_until_true(lambda: self._is_port_active(s[\u0027port_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_44c8b722","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":64},"in_reply_to":"7a8ec9b2_63da104d","updated":"2016-09-21 13:26:19.000000000","message":"The trunk should not be ACTIVE after subports are added until they are wired.","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":117,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":118,"context_line":"        # move subports over to other server"},{"line_number":119,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":120,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":122,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_63b13001","line":119,"range":{"start_line":119,"start_character":36,"end_line":119,"end_character":58},"updated":"2016-09-21 12:00:24.000000000","message":"t1","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":117,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":118,"context_line":"        # move subports over to other server"},{"line_number":119,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":120,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":122,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e4ae232d","line":119,"range":{"start_line":119,"start_character":36,"end_line":119,"end_character":58},"in_reply_to":"7a8ec9b2_63b13001","updated":"2016-09-21 13:26:19.000000000","message":"Done","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":118,"context_line":"        # move subports over to other server"},{"line_number":119,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":120,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":122,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":123,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t2))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_7579e781","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":1},"updated":"2016-09-21 12:00:24.000000000","message":"Should we check subports\u0027 state and maybe binding here?","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cb75bc128dfc92be9a62ba3b0dbc525256245ea5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":118,"context_line":"        # move subports over to other server"},{"line_number":119,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":120,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":122,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":123,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t2))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_b5b0cf44","line":120,"range":{"start_line":120,"start_character":33,"end_line":120,"end_character":55},"updated":"2016-09-21 12:00:24.000000000","message":"t2","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ac2b93c391a8b537bda497a8ffcec5741bc522","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":118,"context_line":"        # move subports over to other server"},{"line_number":119,"context_line":"        self.client.remove_subports(server1[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":120,"context_line":"        self.client.add_subports(server2[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":121,"context_line":"        # wait for both trunks to go back to ACTIVE"},{"line_number":122,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t1))"},{"line_number":123,"context_line":"        utils.wait_until_true(lambda: self._is_trunk_active(t2))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_8438ffef","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":1},"in_reply_to":"7a8ec9b2_7579e781","updated":"2016-09-21 13:26:19.000000000","message":"binding requires admin credentials. i don\u0027t want to use them if we can avoid it","commit_id":"c1c50c65b30da297ed4038a245ee7e5862d10c29"}]}
