)]}'
{"neutron/agent/ovsdb/impl_idl.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"49ae547c12dead6ffb4bb73ffa0ca9497a66a92b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import time"},{"line_number":16,"context_line":"from uuid import UUID"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import exceptions"},{"line_number":19,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_9c4ee5bf","line":16,"updated":"2016-09-20 12:07:02.000000000","message":"I think it would be better to import uuid, and use uuid.UUID, as per http://docs.openstack.org/developer/hacking/#imports .","commit_id":"112f41d60d1c3237655d02783903892b8943c1a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"4bcf251a86324924047cdef7ec9080678d433e5d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import time"},{"line_number":16,"context_line":"from uuid import UUID"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import exceptions"},{"line_number":19,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_1fb487f0","line":16,"in_reply_to":"7a8ec9b2_9c4ee5bf","updated":"2016-09-20 12:16:24.000000000","message":"Sure, will fix this.","commit_id":"112f41d60d1c3237655d02783903892b8943c1a6"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"49ae547c12dead6ffb4bb73ffa0ca9497a66a92b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            for c in self.commands:"},{"line_number":132,"context_line":"                if isinstance(c.result, UUID):"},{"line_number":133,"context_line":"                    insert_uuid \u003d txn.get_insert_uuid(c.result)"},{"line_number":134,"context_line":"                    retval.append(insert_uuid if insert_uuid else c.result)"},{"line_number":135,"context_line":"                else:"},{"line_number":136,"context_line":"                    retval.append(c.result)"},{"line_number":137,"context_line":"            return retval"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_9c0345b8","line":134,"range":{"start_line":134,"start_character":34,"end_line":134,"end_character":74},"updated":"2016-09-20 12:07:02.000000000","message":"Wouldn\u0027t writing (insert_uuid or c.result) simpler?","commit_id":"112f41d60d1c3237655d02783903892b8943c1a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"4bcf251a86324924047cdef7ec9080678d433e5d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            for c in self.commands:"},{"line_number":132,"context_line":"                if isinstance(c.result, UUID):"},{"line_number":133,"context_line":"                    insert_uuid \u003d txn.get_insert_uuid(c.result)"},{"line_number":134,"context_line":"                    retval.append(insert_uuid if insert_uuid else c.result)"},{"line_number":135,"context_line":"                else:"},{"line_number":136,"context_line":"                    retval.append(c.result)"},{"line_number":137,"context_line":"            return retval"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3faea398","line":134,"range":{"start_line":134,"start_character":34,"end_line":134,"end_character":74},"in_reply_to":"7a8ec9b2_9c0345b8","updated":"2016-09-20 12:16:24.000000000","message":"Yep, that\u0027s would be better.","commit_id":"112f41d60d1c3237655d02783903892b8943c1a6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"00a602a3056ad5c92a0f3e8189e389c74a32f690","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            elif status \u003d\u003d txn.SUCCESS:"},{"line_number":128,"context_line":"                self.post_commit(txn)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            return ["},{"line_number":131,"context_line":"                isinstance(cmd.result, uuid.UUID) and txn.get_insert_uuid("},{"line_number":132,"context_line":"                    cmd.result) or cmd.result"},{"line_number":133,"context_line":"                for cmd in self.commands]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_755591c4","line":130,"updated":"2016-09-20 19:25:29.000000000","message":"I think it would be better to add a method to get inserted uuids similar to how post_commit_failed_interfaces() works.  Otherwise callers have a confusing mix of return data.","commit_id":"13270d5f7b2b9266bf0ceb87d995a3374bcb3741"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"0e902c41728f940ed7c80c8dec11c1732656bad4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            elif status \u003d\u003d txn.SUCCESS:"},{"line_number":128,"context_line":"                self.post_commit(txn)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            return ["},{"line_number":131,"context_line":"                isinstance(cmd.result, uuid.UUID) and txn.get_insert_uuid("},{"line_number":132,"context_line":"                    cmd.result) or cmd.result"},{"line_number":133,"context_line":"                for cmd in self.commands]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_e9f625f8","line":130,"in_reply_to":"7a8ec9b2_755591c4","updated":"2016-09-20 22:57:43.000000000","message":"Oops, seems I get a lit far away to simplify. OK, align to existing method is acceptable to me.","commit_id":"13270d5f7b2b9266bf0ceb87d995a3374bcb3741"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"773dc6459e7bbf51332d44fa30eeb8d84477c704","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                    isinstance(c.result, uuid.UUID) and txn.get_insert_uuid("},{"line_number":137,"context_line":"                        c.result))"},{"line_number":138,"context_line":"                retval.append(insert_uuid or c.result)"},{"line_number":139,"context_line":"            return retval"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def elapsed_time(self):"},{"line_number":142,"context_line":"        return time.time() - self.start_time"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_c921424f","line":139,"updated":"2016-09-21 12:47:45.000000000","message":"This doesn\u0027t address my comment in patch set 3.","commit_id":"8ed4743909bf553a7e5adb781a52e6644c6cc7b6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"a9d66c7d62e9fdee551e62aa17d52a9e584299b3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                    isinstance(c.result, uuid.UUID) and txn.get_insert_uuid("},{"line_number":137,"context_line":"                        c.result))"},{"line_number":138,"context_line":"                retval.append(insert_uuid or c.result)"},{"line_number":139,"context_line":"            return retval"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def elapsed_time(self):"},{"line_number":142,"context_line":"        return time.time() - self.start_time"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_fa179eeb","line":139,"in_reply_to":"7a8ec9b2_c921424f","updated":"2016-09-21 13:28:38.000000000","message":"Oops, but I think it does.\nL135-L137 is simpler than:\n\n if isinstance(c.result, uuid.UUID):\n     insert_uuid \u003d txn.get_insert_uuid(c.result)","commit_id":"8ed4743909bf553a7e5adb781a52e6644c6cc7b6"}]}
