)]}'
{"neutron/agent/ovsdb/impl_idl.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c4a8d88d3e287f30dc181da98e20105abe1070d1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.check_error \u003d check_error"},{"line_number":45,"context_line":"        self.log_errors \u003d log_errors"},{"line_number":46,"context_line":"        self.commands \u003d []"},{"line_number":47,"context_line":"        self.results \u003d Queue.Queue(1)"},{"line_number":48,"context_line":"        self.ovsdb_connection \u003d ovsdb_connection"},{"line_number":49,"context_line":"        self.timeout \u003d timeout"},{"line_number":50,"context_line":"        self.expected_ifaces \u003d set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d08bec66","line":47,"range":{"start_line":47,"start_character":35,"end_line":47,"end_character":36},"updated":"2016-09-20 12:56:19.000000000","message":"Nit (and not related to the bug): It would be nice to name this arg.","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"28b1efd35fb476fe1b7e77afd89f9edc86ba6aa5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.check_error \u003d check_error"},{"line_number":45,"context_line":"        self.log_errors \u003d log_errors"},{"line_number":46,"context_line":"        self.commands \u003d []"},{"line_number":47,"context_line":"        self.results \u003d Queue.Queue(1)"},{"line_number":48,"context_line":"        self.ovsdb_connection \u003d ovsdb_connection"},{"line_number":49,"context_line":"        self.timeout \u003d timeout"},{"line_number":50,"context_line":"        self.expected_ifaces \u003d set()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_02741f9a","line":47,"range":{"start_line":47,"start_character":35,"end_line":47,"end_character":36},"in_reply_to":"7a8ec9b2_d08bec66","updated":"2016-09-20 14:40:13.000000000","message":"+1","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c4a8d88d3e287f30dc181da98e20105abe1070d1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_c5d6ccf0","line":67,"updated":"2016-09-20 12:56:19.000000000","message":"Nit: It would be nice with named args here.","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e643096d1f530d9fa1203465528f82844995fade","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_75d29801","line":67,"in_reply_to":"7a8ec9b2_10ae1b98","updated":"2016-09-22 02:57:09.000000000","message":"Thanks, I will add the key name to parameters.","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"70ba8e3d105ccdae9e3a1b1dc84791061664931a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_fa1fd058","line":67,"in_reply_to":"7a8ec9b2_3ff92ac9","updated":"2016-09-20 18:49:42.000000000","message":"The wording at [1] is terrible, but I read it as \"timeout is ignored if block\u003dFalse\".","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"28b1efd35fb476fe1b7e77afd89f9edc86ba6aa5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e22f3386","line":67,"in_reply_to":"7a8ec9b2_c5d6ccf0","updated":"2016-09-20 14:40:13.000000000","message":"+1","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9990b649540dd1da3224d18d8db2c824dbf40fae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3ff92ac9","line":67,"in_reply_to":"7a8ec9b2_e22f3386","updated":"2016-09-20 18:29:36.000000000","message":"I might be reading [1] this wrong, but I see no problem with this code:\n\nIf timeout is a positive number, it blocks at most timeout seconds and raises the Empty exception if no item was available within that time. Block must not be True for that to work.\n\n[1] https://docs.python.org/2/library/queue.html#Queue.Queue.get","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e812cd2b1145c2c5ffbdbcf74f0628eec2f29d35","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_10ae1b98","line":67,"in_reply_to":"7a8ec9b2_fa0ef0e3","updated":"2016-09-20 20:09:59.000000000","message":"Sorry, my comments are too terse, perhaps. In my original comment I was merely expressing a preference for the following explicit style:\n\n    result \u003d self.results.get(block\u003dTrue, timeout\u003dself.timeout)\n\nI don\u0027t like \"naked booleans\" and \"naked numbers\" being passed as arguments if it causes reviewers to make unnecessary trips to the documentation to understand the code.","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8c83b3f41d02a07047d1e84dfe22aa061c87ec50","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def commit(self):"},{"line_number":65,"context_line":"        self.ovsdb_connection.queue_txn(self)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            result \u003d self.results.get(True, self.timeout)"},{"line_number":68,"context_line":"        except Queue.Empty:"},{"line_number":69,"context_line":"            raise api.TimeoutException("},{"line_number":70,"context_line":"                _(\"Commands %(commands)s exceeded timeout %(timeout)d \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_fa0ef0e3","line":67,"in_reply_to":"7a8ec9b2_fa1fd058","updated":"2016-09-20 19:00:17.000000000","message":"I suppose there\u0027s nothing better than trying this out:\n\nfrom six.moves import queue as Queue\nq \u003d Queue.Queue(1)\nresult \u003d q.get(True, 3)\n\nwithout True, this is blocking for ever.","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"}],"neutron/tests/unit/agent/ovsdb/test_impl_idl.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"15651f2ec30fb34be344abc75cf8f7b735619d5a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def test_commit_raises_exception_on_timeout(self):"},{"line_number":26,"context_line":"        transaction \u003d impl_idl.NeutronOVSDBTransaction(mock.sentinel,"},{"line_number":27,"context_line":"                                                       mock.Mock(), 1)"},{"line_number":28,"context_line":"        with timeout.Timeout(10):"},{"line_number":29,"context_line":"            with testtools.ExpectedException(api.TimeoutException):"},{"line_number":30,"context_line":"                transaction.commit()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_44d4371f","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":28},"updated":"2016-09-21 13:02:43.000000000","message":"You should use self.assert_max_execution_time(10) instead. Otherwise it will stop executing other scheduled tests for now.","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e643096d1f530d9fa1203465528f82844995fade","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def test_commit_raises_exception_on_timeout(self):"},{"line_number":26,"context_line":"        transaction \u003d impl_idl.NeutronOVSDBTransaction(mock.sentinel,"},{"line_number":27,"context_line":"                                                       mock.Mock(), 1)"},{"line_number":28,"context_line":"        with timeout.Timeout(10):"},{"line_number":29,"context_line":"            with testtools.ExpectedException(api.TimeoutException):"},{"line_number":30,"context_line":"                transaction.commit()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_b5d8a01f","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":28},"in_reply_to":"7a8ec9b2_44d4371f","updated":"2016-09-22 02:57:09.000000000","message":"Done","commit_id":"c8ca5d79b4285822f0bdf1ceaf50c84a3f6a56d2"}]}
