)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b034d2d5bbcaed69ded8242adde32f7a6b8ad283","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_bcd353d4","line":675,"updated":"2016-09-21 13:45:26.000000000","message":"do we really need to disable all retries here, or just duplicates? should we have some mechanism to allow ignoring just some retriable exceptions?","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"74515351b2a34f61010d4c836c8a47fa4453e189","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f6c25284","line":675,"in_reply_to":"7a8ec9b2_0b5317e3","updated":"2016-09-21 14:47:44.000000000","message":"Oh, so we then probably DON\u0027T have a case where we would want to catch the error at this layer. In which case there is no need for partial-bug or todo, and it\u0027s not a good idea.","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8fc91311181a2c2d4ae8e558b7ae06a4b0f5bb95","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_0b5317e3","line":675,"in_reply_to":"7a8ec9b2_2b18d374","updated":"2016-09-21 14:38:09.000000000","message":"Right, it then will be propagated to the parent create_security_group() and retried","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a0ae87b0ae29ac5064a9065ad6a17a7f6c7f8c29","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_2b18d374","line":675,"in_reply_to":"7a8ec9b2_50bb0ee5","updated":"2016-09-21 14:35:36.000000000","message":"You can definitely hit eg. DBConnectionError during the process.","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a930fbe577ebaaf2538e0bdfc082debc4695c25","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_65b76ad8","line":675,"in_reply_to":"7a8ec9b2_629cc0c0","updated":"2016-09-21 14:19:24.000000000","message":"Wouldn\u0027t it then make sense to make the patch Partial-Bug one, and add a TODO here to revisit the code in Ocata?","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8bb5986dd2816792a7b53d92f08e5fb794b3d402","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_50bb0ee5","line":675,"in_reply_to":"7a8ec9b2_65b76ad8","updated":"2016-09-21 14:33:08.000000000","message":"well, but it\u0027s not a partial fix - this completely fixes the problem of reaching max db retries when creating default security group which the bug is about. We do not know yet if there might be some errors that would make sense to retry during default group creation, I can certainly add a comment about it. Does it make sense?","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"dc0f24d18a897117dc8bab4400ff5c0657383a19","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                     \u0027description\u0027: _(\u0027Default security group\u0027)}"},{"line_number":673,"context_line":"            }"},{"line_number":674,"context_line":"            # starting a transaction before create to avoid db retries"},{"line_number":675,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":676,"context_line":"                sg_id \u003d self.create_security_group("},{"line_number":677,"context_line":"                    context, security_group, default_sg\u003dTrue)[\u0027id\u0027]"},{"line_number":678,"context_line":"            return sg_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_629cc0c0","line":675,"in_reply_to":"7a8ec9b2_bcd353d4","updated":"2016-09-21 14:01:28.000000000","message":"Sounds like a good idea to me, it just seems too late in the cycle to alter db retry mechanism. I\u0027d suggest return to it once we clearly see issues where we need to retry just some particular db errors.","commit_id":"09d1185d24c30690358a9314c14fabaead2f4c78"}]}
