)]}'
{"neutron/services/trunk/rules.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d35d477e1f4061b18524fe7876ad9e1ee0258863","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        except KeyError:"},{"line_number":224,"context_line":"            msg \u003d _(\"Invalid subport details \u0027%s\u0027: missing segmentation \""},{"line_number":225,"context_line":"                    \"information. Must specify both segmentation ID and \""},{"line_number":226,"context_line":"                    \"segmentation type\") % subport"},{"line_number":227,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":228,"context_line":"        except n_exc.InvalidInput:"},{"line_number":229,"context_line":"            msg \u003d _(\"Invalid subport details: segmentation_id \u0027%s\u0027 is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d470d242","line":226,"updated":"2016-09-22 01:12:59.000000000","message":"As an API user it\u0027s worse though because you don\u0027t know what the field should be. It\u0027s also now inconsistent with L229 and L234. I would say we should just make the params required in the client on the related bug.","commit_id":"3f4a04a59b731e00f71db63382d8970395d44770"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2fb2c9a6a07a6d8745bf8aa00ce67f2b54e8ccf","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        except KeyError:"},{"line_number":224,"context_line":"            msg \u003d _(\"Invalid subport details \u0027%s\u0027: missing segmentation \""},{"line_number":225,"context_line":"                    \"information. Must specify both segmentation ID and \""},{"line_number":226,"context_line":"                    \"segmentation type\") % subport"},{"line_number":227,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":228,"context_line":"        except n_exc.InvalidInput:"},{"line_number":229,"context_line":"            msg \u003d _(\"Invalid subport details: segmentation_id \u0027%s\u0027 is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f5787e80","line":226,"updated":"2016-09-21 17:07:01.000000000","message":"What was wrong with the previous message? I find it more accurate as it actually says which attributes are required in the request body","commit_id":"3f4a04a59b731e00f71db63382d8970395d44770"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9af688a6700dde8e349cbbede88f5b8a03703b65","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        except KeyError:"},{"line_number":224,"context_line":"            msg \u003d _(\"Invalid subport details \u0027%s\u0027: missing segmentation \""},{"line_number":225,"context_line":"                    \"information. Must specify both segmentation ID and \""},{"line_number":226,"context_line":"                    \"segmentation type\") % subport"},{"line_number":227,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":228,"context_line":"        except n_exc.InvalidInput:"},{"line_number":229,"context_line":"            msg \u003d _(\"Invalid subport details: segmentation_id \u0027%s\u0027 is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_66cf6256","line":226,"in_reply_to":"7a8ec9b2_269b9a67","updated":"2016-09-21 18:14:21.000000000","message":"Perhaps we should replace these with segmentation-id or segmentation-type, but in Neutron the use of hyphens vs underscores has always been a potential pitfall. I figured being more high level may address the confusion partially.","commit_id":"3f4a04a59b731e00f71db63382d8970395d44770"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5c218abdd2a159634b09bd0b8d85f803204d0ab","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        except KeyError:"},{"line_number":224,"context_line":"            msg \u003d _(\"Invalid subport details \u0027%s\u0027: missing segmentation \""},{"line_number":225,"context_line":"                    \"information. Must specify both segmentation ID and \""},{"line_number":226,"context_line":"                    \"segmentation type\") % subport"},{"line_number":227,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":228,"context_line":"        except n_exc.InvalidInput:"},{"line_number":229,"context_line":"            msg \u003d _(\"Invalid subport details: segmentation_id \u0027%s\u0027 is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f4630e18","line":226,"in_reply_to":"7a8ec9b2_d470d242","updated":"2016-09-22 01:30:49.000000000","message":"the client should probably be able to handle both hyphen and underscore versions. We can\u0027t make them required to avoid breaking use cases (like Ironic) where these may be missing.","commit_id":"3f4a04a59b731e00f71db63382d8970395d44770"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f9edc6800579b25409aa021dcf4d041856d192b","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        except KeyError:"},{"line_number":224,"context_line":"            msg \u003d _(\"Invalid subport details \u0027%s\u0027: missing segmentation \""},{"line_number":225,"context_line":"                    \"information. Must specify both segmentation ID and \""},{"line_number":226,"context_line":"                    \"segmentation type\") % subport"},{"line_number":227,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":228,"context_line":"        except n_exc.InvalidInput:"},{"line_number":229,"context_line":"            msg \u003d _(\"Invalid subport details: segmentation_id \u0027%s\u0027 is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_269b9a67","line":226,"in_reply_to":"7a8ec9b2_f5787e80","updated":"2016-09-21 18:12:43.000000000","message":"See bug report.","commit_id":"3f4a04a59b731e00f71db63382d8970395d44770"}]}
