)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shashank Kumar Shankar \u003cshashank.kumar.shankar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-04 21:46:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Port Binding Level OVO in clear_binding_levels method in"},{"line_number":8,"context_line":"neutron/plugin/ml2/db.py"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This patch integrates OVO for Port Binding Level OVO in"},{"line_number":11,"context_line":"clear_binding_levels method in /plugin/ml2/db.py and introduces context"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa6399be_ec50e560","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":24},"updated":"2016-10-12 23:34:44.000000000","message":"This title exceeds the limit of characters(50)","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"82652a963f8d2f16eb8f12c3d468533591122068","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                                                host\u003dcontext.host,"},{"line_number":796,"context_line":"                                                level\u003dlevel,"},{"line_number":797,"context_line":"                                                driver\u003ddriver.name,"},{"line_number":798,"context_line":"                                                segment_id\u003dsegment)"},{"line_number":799,"context_line":"                    )"},{"line_number":800,"context_line":"                    next_segments \u003d context._next_segments_to_bind"},{"line_number":801,"context_line":"                    if next_segments:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_c490b998","line":798,"updated":"2016-09-28 19:45:54.000000000","message":"segment_id field is not present in PortBindingLevel Ovo ?","commit_id":"6ec2808b9d23ba334d60951a658fb5534de057c9"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"2a1b1d79ddb2a1433cce59100aa581925c2c63c3","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                                                host\u003dcontext.host,"},{"line_number":796,"context_line":"                                                level\u003dlevel,"},{"line_number":797,"context_line":"                                                driver\u003ddriver.name,"},{"line_number":798,"context_line":"                                                segment_id\u003dsegment)"},{"line_number":799,"context_line":"                    )"},{"line_number":800,"context_line":"                    next_segments \u003d context._next_segments_to_bind"},{"line_number":801,"context_line":"                    if next_segments:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_a43c8d30","line":798,"in_reply_to":"3a98d1f4_c490b998","updated":"2016-09-28 20:04:20.000000000","message":"not here sorry","commit_id":"6ec2808b9d23ba334d60951a658fb5534de057c9"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        if changes:"},{"line_number":331,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_UNBOUND"},{"line_number":332,"context_line":"            binding.vif_details \u003d \u0027\u0027"},{"line_number":333,"context_line":"            db.clear_binding_levels(context, port_id\u003dport_id,"},{"line_number":334,"context_line":"                                    host\u003doriginal_host)"},{"line_number":335,"context_line":"            mech_context._clear_binding_levels()"},{"line_number":336,"context_line":"            port[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":337,"context_line":"            super(Ml2Plugin, self).update_port("}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_cc8a41bf","line":334,"range":{"start_line":333,"start_character":12,"end_line":334,"end_character":55},"updated":"2016-10-12 23:34:44.000000000","message":"port_id and host are mandatory arguments, you can call this method without mentioning the name of the argument:\n\n    db.clear_binding_levels(context, port_id, original_host)","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"65ad0e5cdff12a52fba12edad7f06dd9d71b1ca4","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        if changes:"},{"line_number":331,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_UNBOUND"},{"line_number":332,"context_line":"            binding.vif_details \u003d \u0027\u0027"},{"line_number":333,"context_line":"            db.clear_binding_levels(context, port_id\u003dport_id,"},{"line_number":334,"context_line":"                                    host\u003doriginal_host)"},{"line_number":335,"context_line":"            mech_context._clear_binding_levels()"},{"line_number":336,"context_line":"            port[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":337,"context_line":"            super(Ml2Plugin, self).update_port("}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_4d9d27bb","line":334,"range":{"start_line":333,"start_character":12,"end_line":334,"end_character":55},"in_reply_to":"fa6399be_cc8a41bf","updated":"2016-10-13 15:51:35.000000000","message":"good catches on these.","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":342,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_UNBOUND"},{"line_number":343,"context_line":"            binding.vif_details \u003d \u0027\u0027"},{"line_number":344,"context_line":"            db.clear_binding_levels(context, port_id\u003dport_id,"},{"line_number":345,"context_line":"                                    host\u003doriginal_host)"},{"line_number":346,"context_line":"            mech_context._clear_binding_levels()"},{"line_number":347,"context_line":"            binding.host \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_2c901dec","line":344,"updated":"2016-10-12 23:34:44.000000000","message":"ditto: line 334","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":507,"context_line":"                # results."},{"line_number":508,"context_line":"                cur_binding.vif_type \u003d new_binding.vif_type"},{"line_number":509,"context_line":"                cur_binding.vif_details \u003d new_binding.vif_details"},{"line_number":510,"context_line":"                db.clear_binding_levels("},{"line_number":511,"context_line":"                    plugin_context, port_id\u003dport_id, host\u003dcur_binding.host)"},{"line_number":512,"context_line":"                db.set_binding_levels(session, bind_context._binding_levels)"},{"line_number":513,"context_line":"                cur_context._binding_levels \u003d bind_context._binding_levels"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_6cc055e1","line":510,"updated":"2016-10-12 23:34:44.000000000","message":"ditto: line 334","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                cur_binding.vif_type \u003d new_binding.vif_type"},{"line_number":509,"context_line":"                cur_binding.vif_details \u003d new_binding.vif_details"},{"line_number":510,"context_line":"                db.clear_binding_levels("},{"line_number":511,"context_line":"                    plugin_context, port_id\u003dport_id, host\u003dcur_binding.host)"},{"line_number":512,"context_line":"                db.set_binding_levels(session, bind_context._binding_levels)"},{"line_number":513,"context_line":"                cur_context._binding_levels \u003d bind_context._binding_levels"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_ec21c5b5","line":511,"range":{"start_line":511,"start_character":20,"end_line":511,"end_character":34},"updated":"2016-10-12 23:34:44.000000000","message":"interesting that this is using its local variable instead of a instance member","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_UNBOUND"},{"line_number":1521,"context_line":"            if binding.host:"},{"line_number":1522,"context_line":"                db.clear_binding_levels("},{"line_number":1523,"context_line":"                    mech_context._plugin_context, port_id\u003dport_id,"},{"line_number":1524,"context_line":"                    host\u003dbinding.host)"},{"line_number":1525,"context_line":"            binding.host \u003d \u0027\u0027"},{"line_number":1526,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_4f00e301","line":1523,"range":{"start_line":1523,"start_character":20,"end_line":1523,"end_character":48},"updated":"2016-10-12 23:34:44.000000000","message":"And why are you not using the context argument provided in the line 1513?","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"24a29ba27263498a93509343e76843398986c960","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_UNBOUND"},{"line_number":1521,"context_line":"            if binding.host:"},{"line_number":1522,"context_line":"                db.clear_binding_levels("},{"line_number":1523,"context_line":"                    mech_context._plugin_context, port_id\u003dport_id,"},{"line_number":1524,"context_line":"                    host\u003dbinding.host)"},{"line_number":1525,"context_line":"            binding.host \u003d \u0027\u0027"},{"line_number":1526,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_acba6d6c","line":1523,"updated":"2016-10-12 23:34:44.000000000","message":"ditto: line 334","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"65ad0e5cdff12a52fba12edad7f06dd9d71b1ca4","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_UNBOUND"},{"line_number":1521,"context_line":"            if binding.host:"},{"line_number":1522,"context_line":"                db.clear_binding_levels("},{"line_number":1523,"context_line":"                    mech_context._plugin_context, port_id\u003dport_id,"},{"line_number":1524,"context_line":"                    host\u003dbinding.host)"},{"line_number":1525,"context_line":"            binding.host \u003d \u0027\u0027"},{"line_number":1526,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_8d1e5f5d","line":1523,"range":{"start_line":1523,"start_character":20,"end_line":1523,"end_character":48},"in_reply_to":"fa6399be_4f00e301","updated":"2016-10-13 15:51:35.000000000","message":"he\u0027s using the context that has the session the original code used, so the way its done here makes sense.","commit_id":"6e395b1a99cd8139b0a52eca9d8c33d6e2c57e82"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"82bff1be86d865e307c583b31df9b5b99a1b5ac2","unresolved":false,"context_lines":[{"line_number":1649,"context_line":"        context \u003d mock.Mock()"},{"line_number":1650,"context_line":"        new_router_id \u003d \u0027new_router\u0027"},{"line_number":1651,"context_line":"        attrs \u003d {\u0027device_id\u0027: new_router_id, portbindings.HOST_ID: host_id}"},{"line_number":1652,"context_line":"        from neutron.objects import ports"},{"line_number":1653,"context_line":"        with mock.patch.object(plugin, \u0027_update_port_dict_binding\u0027):"},{"line_number":1654,"context_line":"            with mock.patch.object(segments_db, \u0027get_network_segments\u0027,"},{"line_number":1655,"context_line":"                                   return_value\u003d[]):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_82222ab8","line":1652,"updated":"2016-10-04 21:25:58.000000000","message":"The import statement should be up with other import statements.","commit_id":"6a1a36fdde7fc3b1db112e7906a6280ceb4ac663"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"5fb34eec97ad5c6ec7a21f98ed7f97537a916511","unresolved":false,"context_lines":[{"line_number":1649,"context_line":"        context \u003d mock.Mock()"},{"line_number":1650,"context_line":"        new_router_id \u003d \u0027new_router\u0027"},{"line_number":1651,"context_line":"        attrs \u003d {\u0027device_id\u0027: new_router_id, portbindings.HOST_ID: host_id}"},{"line_number":1652,"context_line":"        from neutron.objects import ports"},{"line_number":1653,"context_line":"        with mock.patch.object(plugin, \u0027_update_port_dict_binding\u0027):"},{"line_number":1654,"context_line":"            with mock.patch.object(segments_db, \u0027get_network_segments\u0027,"},{"line_number":1655,"context_line":"                                   return_value\u003d[]):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_b93758e2","line":1652,"in_reply_to":"1a95cdbc_82222ab8","updated":"2016-10-04 21:47:20.000000000","message":"Done","commit_id":"6a1a36fdde7fc3b1db112e7906a6280ceb4ac663"}]}
