)]}'
{"neutron/hacking/checks.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d157a9668a2282e9113c2cdd196896be8b268b8","unresolved":false,"context_lines":[{"line_number":418,"context_line":"def check_assertIsNone(logical_line, filename):"},{"line_number":419,"context_line":"    \"\"\"N345 - Enforce using assertIsNone.\"\"\""},{"line_number":420,"context_line":"    if \u0027neutron/tests/\u0027 in filename:"},{"line_number":421,"context_line":"        if re.search(r\"assertEqual\\(\\s*None,\\s*[^,]*\\)\","},{"line_number":422,"context_line":"                     logical_line):"},{"line_number":423,"context_line":"            msg \u003d (\"N345: Use assertIsNone(observed) instead \""},{"line_number":424,"context_line":"                   \"of assertEqual(None, observed))\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_a67f7113","line":421,"range":{"start_line":421,"start_character":20,"end_line":421,"end_character":55},"updated":"2016-09-27 08:53:39.000000000","message":"I know, this is expected way of writing asserts, but probably it would be also good to add other regex, to block possibility to bypass this check.\n\n assertEqual(observed, None)","commit_id":"0f68ca35ad6de5c5cd2e4d724a67a9b703df1de2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6b1acd5374afc25869a92e275d25952bb71d8468","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"@flake8ext"},{"line_number":418,"context_line":"def check_assertIsNone(logical_line):"},{"line_number":419,"context_line":"    \"\"\"N345 - Enforce using assertIsNone.\"\"\""},{"line_number":420,"context_line":"    asse_equal_end_with_none_re \u003d re.compile(r\"assertEqual\\(.*?,\\s+None\\)$\")"},{"line_number":421,"context_line":"    asse_equal_start_with_none_re \u003d re.compile(r\"assertEqual\\(None,\")"},{"line_number":422,"context_line":"    res \u003d (asse_equal_start_with_none_re.search(logical_line) or"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_8274eccf","line":419,"range":{"start_line":418,"start_character":0,"end_line":419,"end_character":44},"updated":"2016-10-11 08:55:20.000000000","message":"Why did remove a check to filename? I think that this check should be applied to files in \u0027neutron/tests/\u0027.","commit_id":"29d5fccb6d8e8b26e27c72fb1b22863d4c76989e"}],"neutron/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c265213025e3ccc3c3a7c7c73bdd23eebec1a947","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def test_check_assertIsNone(self):"},{"line_number":364,"context_line":"        self.assertEqual(1, len(list(checks.check_assertIsNone("},{"line_number":365,"context_line":"            \"self.assertEqual(A, None)\"))))"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        self.assertEqual(1, len(list(checks.check_assertIsNone("},{"line_number":368,"context_line":"            \"self.assertEqual(None, A)\"))))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_86dd8044","line":365,"updated":"2016-10-19 20:38:39.000000000","message":"You forgot to pass a filename here. Please see how you defined the function in https://review.openstack.org/#/c/374594/5/neutron/hacking/checks.py@417","commit_id":"f0490544f90b7ba911857fe39a193d5effff9e5e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c265213025e3ccc3c3a7c7c73bdd23eebec1a947","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            \"self.assertEqual(A, None)\"))))"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        self.assertEqual(1, len(list(checks.check_assertIsNone("},{"line_number":368,"context_line":"            \"self.assertEqual(None, A)\"))))"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        self.assertEqual(0, len(list(checks.check_assertIsNone("},{"line_number":371,"context_line":"            \"self.assertIsNone()\"))))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_c6e77810","line":368,"updated":"2016-10-19 20:38:39.000000000","message":"Ditto","commit_id":"f0490544f90b7ba911857fe39a193d5effff9e5e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c265213025e3ccc3c3a7c7c73bdd23eebec1a947","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            \"self.assertEqual(None, A)\"))))"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        self.assertEqual(0, len(list(checks.check_assertIsNone("},{"line_number":371,"context_line":"            \"self.assertIsNone()\"))))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"# The following is borrowed from hacking/tests/test_doctest.py."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_06f250d2","line":371,"updated":"2016-10-19 20:38:39.000000000","message":"Ditto","commit_id":"f0490544f90b7ba911857fe39a193d5effff9e5e"}]}
