)]}'
{"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a55de990d7383442d70d88516ab3c5ace0da5783","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":138,"context_line":"        if result:"},{"line_number":139,"context_line":"            return result.pop()"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            return None"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_aa0df091","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":12},"updated":"2016-10-12 23:16:35.000000000","message":"nit: this else is not required","commit_id":"ab41419824673765932a7cf88e8e44ae23feb8fb"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"e3e36a077ed5245b7b53aa7c337dc0bb4fdbf2fb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":138,"context_line":"        if result:"},{"line_number":139,"context_line":"            return result.pop()"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            return None"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_cbb8caeb","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":12},"in_reply_to":"fa6399be_aa0df091","updated":"2016-10-17 18:40:05.000000000","message":"Done","commit_id":"ab41419824673765932a7cf88e8e44ae23feb8fb"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a55de990d7383442d70d88516ab3c5ace0da5783","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _create_ha_network_tenant_binding(self, context, tenant_id,"},{"line_number":210,"context_line":"                                          network_id):"},{"line_number":211,"context_line":"        with context.session.begin():"},{"line_number":212,"context_line":"            ha_network \u003d l3_obj.L3HARouterNetwork("},{"line_number":213,"context_line":"                context, project_id\u003dtenant_id, network_id\u003dnetwork_id)"},{"line_number":214,"context_line":"            ha_network.create()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_acb42dd1","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":37},"updated":"2016-10-12 23:16:35.000000000","message":"Given that OVO creates a session internally[1], you don\u0027t need this line\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/api.py#L221","commit_id":"ab41419824673765932a7cf88e8e44ae23feb8fb"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"e3e36a077ed5245b7b53aa7c337dc0bb4fdbf2fb","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _create_ha_network_tenant_binding(self, context, tenant_id,"},{"line_number":210,"context_line":"                                          network_id):"},{"line_number":211,"context_line":"        with context.session.begin():"},{"line_number":212,"context_line":"            ha_network \u003d l3_obj.L3HARouterNetwork("},{"line_number":213,"context_line":"                context, project_id\u003dtenant_id, network_id\u003dnetwork_id)"},{"line_number":214,"context_line":"            ha_network.create()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_cb9fea63","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":37},"in_reply_to":"fa6399be_acb42dd1","updated":"2016-10-17 18:40:05.000000000","message":"Done","commit_id":"ab41419824673765932a7cf88e8e44ae23feb8fb"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a55de990d7383442d70d88516ab3c5ace0da5783","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        except Exception:"},{"line_number":257,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":258,"context_line":"                self._core_plugin.delete_network(admin_ctx, network[\u0027id\u0027])"},{"line_number":259,"context_line":"        print(\"ha_network:\", ha_network)"},{"line_number":260,"context_line":"        return ha_network"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def get_number_of_agents_for_scheduling(self, context):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_0cdd190e","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":40},"updated":"2016-10-12 23:16:35.000000000","message":"More likely you forgot to remove this line :)","commit_id":"ab41419824673765932a7cf88e8e44ae23feb8fb"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"e3e36a077ed5245b7b53aa7c337dc0bb4fdbf2fb","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        except Exception:"},{"line_number":257,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":258,"context_line":"                self._core_plugin.delete_network(admin_ctx, network[\u0027id\u0027])"},{"line_number":259,"context_line":"        print(\"ha_network:\", ha_network)"},{"line_number":260,"context_line":"        return ha_network"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def get_number_of_agents_for_scheduling(self, context):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_0bb3a20b","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":40},"in_reply_to":"fa6399be_0cdd190e","updated":"2016-10-17 18:40:05.000000000","message":"Done","commit_id":"ab41419824673765932a7cf88e8e44ae23feb8fb"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a55de990d7383442d70d88516ab3c5ace0da5783","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        router \u003d self._create_router()"},{"line_number":545,"context_line":"        network \u003d self.plugin.get_ha_network(self.admin_ctx,"},{"line_number":546,"context_line":"                                             router[\u0027tenant_id\u0027])"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        allocs_before \u003d self.plugin._get_allocated_vr_id(self.admin_ctx,"},{"line_number":549,"context_line":"                                                         network.network_id)"},{"line_number":550,"context_line":"        router \u003d self._create_router()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_4c055178","side":"PARENT","line":547,"updated":"2016-10-12 23:16:35.000000000","message":"this change is not needed","commit_id":"8fdaec42686a1cdedfeb082044d425b5d015c399"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"e3e36a077ed5245b7b53aa7c337dc0bb4fdbf2fb","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        router \u003d self._create_router()"},{"line_number":545,"context_line":"        network \u003d self.plugin.get_ha_network(self.admin_ctx,"},{"line_number":546,"context_line":"                                             router[\u0027tenant_id\u0027])"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        allocs_before \u003d self.plugin._get_allocated_vr_id(self.admin_ctx,"},{"line_number":549,"context_line":"                                                         network.network_id)"},{"line_number":550,"context_line":"        router \u003d self._create_router()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_0baac285","side":"PARENT","line":547,"in_reply_to":"fa6399be_4c055178","updated":"2016-10-17 18:40:05.000000000","message":"Done","commit_id":"8fdaec42686a1cdedfeb082044d425b5d015c399"}]}