)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"917628e6942d4184b3f371a6a9bbced0b9f1663e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lianghwa Jou \u003clianghwajou@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-19 07:44:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default route to dhcp agent netns."},{"line_number":8,"context_line":"If there is a metadata network, use its gateway as default route; otherwise, set the default route to the gateway of a subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I71eaaf46bbd01f577988211b650fdbe3972d1fa0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2F5u8%3D","line":7,"updated":"2013-07-19 14:52:36.000000000","message":"please put a blank line after the first line. This should shorten review/commit title and make it more readable","commit_id":"43ec4bb39f7be61b8fe38aad9a07c3a7193acab4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"f6bf15dac3291402b997d848502af7ffba2c0a21","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add default route to dhcp agent netns."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove code block \"if self.conf.enable_metadata_network:\". No need to treat it differently. Defautl route will be set as any other network."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I71eaaf46bbd01f577988211b650fdbe3972d1fa0"},{"line_number":12,"context_line":"Fixes: bug #1196889"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAQn%2F%2F42w%3D","line":9,"updated":"2013-07-19 19:06:26.000000000","message":"Commit message should not exceed 79 chars per line.","commit_id":"0912799836c561d9b6920cd8e26cac87b6126780"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a3bad7aa34a1d7d2a1de7f89cda2a4ea35c98d88","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add default route to dhcp agent netns."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove code block \"if self.conf.enable_metadata_network:\". No need to treat it"},{"line_number":10,"context_line":"differently. Defautl route will be set as any other network."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I71eaaf46bbd01f577988211b650fdbe3972d1fa0"},{"line_number":13,"context_line":"Fixes: bug #1196889"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAQn%2F%2F4h4%3D","line":10,"updated":"2013-07-19 20:40:43.000000000","message":"Tiny nit:  s/Defautl/Default/","commit_id":"df46889f1efebf1454e4533d051f537f7cb41097"}],"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"727df27f4a1873366b198f9cdd5e8f41f8114358","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                                         namespace)"},{"line_number":718,"context_line":"                # Only 1 subnet on metadata access network"},{"line_number":719,"context_line":"                gateway_ip \u003d metadata_subnets[0].gateway_ip"},{"line_number":720,"context_line":"                device.route.add_gateway(gateway_ip)"},{"line_number":721,"context_line":"        if self.conf.use_namespaces:"},{"line_number":722,"context_line":"            self._set_default_route(network)"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F9B8%3D","line":720,"updated":"2013-07-18 15:39:53.000000000","message":"Gateway is added above and then _set_default_route will set it again.  This will cause a little thrash between gateways if they are different.\n\nWould be better to consider the gateway added above in the logic for _set_default_gateway and set the gateway once and set it the consistently every time to avoid thrashing.","commit_id":"b78d705d97c1fc464296767b14ee8a76ffabe1ac"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7aa2f554ad20702fd48a94427ea2e8bf42d3186a","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            device \u003d ip_lib.IPDevice(interface_name,"},{"line_number":706,"context_line":"                                     self.root_helper)"},{"line_number":707,"context_line":"            device.route.pullup_route(interface_name)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        if self.conf.enable_metadata_network:"},{"line_number":710,"context_line":"            meta_cidr \u003d netaddr.IPNetwork(METADATA_DEFAULT_IP)"},{"line_number":711,"context_line":"            metadata_subnets \u003d [s for s in network.subnets if"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F5T0%3D","line":708,"updated":"2013-07-19 16:51:06.000000000","message":"The work done under this if statement is negated on the first call to update.  Can we take this whole path out (under this if statement)?  It would simplify things and I can\u0027t figure out what is special about this path of code now that we have _set_default_gateway.","commit_id":"a3a0c8c7bb7660c4564e5ade837b0384cbdb1190"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7aa2f554ad20702fd48a94427ea2e8bf42d3186a","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                gateway_ip \u003d metadata_subnets[0].gateway_ip"},{"line_number":720,"context_line":"                device.route.add_gateway(gateway_ip)"},{"line_number":721,"context_line":"                return interface_name"},{"line_number":722,"context_line":"        if self.conf.use_namespaces:"},{"line_number":723,"context_line":"            self._set_default_route(network)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        return interface_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F5Tw%3D","line":722,"updated":"2013-07-19 16:51:06.000000000","message":"This new code is the logical equivalent to what it replaces.  No?","commit_id":"a3a0c8c7bb7660c4564e5ade837b0384cbdb1190"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7aa2f554ad20702fd48a94427ea2e8bf42d3186a","unresolved":false,"context_lines":[{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    def update(self, network):"},{"line_number":728,"context_line":"        \"\"\"Update device settings for the network\u0027s DHCP on this host.\"\"\""},{"line_number":729,"context_line":"        if self.conf.use_namespaces:"},{"line_number":730,"context_line":"            self._set_default_route(network)"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def destroy(self, network, device_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F5Tg%3D","line":729,"updated":"2013-07-19 16:51:06.000000000","message":"This now negates the effect of the add_gateway call in the setup method above on the first update.  (The call under the if enable_metadata_network code path.)\n\nThis makes me wonder if we need to do anything special for the \"enable_metadata_network \u003d\u003d True\" case now that we have _set_default_route method in here.","commit_id":"a3a0c8c7bb7660c4564e5ade837b0384cbdb1190"}]}