)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"d9f08327f18f92c2f9c250d6022be41992d48fa3","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Since the base scheduler class expects \u0027plugin, context\u0027, some functions"},{"line_number":16,"context_line":"couldn\u0027t be changed to accept the other variation. Instead, context will"},{"line_number":17,"context_line":"always be last. Also, modified unit tests to make sure they test."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I825e108170a29d5ecaa0f0883bb0a171b5fdb895"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_680f2188","line":17,"range":{"start_line":17,"start_character":60,"end_line":17,"end_character":64},"updated":"2016-09-26 15:52:11.000000000","message":"lol, this should be \u0027pass\u0027.","commit_id":"7d058f19cde86ab7fec5c35ddeeafd27688cd22a"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ef513cb2c04e8087746fbc1943ecd54c1fb8e0bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-29 16:49:46 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l3scheduler: use consistent plugin, context args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the l3_agent_scheduler.py file, some functions accept both the"},{"line_number":10,"context_line":"\u0027plugin\u0027 and \u0027context\u0027 argument. However, some functions expect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98d1f4_7e7826c5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2016-09-29 14:05:40.000000000","message":"This is already not only about l3scheduler :P","commit_id":"86e48fb7ee940b09e48d2b4d8cbd4437fc90758e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"2a7d78cbc75eab910e332c5c2995c18fcc7a897c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-29 16:49:46 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l3scheduler: use consistent plugin, context args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the l3_agent_scheduler.py file, some functions accept both the"},{"line_number":10,"context_line":"\u0027plugin\u0027 and \u0027context\u0027 argument. However, some functions expect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98d1f4_51727bae","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"3a98d1f4_7114d743","updated":"2016-09-29 14:07:40.000000000","message":"Done","commit_id":"86e48fb7ee940b09e48d2b4d8cbd4437fc90758e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"9a9dd0d3dbee108a109a93e242c1709636e5bef7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-29 16:49:46 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l3scheduler: use consistent plugin, context args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the l3_agent_scheduler.py file, some functions accept both the"},{"line_number":10,"context_line":"\u0027plugin\u0027 and \u0027context\u0027 argument. However, some functions expect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98d1f4_7114d743","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"3a98d1f4_7e7826c5","updated":"2016-09-29 14:06:26.000000000","message":"True!","commit_id":"86e48fb7ee940b09e48d2b4d8cbd4437fc90758e"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0d455f11757524efa18a6a7a20900c68eb99b5a0","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027by concurrent operation\u0027, router_id)"},{"line_number":327,"context_line":"                return"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def get_ha_routers_l3_agents_counts(self, plugin, context, filters\u003dNone):"},{"line_number":330,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":331,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_0e03f7b8","line":329,"updated":"2016-09-26 19:25:33.000000000","message":"This doesn\u0027t look safe to change as this is technically an API because it\u0027s a public method.  Someone could be inheriting from the L3Scheduler class and suddenly break.\n\nSomeone else will correct me if I\u0027m wrong I hope.","commit_id":"7d058f19cde86ab7fec5c35ddeeafd27688cd22a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"215579194960f751fe29405a3cc08965863cba2a","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027by concurrent operation\u0027, router_id)"},{"line_number":327,"context_line":"                return"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def get_ha_routers_l3_agents_counts(self, plugin, context, filters\u003dNone):"},{"line_number":330,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":331,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_a4e77faa","line":329,"in_reply_to":"5a8bc5a2_0e03f7b8","updated":"2016-09-26 22:03:21.000000000","message":"I agree with Brian. Last week we saw a similar case reverted exactly for this reason: https://review.openstack.org/#/c/373647/","commit_id":"7d058f19cde86ab7fec5c35ddeeafd27688cd22a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9b3c9932725993ffc19ee7717756a567d6dc4c8c","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027by concurrent operation\u0027, router_id)"},{"line_number":327,"context_line":"                return"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def get_ha_routers_l3_agents_counts(self, plugin, context, filters\u003dNone):"},{"line_number":330,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":331,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_ab51c064","line":329,"in_reply_to":"5a8bc5a2_2b3a17e8","updated":"2016-09-28 18:54:07.000000000","message":"Here is URL for codesearch [1]\n\n[1] http://codesearch.openstack.org/?q\u003dget_ha_routers_l3_agents_counts\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"7d058f19cde86ab7fec5c35ddeeafd27688cd22a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"af36c2f462321200578968850461f2b5e8e0bab0","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027by concurrent operation\u0027, router_id)"},{"line_number":327,"context_line":"                return"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def get_ha_routers_l3_agents_counts(self, plugin, context, filters\u003dNone):"},{"line_number":330,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":331,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_2b3a17e8","line":329,"in_reply_to":"5a8bc5a2_7f11745c","updated":"2016-09-28 01:08:53.000000000","message":"John - that search didn\u0027t work for me","commit_id":"7d058f19cde86ab7fec5c35ddeeafd27688cd22a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"ff9a1bb69785cad9905abf4752f65a5cb7a58a0a","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027by concurrent operation\u0027, router_id)"},{"line_number":327,"context_line":"                return"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def get_ha_routers_l3_agents_counts(self, plugin, context, filters\u003dNone):"},{"line_number":330,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":331,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_7f11745c","line":329,"in_reply_to":"5a8bc5a2_a4e77faa","updated":"2016-09-27 07:36:15.000000000","message":"I agree with both of you. However, I\u0027ve done a github search for all the code that calls this function [1] - and outside openstack/neutron (and numerous forks), none of the other openstack projects (including stadium repos) call this function, so it\u0027s safe to change this.\n\nCan you reconsider?\n\n[1]: https://github.com/search?q\u003dget_ha_routers_l3_agents_counts\u0026ref\u003dsearchresults\u0026type\u003dCode\u0026utf8\u003d%E2%9C%93","commit_id":"7d058f19cde86ab7fec5c35ddeeafd27688cd22a"}]}