)]}'
{"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"c097f0d7da748ab415d41d6bb449f99e2156075a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from neutron.objects import base as obj_base"},{"line_number":51,"context_line":"from neutron.objects import l3_hamode as l3_obj"},{"line_number":52,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_deprecate._moved_global(\u0027L3HARouterAgentPortBinding\u0027,"},{"line_number":55,"context_line":"                         new_module\u003dl3_hamode_model)"},{"line_number":56,"context_line":"_deprecate._moved_global(\u0027L3HARouterNetwork\u0027, new_module\u003dl3_hamode_model)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_43085628","line":53,"updated":"2016-09-27 10:52:00.000000000","message":"why remove the whitespace?","commit_id":"c4808b4bc2884d007aa4096e0bee3f37e3c4e306"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"8a0ea6ec56dec47f703129ac92ee08b859db844b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from neutron.objects import base as obj_base"},{"line_number":51,"context_line":"from neutron.objects import l3_hamode as l3_obj"},{"line_number":52,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_deprecate._moved_global(\u0027L3HARouterAgentPortBinding\u0027,"},{"line_number":55,"context_line":"                         new_module\u003dl3_hamode_model)"},{"line_number":56,"context_line":"_deprecate._moved_global(\u0027L3HARouterNetwork\u0027, new_module\u003dl3_hamode_model)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_d83ca3ca","line":53,"in_reply_to":"5a8bc5a2_43085628","updated":"2016-09-30 15:48:24.000000000","message":"Done","commit_id":"c4808b4bc2884d007aa4096e0bee3f37e3c4e306"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"c097f0d7da748ab415d41d6bb449f99e2156075a","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _delete_vr_id_allocation(self, context, ha_network, vr_id):"},{"line_number":185,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":186,"context_line":"            obj \u003d l3_obj.L3HARouterVRIdAllocation.get_object("},{"line_number":187,"context_line":"                context, network_id\u003dha_network.network_id, vr_id\u003dvr_id)"},{"line_number":188,"context_line":"            if obj:"},{"line_number":189,"context_line":"                obj.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_e3e1622b","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":15},"updated":"2016-09-27 10:52:00.000000000","message":"nit: \u0027obj\u0027 is a bit generic. Perhaps vr_id_allocation or similar?","commit_id":"c4808b4bc2884d007aa4096e0bee3f37e3c4e306"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"8a0ea6ec56dec47f703129ac92ee08b859db844b","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _delete_vr_id_allocation(self, context, ha_network, vr_id):"},{"line_number":185,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":186,"context_line":"            obj \u003d l3_obj.L3HARouterVRIdAllocation.get_object("},{"line_number":187,"context_line":"                context, network_id\u003dha_network.network_id, vr_id\u003dvr_id)"},{"line_number":188,"context_line":"            if obj:"},{"line_number":189,"context_line":"                obj.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_383027e8","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":15},"in_reply_to":"5a8bc5a2_e3e1622b","updated":"2016-09-30 15:48:24.000000000","message":"Done","commit_id":"c4808b4bc2884d007aa4096e0bee3f37e3c4e306"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"3c1f7d1d2b086ce652be9793c76d61634367aa2f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_150c0d40","line":16,"updated":"2016-10-07 11:08:00.000000000","message":"extra whitespace?","commit_id":"db8515ad842949d78f89c5c704bdd1bfd989aa8e"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0401f8f3833c73fbde16c60f09b4953719f4ac66","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_1f113a5d","line":16,"in_reply_to":"1a95cdbc_150c0d40","updated":"2016-10-10 14:51:58.000000000","message":"Done","commit_id":"db8515ad842949d78f89c5c704bdd1bfd989aa8e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a7d33ede19315c938e78f875cc743bbd06de230f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_846b431d","line":16,"in_reply_to":"1a95cdbc_150c0d40","updated":"2016-10-10 14:32:32.000000000","message":"It should be removed.","commit_id":"db8515ad842949d78f89c5c704bdd1bfd989aa8e"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0401f8f3833c73fbde16c60f09b4953719f4ac66","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_3f14364b","line":16,"in_reply_to":"1a95cdbc_846b431d","updated":"2016-10-10 14:51:58.000000000","message":"Done","commit_id":"db8515ad842949d78f89c5c704bdd1bfd989aa8e"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6b5fcb873c4247e0cc27df04571fdd86ed419ed1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from neutron.objects import l3_hamode as l3_obj"},{"line_number":52,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"_deprecate._moved_global(\u0027L3HARouterAgentPortBinding\u0027, new_module\u003dl3ha_model)"},{"line_number":56,"context_line":"_deprecate._moved_global(\u0027L3HARouterNetwork\u0027, new_module\u003dl3ha_model)"},{"line_number":57,"context_line":"_deprecate._moved_global(\u0027L3HARouterVRIdAllocation\u0027, new_module\u003dl3ha_model)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_8917c5ec","line":54,"updated":"2016-10-10 21:27:36.000000000","message":"extra line needs to be removed","commit_id":"7de42e27bc7f02371992711fd2eefc4cd1991ac8"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"70a14f59eee34c9ed4bd7f39ba888683fecd6090","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from neutron.objects import l3_hamode as l3_obj"},{"line_number":52,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"_deprecate._moved_global(\u0027L3HARouterAgentPortBinding\u0027, new_module\u003dl3ha_model)"},{"line_number":56,"context_line":"_deprecate._moved_global(\u0027L3HARouterNetwork\u0027, new_module\u003dl3ha_model)"},{"line_number":57,"context_line":"_deprecate._moved_global(\u0027L3HARouterVRIdAllocation\u0027, new_module\u003dl3ha_model)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_9ca44958","line":54,"in_reply_to":"fa6399be_8917c5ec","updated":"2016-10-11 13:04:36.000000000","message":"No, two lines after imports is correct. See http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"7de42e27bc7f02371992711fd2eefc4cd1991ac8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6324cc52727b1c900c86a24b71e403c7eab7ebdc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            vr_id_obj \u003d l3_obj.L3HARouterVRIdAllocation.get_objects("},{"line_number":144,"context_line":"                context, network_id\u003dnetwork_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        allocated_vr_ids \u003d set(a.vr_id for a in vr_id_obj) - set([0])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return allocated_vr_ids"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_05ab781e","line":146,"range":{"start_line":146,"start_character":27,"end_line":146,"end_character":69},"updated":"2016-10-11 14:02:34.000000000","message":"I\u0027m  wondering if this can be written like this:\n\n    set(a.vr_id for a in vr_id_obj if a.vr_id !\u003d 0)","commit_id":"7de42e27bc7f02371992711fd2eefc4cd1991ac8"}]}