)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Integration of RouterL3AgentBinding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrated the OVO created for RouterL3AgentBinding into"},{"line_number":10,"context_line":"the code base"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0af665a97087ad72431d58f04089a804088ef005"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa6399be_5e125eb5","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":21},"updated":"2016-10-19 15:51:35.000000000","message":"s/integrated/integrates","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"2f7891345ee3753335860108eb1b67b269f192bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Integration of RouterL3AgentBinding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrated the OVO created for RouterL3AgentBinding into"},{"line_number":10,"context_line":"the code base"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0af665a97087ad72431d58f04089a804088ef005"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba5da102_6f06631e","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":21},"in_reply_to":"fa6399be_5e125eb5","updated":"2016-11-01 21:34:32.000000000","message":"Done","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5ee4aa7aeda241dc57cbe4aa7ddcc5ae98261f59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anindita Das \u003canindita.das@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-29 22:47:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of RouterL3AgentBinding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrates the OVO created for RouterL3AgentBinding into"},{"line_number":10,"context_line":"the code base."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"5a74a57a_c881644f","line":7,"updated":"2016-12-01 07:01:51.000000000","message":"Please prefix this with OVO or something object related - the hint helps reviewers","commit_id":"acc6339aea3d764202ad92d57875c6c68557d480"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                reschedule_resource\u003dself.reschedule_router,"},{"line_number":106,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    #TODO(dasanind):Implement join when Agent and RouterExtrattributes OVO\u0027s"},{"line_number":109,"context_line":"    # are available"},{"line_number":110,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":111,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_85ee9889","line":108,"range":{"start_line":108,"start_character":19,"end_line":108,"end_character":21},"updated":"2016-10-05 13:37:06.000000000","message":"nit: add space after \u0027:\u0027","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"39eb809eb18541c881fc200093004e26bd0e0710","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                reschedule_resource\u003dself.reschedule_router,"},{"line_number":106,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    #TODO(dasanind):Implement join when Agent and RouterExtrattributes OVO\u0027s"},{"line_number":109,"context_line":"    # are available"},{"line_number":110,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":111,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_121a876e","line":108,"range":{"start_line":108,"start_character":19,"end_line":108,"end_character":21},"in_reply_to":"1a95cdbc_85ee9889","updated":"2016-10-10 18:42:59.000000000","message":"Done","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        Overridden for DVR to handle agents in \u0027dvr\u0027 mode which have"},{"line_number":352,"context_line":"        no explicit bindings with routers"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":355,"context_line":"                      context,"},{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_eba48b58","line":356,"range":{"start_line":354,"start_character":8,"end_line":356,"end_character":43},"updated":"2016-10-05 13:37:06.000000000","message":"The entire \u0027if router_ids\u0027 logic can be removed by providing router_id\u003drouter_ids to get_objects(). It\u0027s smart enough to realize \u0027router_ids\u0027 is a list and translate it to a \u0027in_\u0027 request for sqlalchemy.","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3351cf0a74939d6be39daf221c12ebd1ff819ae8","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        Overridden for DVR to handle agents in \u0027dvr\u0027 mode which have"},{"line_number":352,"context_line":"        no explicit bindings with routers"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":355,"context_line":"                      context,"},{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_2c9652f0","line":356,"range":{"start_line":354,"start_character":8,"end_line":356,"end_character":43},"in_reply_to":"1a95cdbc_b306ba83","updated":"2016-10-13 07:36:19.000000000","message":"Aye - walking through the code (using pdb), what happens is that the sync_routers() call eventually goes inside _get_router_ids_for_agent() with router_ids\u003dNone. This will make this call return an empty list (since the in_() argument is an empty list), which explains the issue.\n\nHow about the following snippet (I ran it against the test that failed and it now succeeds)?\n\n filters \u003d {\u0027l3_agent_id\u0027: agent.id}\n  if router_ids:\n       filters[\u0027router_id\u0027] \u003d router_ids\n\n record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects(context, **filters)","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"39eb809eb18541c881fc200093004e26bd0e0710","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        Overridden for DVR to handle agents in \u0027dvr\u0027 mode which have"},{"line_number":352,"context_line":"        no explicit bindings with routers"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":355,"context_line":"                      context,"},{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_b306ba83","line":356,"range":{"start_line":354,"start_character":8,"end_line":356,"end_character":43},"in_reply_to":"1a95cdbc_eba48b58","updated":"2016-10-10 18:42:59.000000000","message":"I tested using router_id\u003drouter_ids in get_objects as follows :\n\nrecord_objs \u003d rb_obj.RouterL3AgentBinding.get_objects(\ncontext,\nl3_agent_id\u003dagent.id, router_id\u003drouter_ids)\n\nIt failed with the error as in [1]\nhttp://paste.openstack.org/show/585232/","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3fd219a3ec08a161a97349072964f3c9cff860fc","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        Overridden for DVR to handle agents in \u0027dvr\u0027 mode which have"},{"line_number":352,"context_line":"        no explicit bindings with routers"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":355,"context_line":"                      context,"},{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_992cb49a","line":356,"range":{"start_line":354,"start_character":8,"end_line":356,"end_character":43},"in_reply_to":"fa6399be_2c9652f0","updated":"2016-10-14 15:42:54.000000000","message":"It worked. Thank you for the review and the suggestion. :)","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d []"},{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_20f772d4","line":362,"range":{"start_line":359,"start_character":12,"end_line":362,"end_character":57},"updated":"2016-10-05 13:37:06.000000000","message":"This is a classic case of using a list comprehension.","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"39eb809eb18541c881fc200093004e26bd0e0710","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d []"},{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_53f6568f","line":362,"range":{"start_line":359,"start_character":12,"end_line":362,"end_character":57},"in_reply_to":"1a95cdbc_20f772d4","updated":"2016-10-10 18:42:59.000000000","message":"Done","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_c06ecec8","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":49},"updated":"2016-10-05 13:37:06.000000000","message":"This logic seems wrong to me. Why create \u0027selected_record_objs\u0027, just to create a copy of it called \u0027record_objs\u0027? Why not directly call it \u0027record_objs\u0027?","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"39eb809eb18541c881fc200093004e26bd0e0710","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_13b84e74","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":49},"in_reply_to":"1a95cdbc_44b18046","updated":"2016-10-10 18:42:59.000000000","message":"Same as above","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3351cf0a74939d6be39daf221c12ebd1ff819ae8","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_acf98282","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":49},"in_reply_to":"1a95cdbc_739272f7","updated":"2016-10-13 07:36:19.000000000","message":"Alas, \u0027record_obj \u003d selected_record_objs\u0027 will suffice (it\u0027s O(1) as opposed to using [:] which makes a copy of each of the objects in selected_record_objs).\n\n* I haven\u0027t checked if the [:] makes a deep copy (duplicating the objects) or a shallow copy (just using the \u0027pointers\u0027 to the objects), but it\u0027s still O(n) as it needs to iterate on all the objects anyway.","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"ca3dfb5c73b8918d904d9908913d4ed72975dcf2","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_44b18046","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":49},"in_reply_to":"1a95cdbc_c06ecec8","updated":"2016-10-07 14:34:03.000000000","message":"+1","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"39eb809eb18541c881fc200093004e26bd0e0710","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_739272f7","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":49},"in_reply_to":"1a95cdbc_c06ecec8","updated":"2016-10-10 18:42:59.000000000","message":"I am iterating through the record_objs list to create another list selected_record_objs that contains the router_ids (if any). I cannot name the result as record_objs while iterating on record_objs. Eventually I need to copy the result into record_objs as in line 365 I am iterating on the record_objs to return the router_ids.","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3fd219a3ec08a161a97349072964f3c9cff860fc","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            for item in record_objs:"},{"line_number":361,"context_line":"                if item.router_id in router_ids:"},{"line_number":362,"context_line":"                        selected_record_objs.append(item)"},{"line_number":363,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_b956d803","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":49},"in_reply_to":"fa6399be_acf98282","updated":"2016-10-14 15:42:54.000000000","message":"Not needed any more so removed it.","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                context, host, agent, scheduled_router_ids)"},{"line_number":387,"context_line":"        return []"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":390,"context_line":"    def get_l3_agents_hosting_routers(self, context, router_ids,"},{"line_number":391,"context_line":"                                      admin_state_up\u003dNone,"},{"line_number":392,"context_line":"                                      active\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_c5e8a07f","line":389,"range":{"start_line":389,"start_character":19,"end_line":389,"end_character":21},"updated":"2016-10-05 13:37:06.000000000","message":"nit: add space after \u0027:\u0027","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                             l3_agent[\u0027heartbeat_timestamp\u0027])]"},{"line_number":410,"context_line":"        return l3_agents"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":413,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":414,"context_line":"        if not router_ids:"},{"line_number":415,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_e5ed9c8c","line":412,"updated":"2016-10-05 13:37:06.000000000","message":"ditto","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"42dc05662e4756c10b1ff0aa4c6d447d7d965a00","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        for router in routers:"},{"line_number":512,"context_line":"            self.schedule_router(context, router, candidates\u003dNone)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    #TODO(dasanind)Implement the join when Agent OVO is available"},{"line_number":515,"context_line":"    def get_l3_agent_with_min_routers(self, context, agent_ids):"},{"line_number":516,"context_line":"        \"\"\"Return l3 agent with the least number of routers.\"\"\""},{"line_number":517,"context_line":"        if not agent_ids:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_65fa6c44","line":514,"range":{"start_line":514,"start_character":18,"end_line":514,"end_character":20},"updated":"2016-10-05 13:37:06.000000000","message":"nit: add \u0027: \u0027 after \u0027)\u0027","commit_id":"87d2d425b29c1a869084b7ed67cd0e80dbf8a521"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"d7418157e965326719bcec1fd27324d62d19c116","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":260,"context_line":"            record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":261,"context_line":"                    context,"},{"line_number":262,"context_line":"                    router_id\u003drouter_id,"},{"line_number":263,"context_line":"                    l3_agent_id\u003dagent_id)"},{"line_number":264,"context_line":"            if record_obj:"},{"line_number":265,"context_line":"                record_obj.delete()"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_85674524","line":263,"range":{"start_line":262,"start_character":0,"end_line":263,"end_character":41},"updated":"2016-10-12 19:36:47.000000000","message":"this can be included in previous line","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4f74fc708740b1f59d8b16da03e347fa3f8cea78","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":260,"context_line":"            record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":261,"context_line":"                    context,"},{"line_number":262,"context_line":"                    router_id\u003drouter_id,"},{"line_number":263,"context_line":"                    l3_agent_id\u003dagent_id)"},{"line_number":264,"context_line":"            if record_obj:"},{"line_number":265,"context_line":"                record_obj.delete()"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_d970eca6","line":263,"range":{"start_line":262,"start_character":0,"end_line":263,"end_character":41},"in_reply_to":"fa6399be_85674524","updated":"2016-10-14 15:43:01.000000000","message":"Done","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"d7418157e965326719bcec1fd27324d62d19c116","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    def list_routers_on_l3_agent(self, context, agent_id):"},{"line_number":316,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":317,"context_line":"                      context,"},{"line_number":318,"context_line":"                      l3_agent_id\u003dagent_id)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        router_ids \u003d [item.router_id for item in record_objs]"},{"line_number":321,"context_line":"        if router_ids:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c5485d8a","line":318,"range":{"start_line":318,"start_character":18,"end_line":318,"end_character":43},"updated":"2016-10-12 19:36:47.000000000","message":"this can be included in previous line\nrb_obj.RouterL3AgentBinding.get_objects(\n                      context, l3_agent_id\u003dagent_id)","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4f74fc708740b1f59d8b16da03e347fa3f8cea78","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    def list_routers_on_l3_agent(self, context, agent_id):"},{"line_number":316,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":317,"context_line":"                      context,"},{"line_number":318,"context_line":"                      l3_agent_id\u003dagent_id)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        router_ids \u003d [item.router_id for item in record_objs]"},{"line_number":321,"context_line":"        if router_ids:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_b9a41808","line":318,"range":{"start_line":318,"start_character":18,"end_line":318,"end_character":43},"in_reply_to":"fa6399be_c5485d8a","updated":"2016-10-14 15:43:01.000000000","message":"Done","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"d7418157e965326719bcec1fd27324d62d19c116","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d [item for item in record_objs"},{"line_number":360,"context_line":"                    if item.router_id in router_ids]"},{"line_number":361,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c5d5bdb9","line":361,"range":{"start_line":359,"start_character":0,"end_line":361,"end_character":49},"updated":"2016-10-12 19:36:47.000000000","message":"you can replace this with\n        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects(\n                      context,\n                      l3_agent_id\u003dagent.id\n                      router_id\u003drouter_ids)\nthis should be sufficient to handle sqlalchemy in_ operator","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4f74fc708740b1f59d8b16da03e347fa3f8cea78","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                      l3_agent_id\u003dagent.id)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if router_ids:"},{"line_number":359,"context_line":"            selected_record_objs \u003d [item for item in record_objs"},{"line_number":360,"context_line":"                    if item.router_id in router_ids]"},{"line_number":361,"context_line":"            record_objs \u003d selected_record_objs[:]"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_d9a70c09","line":361,"range":{"start_line":359,"start_character":0,"end_line":361,"end_character":49},"in_reply_to":"fa6399be_c5d5bdb9","updated":"2016-10-14 15:43:01.000000000","message":"Done","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"d7418157e965326719bcec1fd27324d62d19c116","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":550,"context_line":"                      context,"},{"line_number":551,"context_line":"                      router_id\u003drouter_id)"},{"line_number":552,"context_line":"        bindings.sort(key\u003doperator.attrgetter(\u0027router_id\u0027))"},{"line_number":553,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"},{"line_number":554,"context_line":"        all_indicies \u003d set(range(rb_model.LOWEST_BINDING_INDEX,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_853585f8","line":551,"range":{"start_line":550,"start_character":0,"end_line":551,"end_character":42},"updated":"2016-10-12 19:36:47.000000000","message":"ditto","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4f74fc708740b1f59d8b16da03e347fa3f8cea78","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":550,"context_line":"                      context,"},{"line_number":551,"context_line":"                      router_id\u003drouter_id)"},{"line_number":552,"context_line":"        bindings.sort(key\u003doperator.attrgetter(\u0027router_id\u0027))"},{"line_number":553,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"},{"line_number":554,"context_line":"        all_indicies \u003d set(range(rb_model.LOWEST_BINDING_INDEX,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_d97e2c69","line":551,"range":{"start_line":550,"start_character":0,"end_line":551,"end_character":42},"in_reply_to":"fa6399be_853585f8","updated":"2016-10-14 15:43:01.000000000","message":"Done","commit_id":"4438940d3eb55106de52d5ce885bb00311c6a920"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                context, router_id, agent.host)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _unbind_router(self, context, router_id, agent_id):"},{"line_number":260,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":261,"context_line":"            record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":262,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":263,"context_line":"            if record_obj:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_fed6d2c1","line":260,"range":{"start_line":260,"start_character":8,"end_line":260,"end_character":57},"updated":"2016-10-19 15:51:35.000000000","message":"nit: Given that objects internally create a session, you don\u0027t need this line anymore","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"45847e57a4e63d073b3a7f1c867c426815ae9fdf","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                context, router_id, agent.host)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _unbind_router(self, context, router_id, agent_id):"},{"line_number":260,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":261,"context_line":"            record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":262,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":263,"context_line":"            if record_obj:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_bdaef995","line":260,"range":{"start_line":260,"start_character":8,"end_line":260,"end_character":57},"in_reply_to":"fa6399be_fed6d2c1","updated":"2016-11-01 19:12:03.000000000","message":"Done","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def list_routers_on_l3_agent(self, context, agent_id):"},{"line_number":315,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":316,"context_line":"                      context, l3_agent_id\u003dagent_id)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        router_ids \u003d [item.router_id for item in record_objs]"},{"line_number":319,"context_line":"        if router_ids:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_de890ecc","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":52},"updated":"2016-10-19 15:51:35.000000000","message":"nit: I think this line has wrong identation","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"45847e57a4e63d073b3a7f1c867c426815ae9fdf","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def list_routers_on_l3_agent(self, context, agent_id):"},{"line_number":315,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":316,"context_line":"                      context, l3_agent_id\u003dagent_id)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        router_ids \u003d [item.router_id for item in record_objs]"},{"line_number":319,"context_line":"        if router_ids:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_dd7e4d18","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":52},"in_reply_to":"fa6399be_de890ecc","updated":"2016-11-01 19:12:03.000000000","message":"Done","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if router_ids:"},{"line_number":354,"context_line":"            filters[\u0027router_id\u0027] \u003d router_ids"},{"line_number":355,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":356,"context_line":"                      context, **filters)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        #if router_ids:"},{"line_number":359,"context_line":"        #    selected_record_objs \u003d [item for item in record_objs"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_1eab861e","line":356,"updated":"2016-10-19 15:51:35.000000000","message":"ditto: line 316","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"45847e57a4e63d073b3a7f1c867c426815ae9fdf","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if router_ids:"},{"line_number":354,"context_line":"            filters[\u0027router_id\u0027] \u003d router_ids"},{"line_number":355,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":356,"context_line":"                      context, **filters)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        #if router_ids:"},{"line_number":359,"context_line":"        #    selected_record_objs \u003d [item for item in record_objs"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_bd9c395e","line":356,"in_reply_to":"fa6399be_1eab861e","updated":"2016-11-01 19:12:03.000000000","message":"Done","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":356,"context_line":"                      context, **filters)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        #if router_ids:"},{"line_number":359,"context_line":"        #    selected_record_objs \u003d [item for item in record_objs"},{"line_number":360,"context_line":"        #            if item.router_id in router_ids]"},{"line_number":361,"context_line":"        #    record_objs \u003d selected_record_objs[:]"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_be70dadd","line":361,"range":{"start_line":358,"start_character":0,"end_line":361,"end_character":50},"updated":"2016-10-19 15:51:35.000000000","message":"If those lines are not need you can remove them","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"45847e57a4e63d073b3a7f1c867c426815ae9fdf","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":356,"context_line":"                      context, **filters)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        #if router_ids:"},{"line_number":359,"context_line":"        #    selected_record_objs \u003d [item for item in record_objs"},{"line_number":360,"context_line":"        #            if item.router_id in router_ids]"},{"line_number":361,"context_line":"        #    record_objs \u003d selected_record_objs[:]"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        return [item.router_id for item in record_objs]"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_dda56da2","line":361,"range":{"start_line":358,"start_character":0,"end_line":361,"end_character":50},"in_reply_to":"fa6399be_be70dadd","updated":"2016-11-01 19:12:03.000000000","message":"Done","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":550,"context_line":"                      context, router_id\u003drouter_id)"},{"line_number":551,"context_line":"        bindings.sort(key\u003doperator.attrgetter(\u0027router_id\u0027))"},{"line_number":552,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"},{"line_number":553,"context_line":"        all_indicies \u003d set(range(rb_model.LOWEST_BINDING_INDEX,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_9e3b16eb","line":550,"updated":"2016-10-19 15:51:35.000000000","message":"ditto: line 316","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"45847e57a4e63d073b3a7f1c867c426815ae9fdf","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":550,"context_line":"                      context, router_id\u003drouter_id)"},{"line_number":551,"context_line":"        bindings.sort(key\u003doperator.attrgetter(\u0027router_id\u0027))"},{"line_number":552,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"},{"line_number":553,"context_line":"        all_indicies \u003d set(range(rb_model.LOWEST_BINDING_INDEX,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_7dbd41b6","line":550,"in_reply_to":"fa6399be_9e3b16eb","updated":"2016-11-01 19:12:03.000000000","message":"Done","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"be82655226408d96086410fdae4741da6f6af64b","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        \"\"\""},{"line_number":541,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":544,"context_line":"                context, router_id\u003drouter_id)"},{"line_number":545,"context_line":"        bindings.sort(key\u003doperator.attrgetter(\u0027router_id\u0027))"},{"line_number":546,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_7c962340","line":543,"updated":"2016-11-09 22:20:24.000000000","message":"Here pager can be used instead of sorting on operator.attrgetter. Example: https://review.openstack.org/#/c/382037/22/neutron/plugins/ml2/db.py@133","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b80750fd403b476b28da02b58ef296c0ecabd331","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        \"\"\""},{"line_number":541,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":544,"context_line":"                context, router_id\u003drouter_id)"},{"line_number":545,"context_line":"        bindings.sort(key\u003doperator.attrgetter(\u0027router_id\u0027))"},{"line_number":546,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_a0ae7c2b","line":543,"in_reply_to":"9a629dbe_7c962340","updated":"2016-11-11 17:28:10.000000000","message":"Done","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"56993eea4e919d9830913015a49480119d44224c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import debtcollector"},{"line_number":17,"context_line":"from neutron_lib import constants"},{"line_number":18,"context_line":"import operator"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_db import exception as db_exc"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_1e8140fb","line":18,"updated":"2016-11-11 20:03:20.000000000","message":"Is this used anywhere?","commit_id":"52411a0eb27fbc1345792d7ecb09011f6ef0670c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5a684cbe9298e2a8f5703ef618db7e3ed2fb7ac1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import debtcollector"},{"line_number":17,"context_line":"from neutron_lib import constants"},{"line_number":18,"context_line":"import operator"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_db import exception as db_exc"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_d4683fbd","line":18,"in_reply_to":"9a629dbe_1e8140fb","updated":"2016-11-15 21:49:14.000000000","message":"removed","commit_id":"52411a0eb27fbc1345792d7ecb09011f6ef0670c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"56993eea4e919d9830913015a49480119d44224c","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        \"\"\""},{"line_number":541,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        pager \u003d objects_base.Pager(sorts\u003d[(\u0027level\u0027, True)])"},{"line_number":544,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":545,"context_line":"                context, _pager\u003dpager, router_id\u003drouter_id)"},{"line_number":546,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_1eaf807d","line":543,"updated":"2016-11-11 20:03:20.000000000","message":"I think you are sorting here by \u0027level\u0027. But originally,  order_by is done on rb_model.RouterL3AgentBinding.binding_index.asc(). Check if this is level.","commit_id":"52411a0eb27fbc1345792d7ecb09011f6ef0670c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5a684cbe9298e2a8f5703ef618db7e3ed2fb7ac1","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        \"\"\""},{"line_number":541,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        pager \u003d objects_base.Pager(sorts\u003d[(\u0027level\u0027, True)])"},{"line_number":544,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":545,"context_line":"                context, _pager\u003dpager, router_id\u003drouter_id)"},{"line_number":546,"context_line":"        binding_indices \u003d [b.binding_index for b in bindings]"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_549b4fc9","line":543,"in_reply_to":"9a629dbe_1eaf807d","updated":"2016-11-15 21:49:14.000000000","message":"oops...my bad changed it to binding_index","commit_id":"52411a0eb27fbc1345792d7ecb09011f6ef0670c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"fc7a9e652f66cbdcdb1f29a494e1cb70171f86a3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                context, router_id, agent.host)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _unbind_router(self, context, router_id, agent_id):"},{"line_number":260,"context_line":"        record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":261,"context_line":"                context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":262,"context_line":"        if record_obj:"},{"line_number":263,"context_line":"            record_obj.delete()"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _unschedule_router(self, context, router_id, agents_ids):"},{"line_number":266,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_94ab2789","line":263,"range":{"start_line":260,"start_character":3,"end_line":263,"end_character":31},"updated":"2016-11-16 00:21:20.000000000","message":"If the object doesn\u0027t exists during delete, ObjectNotFound is raised [1]. It seems that checking if obj exists is not required. How about?\n    rb_obj.RouterL3AgentBinding.get_object(context, router_id\u003drouter_id,\n        l3_agent_id\u003dagent_id).delete()\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/db/api.py#L67-#L74","commit_id":"c617c1a94ca8bf6d85d1b3360e0ad10bbe35f9e7"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"aca8fa87a0bca40410ad31877972c1293bec454e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                context, router_id, agent.host)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _unbind_router(self, context, router_id, agent_id):"},{"line_number":260,"context_line":"        record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":261,"context_line":"                context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":262,"context_line":"        if record_obj:"},{"line_number":263,"context_line":"            record_obj.delete()"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _unschedule_router(self, context, router_id, agents_ids):"},{"line_number":266,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_12dd01e0","line":263,"range":{"start_line":260,"start_character":3,"end_line":263,"end_character":31},"in_reply_to":"7a77a97e_94ab2789","updated":"2016-11-28 06:21:26.000000000","message":"Done","commit_id":"c617c1a94ca8bf6d85d1b3360e0ad10bbe35f9e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5ee4aa7aeda241dc57cbe4aa7ddcc5ae98261f59","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if admin_state_up is not None:"},{"line_number":374,"context_line":"            for obj in record_objs:"},{"line_number":375,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":376,"context_line":"                print(\"assoc_agent\", assoc_agent)"},{"line_number":377,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":378,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":379,"context_line":"                    print(\"l3_agenets\", l3_agents)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a74a57a_88904c97","line":376,"updated":"2016-12-01 07:01:51.000000000","message":"please remove","commit_id":"acc6339aea3d764202ad92d57875c6c68557d480"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f72ad57d7f9b88ff9b4fc8d9607010577eba77c5","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if admin_state_up is not None:"},{"line_number":374,"context_line":"            for obj in record_objs:"},{"line_number":375,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":376,"context_line":"                print(\"assoc_agent\", assoc_agent)"},{"line_number":377,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":378,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":379,"context_line":"                    print(\"l3_agenets\", l3_agents)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_32352346","line":376,"in_reply_to":"5a74a57a_88904c97","updated":"2016-12-01 16:45:22.000000000","message":"Done","commit_id":"acc6339aea3d764202ad92d57875c6c68557d480"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5ee4aa7aeda241dc57cbe4aa7ddcc5ae98261f59","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":376,"context_line":"                print(\"assoc_agent\", assoc_agent)"},{"line_number":377,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":378,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":379,"context_line":"                    print(\"l3_agenets\", l3_agents)"},{"line_number":380,"context_line":"        else:"},{"line_number":381,"context_line":"            l3_agents \u003d [binding.l3_agent for binding in record_objs]"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a74a57a_c8e88419","line":378,"updated":"2016-12-01 07:01:51.000000000","message":"ditto","commit_id":"acc6339aea3d764202ad92d57875c6c68557d480"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"f72ad57d7f9b88ff9b4fc8d9607010577eba77c5","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":376,"context_line":"                print(\"assoc_agent\", assoc_agent)"},{"line_number":377,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":378,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":379,"context_line":"                    print(\"l3_agenets\", l3_agents)"},{"line_number":380,"context_line":"        else:"},{"line_number":381,"context_line":"            l3_agents \u003d [binding.l3_agent for binding in record_objs]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_f211ebb0","line":378,"in_reply_to":"5a74a57a_c8e88419","updated":"2016-12-01 16:45:22.000000000","message":"Done","commit_id":"acc6339aea3d764202ad92d57875c6c68557d480"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                context, router_id, agent.host)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _unbind_router(self, context, router_id, agent_id):"},{"line_number":243,"context_line":"        record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":244,"context_line":"                context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":245,"context_line":"        if record_obj:"},{"line_number":246,"context_line":"            record_obj.delete()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def _unschedule_router(self, context, router_id, agents_ids):"},{"line_number":249,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_c0369db3","line":246,"range":{"start_line":243,"start_character":8,"end_line":246,"end_character":31},"updated":"2016-12-20 14:08:48.000000000","message":"You can use delete_objects here.","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                context, router_id, agent.host)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _unbind_router(self, context, router_id, agent_id):"},{"line_number":243,"context_line":"        record_obj \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":244,"context_line":"                context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":245,"context_line":"        if record_obj:"},{"line_number":246,"context_line":"            record_obj.delete()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def _unschedule_router(self, context, router_id, agents_ids):"},{"line_number":249,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_4acd5c5c","line":246,"range":{"start_line":243,"start_character":8,"end_line":246,"end_character":31},"in_reply_to":"1a6eadb0_c0369db3","updated":"2016-12-23 21:00:47.000000000","message":"Done","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                context, host, agent, scheduled_router_ids)"},{"line_number":362,"context_line":"        return []"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":365,"context_line":"    def get_l3_agents_hosting_routers(self, context, router_ids,"},{"line_number":366,"context_line":"                                      admin_state_up\u003dNone,"},{"line_number":367,"context_line":"                                      active\u003dNone):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_60f4e9ce","line":364,"range":{"start_line":364,"start_character":4,"end_line":364,"end_character":51},"updated":"2016-12-20 14:08:48.000000000","message":"This comment can be removed.","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                context, host, agent, scheduled_router_ids)"},{"line_number":362,"context_line":"        return []"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":365,"context_line":"    def get_l3_agents_hosting_routers(self, context, router_ids,"},{"line_number":366,"context_line":"                                      admin_state_up\u003dNone,"},{"line_number":367,"context_line":"                                      active\u003dNone):"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_aa04087e","line":364,"range":{"start_line":364,"start_character":4,"end_line":364,"end_character":51},"in_reply_to":"1a6eadb0_60f4e9ce","updated":"2016-12-23 21:00:47.000000000","message":"Done","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        return []"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":365,"context_line":"    def get_l3_agents_hosting_routers(self, context, router_ids,"},{"line_number":366,"context_line":"                                      admin_state_up\u003dNone,"},{"line_number":367,"context_line":"                                      active\u003dNone):"},{"line_number":368,"context_line":"        if not router_ids:"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_223bd439","line":365,"updated":"2016-12-20 14:08:48.000000000","message":"If this is failing in functional test, maybe you can try to add UT to simulate the same behavior that the functional test?","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        return []"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":365,"context_line":"    def get_l3_agents_hosting_routers(self, context, router_ids,"},{"line_number":366,"context_line":"                                      admin_state_up\u003dNone,"},{"line_number":367,"context_line":"                                      active\u003dNone):"},{"line_number":368,"context_line":"        if not router_ids:"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_ea353046","line":365,"in_reply_to":"1a6eadb0_223bd439","updated":"2016-12-23 21:00:47.000000000","message":"Fixed the code, functional tests passing now","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                                      active\u003dNone):"},{"line_number":368,"context_line":"        if not router_ids:"},{"line_number":369,"context_line":"            return []"},{"line_number":370,"context_line":"        l3_agents \u003d []"},{"line_number":371,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":372,"context_line":"                context, router_id\u003drouter_ids)"},{"line_number":373,"context_line":"        if admin_state_up is not None:"},{"line_number":374,"context_line":"            for obj in record_objs:"},{"line_number":375,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":376,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":377,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            l3_agents \u003d [binding.l3_agent for binding in record_objs]"},{"line_number":380,"context_line":"        if active is not None:"},{"line_number":381,"context_line":"            l3_agents \u003d [l3_agent for l3_agent in"},{"line_number":382,"context_line":"                         l3_agents if not"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_1fc0ef7b","line":379,"range":{"start_line":370,"start_character":7,"end_line":379,"end_character":69},"updated":"2016-12-20 14:08:48.000000000","message":"You can try to use original query and create new method in RouterL3AgentBinding called \nget_l3_agents_hosting_routers(context, router_ids, admins_state_up\u003dNone)","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                                      active\u003dNone):"},{"line_number":368,"context_line":"        if not router_ids:"},{"line_number":369,"context_line":"            return []"},{"line_number":370,"context_line":"        l3_agents \u003d []"},{"line_number":371,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":372,"context_line":"                context, router_id\u003drouter_ids)"},{"line_number":373,"context_line":"        if admin_state_up is not None:"},{"line_number":374,"context_line":"            for obj in record_objs:"},{"line_number":375,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":376,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":377,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            l3_agents \u003d [binding.l3_agent for binding in record_objs]"},{"line_number":380,"context_line":"        if active is not None:"},{"line_number":381,"context_line":"            l3_agents \u003d [l3_agent for l3_agent in"},{"line_number":382,"context_line":"                         l3_agents if not"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_2a4018a5","line":379,"range":{"start_line":370,"start_character":7,"end_line":379,"end_character":69},"in_reply_to":"1a6eadb0_1fc0ef7b","updated":"2016-12-23 21:00:47.000000000","message":"Fixed the code it\u0027s working now","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        return l3_agents"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":388,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":389,"context_line":"        if not router_ids:"},{"line_number":390,"context_line":"            return []"},{"line_number":391,"context_line":"        query \u003d context.session.query(rb_model.RouterL3AgentBinding)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_5fd7c7ec","line":388,"updated":"2016-12-20 14:08:48.000000000","message":"This can be converted in this PS.","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        return l3_agents"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    #TODO(dasanind):change the query to use objects"},{"line_number":388,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":389,"context_line":"        if not router_ids:"},{"line_number":390,"context_line":"            return []"},{"line_number":391,"context_line":"        query \u003d context.session.query(rb_model.RouterL3AgentBinding)"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_ce715be2","line":388,"in_reply_to":"1a6eadb0_5fd7c7ec","updated":"2016-12-23 21:00:47.000000000","message":"Done","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a47410fbcf107008e1934058a0f9165bb6540bb9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from neutron.db.models import l3agent as rb_model"},{"line_number":36,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":37,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":38,"context_line":"from neutron.objects import agent as ag_obj  # noqa"},{"line_number":39,"context_line":"from neutron.objects import base as objects_base"},{"line_number":40,"context_line":"from neutron.objects import l3agent as rb_obj"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_a187fe5f","line":38,"updated":"2017-01-02 16:09:42.000000000","message":"I guess this fixes the functional tests?","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ce991befdd6b9d00fd3305e1910e934d275abd84","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from neutron.db.models import l3agent as rb_model"},{"line_number":36,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":37,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":38,"context_line":"from neutron.objects import agent as ag_obj  # noqa"},{"line_number":39,"context_line":"from neutron.objects import base as objects_base"},{"line_number":40,"context_line":"from neutron.objects import l3agent as rb_obj"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_b9bc2ebc","line":38,"in_reply_to":"ba5201f7_a187fe5f","updated":"2017-01-12 17:17:54.000000000","message":"Yes","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a47410fbcf107008e1934058a0f9165bb6540bb9","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    # NOTE(dasanind): Moved the query as a classmethod in objects/l3agent.py"},{"line_number":385,"context_line":"    # until we figure out the way to deal with LEFT OUTER JOIN using OVO"},{"line_number":386,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        return (rb_obj.RouterL3AgentBinding"},{"line_number":389,"context_line":"                .get_l3_bindings_filter_by_router_ids(context, router_ids))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_44e660b5","line":386,"updated":"2017-01-02 16:09:42.000000000","message":"this method is only wrapping the object class method. Maybe we can get rid of this _get_l3_binding_hosting_routers and use in proper places the object class method?","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ce991befdd6b9d00fd3305e1910e934d275abd84","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    # NOTE(dasanind): Moved the query as a classmethod in objects/l3agent.py"},{"line_number":385,"context_line":"    # until we figure out the way to deal with LEFT OUTER JOIN using OVO"},{"line_number":386,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        return (rb_obj.RouterL3AgentBinding"},{"line_number":389,"context_line":"                .get_l3_bindings_filter_by_router_ids(context, router_ids))"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a57fde8_6d3a8238","line":386,"in_reply_to":"ba5201f7_44e660b5","updated":"2017-01-12 17:17:54.000000000","message":"Makes sense Done","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3b6f83acfdf9d5b078a326f7bb748039b17cab99","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":367,"context_line":"                context, router_id\u003drouter_ids)"},{"line_number":368,"context_line":"        if admin_state_up is not None:"},{"line_number":369,"context_line":"            for obj in record_objs:"},{"line_number":370,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":371,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":372,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":373,"context_line":"        else:"},{"line_number":374,"context_line":"            l3_agents \u003d [binding.l3_agent for binding in record_objs]"},{"line_number":375,"context_line":"        if active is not None:"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a461143_a85b7653","line":372,"range":{"start_line":369,"start_character":12,"end_line":372,"end_character":49},"updated":"2017-01-25 21:30:52.000000000","message":"instead of relying on l3_agent field, can\u0027t we have something like:\n\nl3_agents \u003d Agent.get_objects(context, id\u003d[obj.l3_agent_id for obj in record_objs], admin_state_up\u003dadmin_state_up)\n\nThen we don\u0027t want l3_agent field in the first place, and the code seems more logical.","commit_id":"e40a789b5b2461f9e43d33b3e480a16f824fbae4"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9080cbc0bdb8495f6cef4d192f46c30585e23769","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":367,"context_line":"                context, router_id\u003drouter_ids)"},{"line_number":368,"context_line":"        if admin_state_up is not None:"},{"line_number":369,"context_line":"            for obj in record_objs:"},{"line_number":370,"context_line":"                assoc_agent \u003d obj.l3_agent"},{"line_number":371,"context_line":"                if(assoc_agent.admin_state_up \u003d\u003d admin_state_up):"},{"line_number":372,"context_line":"                    l3_agents.append(assoc_agent)"},{"line_number":373,"context_line":"        else:"},{"line_number":374,"context_line":"            l3_agents \u003d [binding.l3_agent for binding in record_objs]"},{"line_number":375,"context_line":"        if active is not None:"}],"source_content_type":"text/x-python","patch_set":42,"id":"1a430d35_e0851107","line":372,"range":{"start_line":369,"start_character":12,"end_line":372,"end_character":49},"in_reply_to":"3a461143_a85b7653","updated":"2017-02-07 16:56:49.000000000","message":"Done","commit_id":"e40a789b5b2461f9e43d33b3e480a16f824fbae4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"029524ca1fe2d908618420f8c426205acc38b477","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":39,"context_line":"from neutron.objects import agent as ag_obj"},{"line_number":40,"context_line":"from neutron.objects import base as objects_base"},{"line_number":41,"context_line":"from neutron.objects import l3agent as rb_obj"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"da36d5c6_569e2757","line":40,"updated":"2017-02-20 07:24:20.000000000","message":"sorry to nit pick here but can we have some kind of consistency for the object import names. maybe consider base_obj","commit_id":"ad62be4855f10d527220d2abf44d51b511203b3e"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5187d3dbbf1cbbe3b76a6ca12c284770456260d6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":39,"context_line":"from neutron.objects import agent as ag_obj"},{"line_number":40,"context_line":"from neutron.objects import base as objects_base"},{"line_number":41,"context_line":"from neutron.objects import l3agent as rb_obj"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"ba2be162_50afd993","line":40,"in_reply_to":"da36d5c6_569e2757","updated":"2017-03-01 23:34:48.000000000","message":"Done","commit_id":"ad62be4855f10d527220d2abf44d51b511203b3e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"029524ca1fe2d908618420f8c426205acc38b477","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                    router_id\u003drouter_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def list_routers_on_l3_agent(self, context, agent_id):"},{"line_number":296,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":297,"context_line":"                context, l3_agent_id\u003dagent_id)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        router_ids \u003d [item.router_id for item in record_objs]"}],"source_content_type":"text/x-python","patch_set":50,"id":"da36d5c6_d6aa1770","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":14},"updated":"2017-02-20 07:24:20.000000000","message":"record? router no?","commit_id":"ad62be4855f10d527220d2abf44d51b511203b3e"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5187d3dbbf1cbbe3b76a6ca12c284770456260d6","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                    router_id\u003drouter_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def list_routers_on_l3_agent(self, context, agent_id):"},{"line_number":296,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":297,"context_line":"                context, l3_agent_id\u003dagent_id)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        router_ids \u003d [item.router_id for item in record_objs]"}],"source_content_type":"text/x-python","patch_set":50,"id":"ba2be162_b0fd753c","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":14},"in_reply_to":"da36d5c6_d6aa1770","updated":"2017-03-01 23:34:48.000000000","message":"changed it to binding_objs","commit_id":"ad62be4855f10d527220d2abf44d51b511203b3e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6270f76b6f7c7a999433ce413027dd476300635e","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        return bindings"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def list_l3_agents_hosting_router(self, context, router_id):"},{"line_number":376,"context_line":"        #with context.session.begin(subtransactions\u003dTrue):"},{"line_number":377,"context_line":"        bindings \u003d self._get_l3_bindings_hosting_routers("},{"line_number":378,"context_line":"            context, [router_id])"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"ffe62b97_00109b00","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":9},"updated":"2017-03-27 12:38:15.000000000","message":"why remove transaction from here?","commit_id":"04cfaf0d776128cab9f1964a8d32720685ed0c1b"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b5ff511a0e098dd3348bdbfe410947a4c37ae8ca","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        return bindings"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def list_l3_agents_hosting_router(self, context, router_id):"},{"line_number":376,"context_line":"        #with context.session.begin(subtransactions\u003dTrue):"},{"line_number":377,"context_line":"        bindings \u003d self._get_l3_bindings_hosting_routers("},{"line_number":378,"context_line":"            context, [router_id])"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"5ff73747_63935651","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":9},"in_reply_to":"ffe62b97_00109b00","updated":"2017-04-21 23:31:41.000000000","message":"Added it back","commit_id":"04cfaf0d776128cab9f1964a8d32720685ed0c1b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":86,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":87,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":88,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":89,"context_line":"            return rb_obj.RouterL3AgentBinding.get_down_router_bindings("},{"line_number":90,"context_line":"                   context, cutoff, agent_dead_limit)"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_d3b84577","line":87,"range":{"start_line":86,"start_character":8,"end_line":87,"end_character":66},"updated":"2017-04-26 18:02:53.000000000","message":"I think we should now clean that up","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":86,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":87,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":88,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":89,"context_line":"            return rb_obj.RouterL3AgentBinding.get_down_router_bindings("},{"line_number":90,"context_line":"                   context, cutoff, agent_dead_limit)"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_f1794393","line":87,"range":{"start_line":86,"start_character":8,"end_line":87,"end_character":66},"in_reply_to":"5ff73747_d3b84577","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        filters \u003d {\u0027l3_agent_id\u0027: agent.id}"},{"line_number":314,"context_line":"        if router_ids:"},{"line_number":315,"context_line":"            filters[\u0027router_id\u0027] \u003d router_ids"},{"line_number":316,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":317,"context_line":"                context, **filters)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        return [item.router_id for item in record_objs]"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_732051b1","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":14},"updated":"2017-04-26 18:02:53.000000000","message":"not sure what \u0027record\u0027 means here. Maybe binding_objs?","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        filters \u003d {\u0027l3_agent_id\u0027: agent.id}"},{"line_number":314,"context_line":"        if router_ids:"},{"line_number":315,"context_line":"            filters[\u0027router_id\u0027] \u003d router_ids"},{"line_number":316,"context_line":"        record_objs \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":317,"context_line":"                context, **filters)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        return [item.router_id for item in record_objs]"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_315fbb0f","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":14},"in_reply_to":"5ff73747_732051b1","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        l3_agents \u003d []"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            l3_agents \u003d ag_obj.Agent.get_objects(context,"},{"line_number":353,"context_line":"                     id\u003d[obj.l3_agent_id for obj in record_objs],"},{"line_number":354,"context_line":"                     admin_state_up\u003dadmin_state_up)"},{"line_number":355,"context_line":"        else:"},{"line_number":356,"context_line":"            for obj in record_objs:"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_66376de5","line":353,"updated":"2017-04-26 18:02:53.000000000","message":"nit: wrapping here is not too conventional","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        l3_agents \u003d []"},{"line_number":351,"context_line":"        if admin_state_up is not None:"},{"line_number":352,"context_line":"            l3_agents \u003d ag_obj.Agent.get_objects(context,"},{"line_number":353,"context_line":"                     id\u003d[obj.l3_agent_id for obj in record_objs],"},{"line_number":354,"context_line":"                     admin_state_up\u003dadmin_state_up)"},{"line_number":355,"context_line":"        else:"},{"line_number":356,"context_line":"            for obj in record_objs:"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_119a77c4","line":353,"in_reply_to":"5ff73747_66376de5","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                             l3_agent[\u0027heartbeat_timestamp\u0027])]"},{"line_number":364,"context_line":"        return l3_agents"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":367,"context_line":"        if not router_ids:"},{"line_number":368,"context_line":"            return []"},{"line_number":369,"context_line":"        bindings \u003d (rb_obj.RouterL3AgentBinding"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_e6081dda","line":366,"updated":"2017-04-26 18:02:53.000000000","message":"I think this method now returns agent sqlalchemy records. But I think the right thing to do here is making the get_l3_bindings_filter_by_router_ids return actual bindings; or make it return Agent objects (and then get named differently).","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                             l3_agent[\u0027heartbeat_timestamp\u0027])]"},{"line_number":364,"context_line":"        return l3_agents"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _get_l3_bindings_hosting_routers(self, context, router_ids):"},{"line_number":367,"context_line":"        if not router_ids:"},{"line_number":368,"context_line":"            return []"},{"line_number":369,"context_line":"        bindings \u003d (rb_obj.RouterL3AgentBinding"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_31721b13","line":366,"in_reply_to":"5ff73747_e6081dda","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        if not router_ids:"},{"line_number":368,"context_line":"            return []"},{"line_number":369,"context_line":"        bindings \u003d (rb_obj.RouterL3AgentBinding"},{"line_number":370,"context_line":"                    .get_l3_bindings_filter_by_router_ids(context, router_ids))"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        return bindings"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_466471e4","line":370,"updated":"2017-04-26 18:02:53.000000000","message":"wrapping could be refined a bit here","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        if not router_ids:"},{"line_number":368,"context_line":"            return []"},{"line_number":369,"context_line":"        bindings \u003d (rb_obj.RouterL3AgentBinding"},{"line_number":370,"context_line":"                    .get_l3_bindings_filter_by_router_ids(context, router_ids))"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        return bindings"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_d1f19f03","line":370,"in_reply_to":"5ff73747_466471e4","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def list_l3_agents_hosting_router(self, context, router_id):"},{"line_number":375,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":376,"context_line":"            bindings \u003d self._get_l3_bindings_hosting_routers("},{"line_number":377,"context_line":"                context, [router_id])"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        return {\u0027agents\u0027: [self._make_agent_dict(binding) for"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_66f40dd0","line":376,"updated":"2017-04-26 18:02:53.000000000","message":"a reader may think that we pass binding objects in line 379, but \u0027bindings\u0027 is really now a list of L3Agent sqlalchemy records...","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def list_l3_agents_hosting_router(self, context, router_id):"},{"line_number":375,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":376,"context_line":"            bindings \u003d self._get_l3_bindings_hosting_routers("},{"line_number":377,"context_line":"                context, [router_id])"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        return {\u0027agents\u0027: [self._make_agent_dict(binding) for"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_117837f6","line":376,"in_reply_to":"5ff73747_66f40dd0","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/db/l3_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"37f1b38d3ffd227c180a922a5d9851ae92068804","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":428,"context_line":"            gw_port \u003d router.gw_port"},{"line_number":429,"context_line":"            router.gw_port \u003d None"},{"line_number":430,"context_line":"            if router not in context.session:"},{"line_number":431,"context_line":"                context.session.add(router)"},{"line_number":432,"context_line":"            context.session.expire(gw_port)"},{"line_number":433,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_38cc2bbb","line":430,"updated":"2017-04-25 02:50:20.000000000","message":"This function definitely needs to be cleaned up in another patch to just not deal with sqla objects.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"be82655226408d96086410fdae4741da6f6af64b","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        if removed_hosts:"},{"line_number":519,"context_line":"            agents \u003d plugin.get_l3_agents(context,"},{"line_number":520,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":521,"context_line":"            snat_binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":522,"context_line":"                context, router_id\u003drouter_id)).next()"},{"line_number":523,"context_line":"            for agent in agents:"},{"line_number":524,"context_line":"                is_this_snat_agent \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_5c14ff9e","line":521,"updated":"2016-11-09 22:20:24.000000000","message":"May I know why iter() and .next() is used here? Is it because the first object from get_objects() returned list is needed?","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b80750fd403b476b28da02b58ef296c0ecabd331","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        if removed_hosts:"},{"line_number":519,"context_line":"            agents \u003d plugin.get_l3_agents(context,"},{"line_number":520,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":521,"context_line":"            snat_binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":522,"context_line":"                context, router_id\u003drouter_id)).next()"},{"line_number":523,"context_line":"            for agent in agents:"},{"line_number":524,"context_line":"                is_this_snat_agent \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_c080d08d","line":521,"in_reply_to":"9a629dbe_5c14ff9e","updated":"2016-11-11 17:28:10.000000000","message":"Yes. I cannot use get_object as it needs Primary Keys. So I am using get_objects and taking the first one","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"56993eea4e919d9830913015a49480119d44224c","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        if removed_hosts:"},{"line_number":519,"context_line":"            agents \u003d plugin.get_l3_agents(context,"},{"line_number":520,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":521,"context_line":"            snat_binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":522,"context_line":"                context, router_id\u003drouter_id)).next()"},{"line_number":523,"context_line":"            for agent in agents:"},{"line_number":524,"context_line":"                is_this_snat_agent \u003d ("}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_7ec87c55","line":521,"updated":"2016-11-11 20:03:20.000000000","message":"Can you please tell why iter is used? To get the first object in the list of objects?","commit_id":"52411a0eb27fbc1345792d7ecb09011f6ef0670c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"5a684cbe9298e2a8f5703ef618db7e3ed2fb7ac1","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        if removed_hosts:"},{"line_number":519,"context_line":"            agents \u003d plugin.get_l3_agents(context,"},{"line_number":520,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":521,"context_line":"            snat_binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":522,"context_line":"                context, router_id\u003drouter_id)).next()"},{"line_number":523,"context_line":"            for agent in agents:"},{"line_number":524,"context_line":"                is_this_snat_agent \u003d ("}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_14bab723","line":521,"in_reply_to":"9a629dbe_7ec87c55","updated":"2016-11-15 21:49:14.000000000","message":"I replied in PS13 :)\nYes. I cannot use get_object as it needs Primary Keys. So I am using get_objects and taking the first one","commit_id":"52411a0eb27fbc1345792d7ecb09011f6ef0670c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        if removed_hosts:"},{"line_number":436,"context_line":"            agents \u003d plugin.get_l3_agents(context,"},{"line_number":437,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":438,"context_line":"            snat_binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":439,"context_line":"                context, router_id\u003drouter_id)).next()"},{"line_number":440,"context_line":"            for agent in agents:"},{"line_number":441,"context_line":"                is_this_snat_agent \u003d ("},{"line_number":442,"context_line":"                    snat_binding and snat_binding.l3_agent_id \u003d\u003d agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_250f5e2f","line":439,"range":{"start_line":438,"start_character":12,"end_line":439,"end_character":53},"updated":"2016-12-20 14:08:48.000000000","message":"What if get_objects return empty list? It should be rewritten at least to:\nnext(iter(rb_obj.RouterL3AgentBinding.get_objects(\n                context, router_id\u003drouter_id), None)\n\nor:\nbindings \u003d rb_obj.RouterL3AgentBinding.get_objects(\n                context, router_id\u003drouter_id)\nsnat_binding \u003d bindings.pop() if bindings or None","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        if removed_hosts:"},{"line_number":436,"context_line":"            agents \u003d plugin.get_l3_agents(context,"},{"line_number":437,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":438,"context_line":"            snat_binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":439,"context_line":"                context, router_id\u003drouter_id)).next()"},{"line_number":440,"context_line":"            for agent in agents:"},{"line_number":441,"context_line":"                is_this_snat_agent \u003d ("},{"line_number":442,"context_line":"                    snat_binding and snat_binding.l3_agent_id \u003d\u003d agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_0aba746e","line":439,"range":{"start_line":438,"start_character":12,"end_line":439,"end_character":53},"in_reply_to":"1a6eadb0_250f5e2f","updated":"2016-12-23 21:00:47.000000000","message":"Done","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a47410fbcf107008e1934058a0f9165bb6540bb9","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":438,"context_line":"            bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":439,"context_line":"                context, router_id\u003drouter_id)"},{"line_number":440,"context_line":"            snat_binding \u003d None"},{"line_number":441,"context_line":"            if bindings:"},{"line_number":442,"context_line":"                snat_binding \u003d bindings.pop()"},{"line_number":443,"context_line":"            for agent in agents:"},{"line_number":444,"context_line":"                is_this_snat_agent \u003d ("},{"line_number":445,"context_line":"                    snat_binding and snat_binding.l3_agent_id \u003d\u003d agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_2194ee89","line":442,"range":{"start_line":440,"start_character":12,"end_line":442,"end_character":45},"updated":"2017-01-02 16:09:42.000000000","message":"This looks better:\n\n    snat_binding \u003d bindings.pop() if bindings or None","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ce991befdd6b9d00fd3305e1910e934d275abd84","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                                          filters\u003d{\u0027host\u0027: removed_hosts})"},{"line_number":438,"context_line":"            bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":439,"context_line":"                context, router_id\u003drouter_id)"},{"line_number":440,"context_line":"            snat_binding \u003d None"},{"line_number":441,"context_line":"            if bindings:"},{"line_number":442,"context_line":"                snat_binding \u003d bindings.pop()"},{"line_number":443,"context_line":"            for agent in agents:"},{"line_number":444,"context_line":"                is_this_snat_agent \u003d ("},{"line_number":445,"context_line":"                    snat_binding and snat_binding.l3_agent_id \u003d\u003d agent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_5c6a5082","line":442,"range":{"start_line":440,"start_character":12,"end_line":442,"end_character":45},"in_reply_to":"ba5201f7_2194ee89","updated":"2017-01-12 17:17:54.000000000","message":"I get the following error [1] when I write it in the above format. Am I missing something?\n\n[1] http://paste.openstack.org/show/594640/","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"46ccda02c6ef86531142d1207fdf1f47e9e79a78","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                    LOG.debug(\u0027No snat is bound to router %s\u0027, rtr[\u0027id\u0027])"},{"line_number":488,"context_line":"                    continue"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"                l3_agent \u003d ag_obj.Agent.get_object(context,"},{"line_number":491,"context_line":"                        id\u003dbinding.l3_agent_id)"},{"line_number":492,"context_line":"                rtr[\u0027gw_port_host\u0027] \u003d l3_agent.host"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        return routers"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"ffe62b97_08fcb96d","line":492,"range":{"start_line":490,"start_character":1,"end_line":492,"end_character":51},"updated":"2017-03-30 00:29:26.000000000","message":"replaced this by\n rtr[\u0027gw_port_host\u0027] \u003d binding.l3_agent.host \n\nAnd py27 neutron.tests.unit.objects works fine.","commit_id":"04cfaf0d776128cab9f1964a8d32720685ed0c1b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        if not routers:"},{"line_number":586,"context_line":"            return []"},{"line_number":587,"context_line":"        router_ids \u003d [r[\u0027id\u0027] for r in routers]"},{"line_number":588,"context_line":"        query \u003d rb_obj.RouterL3AgentBinding.get_objects(context,"},{"line_number":589,"context_line":"                 router_id\u003drouter_ids)"},{"line_number":590,"context_line":"        bindings \u003d dict((b.router_id, b) for b in query)"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_4677d103","line":588,"range":{"start_line":588,"start_character":8,"end_line":588,"end_character":13},"updated":"2017-04-26 18:02:53.000000000","message":"should be renamed into something more applicable to the new type of the variable. Maybe \u0027binding_objs\u0027 or \u0027bindings\u0027.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        if not routers:"},{"line_number":586,"context_line":"            return []"},{"line_number":587,"context_line":"        router_ids \u003d [r[\u0027id\u0027] for r in routers]"},{"line_number":588,"context_line":"        query \u003d rb_obj.RouterL3AgentBinding.get_objects(context,"},{"line_number":589,"context_line":"                 router_id\u003drouter_ids)"},{"line_number":590,"context_line":"        bindings \u003d dict((b.router_id, b) for b in query)"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_d15abf81","line":588,"range":{"start_line":588,"start_character":8,"end_line":588,"end_character":13},"in_reply_to":"5ff73747_4677d103","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        router_ids \u003d [r[\u0027id\u0027] for r in routers]"},{"line_number":588,"context_line":"        query \u003d rb_obj.RouterL3AgentBinding.get_objects(context,"},{"line_number":589,"context_line":"                 router_id\u003drouter_ids)"},{"line_number":590,"context_line":"        bindings \u003d dict((b.router_id, b) for b in query)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        for rtr in routers:"},{"line_number":593,"context_line":"            gw_port_id \u003d rtr[\u0027gw_port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_4650f15d","line":590,"range":{"start_line":590,"start_character":8,"end_line":590,"end_character":16},"updated":"2017-04-26 18:02:53.000000000","message":"(No action required) that name doesn\u0027t reflect what\u0027s inside (it would probably be better if it would be named e.g. \u0027binding_map\u0027).","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        router_ids \u003d [r[\u0027id\u0027] for r in routers]"},{"line_number":588,"context_line":"        query \u003d rb_obj.RouterL3AgentBinding.get_objects(context,"},{"line_number":589,"context_line":"                 router_id\u003drouter_ids)"},{"line_number":590,"context_line":"        bindings \u003d dict((b.router_id, b) for b in query)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        for rtr in routers:"},{"line_number":593,"context_line":"            gw_port_id \u003d rtr[\u0027gw_port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_91d9e7f5","line":590,"range":{"start_line":590,"start_character":8,"end_line":590,"end_character":16},"in_reply_to":"5ff73747_4650f15d","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b004b846398592dc8f9db8a1af13e65492a22a90","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        removed_router_info \u003d []"},{"line_number":167,"context_line":"        for router_id in router_ids:"},{"line_number":168,"context_line":"            snat_binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":169,"context_line":"                        context,"},{"line_number":170,"context_line":"                        router_id\u003drouter_id,"},{"line_number":171,"context_line":"                        l3_agent_id\u003dagent.id)"},{"line_number":172,"context_line":"            if snat_binding:"},{"line_number":173,"context_line":"                # not removing from the agent hosting SNAT for the router"},{"line_number":174,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_99025008","line":171,"range":{"start_line":169,"start_character":0,"end_line":171,"end_character":45},"updated":"2016-10-19 15:51:35.000000000","message":"nit: This seems to have wrong identation","commit_id":"18b4bdb1f311ae858453417bb4799247f5bae75b"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"fc7a9e652f66cbdcdb1f29a494e1cb70171f86a3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":166,"context_line":"        removed_router_info \u003d []"},{"line_number":167,"context_line":"        for router_id in router_ids:"},{"line_number":168,"context_line":"            snat_binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":169,"context_line":"                        context,"},{"line_number":170,"context_line":"                        router_id\u003drouter_id,"},{"line_number":171,"context_line":"                        l3_agent_id\u003dagent.id)"},{"line_number":172,"context_line":"            if snat_binding:"},{"line_number":173,"context_line":"                # not removing from the agent hosting SNAT for the router"},{"line_number":174,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_b49e6354","line":171,"range":{"start_line":168,"start_character":1,"end_line":171,"end_character":45},"updated":"2016-11-16 00:21:20.000000000","message":"how about?\n            snat_binding \u003d rb_obj.RouterL3AgentBinding.get_object(\n                context, router_id\u003drouter_id, l3_agent_id\u003dagent.id)","commit_id":"c617c1a94ca8bf6d85d1b3360e0ad10bbe35f9e7"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"aca8fa87a0bca40410ad31877972c1293bec454e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":166,"context_line":"        removed_router_info \u003d []"},{"line_number":167,"context_line":"        for router_id in router_ids:"},{"line_number":168,"context_line":"            snat_binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":169,"context_line":"                        context,"},{"line_number":170,"context_line":"                        router_id\u003drouter_id,"},{"line_number":171,"context_line":"                        l3_agent_id\u003dagent.id)"},{"line_number":172,"context_line":"            if snat_binding:"},{"line_number":173,"context_line":"                # not removing from the agent hosting SNAT for the router"},{"line_number":174,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_32dafde8","line":171,"range":{"start_line":168,"start_character":1,"end_line":171,"end_character":45},"in_reply_to":"7a77a97e_b49e6354","updated":"2016-11-28 06:21:26.000000000","message":"it\u0027s easier to read this way","commit_id":"c617c1a94ca8bf6d85d1b3360e0ad10bbe35f9e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":164,"context_line":"        removed_router_info \u003d []"},{"line_number":165,"context_line":"        for router_id in router_ids:"},{"line_number":166,"context_line":"            snat_binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":167,"context_line":"                        context,"},{"line_number":168,"context_line":"                        router_id\u003drouter_id,"},{"line_number":169,"context_line":"                        l3_agent_id\u003dagent.id)"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_069669f1","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":24},"updated":"2017-04-26 18:02:53.000000000","message":"since all we care about is whether the object exists, better to use .objects_exist method instead of .get_object.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            context, n_const.AGENT_TYPE_L3, port_host)"},{"line_number":164,"context_line":"        removed_router_info \u003d []"},{"line_number":165,"context_line":"        for router_id in router_ids:"},{"line_number":166,"context_line":"            snat_binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":167,"context_line":"                        context,"},{"line_number":168,"context_line":"                        router_id\u003drouter_id,"},{"line_number":169,"context_line":"                        l3_agent_id\u003dagent.id)"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_71ff7334","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":24},"in_reply_to":"5ff73747_069669f1","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/db/l3_hascheduler_db.py":[{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"29b1a44a36495b68098b4831ed74a1f7b341b7b6","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    #TODO(dasanind): Change it to objects once Router, Agent OVO is available"},{"line_number":34,"context_line":"    def get_ha_routers_l3_agents_count(self, context):"},{"line_number":35,"context_line":"        \"\"\"Return a map between HA routers and how many agents every"},{"line_number":36,"context_line":"        router is scheduled to."}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_51fce071","line":33,"updated":"2017-01-05 19:10:14.000000000","message":"This part is taken care of here in patch: [1]\n\n[1] - https://review.openstack.org/#/c/381209/17/neutron/db/l3_hascheduler_db.py@43","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def get_l3_agents_ordered_by_num_routers(self, context, agent_ids):"},{"line_number":29,"context_line":"        if not agent_ids:"},{"line_number":30,"context_line":"            return []"},{"line_number":31,"context_line":"        l3_agents \u003d ag_obj.Agent.get_l3_agents_ordered_by_num_routers(context,"},{"line_number":32,"context_line":"                agent_ids)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        return l3_agents"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_46ac7133","line":31,"updated":"2017-04-26 18:02:53.000000000","message":"nit: wrapping is not conventional here (better to wrap on \u0027(\u0027 brace and use 4-space indentation).","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def get_l3_agents_ordered_by_num_routers(self, context, agent_ids):"},{"line_number":29,"context_line":"        if not agent_ids:"},{"line_number":30,"context_line":"            return []"},{"line_number":31,"context_line":"        l3_agents \u003d ag_obj.Agent.get_l3_agents_ordered_by_num_routers(context,"},{"line_number":32,"context_line":"                agent_ids)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        return l3_agents"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_d19d1f0b","line":31,"in_reply_to":"5ff73747_46ac7133","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            return []"},{"line_number":31,"context_line":"        l3_agents \u003d ag_obj.Agent.get_l3_agents_ordered_by_num_routers(context,"},{"line_number":32,"context_line":"                agent_ids)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        return l3_agents"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _get_agents_dict_for_router(self, agents_and_states):"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_86603903","line":33,"updated":"2017-04-26 18:02:53.000000000","message":"nit: this line doesn\u0027t seem too helpful. Overall, can\u0027t you just return the result of the method call right away wihout storing it in a variable?","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            return []"},{"line_number":31,"context_line":"        l3_agents \u003d ag_obj.Agent.get_l3_agents_ordered_by_num_routers(context,"},{"line_number":32,"context_line":"                agent_ids)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        return l3_agents"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _get_agents_dict_for_router(self, agents_and_states):"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_b1a2ab4a","line":33,"in_reply_to":"5ff73747_86603903","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":49,"context_line":"                    context, router_id)"},{"line_number":50,"context_line":"            else:"},{"line_number":51,"context_line":"                bindings \u003d self._get_l3_bindings_hosting_routers("},{"line_number":52,"context_line":"                    context, [router_id])"},{"line_number":53,"context_line":"                bindings \u003d [(binding, None) for binding in bindings]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_e61dbd73","line":51,"updated":"2017-04-26 18:02:53.000000000","message":"if only that method would actually return bindings, the line 53 would be broken. But the method returns agents despite the name...","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                bindings \u003d self.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":49,"context_line":"                    context, router_id)"},{"line_number":50,"context_line":"            else:"},{"line_number":51,"context_line":"                bindings \u003d self._get_l3_bindings_hosting_routers("},{"line_number":52,"context_line":"                    context, [router_id])"},{"line_number":53,"context_line":"                bindings \u003d [(binding, None) for binding in bindings]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_11bdd767","line":51,"in_reply_to":"5ff73747_e61dbd73","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/objects/agent.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"46ccda02c6ef86531142d1207fdf1f47e9e79a78","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                group_by(agent_model.Agent.id)."},{"line_number":105,"context_line":"                filter(agent_model.Agent.id.in_(agent_ids))."},{"line_number":106,"context_line":"                order_by(\u0027count\u0027))"},{"line_number":107,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":58,"id":"ffe62b97_c87ed1ad","line":107,"range":{"start_line":107,"start_character":7,"end_line":107,"end_character":75},"updated":"2017-03-30 00:29:26.000000000","message":"afaiu this code has been moved to class method from [1] because it has outer join. Can you please explain why cls._load_object is being used instead of existing code [2] \"return [record[0] for record in query]\" ?\n\n[1]\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_hascheduler_db.py#L30-#L41\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/l3_hascheduler_db.py#L41","commit_id":"04cfaf0d776128cab9f1964a8d32720685ed0c1b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        return agent_obj"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @classmethod"},{"line_number":98,"context_line":"    def get_l3_agents_ordered_by_num_routers(cls, context, agent_ids):"},{"line_number":99,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":100,"context_line":"            query \u003d (context.session.query(agent_model.Agent, func.count("},{"line_number":101,"context_line":"                rb_model.RouterL3AgentBinding.router_id)"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_c6b2c1e6","line":98,"updated":"2017-04-26 18:02:53.000000000","message":"(No action required) those could probably rely on the same query (get_l3_agent_with_min_routers being a special case of get_l3_agents_ordered_by_num_routers) but I understand that you probably don\u0027t want to refactor it as part of this patch.\n\nMaybe worth a comment suggesting reusing the query.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        return agent_obj"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @classmethod"},{"line_number":98,"context_line":"    def get_l3_agents_ordered_by_num_routers(cls, context, agent_ids):"},{"line_number":99,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":100,"context_line":"            query \u003d (context.session.query(agent_model.Agent, func.count("},{"line_number":101,"context_line":"                rb_model.RouterL3AgentBinding.router_id)"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_51aa2f19","line":98,"in_reply_to":"5ff73747_c6b2c1e6","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/objects/l3agent.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a47410fbcf107008e1934058a0f9165bb6540bb9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        query \u003d context.session.query(l3agent.RouterL3AgentBinding)"},{"line_number":46,"context_line":"        query \u003d query.options(joinedload(\u0027l3_agent\u0027)).filter("},{"line_number":47,"context_line":"            l3agent.RouterL3AgentBinding.router_id.in_(router_ids))"},{"line_number":48,"context_line":"        return query.all()"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_e4d674c4","line":48,"updated":"2017-01-02 16:09:42.000000000","message":"Do we want to return DB or OVO object? I would prefer the latter.","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ce991befdd6b9d00fd3305e1910e934d275abd84","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        query \u003d context.session.query(l3agent.RouterL3AgentBinding)"},{"line_number":46,"context_line":"        query \u003d query.options(joinedload(\u0027l3_agent\u0027)).filter("},{"line_number":47,"context_line":"            l3agent.RouterL3AgentBinding.router_id.in_(router_ids))"},{"line_number":48,"context_line":"        return query.all()"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a57fde8_c3f25f9a","line":48,"in_reply_to":"ba5201f7_e4d674c4","updated":"2017-01-12 17:17:54.000000000","message":"Done","commit_id":"ef2b2e86ac64725608cff51c8cf71157dc5548ec"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        query \u003d context.session.query(l3agent.RouterL3AgentBinding)"},{"line_number":46,"context_line":"        query \u003d query.options(joinedload(\u0027l3_agent\u0027)).filter("},{"line_number":47,"context_line":"            l3agent.RouterL3AgentBinding.router_id.in_(router_ids))"},{"line_number":48,"context_line":"        bindings \u003d [db_obj.l3_agent for db_obj in query.all()]"},{"line_number":49,"context_line":"        return bindings"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_26bba50e","line":48,"updated":"2017-04-26 18:02:53.000000000","message":"it seems like you return agent sqlalchemy models here, not bindings, and not objects. Should we convert those to Agent objects before returning, and rename the method to reflect the return value type?","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        query \u003d context.session.query(l3agent.RouterL3AgentBinding)"},{"line_number":46,"context_line":"        query \u003d query.options(joinedload(\u0027l3_agent\u0027)).filter("},{"line_number":47,"context_line":"            l3agent.RouterL3AgentBinding.router_id.in_(router_ids))"},{"line_number":48,"context_line":"        bindings \u003d [db_obj.l3_agent for db_obj in query.all()]"},{"line_number":49,"context_line":"        return bindings"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_676fb192","line":48,"in_reply_to":"5ff73747_26bba50e","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return bindings"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def get_down_router_bindings(cls, context, cutoff, agent_dead_limit):"},{"line_number":53,"context_line":"        query \u003d (context.session.query("},{"line_number":54,"context_line":"                 l3agent.RouterL3AgentBinding)."},{"line_number":55,"context_line":"                 join(agent_model.Agent)."}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_73ff3134","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":71},"updated":"2017-04-26 18:02:53.000000000","message":"I don\u0027t see it ever used.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return bindings"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def get_down_router_bindings(cls, context, cutoff, agent_dead_limit):"},{"line_number":53,"context_line":"        query \u003d (context.session.query("},{"line_number":54,"context_line":"                 l3agent.RouterL3AgentBinding)."},{"line_number":55,"context_line":"                 join(agent_model.Agent)."}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_b1706bde","line":52,"range":{"start_line":52,"start_character":53,"end_line":52,"end_character":71},"in_reply_to":"5ff73747_73ff3134","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                     l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.false(),"},{"line_number":63,"context_line":"                     l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.null())))"},{"line_number":64,"context_line":"        bindings \u003d [cls._load_object(context, db_obj) for db_obj in"},{"line_number":65,"context_line":"                query.all()]"},{"line_number":66,"context_line":"        return bindings"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_491da264","line":65,"updated":"2017-04-26 18:02:53.000000000","message":"the wrapping here is not ideal. Consider:\n\nreturn [\n    cls._load_object(...)\n    for db_obj in query.all()\n]","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                     l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.false(),"},{"line_number":63,"context_line":"                     l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.null())))"},{"line_number":64,"context_line":"        bindings \u003d [cls._load_object(context, db_obj) for db_obj in"},{"line_number":65,"context_line":"                query.all()]"},{"line_number":66,"context_line":"        return bindings"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_d144ff76","line":65,"in_reply_to":"5ff73747_491da264","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        RouterL3AgentBinding object to the database."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":230,"context_line":"                context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":231,"context_line":"        if bindings:"},{"line_number":232,"context_line":"            LOG.debug(\u0027Router %(router_id)s has already been scheduled \u0027"},{"line_number":233,"context_line":"                      \u0027to L3 agent %(agent_id)s.\u0027,"},{"line_number":234,"context_line":"                      {\u0027router_id\u0027: router_id, \u0027agent_id\u0027: agent_id})"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_a52fee3c","line":231,"range":{"start_line":229,"start_character":8,"end_line":231,"end_character":20},"updated":"2016-12-20 14:08:48.000000000","message":"you can use objects_exist here.","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        RouterL3AgentBinding object to the database."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        bindings \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":230,"context_line":"                context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":231,"context_line":"        if bindings:"},{"line_number":232,"context_line":"            LOG.debug(\u0027Router %(router_id)s has already been scheduled \u0027"},{"line_number":233,"context_line":"                      \u0027to L3 agent %(agent_id)s.\u0027,"},{"line_number":234,"context_line":"                      {\u0027router_id\u0027: router_id, \u0027agent_id\u0027: agent_id})"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_0a16f454","line":231,"range":{"start_line":229,"start_character":8,"end_line":231,"end_character":20},"in_reply_to":"1a6eadb0_a52fee3c","updated":"2016-12-23 21:00:47.000000000","message":"Done","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0aad296fd61aa35010cbe44f29749ff9bd5be524","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        if not is_ha:"},{"line_number":238,"context_line":"            binding_index \u003d rb_model.LOWEST_BINDING_INDEX"},{"line_number":239,"context_line":"            bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":240,"context_line":"                context, router_id\u003drouter_id,"},{"line_number":241,"context_line":"                binding_index\u003dbinding_index)"},{"line_number":242,"context_line":"            if bindings:"},{"line_number":243,"context_line":"                LOG.debug(\u0027Non-HA router %s has already been scheduled\u0027,"},{"line_number":244,"context_line":"                          router_id)"},{"line_number":245,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_e5e006fd","line":242,"range":{"start_line":239,"start_character":12,"end_line":242,"end_character":24},"updated":"2016-12-20 14:08:48.000000000","message":"ditto line 231.","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"7673e7836474e0c653c17f2a65f27d681064b586","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        if not is_ha:"},{"line_number":238,"context_line":"            binding_index \u003d rb_model.LOWEST_BINDING_INDEX"},{"line_number":239,"context_line":"            bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":240,"context_line":"                context, router_id\u003drouter_id,"},{"line_number":241,"context_line":"                binding_index\u003dbinding_index)"},{"line_number":242,"context_line":"            if bindings:"},{"line_number":243,"context_line":"                LOG.debug(\u0027Non-HA router %s has already been scheduled\u0027,"},{"line_number":244,"context_line":"                          router_id)"},{"line_number":245,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_253bebd2","line":242,"range":{"start_line":239,"start_character":12,"end_line":242,"end_character":24},"in_reply_to":"1a6eadb0_e5e006fd","updated":"2016-12-23 21:00:47.000000000","message":"Done","commit_id":"9cd46c3b397fad7a04bb311510c5a3c2d0a2acac"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        RouterL3AgentBinding object to the database."},{"line_number":191,"context_line":"        \"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if(rb_obj.RouterL3AgentBinding.objects_exist("},{"line_number":194,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)):"},{"line_number":195,"context_line":"            LOG.debug(\u0027Router %(router_id)s has already been scheduled \u0027"},{"line_number":196,"context_line":"                      \u0027to L3 agent %(agent_id)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_293136ed","line":193,"range":{"start_line":193,"start_character":10,"end_line":193,"end_character":11},"updated":"2017-04-26 18:02:53.000000000","message":"I guess the brace (and its closing counterpart) are not needed. Replace with a space.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        RouterL3AgentBinding object to the database."},{"line_number":191,"context_line":"        \"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if(rb_obj.RouterL3AgentBinding.objects_exist("},{"line_number":194,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)):"},{"line_number":195,"context_line":"            LOG.debug(\u0027Router %(router_id)s has already been scheduled \u0027"},{"line_number":196,"context_line":"                      \u0027to L3 agent %(agent_id)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_b1498b8c","line":193,"range":{"start_line":193,"start_character":10,"end_line":193,"end_character":11},"in_reply_to":"5ff73747_293136ed","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not is_ha:"},{"line_number":201,"context_line":"            binding_index \u003d rb_model.LOWEST_BINDING_INDEX"},{"line_number":202,"context_line":"            if(rb_obj.RouterL3AgentBinding.objects_exist("},{"line_number":203,"context_line":"                context, router_id\u003drouter_id, binding_index\u003dbinding_index)):"},{"line_number":204,"context_line":"                LOG.debug(\u0027Non-HA router %s has already been scheduled\u0027,"},{"line_number":205,"context_line":"                          router_id)"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_c9577202","line":202,"updated":"2017-04-26 18:02:53.000000000","message":"ditto","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not is_ha:"},{"line_number":201,"context_line":"            binding_index \u003d rb_model.LOWEST_BINDING_INDEX"},{"line_number":202,"context_line":"            if(rb_obj.RouterL3AgentBinding.objects_exist("},{"line_number":203,"context_line":"                context, router_id\u003drouter_id, binding_index\u003dbinding_index)):"},{"line_number":204,"context_line":"                LOG.debug(\u0027Non-HA router %s has already been scheduled\u0027,"},{"line_number":205,"context_line":"                          router_id)"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_31557b1e","line":202,"in_reply_to":"5ff73747_c9577202","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        try:"},{"line_number":218,"context_line":"            rb_obj.RouterL3AgentBinding(context, l3_agent_id\u003dagent_id,"},{"line_number":219,"context_line":"                    router_id\u003drouter_id, binding_index\u003dbinding_index).create()"},{"line_number":220,"context_line":"            binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":221,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":222,"context_line":"            LOG.debug(\u0027Router %(router_id)s is scheduled to L3 agent \u0027"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_a9a8a6da","line":219,"updated":"2017-04-26 18:02:53.000000000","message":"again, wrapping is usually 4chars.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        try:"},{"line_number":218,"context_line":"            rb_obj.RouterL3AgentBinding(context, l3_agent_id\u003dagent_id,"},{"line_number":219,"context_line":"                    router_id\u003drouter_id, binding_index\u003dbinding_index).create()"},{"line_number":220,"context_line":"            binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":221,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":222,"context_line":"            LOG.debug(\u0027Router %(router_id)s is scheduled to L3 agent \u0027"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_d1399ff2","line":219,"in_reply_to":"5ff73747_a9a8a6da","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        try:"},{"line_number":218,"context_line":"            rb_obj.RouterL3AgentBinding(context, l3_agent_id\u003dagent_id,"},{"line_number":219,"context_line":"                    router_id\u003drouter_id, binding_index\u003dbinding_index).create()"},{"line_number":220,"context_line":"            binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":221,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":222,"context_line":"            LOG.debug(\u0027Router %(router_id)s is scheduled to L3 agent \u0027"},{"line_number":223,"context_line":"                      \u0027%(agent_id)s with binding_index %(binding_index)d\u0027,"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_a9f666f8","line":220,"updated":"2017-04-26 18:02:53.000000000","message":"why do you need to fetch it? Can\u0027t you just return the object that you already instantiated in line 218-219?","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        try:"},{"line_number":218,"context_line":"            rb_obj.RouterL3AgentBinding(context, l3_agent_id\u003dagent_id,"},{"line_number":219,"context_line":"                    router_id\u003drouter_id, binding_index\u003dbinding_index).create()"},{"line_number":220,"context_line":"            binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":221,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":222,"context_line":"            LOG.debug(\u0027Router %(router_id)s is scheduled to L3 agent \u0027"},{"line_number":223,"context_line":"                      \u0027%(agent_id)s with binding_index %(binding_index)d\u0027,"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_712093b1","line":220,"in_reply_to":"5ff73747_a9f666f8","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            rb_obj.RouterL3AgentBinding(context, l3_agent_id\u003dagent_id,"},{"line_number":219,"context_line":"                    router_id\u003drouter_id, binding_index\u003dbinding_index).create()"},{"line_number":220,"context_line":"            binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":221,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":222,"context_line":"            LOG.debug(\u0027Router %(router_id)s is scheduled to L3 agent \u0027"},{"line_number":223,"context_line":"                      \u0027%(agent_id)s with binding_index %(binding_index)d\u0027,"},{"line_number":224,"context_line":"                      {\u0027router_id\u0027: router_id,"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_49b9222c","line":221,"updated":"2017-04-26 18:02:53.000000000","message":"ditto","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            rb_obj.RouterL3AgentBinding(context, l3_agent_id\u003dagent_id,"},{"line_number":219,"context_line":"                    router_id\u003drouter_id, binding_index\u003dbinding_index).create()"},{"line_number":220,"context_line":"            binding \u003d rb_obj.RouterL3AgentBinding.get_object("},{"line_number":221,"context_line":"                    context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":222,"context_line":"            LOG.debug(\u0027Router %(router_id)s is scheduled to L3 agent \u0027"},{"line_number":223,"context_line":"                      \u0027%(agent_id)s with binding_index %(binding_index)d\u0027,"},{"line_number":224,"context_line":"                      {\u0027router_id\u0027: router_id,"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_512d8fa6","line":221,"in_reply_to":"5ff73747_49b9222c","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _filter_scheduled_agents(self, plugin, context, router_id, candidates):"},{"line_number":315,"context_line":"        hosting \u003d plugin.get_l3_agents_hosting_routers(context, [router_id])"},{"line_number":316,"context_line":"        hosting_list \u003d []"},{"line_number":317,"context_line":"        for host in hosting:"},{"line_number":318,"context_line":"            hosting_list.append(tuple(host))"},{"line_number":319,"context_line":"        return list(set(candidates) - set(hosting_list))"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_29c5b65b","line":316,"range":{"start_line":316,"start_character":24,"end_line":316,"end_character":25},"updated":"2017-04-26 18:02:53.000000000","message":"So I don\u0027t fully understand the intent of the change. What\u0027s the problem here? Is it because \u0027hosting\u0027 contains Agent objects, but \u0027candidates\u0027 are SQLAlchemy records? (If so, why not convert them to some common type before doing set manipulations?)","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _filter_scheduled_agents(self, plugin, context, router_id, candidates):"},{"line_number":315,"context_line":"        hosting \u003d plugin.get_l3_agents_hosting_routers(context, [router_id])"},{"line_number":316,"context_line":"        hosting_list \u003d []"},{"line_number":317,"context_line":"        for host in hosting:"},{"line_number":318,"context_line":"            hosting_list.append(tuple(host))"},{"line_number":319,"context_line":"        return list(set(candidates) - set(hosting_list))"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_ac0c903b","line":316,"range":{"start_line":316,"start_character":24,"end_line":316,"end_character":25},"in_reply_to":"5ff73747_29c5b65b","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _filter_scheduled_agents(self, plugin, context, router_id, candidates):"},{"line_number":315,"context_line":"        hosting \u003d plugin.get_l3_agents_hosting_routers(context, [router_id])"},{"line_number":316,"context_line":"        hosting_list \u003d []"},{"line_number":317,"context_line":"        for host in hosting:"},{"line_number":318,"context_line":"            hosting_list.append(tuple(host))"},{"line_number":319,"context_line":"        return list(set(candidates) - set(hosting_list))"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def _bind_ha_router(self, plugin, context, router_id,"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_a944261c","line":318,"range":{"start_line":316,"start_character":8,"end_line":318,"end_character":44},"updated":"2017-04-26 18:02:53.000000000","message":"hosting_list \u003d [tuple(host) for host in hosting]","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _filter_scheduled_agents(self, plugin, context, router_id, candidates):"},{"line_number":315,"context_line":"        hosting \u003d plugin.get_l3_agents_hosting_routers(context, [router_id])"},{"line_number":316,"context_line":"        hosting_list \u003d []"},{"line_number":317,"context_line":"        for host in hosting:"},{"line_number":318,"context_line":"            hosting_list.append(tuple(host))"},{"line_number":319,"context_line":"        return list(set(candidates) - set(hosting_list))"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def _bind_ha_router(self, plugin, context, router_id,"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_6c3798e5","line":318,"range":{"start_line":316,"start_character":8,"end_line":318,"end_character":44},"in_reply_to":"5ff73747_a944261c","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/tests/unit/db/test_agentschedulers_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"91e3ef734f55a4d5af20a9b13f88d1e956cb996b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from neutron.extensions import dhcpagentscheduler"},{"line_number":39,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":40,"context_line":"from neutron import manager"},{"line_number":41,"context_line":"#from neutron.objects import l3agent as rb_obj"},{"line_number":42,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":43,"context_line":"from neutron.tests.common import helpers"},{"line_number":44,"context_line":"from neutron.tests import fake_notifier"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_7332bef3","line":41,"updated":"2016-11-02 09:41:02.000000000","message":"why is this commented out - is this for future use? do you want to add a comment here explaining this?","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b80750fd403b476b28da02b58ef296c0ecabd331","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from neutron.extensions import dhcpagentscheduler"},{"line_number":39,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":40,"context_line":"from neutron import manager"},{"line_number":41,"context_line":"#from neutron.objects import l3agent as rb_obj"},{"line_number":42,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":43,"context_line":"from neutron.tests.common import helpers"},{"line_number":44,"context_line":"from neutron.tests import fake_notifier"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_0015689a","line":41,"in_reply_to":"ba5da102_7332bef3","updated":"2016-11-11 17:28:10.000000000","message":"It\u0027s needed for future use. Removing it at this point. Will add it when the Agent OVO is ready for use.","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"91e3ef734f55a4d5af20a9b13f88d1e956cb996b","unresolved":false,"context_lines":[{"line_number":803,"context_line":"            rab \u003d rb_model.RouterL3AgentBinding"},{"line_number":804,"context_line":"            binding \u003d (self.adminContext.session.query(rab)."},{"line_number":805,"context_line":"                       filter(rab.router_id \u003d\u003d r[\u0027router\u0027][\u0027id\u0027]).first())"},{"line_number":806,"context_line":"            #binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":807,"context_line":"            #        self.adminContext, router_id\u003dr[\u0027router\u0027][\u0027id\u0027])).next()"},{"line_number":808,"context_line":"            self.assertEqual(binding.l3_agent.host, L3_HOSTA)"},{"line_number":809,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5da102_b34e166d","line":806,"updated":"2016-11-02 09:41:02.000000000","message":"ditto","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"b80750fd403b476b28da02b58ef296c0ecabd331","unresolved":false,"context_lines":[{"line_number":803,"context_line":"            rab \u003d rb_model.RouterL3AgentBinding"},{"line_number":804,"context_line":"            binding \u003d (self.adminContext.session.query(rab)."},{"line_number":805,"context_line":"                       filter(rab.router_id \u003d\u003d r[\u0027router\u0027][\u0027id\u0027]).first())"},{"line_number":806,"context_line":"            #binding \u003d iter(rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":807,"context_line":"            #        self.adminContext, router_id\u003dr[\u0027router\u0027][\u0027id\u0027])).next()"},{"line_number":808,"context_line":"            self.assertEqual(binding.l3_agent.host, L3_HOSTA)"},{"line_number":809,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_a024bc0c","line":806,"in_reply_to":"ba5da102_b34e166d","updated":"2016-11-11 17:28:10.000000000","message":"ditto","commit_id":"0fdb8c15d4d505f2e864a82403c3395053c3187c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            ret_b \u003d l3_rpc_cb.get_router_ids(self.adminContext, host\u003dL3_HOSTB)"},{"line_number":780,"context_line":"        self.assertEqual(ret_b, ret_a)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    #TODO(dasanind): Change it to object once Agent OVO is available"},{"line_number":783,"context_line":"    def test_router_no_reschedule_from_dead_admin_down_agent(self):"},{"line_number":784,"context_line":"        with self.router() as r:"},{"line_number":785,"context_line":"            l3_rpc_cb \u003d l3_rpc.L3RpcCallback()"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_299a566d","line":782,"updated":"2017-04-26 18:02:53.000000000","message":"hm, isn\u0027t it what you do in line 799 - using the object?","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            ret_b \u003d l3_rpc_cb.get_router_ids(self.adminContext, host\u003dL3_HOSTB)"},{"line_number":780,"context_line":"        self.assertEqual(ret_b, ret_a)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    #TODO(dasanind): Change it to object once Agent OVO is available"},{"line_number":783,"context_line":"    def test_router_no_reschedule_from_dead_admin_down_agent(self):"},{"line_number":784,"context_line":"        with self.router() as r:"},{"line_number":785,"context_line":"            l3_rpc_cb \u003d l3_rpc.L3RpcCallback()"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_2c31a0ed","line":782,"in_reply_to":"5ff73747_299a566d","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":796,"context_line":"                    self.adminContext, router_id\u003dr[\u0027router\u0027][\u0027id\u0027])"},{"line_number":797,"context_line":"            binding \u003d bindings.pop() if bindings else None"},{"line_number":798,"context_line":"            if binding:"},{"line_number":799,"context_line":"                l3_agent \u003d ag_obj.Agent.get_objects(self.adminContext,"},{"line_number":800,"context_line":"                        id\u003dbinding.l3_agent_id)"},{"line_number":801,"context_line":"                self.assertEqual(l3_agent[0].host, L3_HOSTA)"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_29a81675","line":798,"range":{"start_line":798,"start_character":12,"end_line":798,"end_character":23},"updated":"2017-04-26 18:02:53.000000000","message":"and if the binding is not present, will we silently pass the check? the previous version of the code would fail with AttributeError in line 796 when trying to access \u0027l3_agent\u0027 attribute on None.","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            bindings \u003d rb_obj.RouterL3AgentBinding.get_objects("},{"line_number":796,"context_line":"                    self.adminContext, router_id\u003dr[\u0027router\u0027][\u0027id\u0027])"},{"line_number":797,"context_line":"            binding \u003d bindings.pop() if bindings else None"},{"line_number":798,"context_line":"            if binding:"},{"line_number":799,"context_line":"                l3_agent \u003d ag_obj.Agent.get_objects(self.adminContext,"},{"line_number":800,"context_line":"                        id\u003dbinding.l3_agent_id)"},{"line_number":801,"context_line":"                self.assertEqual(l3_agent[0].host, L3_HOSTA)"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_ec50480d","line":798,"range":{"start_line":798,"start_character":12,"end_line":798,"end_character":23},"in_reply_to":"5ff73747_29a81675","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8fa6ca3331f76ca636c33b4d58f5f7d11c5f2ca7","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        self.plugin._unbind_router(self.adminContext,"},{"line_number":286,"context_line":"                            router[\u0027router\u0027][\u0027id\u0027],"},{"line_number":287,"context_line":"                            agent_id)"},{"line_number":288,"context_line":"        bindings \u003d (rb_obj.RouterL3AgentBinding."},{"line_number":289,"context_line":"            get_l3_bindings_filter_by_router_ids(self.adminContext,"},{"line_number":290,"context_line":"            [router[\u0027router\u0027][\u0027id\u0027]]))"},{"line_number":291,"context_line":"        self.assertEqual(0, len(bindings))"}],"source_content_type":"text/x-python","patch_set":60,"id":"5ff73747_89d16afe","line":288,"updated":"2017-04-26 18:02:53.000000000","message":"the wrapping here is not ideal. Consider:\n\nbindings \u003d (\n    rb_obj.RouterL3AgentBinding.get_l3_bindings_filter_by_router_ids(\n        self.adminContext, [router[\u0027router\u0027][\u0027id\u0027])\n)","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25309c54ae7e44cbc06d8e6c59ee1d1626ea9dc2","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        self.plugin._unbind_router(self.adminContext,"},{"line_number":286,"context_line":"                            router[\u0027router\u0027][\u0027id\u0027],"},{"line_number":287,"context_line":"                            agent_id)"},{"line_number":288,"context_line":"        bindings \u003d (rb_obj.RouterL3AgentBinding."},{"line_number":289,"context_line":"            get_l3_bindings_filter_by_router_ids(self.adminContext,"},{"line_number":290,"context_line":"            [router[\u0027router\u0027][\u0027id\u0027]]))"},{"line_number":291,"context_line":"        self.assertEqual(0, len(bindings))"}],"source_content_type":"text/x-python","patch_set":60,"id":"ff0f0b1f_2c464051","line":288,"in_reply_to":"5ff73747_89d16afe","updated":"2017-05-26 20:06:20.000000000","message":"Done","commit_id":"1bb12e09711801ec3383f043e748ab8cde5db6a6"}]}
