)]}'
{"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04de5bf14eac79a76ddaf9d09a40ec212f58db8d","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        return fixed_ip_list"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    @staticmethod"},{"line_number":567,"context_line":"    def is_host_set(host):"},{"line_number":568,"context_line":"        \"\"\"Utility to tell if the host is set in the port binding\"\"\""},{"line_number":569,"context_line":"        # This seems redundant, but its not. Host is unset if its None, \u0027\u0027,"},{"line_number":570,"context_line":"        # or ATTR_NOT_SPECIFIED due to differences in host binding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_2c63f41b","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":19},"updated":"2016-09-29 06:49:47.000000000","message":"If this method is copied to subnet-obj, why it is not removed from here?","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2f4af49646b1cbec41c48502f38b35a2e3866dac","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        return fixed_ip_list"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    @staticmethod"},{"line_number":567,"context_line":"    def is_host_set(host):"},{"line_number":568,"context_line":"        \"\"\"Utility to tell if the host is set in the port binding\"\"\""},{"line_number":569,"context_line":"        # This seems redundant, but its not. Host is unset if its None, \u0027\u0027,"},{"line_number":570,"context_line":"        # or ATTR_NOT_SPECIFIED due to differences in host binding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_864a04ab","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":19},"in_reply_to":"3a98d1f4_2c63f41b","updated":"2016-09-29 15:43:42.000000000","message":"IMHO, this method should be keep it here and not included in Subnet OVO. Saying that, the change in the line 593 won\u0027t be needed","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"9d3a70cdb28d8dc0c6082b5f647ae79c20011e46","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        return fixed_ip_list"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    @staticmethod"},{"line_number":567,"context_line":"    def is_host_set(host):"},{"line_number":568,"context_line":"        \"\"\"Utility to tell if the host is set in the port binding\"\"\""},{"line_number":569,"context_line":"        # This seems redundant, but its not. Host is unset if its None, \u0027\u0027,"},{"line_number":570,"context_line":"        # or ATTR_NOT_SPECIFIED due to differences in host binding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_3a785f2b","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":19},"in_reply_to":"3a98d1f4_2c63f41b","updated":"2016-09-29 17:08:35.000000000","message":"missed it in this patchset, this should be removed","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"9d3a70cdb28d8dc0c6082b5f647ae79c20011e46","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        return fixed_ip_list"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    @staticmethod"},{"line_number":567,"context_line":"    def is_host_set(host):"},{"line_number":568,"context_line":"        \"\"\"Utility to tell if the host is set in the port binding\"\"\""},{"line_number":569,"context_line":"        # This seems redundant, but its not. Host is unset if its None, \u0027\u0027,"},{"line_number":570,"context_line":"        # or ATTR_NOT_SPECIFIED due to differences in host binding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_a0d36037","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":19},"in_reply_to":"3a98d1f4_864a04ab","updated":"2016-09-29 17:08:35.000000000","message":"moved this method to neutron/objects/subnet.py because it was being used by method find_candidate_subnets [1]\n[1] https://review.openstack.org/#/c/377114/3/neutron/objects/subnet.py@251","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04de5bf14eac79a76ddaf9d09a40ec212f58db8d","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        If no eligible subnets are found, determine why and potentially raise"},{"line_number":578,"context_line":"        an appropriate error."},{"line_number":579,"context_line":"        \"\"\""},{"line_number":580,"context_line":"        subnets \u003d subnet_obj.Subnet.find_candidate_subnets("},{"line_number":581,"context_line":"            context, network_id, host, service_type)"},{"line_number":582,"context_line":"        if subnets:"},{"line_number":583,"context_line":"            subnet_dicts \u003d [self._make_subnet_dict(subnet, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_6c441c74","line":580,"range":{"start_line":580,"start_character":36,"end_line":580,"end_character":58},"updated":"2016-09-29 06:49:47.000000000","message":"This should return Subnet OVO.","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1dc024e285dca7406c1140943e8c2bb98771fe8c","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        If no eligible subnets are found, determine why and potentially raise"},{"line_number":578,"context_line":"        an appropriate error."},{"line_number":579,"context_line":"        \"\"\""},{"line_number":580,"context_line":"        subnets \u003d subnet_obj.Subnet.find_candidate_subnets("},{"line_number":581,"context_line":"            context, network_id, host, service_type)"},{"line_number":582,"context_line":"        if subnets:"},{"line_number":583,"context_line":"            subnet_dicts \u003d [self._make_subnet_dict(subnet, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_2448245b","line":580,"range":{"start_line":580,"start_character":36,"end_line":580,"end_character":58},"in_reply_to":"3a98d1f4_3af4df85","updated":"2016-09-30 08:09:59.000000000","message":"The _make_subnet_dict is not so prepared on receiving the OVO instead of DB object. The problem is when you are passing subnet object to extend_subnet_dict(). You can take a look at my patch that is reworking make_subnet_dict [1]. Still, I have a problem with passing db_obj [2] to extend_subnet_dict, because db_obj is detached from session and cannot load the relationship from DB.\n\nIn this PS we can leave returning the DB object, but follow-up patch should consider using the custom query and preparing the OVO output.\n\n[1] https://review.openstack.org/#/c/321001/18/neutron/db/db_base_plugin_common.py@133\n[2] https://review.openstack.org/#/c/321001/18/neutron/db/db_base_plugin_common.py@164","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2f4af49646b1cbec41c48502f38b35a2e3866dac","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        If no eligible subnets are found, determine why and potentially raise"},{"line_number":578,"context_line":"        an appropriate error."},{"line_number":579,"context_line":"        \"\"\""},{"line_number":580,"context_line":"        subnets \u003d subnet_obj.Subnet.find_candidate_subnets("},{"line_number":581,"context_line":"            context, network_id, host, service_type)"},{"line_number":582,"context_line":"        if subnets:"},{"line_number":583,"context_line":"            subnet_dicts \u003d [self._make_subnet_dict(subnet, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_062a742c","line":580,"range":{"start_line":580,"start_character":36,"end_line":580,"end_character":58},"in_reply_to":"3a98d1f4_6c441c74","updated":"2016-09-29 15:43:42.000000000","message":"Agreed, AFAIK self._make_subnet_dict method is prepared to received OVO as well.","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"9d3a70cdb28d8dc0c6082b5f647ae79c20011e46","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        If no eligible subnets are found, determine why and potentially raise"},{"line_number":578,"context_line":"        an appropriate error."},{"line_number":579,"context_line":"        \"\"\""},{"line_number":580,"context_line":"        subnets \u003d subnet_obj.Subnet.find_candidate_subnets("},{"line_number":581,"context_line":"            context, network_id, host, service_type)"},{"line_number":582,"context_line":"        if subnets:"},{"line_number":583,"context_line":"            subnet_dicts \u003d [self._make_subnet_dict(subnet, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_3af4df85","line":580,"range":{"start_line":580,"start_character":36,"end_line":580,"end_character":58},"in_reply_to":"3a98d1f4_6c441c74","updated":"2016-09-29 17:08:35.000000000","message":"i agree. My concern is that find_candidate_subnets method[1] combines multiple queries.\nFinal sqlalchemy query looks like [2]. Not sure on how to do integration for this. Ihar\u0027s suggestion in one of the upgrade meetings was to pick an object which is of more relevance, in this case subnet and then isolate model interrelationship into neutron/objects. Please suggest.\n  \n[1]https://review.openstack.org/#/c/377114/3/neutron/objects/subnet.py@245\n[2]http://paste.openstack.org/show/572359/","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6e31aadca06903a0ebac9c35e3d26694e53ebc51","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                fixed_ip_list.append({\u0027subnet_id\u0027: subnet[\u0027id\u0027]})"},{"line_number":564,"context_line":"        return fixed_ip_list"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def _ipam_get_subnets(self, context, network_id, host, service_type\u003dNone):"},{"line_number":567,"context_line":"        \"\"\"Return eligible subnets"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        If no eligible subnets are found, determine why and potentially raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_b09c44c1","line":566,"updated":"2016-09-30 19:27:34.000000000","message":"I think it\u0027d be better to move this to the Subnet object as a classmethod and it returns a list of Subnet objects.  This way, you shoudl be able to keep all the otehr methods (like find_candidate_subnets) private and only usable within Subnet.  The probelm they currnetly have is some are returning queries and are public methods, and I don\u0027t think an object should return a query.\n\nHowever, I still think this method and the others belong in the ipam_backend_mixin class and not totally in the Subnet class.  This can be fixed later though which is the intention of all this anyway.","commit_id":"97abca1e7fc60839b8b724346acb04acc0cadaac"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"f6d0ae4d82399ae3fb8157d310891e708f43873f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        a subnet_id then allocate an IP address accordingly."},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        p \u003d port[\u0027port\u0027]"},{"line_number":201,"context_line":"        subnets \u003d subnet_obj.Subnet._ipam_get_subnets(context,"},{"line_number":202,"context_line":"            network_id\u003dp[\u0027network_id\u0027],"},{"line_number":203,"context_line":"            host\u003dp.get(portbindings.HOST_ID),"},{"line_number":204,"context_line":"            service_type\u003dp.get(\u0027device_owner\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_6e76f73f","line":201,"updated":"2016-10-10 21:01:00.000000000","message":"missing newline, or incorrect indentation for all lines below.","commit_id":"fa7bffa539da5acb45e4a3df73aadc108267693d"}],"neutron/objects/subnet.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"74df0bf035cec5e39ad2862a4348f33737df7191","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @classmethod"},{"line_number":280,"context_line":"    def query_subnets_on_network(cls, context, network_id):"},{"line_number":281,"context_line":"        query \u003d cls._get_collection_query(context, models_v2.Subnet)"},{"line_number":282,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_46c74a12","line":281,"updated":"2016-09-28 22:18:59.000000000","message":"i discussed this a bit with you and the best bad solution i can come up with right now is to import the common_db_mixin module and change this line to:\n\nquery \u003d common_db_mixin.CommonDbMixin()._get_collection_query(context, models_v2.Subnet)\n\nI don\u0027t like having to instantiate a mixin but it works and I don\u0027t have a better solution.","commit_id":"d91a4082d57c597c952319d622a0b2d9694c80d1"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"d3a60e0f53af75b3f56f3e50e04b0dc4c11010ee","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    @classmethod"},{"line_number":280,"context_line":"    def query_subnets_on_network(cls, context, network_id):"},{"line_number":281,"context_line":"        query \u003d cls._get_collection_query(context, models_v2.Subnet)"},{"line_number":282,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_f43e3cb7","line":281,"in_reply_to":"3a98d1f4_46c74a12","updated":"2016-09-28 23:10:38.000000000","message":"Done, will wait for more reviews","commit_id":"d91a4082d57c597c952319d622a0b2d9694c80d1"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04de5bf14eac79a76ddaf9d09a40ec212f58db8d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        return [subnet for subnet, _mapping in results]"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @staticmethod"},{"line_number":273,"context_line":"    def is_host_set(host):"},{"line_number":274,"context_line":"        \"\"\"Utility to tell if the host is set in the port binding\"\"\""},{"line_number":275,"context_line":"        # This seems redundant, but its not. Host is unset if its None, \u0027\u0027,"},{"line_number":276,"context_line":"        # or ATTR_NOT_SPECIFIED due to differences in host binding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_6ce7bce4","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":19},"updated":"2016-09-29 06:49:47.000000000","message":"I do not like this method being replicated in 2 place. we need to find it a suitable place.","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"9d3a70cdb28d8dc0c6082b5f647ae79c20011e46","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        return [subnet for subnet, _mapping in results]"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @staticmethod"},{"line_number":273,"context_line":"    def is_host_set(host):"},{"line_number":274,"context_line":"        \"\"\"Utility to tell if the host is set in the port binding\"\"\""},{"line_number":275,"context_line":"        # This seems redundant, but its not. Host is unset if its None, \u0027\u0027,"},{"line_number":276,"context_line":"        # or ATTR_NOT_SPECIFIED due to differences in host binding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_6077983a","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":19},"in_reply_to":"3a98d1f4_6ce7bce4","updated":"2016-09-29 17:08:35.000000000","message":"will be removing this method from neutron/db/ipam_backend_mixin.py in next patchset","commit_id":"9541e5964d22e9e3a75f45dd1f375b22f8b4adba"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6e31aadca06903a0ebac9c35e3d26694e53ebc51","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            raise segment_exc.HostConnectedToMultipleSegments("},{"line_number":268,"context_line":"                host\u003dhost, network_id\u003dnetwork_id)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        return [subnet for subnet, _mapping in results]"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @staticmethod"},{"line_number":273,"context_line":"    def is_host_set(host):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_105b38f7","line":270,"updated":"2016-09-30 19:27:34.000000000","message":"I feel like this should return Subnet objects not SA models","commit_id":"97abca1e7fc60839b8b724346acb04acc0cadaac"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d9556ba8a090754b53a9d56bb5f5ef0647bbd316","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def query_subnets_on_network(cls, context, network_id):"},{"line_number":282,"context_line":"        query \u003d common_db_mixin.CommonDbMixin()._get_collection_query("},{"line_number":283,"context_line":"            context,"},{"line_number":284,"context_line":"            models_v2.Subnet)"},{"line_number":285,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_3373e816","line":284,"updated":"2016-09-30 16:15:05.000000000","message":"Could you put a NOTE above this explaining why this is being done in an unorthodox matter.  It\u0027ll be good information to anyone ocming across it.  Also it will highlight this for other reviewers reviewing this patch to comment on it.","commit_id":"97abca1e7fc60839b8b724346acb04acc0cadaac"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6e31aadca06903a0ebac9c35e3d26694e53ebc51","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        that are on segments. But, we still consider subnets that are not"},{"line_number":332,"context_line":"        associated with any segment (i.e. for non-routed networks)."},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        return query.filter(models_v2.Subnet.segment_id.is_(None))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_d00b90d4","line":334,"updated":"2016-09-30 19:27:34.000000000","message":"seems really odd for an object\u0027s public method to return a SA query.","commit_id":"97abca1e7fc60839b8b724346acb04acc0cadaac"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"680d0f717daffb8e2eb69cf454ef5f6b0388770f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        return host and validators.is_attr_set(host)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @classmethod"},{"line_number":310,"context_line":"    def _ipam_get_subnets(cls, context, network_id, host, service_type\u003dNone):"},{"line_number":311,"context_line":"        \"\"\"Return eligible subnets"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        If no eligible subnets are found, determine why and potentially raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_09f61a8f","line":310,"updated":"2016-10-05 15:18:52.000000000","message":"make this public","commit_id":"fa7bffa539da5acb45e4a3df73aadc108267693d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"680d0f717daffb8e2eb69cf454ef5f6b0388770f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        subnets \u003d cls._find_candidate_subnets("},{"line_number":317,"context_line":"            context, network_id, host, service_type)"},{"line_number":318,"context_line":"        if subnets:"},{"line_number":319,"context_line":"            subnet_dicts \u003d [cls._make_subnet_dict(subnet, context\u003dcontext)"},{"line_number":320,"context_line":"                            for subnet in subnets]"},{"line_number":321,"context_line":"            # Give priority to subnets with service_types"},{"line_number":322,"context_line":"            return sorted("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_64e9851a","line":319,"range":{"start_line":319,"start_character":28,"end_line":319,"end_character":74},"updated":"2016-10-05 15:18:52.000000000","message":"this is the problem with the test failures.  You may have to import and instatiate db_base_plugin_common.DbBasePluginCommon and call _make_subnet_dict from there, OR we can try to use the subnet object\u0027s to_dict method to work but I\u0027m afraid that doesn\u0027t have all the logic _make_subnet_dict has.","commit_id":"fa7bffa539da5acb45e4a3df73aadc108267693d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"f93907167020d8d5ab309db7b70f3b00f00bc442","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        subnets \u003d cls._find_candidate_subnets("},{"line_number":317,"context_line":"            context, network_id, host, service_type)"},{"line_number":318,"context_line":"        if subnets:"},{"line_number":319,"context_line":"            subnet_dicts \u003d [cls._make_subnet_dict(subnet, context\u003dcontext)"},{"line_number":320,"context_line":"                            for subnet in subnets]"},{"line_number":321,"context_line":"            # Give priority to subnets with service_types"},{"line_number":322,"context_line":"            return sorted("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_dfdfd20a","line":319,"range":{"start_line":319,"start_character":28,"end_line":319,"end_character":74},"in_reply_to":"1a95cdbc_64e9851a","updated":"2016-10-10 14:45:32.000000000","message":"Trying to do this yields bad results.  If instantiating DbBasePluginCommon, it requires importing of db_base_plugin_common.  This causes a circular import warning because db_base_plugin_common already imports subnet and subnet will now import it.\n\nWe also cannot use the to_dict method that all objects have because it does not render object attributes that are None.","commit_id":"fa7bffa539da5acb45e4a3df73aadc108267693d"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"f6d0ae4d82399ae3fb8157d310891e708f43873f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        subnets \u003d cls._find_candidate_subnets("},{"line_number":317,"context_line":"            context, network_id, host, service_type)"},{"line_number":318,"context_line":"        if subnets:"},{"line_number":319,"context_line":"            subnet_dicts \u003d [cls._make_subnet_dict(subnet, context\u003dcontext)"},{"line_number":320,"context_line":"                            for subnet in subnets]"},{"line_number":321,"context_line":"            # Give priority to subnets with service_types"},{"line_number":322,"context_line":"            return sorted("}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_0e11fbac","line":319,"range":{"start_line":319,"start_character":28,"end_line":319,"end_character":74},"in_reply_to":"1a95cdbc_dfdfd20a","updated":"2016-10-10 21:01:00.000000000","message":"I second that.","commit_id":"fa7bffa539da5acb45e4a3df73aadc108267693d"}]}
