)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"503b4de825ff7c1afed3c62b5e5acbece320e6a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"were passing the default value of None for fields, even"},{"line_number":11,"context_line":"though they didn\u0027t need to.  Also fixed other callers"},{"line_number":12,"context_line":"to specify fields as a keyword argument since that\u0027s"},{"line_number":13,"context_line":"what it is."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Trivalfix"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_ea008403","line":13,"updated":"2016-10-07 21:02:50.000000000","message":"I think you\u0027re confusing keyword arguments with default values. Here\u0027s the gist: the method definition chooses whether the argument has a default, not if it is a keyword argument. The rule is that args with default values must come after those without.\n\nThe caller of the method chooses whether to pass an argument as positional or keyword. Any argument can be passed as positional or keyword. The rules are just that positional args must be specified starting with the first and sequentially, then the rest can be specified as keyword.\n\nThe two concepts are not the same.","commit_id":"024cd3a71b1c5c004f6ea74518a645d890049d1d"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"503b4de825ff7c1afed3c62b5e5acbece320e6a6","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":1247,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":1248,"context_line":"        port \u003d self._get_port(context, id)"},{"line_number":1249,"context_line":"        return self._make_port_dict(port, fields\u003dfields)"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"    def _get_ports_query(self, context, filters\u003dNone, sorts\u003dNone, limit\u003dNone,"},{"line_number":1252,"context_line":"                         marker_obj\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_2a07cc18","line":1249,"updated":"2016-10-07 21:02:50.000000000","message":"While I\u0027m a big proponent for keyword arguments, this is a totally unnecessary change and doesn\u0027t \"fix\" anything.","commit_id":"024cd3a71b1c5c004f6ea74518a645d890049d1d"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"68173655d02eb2a88e71c9efa07d105cbfd5405c","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":1247,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":1248,"context_line":"        port \u003d self._get_port(context, id)"},{"line_number":1249,"context_line":"        return self._make_port_dict(port, fields\u003dfields)"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"    def _get_ports_query(self, context, filters\u003dNone, sorts\u003dNone, limit\u003dNone,"},{"line_number":1252,"context_line":"                         marker_obj\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c9d7fd21","line":1249,"in_reply_to":"1a95cdbc_2a07cc18","updated":"2016-10-10 21:25:01.000000000","message":"+1","commit_id":"024cd3a71b1c5c004f6ea74518a645d890049d1d"}]}
