)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d4e5acaeca196b847c3dda931160957dfbbcf0aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-25 14:43:18 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable \u0027accept_ras\u0027 in DHCP agent namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The DHCP agent explicitly assigns address to the agent"},{"line_number":10,"context_line":"based on the data model. Change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_b63890d4","line":7,"updated":"2016-09-27 01:44:16.000000000","message":"done","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"068b2bb3aecff3c62fc7604f208dfcaa9558e8d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-25 14:43:18 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable \u0027accept_ras\u0027 in DHCP agent namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The DHCP agent explicitly assigns address to the agent"},{"line_number":10,"context_line":"based on the data model. Change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_73e9bab6","line":7,"updated":"2016-09-27 01:39:47.000000000","message":"nit: accept_ra","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ad14f7bd82c2f157065145061046cceac09e466a","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"        # disable acceptance of RAs in the namespace so we don\u0027t"},{"line_number":1340,"context_line":"        # get dynamic addresses since we explicitly configure them"},{"line_number":1341,"context_line":"        iw \u003d ip_lib.IPWrapper(namespace\u003dnetwork.namespace)"},{"line_number":1342,"context_line":"        iw.ensure_namespace(network.namespace)"},{"line_number":1343,"context_line":"        iw.netns.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027net.ipv6.conf.default.accept_ra\u003d0\u0027])"},{"line_number":1344,"context_line":"        self.driver.plug(network.id,"},{"line_number":1345,"context_line":"                         port.id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_c348e6ce","line":1342,"updated":"2016-09-27 11:00:05.000000000","message":"Done","commit_id":"90e66a70aff6fa60ff8d2902e1a56b7b76f1b481"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32bdee344884dc5f73866d96265547df88563ef2","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"        # disable acceptance of RAs in the namespace so we don\u0027t"},{"line_number":1340,"context_line":"        # get dynamic addresses since we explicitly configure them"},{"line_number":1341,"context_line":"        iw \u003d ip_lib.IPWrapper(namespace\u003dnetwork.namespace)"},{"line_number":1342,"context_line":"        iw.ensure_namespace(network.namespace)"},{"line_number":1343,"context_line":"        iw.netns.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027net.ipv6.conf.default.accept_ra\u003d0\u0027])"},{"line_number":1344,"context_line":"        self.driver.plug(network.id,"},{"line_number":1345,"context_line":"                         port.id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_8fcc458a","line":1342,"updated":"2016-09-27 10:09:25.000000000","message":"you could probably describe here in a comment why you need to set the knob before plugging the namespace into the bridge in line 1344 (to avoid the device receiving an RA before we disable it).","commit_id":"90e66a70aff6fa60ff8d2902e1a56b7b76f1b481"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ad14f7bd82c2f157065145061046cceac09e466a","unresolved":false,"context_lines":[{"line_number":1340,"context_line":"        # get dynamic addresses since we explicitly configure them"},{"line_number":1341,"context_line":"        iw \u003d ip_lib.IPWrapper(namespace\u003dnetwork.namespace)"},{"line_number":1342,"context_line":"        iw.ensure_namespace(network.namespace)"},{"line_number":1343,"context_line":"        iw.netns.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027net.ipv6.conf.default.accept_ra\u003d0\u0027])"},{"line_number":1344,"context_line":"        self.driver.plug(network.id,"},{"line_number":1345,"context_line":"                         port.id,"},{"line_number":1346,"context_line":"                         interface_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_e34322ad","line":1343,"updated":"2016-09-27 11:00:05.000000000","message":"Yeah, I figured a direct call would be a little less invasive this late.","commit_id":"90e66a70aff6fa60ff8d2902e1a56b7b76f1b481"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32bdee344884dc5f73866d96265547df88563ef2","unresolved":false,"context_lines":[{"line_number":1340,"context_line":"        # get dynamic addresses since we explicitly configure them"},{"line_number":1341,"context_line":"        iw \u003d ip_lib.IPWrapper(namespace\u003dnetwork.namespace)"},{"line_number":1342,"context_line":"        iw.ensure_namespace(network.namespace)"},{"line_number":1343,"context_line":"        iw.netns.execute([\u0027sysctl\u0027, \u0027-w\u0027, \u0027net.ipv6.conf.default.accept_ra\u003d0\u0027])"},{"line_number":1344,"context_line":"        self.driver.plug(network.id,"},{"line_number":1345,"context_line":"                         port.id,"},{"line_number":1346,"context_line":"                         interface_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_cc7bbbbc","line":1343,"updated":"2016-09-27 10:09:25.000000000","message":"we could probably extend configure_ipv6_ra to support different values for the setting.","commit_id":"90e66a70aff6fa60ff8d2902e1a56b7b76f1b481"}],"neutron/common/ipv6_utils.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32bdee344884dc5f73866d96265547df88563ef2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            or subnet[\u0027ipv6_ra_mode\u0027] in modes)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":80,"context_line":"    \"\"\"Check if subnet is a slaac subnet.\"\"\""},{"line_number":81,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] \u003d\u003d const.IPV6_SLAAC"},{"line_number":82,"context_line":"            or subnet[\u0027ipv6_ra_mode\u0027] \u003d\u003d const.IPV6_SLAAC)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_4fa15d45","side":"PARENT","line":79,"updated":"2016-09-27 10:09:25.000000000","message":"For other reviewers: we are more or less safe to remove it because it\u0027s a very new function that is probably not adopted by anyone.","commit_id":"6f619b6c5f0fd22a71a89706379a23f3fbce1c31"}],"neutron/tests/functional/agent/test_dhcp_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d4e5acaeca196b847c3dda931160957dfbbcf0aa","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assert_ras_disabled(network.namespace)"},{"line_number":164,"context_line":"        self.assert_dhcp_device(network.namespace, iface_name, dhcp_enabled)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def assert_ras_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u0027net.ipv6.conf.default.accept_ra \u003d 0\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_d6335cf4","line":166,"updated":"2016-09-27 01:44:16.000000000","message":"done","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"068b2bb3aecff3c62fc7604f208dfcaa9558e8d8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assert_ras_disabled(network.namespace)"},{"line_number":164,"context_line":"        self.assert_dhcp_device(network.namespace, iface_name, dhcp_enabled)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def assert_ras_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u0027net.ipv6.conf.default.accept_ra \u003d 0\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_9342c6ac","line":166,"updated":"2016-09-27 01:39:47.000000000","message":"nit: assert_accept_ra_disabled","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d4e5acaeca196b847c3dda931160957dfbbcf0aa","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.assert_dhcp_device(network.namespace, iface_name, dhcp_enabled)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def assert_ras_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u0027net.ipv6.conf.default.accept_ra \u003d 0\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027])"},{"line_number":170,"context_line":"        self.assertIn(expected, actual)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_f62e988a","line":167,"updated":"2016-09-27 01:44:16.000000000","message":"done","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"068b2bb3aecff3c62fc7604f208dfcaa9558e8d8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.assert_dhcp_device(network.namespace, iface_name, dhcp_enabled)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def assert_ras_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u0027net.ipv6.conf.default.accept_ra \u003d 0\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027])"},{"line_number":170,"context_line":"        self.assertIn(expected, actual)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_f38dcad3","line":167,"updated":"2016-09-27 01:39:47.000000000","message":"expected \u003d \u00270\u0027","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"068b2bb3aecff3c62fc7604f208dfcaa9558e8d8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def assert_ras_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u0027net.ipv6.conf.default.accept_ra \u003d 0\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027])"},{"line_number":170,"context_line":"        self.assertIn(expected, actual)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def assert_dhcp_namespace(self, namespace, dhcp_enabled):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_13bf9661","line":169,"updated":"2016-09-27 01:39:47.000000000","message":"add a \u0027-n\u0027 here to not print the key, might be cleaner, then you could use assertEqual","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d4e5acaeca196b847c3dda931160957dfbbcf0aa","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def assert_ras_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u0027net.ipv6.conf.default.accept_ra \u003d 0\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027])"},{"line_number":170,"context_line":"        self.assertIn(expected, actual)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def assert_dhcp_namespace(self, namespace, dhcp_enabled):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_1650640a","line":169,"updated":"2016-09-27 01:44:16.000000000","message":"done","commit_id":"117cfcb38ce3e7d1f31764b0a68b4ccb9c7dba05"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"871fdcf64470f152bec7f5fd916564b2fa90c09f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def assert_accept_ra_disabled(self, namespace):"},{"line_number":167,"context_line":"        expected \u003d \u00270\u0027"},{"line_number":168,"context_line":"        actual \u003d ip_lib.IPWrapper(namespace\u003dnamespace).netns.execute("},{"line_number":169,"context_line":"            [\u0027sysctl\u0027, \u0027-n\u0027, \u0027net.ipv6.conf.default.accept_ra\u0027]"},{"line_number":170,"context_line":"        ).splitlines()[0]"},{"line_number":171,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_79b279e6","line":169,"updated":"2016-09-27 02:42:52.000000000","message":"Actually using -b would be better, my bad, then you don\u0027t need the splitlines.  There\u0027s another functional test that does this too.","commit_id":"82c97aa6fac04f4ca789e3dd4ae8420c5ca6f703"}]}
