)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"263e14059be35c8021ae6da2a5fa3f72176bcd98","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"        ip_cidrs \u003d []"},{"line_number":1360,"context_line":"        for fixed_ip in port.fixed_ips:"},{"line_number":1361,"context_line":"            subnet \u003d fixed_ip.subnet"},{"line_number":1362,"context_line":"            if not ipv6_utils.is_auto_address_subnet(subnet):"},{"line_number":1363,"context_line":"                net \u003d netaddr.IPNetwork(subnet.cidr)"},{"line_number":1364,"context_line":"                ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":1365,"context_line":"                ip_cidrs.append(ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_bd4a1b53","line":1362,"updated":"2016-09-27 10:13:57.000000000","message":"there are basically two fixes here. One to the top makes the agent gracefully recover from a mismatch; and that line changed is to include dhcpv6-stateless addresses into the list to set up by the agent.\n\nIf we are going with the revert, I suggest to at least revert just the second bit, since it\u0027s the one that triggered it.\n\nThe two fixes should have been separated during review, and I pointed it out that those are independent, but it did not happen. It would be a shame to reexpose KeyErrors fixed by the change above due to the line change that has no relevance to the immediate bug targeted by the patch.","commit_id":"88521d227cf940c4d804f8af587ef027a3c66032"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ac9604a0a37b0abca9dc5c594d626af6de19d33b","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"        ip_cidrs \u003d []"},{"line_number":1360,"context_line":"        for fixed_ip in port.fixed_ips:"},{"line_number":1361,"context_line":"            subnet \u003d fixed_ip.subnet"},{"line_number":1362,"context_line":"            if not ipv6_utils.is_auto_address_subnet(subnet):"},{"line_number":1363,"context_line":"                net \u003d netaddr.IPNetwork(subnet.cidr)"},{"line_number":1364,"context_line":"                ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":1365,"context_line":"                ip_cidrs.append(ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_d297d1e9","line":1362,"in_reply_to":"5a8bc5a2_bd4a1b53","updated":"2016-09-27 11:33:44.000000000","message":"The immediate bug targets keyerrors in that map. This also caused a keyerror in the same map. I\u0027m not sure why you think it wasn\u0027t relevant to the bug...","commit_id":"88521d227cf940c4d804f8af587ef027a3c66032"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"799a054e048941610c00db7e0286adf895abb442","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"        ip_cidrs \u003d []"},{"line_number":1360,"context_line":"        for fixed_ip in port.fixed_ips:"},{"line_number":1361,"context_line":"            subnet \u003d fixed_ip.subnet"},{"line_number":1362,"context_line":"            if not ipv6_utils.is_auto_address_subnet(subnet):"},{"line_number":1363,"context_line":"                net \u003d netaddr.IPNetwork(subnet.cidr)"},{"line_number":1364,"context_line":"                ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":1365,"context_line":"                ip_cidrs.append(ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_51d9f2f1","line":1362,"in_reply_to":"5a8bc5a2_d297d1e9","updated":"2016-09-27 15:08:13.000000000","message":"I am not sure I understand your point. I am reverting the patch that introduced bug 1627902. Rather than rushing into some other fix for which we may have not the time to assess its validity on an extended period of time, we should back out and land on safer grounds.","commit_id":"88521d227cf940c4d804f8af587ef027a3c66032"}]}
