)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d5066172c15ce3ba244e3cda9cb25b8a520ef1d6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add an option to neutron.agent.ovsdb.native.connection.Connection to"},{"line_number":10,"context_line":"override the Idl class that is created to communicate with OVSDB."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a feature that would help in Dragonflow[1], where the notify"},{"line_number":13,"context_line":"method should be overriden before start() is called, in order to receive"},{"line_number":14,"context_line":"all events in real-time, and not retroactively."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_ca6053d2","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":50},"updated":"2016-10-13 09:13:07.000000000","message":"[1]?\nmissing foot note?","commit_id":"de8de166fb09ee915efdf27b6fdda4fed0751c64"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"00d2817d82c92039c7795080af2cadd235d3dfe7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add an option to neutron.agent.ovsdb.native.connection.Connection to"},{"line_number":10,"context_line":"override the Idl class that is created to communicate with OVSDB."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a feature that would help in Dragonflow[1], where the notify"},{"line_number":13,"context_line":"method should be overriden before start() is called, in order to receive"},{"line_number":14,"context_line":"all events in real-time, and not retroactively."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_2a654fb4","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":50},"in_reply_to":"fa6399be_ca6053d2","updated":"2016-10-13 09:14:52.000000000","message":"Done","commit_id":"de8de166fb09ee915efdf27b6fdda4fed0751c64"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"da654eacb3befcf3d78bec71760d2be68925684a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"method should be overriden before start() is called, in order to receive"},{"line_number":14,"context_line":"all events in real-time, and not retroactively."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/openstack/dragonflow/blob/master/dragonflow/ovsdb/impl_idl.py#L135"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I49da05f02a00352b1b1db863d244e97f9c148804"},{"line_number":19,"context_line":"Closes-Bug: 1627615"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_1397e6ec","line":16,"updated":"2016-10-13 10:15:32.000000000","message":"master reference with line number will get stale soon.\ni\u0027d suggest to use a specific version.\neg.\nhttps://github.com/openstack/dragonflow/blob/eb5484a5bcfb489e22633bf84bffc234328f0c39/dragonflow/ovsdb/impl_idl.py#L135","commit_id":"812fbe5b2db388b909ea6a0860b5ffb79ce79474"}],"neutron/agent/ovsdb/native/connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"2babaa9a4c64f2ac0d0a5b2e90c945b562458f43","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.txns \u003d TransactionQueue(1)"},{"line_number":61,"context_line":"        self.lock \u003d threading.Lock()"},{"line_number":62,"context_line":"        self.schema_name \u003d schema_name"},{"line_number":63,"context_line":"        self.idl_class \u003d idl.Idl"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self, table_name_list\u003dNone):"},{"line_number":66,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_b706881e","line":63,"updated":"2016-09-28 16:57:49.000000000","message":"Any reason not to make this an kwarg w/ a default argument and just doing self.idl_class \u003d idl_class? Seems a little weird to override Connection, call super() which sets the value, then re-set the value in the overridden __init__. Also enforces an order where you definitely have to call super() then set the value.","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"683e3f270892ece432198965aaebe89727fcdadd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.txns \u003d TransactionQueue(1)"},{"line_number":61,"context_line":"        self.lock \u003d threading.Lock()"},{"line_number":62,"context_line":"        self.schema_name \u003d schema_name"},{"line_number":63,"context_line":"        self.idl_class \u003d idl.Idl"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self, table_name_list\u003dNone):"},{"line_number":66,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_2bd85053","line":63,"in_reply_to":"3a98d1f4_b706881e","updated":"2016-09-28 18:35:49.000000000","message":"The use case I had in mind was:\n\nconnection \u003d connection.Connection(...)\n\nconnection.idl_class \u003d magicidl.MagicIdl\n\nconnection.start(...)\n\n\nBut I can definitely add it as a parameter as well.","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7454520e9631032e36e3c45dad075829ec431730","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_016fac2b","line":56,"updated":"2016-09-29 20:54:39.000000000","message":"shouldn\u0027t this just be idl_class\u003didl.Idl and self.idl_class \u003d idl_class?","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"83224ebe6b81b1391b2a23cb7410635600858d83","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_04224fb9","line":56,"in_reply_to":"3a98d1f4_016fac2b","updated":"2016-09-30 04:00:58.000000000","message":"I tried that, but then if someone (e.g. test code) tries to patch idl.Idl, the patching doesn\u0027t work.\n\nI think that\u0027s because the default value is evaluated on function creation, and for patching it has to be evaluated on function call.","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"db52ebdcae5a024508afceee0e1a3fcaea041741","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_294c6a9d","line":56,"in_reply_to":"3a98d1f4_04224fb9","updated":"2016-09-30 13:07:41.000000000","message":"You can patch out the Connection instance idl_class","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bfcf2e7255e46390f6f502dcfbc6a766a32ac192","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_3e54971f","line":56,"in_reply_to":"3a98d1f4_294c6a9d","updated":"2016-09-30 14:33:15.000000000","message":"Yes, but only after the instance is created. That would change the test. This solution work,s is a smaller change, and works well for both previous and existing scenarios. It has the added bonus of putting a primitive value (None) as a default value in the function.","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"63d3a5c99bb5262a425b8b4510d9e7d0b7de91ce","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_6733f214","line":56,"in_reply_to":"3a98d1f4_3e54971f","updated":"2016-09-30 15:16:16.000000000","message":"Additionally, if someone doesn\u0027t know (or remember, or afraid it might change) the default value, but needs to send a parameter anyway (e.g. when selecting an Idl class according to some conditions), that someone can send None and get the default automatically.","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ed541557339b4537f7c20ce95873d728d8628f56","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_4bf23f07","line":56,"in_reply_to":"3a98d1f4_3e61ecd3","updated":"2016-10-03 14:53:22.000000000","message":"Am I missing something? How is this different :) If you don\u0027t pass explicitly idl_class, Connection instance will have self.idl_class set to idl.Idl. If you modify that class, it\u0027s gonna be modified everywhere, no?","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9a4da4fc6e5eaa1aaae8d3becad08b7f55ff76bb","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_40bdb9d6","line":56,"in_reply_to":"3a98d1f4_4bf23f07","updated":"2016-10-03 15:29:38.000000000","message":"http://docs.python-guide.org/en/latest/writing/gotchas/\n\nJakub,you are right (hopefully I\u0027m right that you are right this time) since the class definition is global already. I was just thinking of http://docs.python-guide.org/en/latest/writing/gotchas/ Obviously I needed more coffee that day. :p","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cee17553df31f060b27c9dffe660c39b73af78f4","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Connection(object):"},{"line_number":56,"context_line":"    def __init__(self, connection, timeout, schema_name, idl_class\u003dNone):"},{"line_number":57,"context_line":"        self.idl \u003d None"},{"line_number":58,"context_line":"        self.connection \u003d connection"},{"line_number":59,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_3e61ecd3","line":56,"in_reply_to":"3a98d1f4_6733f214","updated":"2016-09-30 17:28:14.000000000","message":"Omer, you\u0027re right. Shouldn\u0027t put a mutable object as a default initializer. If someone for some silly reason did:\n\n c \u003d Connection(...)\n c.idl_class.run \u003d None\n\nand then something else did\n\n d \u003d Connection()\n\nd.idl_class.run \u003d\u003d None\n\nas nice as having the default be part of the signature would be, it would be horrible practice. My bad. :)","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"}],"neutron/tests/unit/agent/ovsdb/native/test_connection.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4896b3a0bd83be857eac894c5f958916eb0c7bb1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":64,"context_line":"    def test_start_with_idl_class(self, wait_for_change, get_schema_helper,"},{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":67,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel)"},{"line_number":68,"context_line":"        self.connection.idl_class \u003d mock.Mock()"},{"line_number":69,"context_line":"        returnValue \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_e6ba2fc0","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":13},"updated":"2016-09-28 14:43:40.000000000","message":"Is it used anywhere?","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"df576473938e1953280350f981e4f280ff6272b4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":64,"context_line":"    def test_start_with_idl_class(self, wait_for_change, get_schema_helper,"},{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":67,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel)"},{"line_number":68,"context_line":"        self.connection.idl_class \u003d mock.Mock()"},{"line_number":69,"context_line":"        returnValue \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_468923ca","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":13},"in_reply_to":"3a98d1f4_e6ba2fc0","updated":"2016-09-28 14:52:28.000000000","message":"I don\u0027t think so. But this is true also for the other test in this module, and I didn\u0027t want to change the style here.\n\nI can try making connection a variable rather than a member in another patch. (And testing it first, of course)","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"22b7490ea5f515960122dfb75b6be35af590c5cb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":67,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel)"},{"line_number":68,"context_line":"        self.connection.idl_class \u003d mock.Mock()"},{"line_number":69,"context_line":"        returnValue \u003d mock.Mock()"},{"line_number":70,"context_line":"        self.connection.idl_class.return_value \u003d returnValue"},{"line_number":71,"context_line":"        self.connection.start()"},{"line_number":72,"context_line":"        self.assertEqual(returnValue, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_ff455b17","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":58},"updated":"2016-09-28 12:40:50.000000000","message":"Better is:\n\n with mock.patch.object(self.connection, \u0027idl_class\u0027):\n     idl_instance \u003d self.connection.idl_class.return_value\n     self.connection.start()\n self.assertEqual(idl_instance, self.connection.idl)","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"088d22a78ca4549439cc6127e6f62fa4f93320ff","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":67,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel)"},{"line_number":68,"context_line":"        self.connection.idl_class \u003d mock.Mock()"},{"line_number":69,"context_line":"        returnValue \u003d mock.Mock()"},{"line_number":70,"context_line":"        self.connection.idl_class.return_value \u003d returnValue"},{"line_number":71,"context_line":"        self.connection.start()"},{"line_number":72,"context_line":"        self.assertEqual(returnValue, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_a6ee67ea","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":58},"in_reply_to":"3a98d1f4_a331f9ee","updated":"2016-09-28 14:41:54.000000000","message":"It doesn\u0027t overwrite mock object (idl_class.return_value) with another mock object like you do on L70 with returnValue","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"df576473938e1953280350f981e4f280ff6272b4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":67,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel)"},{"line_number":68,"context_line":"        self.connection.idl_class \u003d mock.Mock()"},{"line_number":69,"context_line":"        returnValue \u003d mock.Mock()"},{"line_number":70,"context_line":"        self.connection.idl_class.return_value \u003d returnValue"},{"line_number":71,"context_line":"        self.connection.start()"},{"line_number":72,"context_line":"        self.assertEqual(returnValue, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_3968b8ba","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":58},"in_reply_to":"3a98d1f4_a6ee67ea","updated":"2016-09-28 14:52:28.000000000","message":"Then maybe just replace L69 and L70 with:\nreturnValue \u003d self.connection.idl_class.return_value ?","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"4cbd3512e7d52f4ecdfa3c279983fc5cfb84650b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":67,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel)"},{"line_number":68,"context_line":"        self.connection.idl_class \u003d mock.Mock()"},{"line_number":69,"context_line":"        returnValue \u003d mock.Mock()"},{"line_number":70,"context_line":"        self.connection.idl_class.return_value \u003d returnValue"},{"line_number":71,"context_line":"        self.connection.start()"},{"line_number":72,"context_line":"        self.assertEqual(returnValue, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_a331f9ee","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":58},"in_reply_to":"3a98d1f4_ff455b17","updated":"2016-09-28 14:27:21.000000000","message":"@Jakub Libosvar: Could you please explain why is this better?\nIf self.connection was global, then yes. But I created it on the previous line, and every test re-creates it as needed.","commit_id":"da1739f32c6ee8eb1ad6835ec1cfd0d83fe1b00b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"db52ebdcae5a024508afceee0e1a3fcaea041741","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @mock.patch.object(idlutils, \u0027get_schema_helper\u0027)"},{"line_number":63,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":64,"context_line":"    def test_start_with_idl_class(self, wait_for_change, get_schema_helper,"},{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_89473e76","line":65,"range":{"start_line":65,"start_character":34,"end_line":65,"end_character":50},"updated":"2016-09-30 13:07:41.000000000","message":"Violates pep8, should be transaction_queue","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bfcf2e7255e46390f6f502dcfbc6a766a32ac192","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    @mock.patch.object(idlutils, \u0027get_schema_helper\u0027)"},{"line_number":63,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":64,"context_line":"    def test_start_with_idl_class(self, wait_for_change, get_schema_helper,"},{"line_number":65,"context_line":"                                  transactionQueue):"},{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_4147c64a","line":65,"range":{"start_line":65,"start_character":34,"end_line":65,"end_character":50},"in_reply_to":"3a98d1f4_89473e76","updated":"2016-09-30 14:33:15.000000000","message":"Done","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"db52ebdcae5a024508afceee0e1a3fcaea041741","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"},{"line_number":69,"context_line":"        returnValue \u003d idl_class.return_value"},{"line_number":70,"context_line":"        self.connection.start()"},{"line_number":71,"context_line":"        self.assertEqual(returnValue, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_a9607a02","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":19},"updated":"2016-09-30 13:07:41.000000000","message":"ditto: return_value","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bfcf2e7255e46390f6f502dcfbc6a766a32ac192","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"},{"line_number":69,"context_line":"        returnValue \u003d idl_class.return_value"},{"line_number":70,"context_line":"        self.connection.start()"},{"line_number":71,"context_line":"        self.assertEqual(returnValue, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_617682a5","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":19},"in_reply_to":"3a98d1f4_a9607a02","updated":"2016-09-30 14:33:15.000000000","message":"Done","commit_id":"4c2c8aff517559797ee3b7e1c12b357228fe16e0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"df9a9d5959b315c45ef2fe85e0b3ee259f570bd7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"},{"line_number":69,"context_line":"        return_value \u003d idl_class.return_value"},{"line_number":70,"context_line":"        self.connection.start()"},{"line_number":71,"context_line":"        self.assertEqual(return_value, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_bab48af2","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":20},"updated":"2016-10-05 14:07:47.000000000","message":"nit: I\u0027d use something more meaningful - like idl_instance","commit_id":"de8de166fb09ee915efdf27b6fdda4fed0751c64"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d5066172c15ce3ba244e3cda9cb25b8a520ef1d6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"},{"line_number":69,"context_line":"        return_value \u003d idl_class.return_value"},{"line_number":70,"context_line":"        self.connection.start()"},{"line_number":71,"context_line":"        self.assertEqual(return_value, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_6af667fa","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":20},"in_reply_to":"1a95cdbc_bab48af2","updated":"2016-10-13 09:13:07.000000000","message":"+1","commit_id":"de8de166fb09ee915efdf27b6fdda4fed0751c64"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"070c062304fb86203e4a7c9e23260729763457c5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"},{"line_number":69,"context_line":"        return_value \u003d idl_class.return_value"},{"line_number":70,"context_line":"        self.connection.start()"},{"line_number":71,"context_line":"        self.assertEqual(return_value, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_e9af2ee1","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":20},"in_reply_to":"1a95cdbc_bab48af2","updated":"2016-10-05 15:06:02.000000000","message":"If I respin, I\u0027ll do that.","commit_id":"de8de166fb09ee915efdf27b6fdda4fed0751c64"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"00d2817d82c92039c7795080af2cadd235d3dfe7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        idl_class \u003d mock.Mock()"},{"line_number":67,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":68,"context_line":"            mock.sentinel, mock.sentinel, mock.sentinel, idl_class\u003didl_class)"},{"line_number":69,"context_line":"        return_value \u003d idl_class.return_value"},{"line_number":70,"context_line":"        self.connection.start()"},{"line_number":71,"context_line":"        self.assertEqual(return_value, self.connection.idl)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_8a749b68","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":20},"in_reply_to":"fa6399be_6af667fa","updated":"2016-10-13 09:14:52.000000000","message":"Done","commit_id":"de8de166fb09ee915efdf27b6fdda4fed0751c64"}]}