)]}'
{"neutron/services/loadbalancer/drivers/abstract_driver.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"e0e2278aca5d7f4a1aa1a31c2dd4f88047f3d499","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":125,"context_line":"        \"\"\"Driver may call the code below in order to delete the monitor."},{"line_number":126,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F6AU%3D","line":126,"updated":"2013-07-19 13:27:42.000000000","message":"oops","commit_id":"fc1388c7a85c471e7d211d825065cc3eb7838eaa"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b92985af6dee57f9afe47d379d91b81eac92afd2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":125,"context_line":"        \"\"\"Driver may call the code below in order to delete the monitor."},{"line_number":126,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzOA%3D","line":126,"updated":"2013-07-23 01:05:59.000000000","message":"whoops","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0f397ba415dc146ccb0746d7f5c465fa540446c5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":125,"context_line":"        \"\"\"Driver may call the code below in order to delete the monitor."},{"line_number":126,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fy14%3D","line":126,"in_reply_to":"AAAAQn%2F%2Fy2w%3D","updated":"2013-07-23 05:25:41.000000000","message":"i see, the others have it... I don\u0027t really have a strong opinion but it seems fairly obvious to figure out without the docstring. Nvm I guess.","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8f936460feebc4d13de759c889ffd8d3fb6b193e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":125,"context_line":"        \"\"\"Driver may call the code below in order to delete the monitor."},{"line_number":126,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fy2w%3D","line":126,"in_reply_to":"AAAAQn%2F%2Fy3E%3D","updated":"2013-07-23 05:08:39.000000000","message":"I\u0027ve added the docstring for consistency with other (most of) methods of this class. Why do you think it\u0027s not needed in this case?","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8953e14dc6969170c3cf09aac0b74407201930ad","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":125,"context_line":"        \"\"\"Driver may call the code below in order to delete the monitor."},{"line_number":126,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fy3E%3D","line":126,"in_reply_to":"AAAAQn%2F%2Fy4Q%3D","updated":"2013-07-23 05:01:54.000000000","message":"I.c: i don\u0027t think this doc string is really need in this case then.","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7999b25ba7b4517d60a3904754289c59e4426562","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":125,"context_line":"        \"\"\"Driver may call the code below in order to delete the monitor."},{"line_number":126,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fy4Q%3D","line":126,"in_reply_to":"AAAAQn%2F%2FzOA%3D","updated":"2013-07-23 04:50:20.000000000","message":"That\u0027s a docstring, not a code :)\n(I\u0027ve left the same comment at first)","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"}],"neutron/services/loadbalancer/drivers/haproxy/plugin_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"81eae23d0c314fd3d52a134d6d22c9269eaf57e6","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        pass"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":361,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def stats(self, context, pool_id):"},{"line_number":364,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fyms%3D","line":361,"updated":"2013-07-23 07:05:39.000000000","message":"Minor nit - health_monitor[\"id\"] - would prefere this as health_monitor[\u0027id\u0027]","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0e275f11f7db95fe50fe7bb863b1615809fc3749","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        pass"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":361,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def stats(self, context, pool_id):"},{"line_number":364,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FyjI%3D","line":361,"in_reply_to":"AAAAQn%2F%2FymE%3D","updated":"2013-07-23 07:38:15.000000000","message":"but it would be a pity to lose all +1\u0027s and +2 just because of this and thus get another round of review which may last for several days :(","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d616f858160e2cd681dd0b64046b8c63cb47c4a1","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        pass"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def delete_health_monitor(self, context, health_monitor):"},{"line_number":361,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def stats(self, context, pool_id):"},{"line_number":364,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FymE%3D","line":361,"in_reply_to":"AAAAQn%2F%2Fyms%3D","updated":"2013-07-23 07:13:20.000000000","message":"me too, not sure how this even happened :)","commit_id":"4bd7bea0dbb54b6ed287f21ab7a6d65b177f017c"}]}