)]}'
{"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0ab707f40daffc4249a4a351f2b2dc100128a97f","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _create_network(self):"},{"line_number":1099,"context_line":"        name \u003d \"test-network-%s\" % tools.get_random_string(4)"},{"line_number":1100,"context_line":"        return obj_db_api.create_object(self.context,"},{"line_number":1101,"context_line":"                                        models_v2.Network,"},{"line_number":1102,"context_line":"                                        {\u0027name\u0027: name})"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def _create_test_subnet(self, network):"},{"line_number":1105,"context_line":"        test_subnet \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_1f1d31bd","line":1102,"range":{"start_line":1100,"start_character":15,"end_line":1102,"end_character":55},"updated":"2016-09-30 08:42:11.000000000","message":"this should also using the Network OVO.","commit_id":"be4780121bd6be314cac38a355aaa6eead41d283"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2a896d0502581955fdb5fe191428c7a611436d6e","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _create_network(self):"},{"line_number":1099,"context_line":"        name \u003d \"test-network-%s\" % tools.get_random_string(4)"},{"line_number":1100,"context_line":"        return obj_db_api.create_object(self.context,"},{"line_number":1101,"context_line":"                                        models_v2.Network,"},{"line_number":1102,"context_line":"                                        {\u0027name\u0027: name})"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def _create_test_subnet(self, network):"},{"line_number":1105,"context_line":"        test_subnet \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_2dee2bb4","line":1102,"range":{"start_line":1100,"start_character":15,"end_line":1102,"end_character":55},"in_reply_to":"3a98d1f4_1f1d31bd","updated":"2016-09-30 15:44:55.000000000","message":"Done","commit_id":"be4780121bd6be314cac38a355aaa6eead41d283"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"4ac88932ae3ce133a0ee8c2b7795c589e9c70586","unresolved":false,"context_lines":[{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"    def _create_network(self):"},{"line_number":1098,"context_line":"        name \u003d \"test-network-%s\" % tools.get_random_string(4)"},{"line_number":1099,"context_line":"        self._network \u003d net_obj.Network(self.context,"},{"line_number":1100,"context_line":"                                       name\u003dname)"},{"line_number":1101,"context_line":"        self._network.create()"},{"line_number":1102,"context_line":"        return self._network"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def _create_test_subnet(self, network):"},{"line_number":1105,"context_line":"        test_subnet \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_0424b3c2","line":1102,"range":{"start_line":1099,"start_character":8,"end_line":1102,"end_character":28},"updated":"2016-10-03 11:26:11.000000000","message":"What is the difference between _create_test_network and _create_network now? If we want to modify the self._network, we can make it in one method.\n\nThe original _create_network was not modifying the self._network, it was just create new network and return it. In my opinion I would leave it the old way, not touch the self._network.","commit_id":"9422311ed2d22bc472e024eb5edc2f2e63e51751"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2d292422db85138e8df1e919a21dc07719644511","unresolved":false,"context_lines":[{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"    def _create_network(self):"},{"line_number":1098,"context_line":"        name \u003d \"test-network-%s\" % tools.get_random_string(4)"},{"line_number":1099,"context_line":"        self._network \u003d net_obj.Network(self.context,"},{"line_number":1100,"context_line":"                                       name\u003dname)"},{"line_number":1101,"context_line":"        self._network.create()"},{"line_number":1102,"context_line":"        return self._network"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def _create_test_subnet(self, network):"},{"line_number":1105,"context_line":"        test_subnet \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_2c9ee6b8","line":1102,"range":{"start_line":1099,"start_character":8,"end_line":1102,"end_character":28},"in_reply_to":"3a98d1f4_0424b3c2","updated":"2016-10-03 16:30:20.000000000","message":"Done","commit_id":"9422311ed2d22bc472e024eb5edc2f2e63e51751"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"0b6131010927d54c120f2a3a6ead8495fb02b48c","unresolved":false,"context_lines":[{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"    def _create_network(self):"},{"line_number":1098,"context_line":"        name \u003d \"test-network-%s\" % tools.get_random_string(4)"},{"line_number":1099,"context_line":"        _network \u003d net_obj.Network(self.context,"},{"line_number":1100,"context_line":"                                   name\u003dname)"},{"line_number":1101,"context_line":"        _network.create()"},{"line_number":1102,"context_line":"        return _network"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_da0cfb96","line":1099,"range":{"start_line":1099,"start_character":8,"end_line":1099,"end_character":9},"updated":"2016-10-05 12:42:06.000000000","message":"why start with an underscore?","commit_id":"6a011c3f26972d8174de206ea38ddec6206d11ac"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a7c487339a498e2264f7fd482ba70fc697971841","unresolved":false,"context_lines":[{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"    def _create_network(self):"},{"line_number":1098,"context_line":"        name \u003d \"test-network-%s\" % tools.get_random_string(4)"},{"line_number":1099,"context_line":"        _network \u003d net_obj.Network(self.context,"},{"line_number":1100,"context_line":"                                   name\u003dname)"},{"line_number":1101,"context_line":"        _network.create()"},{"line_number":1102,"context_line":"        return _network"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_9f0c1896","line":1099,"range":{"start_line":1099,"start_character":8,"end_line":1099,"end_character":9},"in_reply_to":"1a95cdbc_da0cfb96","updated":"2016-10-05 15:40:24.000000000","message":"network is very common variable name to use, so had underscore","commit_id":"6a011c3f26972d8174de206ea38ddec6206d11ac"}]}
