)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4b50364439ea9fd5f0d8954087551e548347b03a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shashank Kumar Shankar \u003cshashank.kumar.shankar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-17 15:21:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Router Extra Attributes OVO in neutron/db/l3_hamode_db.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Integration of Router Extra Attributes in"},{"line_number":10,"context_line":"neutron/db/l3_hamode.py and including context in calling methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa6399be_a295ed33","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":72},"updated":"2016-10-21 14:11:49.000000000","message":"nit: the title exceeds the limit of 50 chars.","commit_id":"f6d875bd46188bade87b348911afb9b8d136a99a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"3c8e91082819da982f22222b0acf2cbbbcf218d2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shashank Kumar Shankar \u003cshashank.kumar.shankar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-17 15:21:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Router Extra Attributes OVO in neutron/db/l3_hamode_db.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Integration of Router Extra Attributes in"},{"line_number":10,"context_line":"neutron/db/l3_hamode.py and including context in calling methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6895a0_2f4779bc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":72},"in_reply_to":"fa6399be_a295ed33","updated":"2016-10-21 16:04:42.000000000","message":"Done","commit_id":"f6d875bd46188bade87b348911afb9b8d136a99a"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"28776892a858b8c108a553203372037bf0635614","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shashank Kumar Shankar \u003cshashank.kumar.shankar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-10 20:55:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Router Extra Attributes OVO."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrates Router Extra Attributes OVO and uses context"},{"line_number":10,"context_line":"in calling methods for object operations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a629dbe_a416a649","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"updated":"2016-11-11 06:36:24.000000000","message":"Oh, doesn\u0027t pep8 blame on periods in the first line of commit messages these days? ;)","commit_id":"5a958a2b9a03e5d2001430f0f89052ccf736a139"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"4d218bf420eafe610697cc03e8a9d2508872ebbc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shashank Kumar Shankar \u003cshashank.kumar.shankar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-10 20:55:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integration of Router Extra Attributes OVO."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch integrates Router Extra Attributes OVO and uses context"},{"line_number":10,"context_line":"in calling methods for object operations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a629dbe_fed56c42","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"in_reply_to":"9a629dbe_a416a649","updated":"2016-11-11 19:57:44.000000000","message":"Done. Removed period.","commit_id":"5a958a2b9a03e5d2001430f0f89052ccf736a139"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"abbad35254dcf590523f077a76e930078e251598","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch integrates Router Extra Attributes OVO and uses context"},{"line_number":10,"context_line":"in calling methods for object operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The other integration parts of this OVO is done in patch [1] and OVO usage"},{"line_number":13,"context_line":"in neutron/db/l3_attrs_db.py needs Router OVO for completion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://review.openstack.org/#/c/377074/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba5201f7_554b2f87","line":12,"range":{"start_line":12,"start_character":1,"end_line":12,"end_character":60},"updated":"2017-01-04 11:13:28.000000000","message":"I do not get this comment, the mentioned patch is covering for RouterL3AgentBinding not Extra Attributes...","commit_id":"f27e6f4fa28217e519ad42abbc234e08e560f2e7"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"88434e0626b0eb91d3a29e4e7b5db7eeb7a7737d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch integrates Router Extra Attributes OVO and uses context"},{"line_number":10,"context_line":"in calling methods for object operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The other integration parts of this OVO is done in patch [1] and OVO usage"},{"line_number":13,"context_line":"in neutron/db/l3_attrs_db.py needs Router OVO for completion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://review.openstack.org/#/c/377074/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba5201f7_f3727148","line":12,"range":{"start_line":12,"start_character":1,"end_line":12,"end_character":60},"in_reply_to":"ba5201f7_554b2f87","updated":"2017-01-04 16:07:55.000000000","message":"The integrations which I mentioned are regarding the joins between RouterL3AgentBinding, Extra Attributes here: [1]. So we felt it would be apt to do the integrations in that patch itself. \n\n[1] - https://review.openstack.org/#/c/377074/35/neutron/db/l3_agentschedulers_db.py@102","commit_id":"f27e6f4fa28217e519ad42abbc234e08e560f2e7"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a61b3d95860e0c075d6cd14d361bd26046293880","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch integrates Router Extra Attributes OVO and uses context"},{"line_number":10,"context_line":"in calling methods for object operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The other integration parts of this OVO is done in patch [1] and OVO usage"},{"line_number":13,"context_line":"in neutron/db/l3_attrs_db.py needs Router OVO for completion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://review.openstack.org/#/c/377074/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"5a3905b3_b0d3f65e","line":12,"range":{"start_line":12,"start_character":73,"end_line":12,"end_character":74},"updated":"2017-01-24 17:49:44.000000000","message":"nit: this line exceeds the max number of characters in the description","commit_id":"1c85effc156fbcd6c54825c4e583590eaa3c1c51"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c68b7a3d09fbd1e7ebf092e04124a092d1b1d297","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch integrates Router Extra Attributes OVO and uses context"},{"line_number":10,"context_line":"in calling methods for object operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The other integration parts of this OVO is done in patch [1] and OVO usage"},{"line_number":13,"context_line":"in neutron/db/l3_attrs_db.py needs Router OVO for completion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - https://review.openstack.org/#/c/377074/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"5a3905b3_8c517adb","line":12,"range":{"start_line":12,"start_character":73,"end_line":12,"end_character":74},"in_reply_to":"5a3905b3_b0d3f65e","updated":"2017-01-24 20:48:49.000000000","message":"Done","commit_id":"1c85effc156fbcd6c54825c4e583590eaa3c1c51"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d31676fc6cb11d9fdd49b5d14d5dc3b876606323","unresolved":false,"context_lines":[{"line_number":10,"context_line":"context in calling methods for object operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The other integration parts of this OVO in l3_agentschedulers_db.py"},{"line_number":13,"context_line":"and l3_attrs_db.py is being done in patch [1] and [2] respectively."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - 377074/42/neutron/db/l3_agentschedulers_db.py@93"},{"line_number":16,"context_line":"[2] - 421863/3/neutron/db/l3_attrs_db.py@55"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a1ced50_735de7e8","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":21},"updated":"2017-03-17 19:48:08.000000000","message":"s/is/are","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ce03215c0e1e8249a2a61cad99e6b19a590dbf3d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"context in calling methods for object operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The other integration parts of this OVO in l3_agentschedulers_db.py"},{"line_number":13,"context_line":"and l3_attrs_db.py is being done in patch [1] and [2] respectively."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - 377074/42/neutron/db/l3_agentschedulers_db.py@93"},{"line_number":16,"context_line":"[2] - 421863/3/neutron/db/l3_attrs_db.py@55"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a1ced50_82a126ac","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":21},"in_reply_to":"1a1ced50_735de7e8","updated":"2017-03-17 20:14:23.000000000","message":"Done","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d31676fc6cb11d9fdd49b5d14d5dc3b876606323","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The other integration parts of this OVO in l3_agentschedulers_db.py"},{"line_number":13,"context_line":"and l3_attrs_db.py is being done in patch [1] and [2] respectively."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - 377074/42/neutron/db/l3_agentschedulers_db.py@93"},{"line_number":16,"context_line":"[2] - 421863/3/neutron/db/l3_attrs_db.py@55"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib6e59ab3405857d3ed4d82df1a80800089c3f06e"},{"line_number":19,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a1ced50_93f983cb","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":43},"updated":"2017-03-17 19:48:08.000000000","message":"I would change this. Instead of providing exact links, just paste change-id. Then it won\u0027t get outdated with next updates.","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ce03215c0e1e8249a2a61cad99e6b19a590dbf3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The other integration parts of this OVO in l3_agentschedulers_db.py"},{"line_number":13,"context_line":"and l3_attrs_db.py is being done in patch [1] and [2] respectively."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] - 377074/42/neutron/db/l3_agentschedulers_db.py@93"},{"line_number":16,"context_line":"[2] - 421863/3/neutron/db/l3_attrs_db.py@55"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib6e59ab3405857d3ed4d82df1a80800089c3f06e"},{"line_number":19,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a1ced50_a2a622bf","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":43},"in_reply_to":"1a1ced50_93f983cb","updated":"2017-03-17 20:14:23.000000000","message":"Done","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"79f147361206d9bcddd2b0407f595d28a64f08da","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        # merged."},{"line_number":413,"context_line":"        l3_model_list \u003d l3_objs.RouterExtraAttributes.get_routers_agents_count("},{"line_number":414,"context_line":"            context)"},{"line_number":415,"context_line":"        return [(self._make_router_dict(router_model), agent_count)"},{"line_number":416,"context_line":"                if agent_count else (self._make_router_dict(router_model), 0)"},{"line_number":417,"context_line":"                for router_model, agent_count in l3_model_list]"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def get_l3_agents(self, context, active\u003dNone, filters\u003dNone):"},{"line_number":420,"context_line":"        query \u003d context.session.query(agent_model.Agent)"}],"source_content_type":"text/x-python","patch_set":21,"id":"da36d5c6_e5b64889","line":417,"range":{"start_line":415,"start_character":8,"end_line":417,"end_character":63},"updated":"2017-02-21 16:46:53.000000000","message":"shouldn\u0027t be better to implement in this way:\n\n        return [(self._make_router_dict(router_model),\n                agent_count if agent_count else 0)                \n                for router_model, agent_count in l3_model_list]","commit_id":"e1cea9656ec73efb600fbb4f85a9037c963178ae"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"d9245603dd2264b502767e6aeb46f07f4ae7f178","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        # merged."},{"line_number":413,"context_line":"        l3_model_list \u003d l3_objs.RouterExtraAttributes.get_routers_agents_count("},{"line_number":414,"context_line":"            context)"},{"line_number":415,"context_line":"        return [(self._make_router_dict(router_model), agent_count)"},{"line_number":416,"context_line":"                if agent_count else (self._make_router_dict(router_model), 0)"},{"line_number":417,"context_line":"                for router_model, agent_count in l3_model_list]"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def get_l3_agents(self, context, active\u003dNone, filters\u003dNone):"},{"line_number":420,"context_line":"        query \u003d context.session.query(agent_model.Agent)"}],"source_content_type":"text/x-python","patch_set":21,"id":"da36d5c6_ae92449d","line":417,"range":{"start_line":415,"start_character":8,"end_line":417,"end_character":63},"in_reply_to":"da36d5c6_e5b64889","updated":"2017-02-22 17:48:58.000000000","message":"Done","commit_id":"e1cea9656ec73efb600fbb4f85a9037c963178ae"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d31676fc6cb11d9fdd49b5d14d5dc3b876606323","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":91,"context_line":"            return (context.session.query("},{"line_number":92,"context_line":"                    rb_model.RouterL3AgentBinding)."},{"line_number":93,"context_line":"                    join(agent_model.Agent)."},{"line_number":94,"context_line":"                    filter(agent_model.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":95,"context_line":"                    agent_model.Agent.admin_state_up).outerjoin("},{"line_number":96,"context_line":"                        l3_attrs.RouterExtraAttributes,"},{"line_number":97,"context_line":"                        l3_attrs.RouterExtraAttributes.router_id \u003d\u003d"},{"line_number":98,"context_line":"                    rb_model.RouterL3AgentBinding.router_id).filter("},{"line_number":99,"context_line":"                    sa.or_("},{"line_number":100,"context_line":"                        l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.false(),"},{"line_number":101,"context_line":"                        l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.null())))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _get_agent_mode(self, agent_db):"},{"line_number":104,"context_line":"        agent_conf \u003d self.get_configuration_dict(agent_db)"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_33652f45","line":101,"range":{"start_line":90,"start_character":0,"end_line":101,"end_character":74},"updated":"2017-03-17 19:48:08.000000000","message":"If I understand it correctly, this part is not touched, because there is no RouterL3AgentBinding.\nCould you add at least comment, that this is left unchanged, and will be modified after all the pieces will be in place?","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ce03215c0e1e8249a2a61cad99e6b19a590dbf3d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":91,"context_line":"            return (context.session.query("},{"line_number":92,"context_line":"                    rb_model.RouterL3AgentBinding)."},{"line_number":93,"context_line":"                    join(agent_model.Agent)."},{"line_number":94,"context_line":"                    filter(agent_model.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":95,"context_line":"                    agent_model.Agent.admin_state_up).outerjoin("},{"line_number":96,"context_line":"                        l3_attrs.RouterExtraAttributes,"},{"line_number":97,"context_line":"                        l3_attrs.RouterExtraAttributes.router_id \u003d\u003d"},{"line_number":98,"context_line":"                    rb_model.RouterL3AgentBinding.router_id).filter("},{"line_number":99,"context_line":"                    sa.or_("},{"line_number":100,"context_line":"                        l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.false(),"},{"line_number":101,"context_line":"                        l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.null())))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _get_agent_mode(self, agent_db):"},{"line_number":104,"context_line":"        agent_conf \u003d self.get_configuration_dict(agent_db)"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_0296164c","line":101,"range":{"start_line":90,"start_character":0,"end_line":101,"end_character":74},"in_reply_to":"1a1ced50_33652f45","updated":"2017-03-17 20:14:23.000000000","message":"Done","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d31676fc6cb11d9fdd49b5d14d5dc3b876606323","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    def get_routers_l3_agents_count(self, context):"},{"line_number":400,"context_line":"        \"\"\"Return a map between routers and agent counts for all routers.\"\"\""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        # Postgres requires every column in the select to be present in"},{"line_number":403,"context_line":"        # the group by statement when using an aggregate function."},{"line_number":404,"context_line":"        # One solution is to generate a subquery and join it with the desired"},{"line_number":405,"context_line":"        # columns."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        # TODO(sshank): This portion needs Router OVO integration when it is"},{"line_number":408,"context_line":"        # merged."}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_d3f13bcf","line":405,"range":{"start_line":402,"start_character":0,"end_line":405,"end_character":18},"updated":"2017-03-17 19:48:08.000000000","message":"This comment is outdated.","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ce03215c0e1e8249a2a61cad99e6b19a590dbf3d","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    def get_routers_l3_agents_count(self, context):"},{"line_number":400,"context_line":"        \"\"\"Return a map between routers and agent counts for all routers.\"\"\""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        # Postgres requires every column in the select to be present in"},{"line_number":403,"context_line":"        # the group by statement when using an aggregate function."},{"line_number":404,"context_line":"        # One solution is to generate a subquery and join it with the desired"},{"line_number":405,"context_line":"        # columns."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        # TODO(sshank): This portion needs Router OVO integration when it is"},{"line_number":408,"context_line":"        # merged."}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_629d0a65","line":405,"range":{"start_line":402,"start_character":0,"end_line":405,"end_character":18},"in_reply_to":"1a1ced50_d3f13bcf","updated":"2017-03-17 20:14:23.000000000","message":"Done","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7e347588786c0d122a00e78076aa80f9a6ce7152","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":91,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":92,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":93,"context_line":"            return (context.session.query("},{"line_number":94,"context_line":"                    rb_model.RouterL3AgentBinding)."}],"source_content_type":"text/x-python","patch_set":25,"id":"1a1ced50_9a0a0778","line":91,"range":{"start_line":90,"start_character":64,"end_line":91,"end_character":66},"updated":"2017-03-21 15:57:46.000000000","message":"IMHO it\u0027s not necessary to specify the Change ID here.  I\u0027d prefer to know the reason of having these changes as separate patch","commit_id":"76e09de50611c738ff53e8b08d8d183d29060561"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"53b09a655ea4fd653132535d8b7bd39002772313","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":91,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":92,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":93,"context_line":"            return (context.session.query("},{"line_number":94,"context_line":"                    rb_model.RouterL3AgentBinding)."}],"source_content_type":"text/x-python","patch_set":25,"id":"1a1ced50_ba3ee3d7","line":91,"range":{"start_line":90,"start_character":6,"end_line":91,"end_character":66},"updated":"2017-03-21 15:16:46.000000000","message":"can be brought in this patch ??","commit_id":"76e09de50611c738ff53e8b08d8d183d29060561"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"9bc2c6166ba685c338e24bb9d05024276b2f0f80","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":91,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":92,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":93,"context_line":"            return (context.session.query("},{"line_number":94,"context_line":"                    rb_model.RouterL3AgentBinding)."}],"source_content_type":"text/x-python","patch_set":25,"id":"1a1ced50_1ddd2c6f","line":91,"range":{"start_line":90,"start_character":64,"end_line":91,"end_character":66},"in_reply_to":"1a1ced50_9a0a0778","updated":"2017-03-21 16:53:17.000000000","message":"This portion is in the patch mentioned above is because the joins need RouterL3AgentBinding and RouterExtraAttributes. To avoid duplicate work, it is taken care of in that patch.","commit_id":"76e09de50611c738ff53e8b08d8d183d29060561"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"53b09a655ea4fd653132535d8b7bd39002772313","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def get_routers_l3_agents_count(self, context):"},{"line_number":402,"context_line":"        \"\"\"Return a map between routers and agent counts for all routers.\"\"\""},{"line_number":403,"context_line":"        # TODO(sshank): This portion needs Router OVO integration when it is"},{"line_number":404,"context_line":"        # merged."},{"line_number":405,"context_line":"        l3_model_list \u003d l3_objs.RouterExtraAttributes.get_agents_count("},{"line_number":406,"context_line":"            context)"},{"line_number":407,"context_line":"        return [(self._make_router_dict(router_model),"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a1ced50_7a1f0b6c","line":404,"range":{"start_line":403,"start_character":8,"end_line":404,"end_character":17},"updated":"2017-03-21 15:16:46.000000000","message":"simple depends-on would work","commit_id":"76e09de50611c738ff53e8b08d8d183d29060561"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"9bc2c6166ba685c338e24bb9d05024276b2f0f80","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def get_routers_l3_agents_count(self, context):"},{"line_number":402,"context_line":"        \"\"\"Return a map between routers and agent counts for all routers.\"\"\""},{"line_number":403,"context_line":"        # TODO(sshank): This portion needs Router OVO integration when it is"},{"line_number":404,"context_line":"        # merged."},{"line_number":405,"context_line":"        l3_model_list \u003d l3_objs.RouterExtraAttributes.get_agents_count("},{"line_number":406,"context_line":"            context)"},{"line_number":407,"context_line":"        return [(self._make_router_dict(router_model),"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a1ced50_3d190823","line":404,"range":{"start_line":403,"start_character":8,"end_line":404,"end_character":17},"in_reply_to":"1a1ced50_7a1f0b6c","updated":"2017-03-21 16:53:17.000000000","message":"The Router OVO itself is not ready yet. It can take a while before Router OVO gets merged.","commit_id":"76e09de50611c738ff53e8b08d8d183d29060561"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e05aa5c960c121abf25a8cbde3075b739acef138","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":91,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":92,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":93,"context_line":"            return (context.session.query("}],"source_content_type":"text/x-python","patch_set":29,"id":"7ffa3b31_25a51e05","line":90,"range":{"start_line":90,"start_character":64,"end_line":90,"end_character":67},"updated":"2017-04-17 14:22:00.000000000","message":"may remove, as well as \"[1] Change-Id: \" below","commit_id":"79cf488c4c73b5596b21a8a9cdd01dd28c77049c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e05aa5c960c121abf25a8cbde3075b739acef138","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rescheduling_failed\u003dl3agentscheduler.RouterReschedulingFailed)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":90,"context_line":"        # TODO(sshank): This portion is done in seperate patch: [1]"},{"line_number":91,"context_line":"        # [1] Change-Id: I0af665a97087ad72431d58f04089a804088ef005"},{"line_number":92,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":93,"context_line":"            return (context.session.query("}],"source_content_type":"text/x-python","patch_set":29,"id":"7ffa3b31_659b26c9","line":90,"range":{"start_line":90,"start_character":48,"end_line":90,"end_character":56},"updated":"2017-04-17 14:22:00.000000000","message":"separate","commit_id":"79cf488c4c73b5596b21a8a9cdd01dd28c77049c"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5838a92bd40a50cbadc658d5da0c31affbcc1250","unresolved":false,"context_lines":[{"line_number":818,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":819,"context_line":"        return True"},{"line_number":820,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":821,"context_line":"        objs \u003d router.RouterExtraAttributes.get_objects("},{"line_number":822,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue)"},{"line_number":823,"context_line":"        return bool(objs[0].count())"},{"line_number":824,"context_line":"    else:"},{"line_number":825,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_a84814b4","line":823,"range":{"start_line":821,"start_character":0,"end_line":823,"end_character":36},"updated":"2016-10-03 22:47:03.000000000","message":"I believe you should be able to do:\nbool(router.RouterExtraAttributes.count(context, router_id\u003drouter_id, ha\u003dTrue))","commit_id":"6a816668b3ca6b59a94c764e62991d192293abd7"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"9df4453a8ed10430e6d0f1334b651fa0986e187f","unresolved":false,"context_lines":[{"line_number":818,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":819,"context_line":"        return True"},{"line_number":820,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":821,"context_line":"        objs \u003d router.RouterExtraAttributes.get_objects("},{"line_number":822,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue)"},{"line_number":823,"context_line":"        return bool(objs[0].count())"},{"line_number":824,"context_line":"    else:"},{"line_number":825,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_ef6da9cd","line":823,"range":{"start_line":821,"start_character":0,"end_line":823,"end_character":36},"in_reply_to":"3a98d1f4_a84814b4","updated":"2016-10-04 14:50:54.000000000","message":"Done","commit_id":"6a816668b3ca6b59a94c764e62991d192293abd7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a59de3f23a953c5eb1d7ec0c55158f9dd2db6ef3","unresolved":false,"context_lines":[{"line_number":760,"context_line":"        return True"},{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_24af6995","line":763,"updated":"2016-11-08 22:57:09.000000000","message":"one minor concern I see with this is that a brand new session was used in the old cold, but now a session attached to the context is being used and its probably the same context being passed around a lot of places.  I could see this potentially being an issue.  I don\u0027t think it will, but I just wanted to leave a comment in case someone comes along and knows for sure.","commit_id":"ddc2df8471d9facf57aa3be6670bb4a60b816aa4"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"28776892a858b8c108a553203372037bf0635614","unresolved":false,"context_lines":[{"line_number":755,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"def is_ha_router_port(context, device_owner, router_id):"},{"line_number":759,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":760,"context_line":"        return True"},{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_842282a1","line":758,"updated":"2016-11-11 06:36:24.000000000","message":"AFAIK, this method has nothing to do with RPC versions.\n\nIs OVO transition of this method really necessary?","commit_id":"5a958a2b9a03e5d2001430f0f89052ccf736a139"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ceed3c49698298e732ca8424ad6053c8ab883db7","unresolved":false,"context_lines":[{"line_number":755,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"def is_ha_router_port(context, device_owner, router_id):"},{"line_number":759,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":760,"context_line":"        return True"},{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_6cf7d58c","line":758,"in_reply_to":"9a629dbe_3e5a84f2","updated":"2016-11-14 09:24:18.000000000","message":"I thought the Neutron team\u0027s policy is to make OVO transitions necessary for online upgrades, and this change doesn\u0027t seem to affect that.","commit_id":"5a958a2b9a03e5d2001430f0f89052ccf736a139"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"4d218bf420eafe610697cc03e8a9d2508872ebbc","unresolved":false,"context_lines":[{"line_number":755,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"def is_ha_router_port(context, device_owner, router_id):"},{"line_number":759,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":760,"context_line":"        return True"},{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_3e5a84f2","line":758,"in_reply_to":"9a629dbe_842282a1","updated":"2016-11-11 19:57:44.000000000","message":"Since there is querying of DB, it is replaced by interaction with objects. I am not sure what you are referring to as RPC versions. Are you referring to the OVO version numbers?","commit_id":"5a958a2b9a03e5d2001430f0f89052ccf736a139"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9716027dcf380bd6caaeadfdb6f0d26150a6e3bb","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":760,"context_line":"        return True"},{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_bf9abb6c","line":763,"range":{"start_line":762,"start_character":15,"end_line":763,"end_character":51},"updated":"2016-12-08 15:39:52.000000000","message":"seems like now we can use objects_exist here?","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c64cba153651171fc761a4d610562d6cfe40da6d","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":760,"context_line":"        return True"},{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_bb72cf47","line":763,"range":{"start_line":762,"start_character":15,"end_line":763,"end_character":51},"in_reply_to":"3a71b18c_bf9abb6c","updated":"2016-12-13 17:22:51.000000000","message":"Done","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"90dc37c4e55f0b977a971b47af743f57d9bed6d7","unresolved":false,"context_lines":[{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_14f2d09a","line":764,"range":{"start_line":764,"start_character":4,"end_line":764,"end_character":9},"updated":"2016-11-21 21:51:56.000000000","message":"nit: this else is not needed, basically this can be like:\n\n    if device_owner \u003d\u003d constants.DEVICE_OWNER_HA_REPLICATED_INT:\n        return True\n    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:\n        return bool(router.RouterExtraAttributes.count(\n            context, router_id\u003drouter_id, ha\u003dTrue))\n    return False","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c64cba153651171fc761a4d610562d6cfe40da6d","unresolved":false,"context_lines":[{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_3b9ddf59","line":764,"range":{"start_line":764,"start_character":4,"end_line":764,"end_character":9},"in_reply_to":"3a71b18c_17e920b7","updated":"2016-12-13 17:22:51.000000000","message":"Done","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"cb12a0c2d5c83ba3d5cc3c4ac1ff317e1dd698f3","unresolved":false,"context_lines":[{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_17e920b7","line":764,"range":{"start_line":764,"start_character":4,"end_line":764,"end_character":9},"in_reply_to":"7a77a97e_14f2d09a","updated":"2016-12-07 08:52:55.000000000","message":"+1","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c64cba153651171fc761a4d610562d6cfe40da6d","unresolved":false,"context_lines":[{"line_number":761,"context_line":"    elif device_owner \u003d\u003d constants.DEVICE_OWNER_ROUTER_SNAT:"},{"line_number":762,"context_line":"        return bool(router.RouterExtraAttributes.count("},{"line_number":763,"context_line":"            context, router_id\u003drouter_id, ha\u003dTrue))"},{"line_number":764,"context_line":"    else:"},{"line_number":765,"context_line":"        return False"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_db8f8b21","line":764,"range":{"start_line":764,"start_character":4,"end_line":764,"end_character":9},"in_reply_to":"7a77a97e_14f2d09a","updated":"2016-12-13 17:22:51.000000000","message":"Done","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"d6755315ee1bfcb4c7190aee2dff07229965c110","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from neutron.extensions import l3_ext_ha_mode as l3_ha"},{"line_number":50,"context_line":"from neutron.extensions import portbindings"},{"line_number":51,"context_line":"from neutron.extensions import providernet"},{"line_number":52,"context_line":"from neutron.objects import router"},{"line_number":53,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5a3905b3_5a0d7636","line":52,"updated":"2017-01-25 04:23:15.000000000","message":"nit: can we name the import like \"import router as router_extra_attributes\"  so that it\u0027s clear it\u0027s not the router object but the routerextra_attributes. Also it would be nice to have it consistent in all the files in this patch","commit_id":"5638e918f8fec2fae092117bcc002a19b2df6338"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"d73c55abe1289218aab56853cb9fbcf0187be53f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from neutron.extensions import l3_ext_ha_mode as l3_ha"},{"line_number":50,"context_line":"from neutron.extensions import portbindings"},{"line_number":51,"context_line":"from neutron.extensions import providernet"},{"line_number":52,"context_line":"from neutron.objects import router"},{"line_number":53,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a461143_f9bfe35d","line":52,"in_reply_to":"5a3905b3_5a0d7636","updated":"2017-01-26 17:47:17.000000000","message":"l3 is renamed to router for consistency [1]. \n\n[1] - https://review.openstack.org/#/c/381209/20/neutron/db/l3_hascheduler_db.py@26","commit_id":"5638e918f8fec2fae092117bcc002a19b2df6338"}],"neutron/objects/router.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"79f147361206d9bcddd2b0407f595d28a64f08da","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @classmethod"},{"line_number":102,"context_line":"    def get_routers_agents_count(cls, context):"},{"line_number":103,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"},{"line_number":104,"context_line":"        sub_query \u003d (context.session.query("},{"line_number":105,"context_line":"            binding_model.router_id,"}],"source_content_type":"text/x-python","patch_set":21,"id":"da36d5c6_a8ffc5ff","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":32},"updated":"2017-02-21 16:46:53.000000000","message":"What about naming this as \"get_agents_count\", because this method belongs to router ovo class so makes a little redundant.","commit_id":"e1cea9656ec73efb600fbb4f85a9037c963178ae"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"d9245603dd2264b502767e6aeb46f07f4ae7f178","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @classmethod"},{"line_number":102,"context_line":"    def get_routers_agents_count(cls, context):"},{"line_number":103,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"},{"line_number":104,"context_line":"        sub_query \u003d (context.session.query("},{"line_number":105,"context_line":"            binding_model.router_id,"}],"source_content_type":"text/x-python","patch_set":21,"id":"da36d5c6_ee8c3c81","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":32},"in_reply_to":"da36d5c6_a8ffc5ff","updated":"2017-02-22 17:48:58.000000000","message":"Done","commit_id":"e1cea9656ec73efb600fbb4f85a9037c963178ae"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d31676fc6cb11d9fdd49b5d14d5dc3b876606323","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @classmethod"},{"line_number":102,"context_line":"    def get_agents_count(cls, context):"},{"line_number":103,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"},{"line_number":104,"context_line":"        sub_query \u003d (context.session.query("},{"line_number":105,"context_line":"            binding_model.router_id,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_fc0c3f44","line":102,"updated":"2017-03-17 19:48:08.000000000","message":"Could you add docstring, why it\u0027s done like that?\nAFAIK, it\u0027s done just temporarily, until solution to handle joins will be developed.","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ce03215c0e1e8249a2a61cad99e6b19a590dbf3d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @classmethod"},{"line_number":102,"context_line":"    def get_agents_count(cls, context):"},{"line_number":103,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"},{"line_number":104,"context_line":"        sub_query \u003d (context.session.query("},{"line_number":105,"context_line":"            binding_model.router_id,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_a28d4233","line":102,"in_reply_to":"1a1ced50_fc0c3f44","updated":"2017-03-17 20:14:23.000000000","message":"Done","commit_id":"532e754b8fe19cede07cf34852d038724a31bf88"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1c32b6fd0d481b47a757459c5ab865219e73a601","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return result"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @classmethod"},{"line_number":102,"context_line":"    def get_agents_count(cls, context):"},{"line_number":103,"context_line":"        # TODO(sshank): This is pulled out from l3_agentschedulers_db.py"},{"line_number":104,"context_line":"        # until a way to handle joins is figured out."},{"line_number":105,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"}],"source_content_type":"text/x-python","patch_set":28,"id":"7ffa3b31_4bd731ef","line":102,"updated":"2017-04-16 02:15:51.000000000","message":"This needs a more descriptive name. It returns routers and agent_counts","commit_id":"4663978ea1028f13b725eb3fc0dda09da9714792"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e05aa5c960c121abf25a8cbde3075b739acef138","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        query \u003d (context.session.query(l3.Router, sub_query.c.count)."},{"line_number":116,"context_line":"                 outerjoin(sub_query))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        return [(router, agent_count) for router, agent_count in query]"}],"source_content_type":"text/x-python","patch_set":29,"id":"7ffa3b31_45eeea22","line":118,"updated":"2017-04-17 14:22:00.000000000","message":"ideally, we would bubble up Router objects instead of models.","commit_id":"79cf488c4c73b5596b21a8a9cdd01dd28c77049c"}],"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"c93d4aa8d7339256dbcf23263485c50f59c2d620","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def update_port_postcommit(self, context):"},{"line_number":148,"context_line":"        port \u003d context.current"},{"line_number":149,"context_line":"        orig \u003d context.original"},{"line_number":150,"context_line":"        if l3_hamode_db.is_ha_router_port(n_context, port[\u0027device_owner\u0027],"},{"line_number":151,"context_line":"                                          port[\u0027device_id\u0027]):"},{"line_number":152,"context_line":"            return"},{"line_number":153,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_616c8008","line":150,"updated":"2016-11-11 06:05:13.000000000","message":"context is PortContext, n_context is a module.\nNeither is Context. See\n\nhttp://logs.openstack.org/09/381209/12/check/gate-tempest-dsvm-neutron-dvr-multinode-full-ubuntu-xenial/d505277/logs/screen-q-svc.txt.gz#_2016-11-10_21_47_15_465","commit_id":"5a958a2b9a03e5d2001430f0f89052ccf736a139"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"fcee93ff0db01ffa307be4f34e1644426832b2d6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":71,"context_line":"        port \u003d context.current"},{"line_number":72,"context_line":"        agent_host \u003d context.host"},{"line_number":73,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":74,"context_line":"        fdb_entries \u003d self._get_agent_fdb("},{"line_number":75,"context_line":"            admin_context, context.bottom_bound_segment, port, agent_host)"},{"line_number":76,"context_line":"        if port[\u0027device_owner\u0027] in l2pop_db.HA_ROUTER_PORTS and fdb_entries:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a629dbe_ac548dca","line":73,"updated":"2016-11-14 09:19:04.000000000","message":"I wonder if this line could be in _get_agent_fdb, saving a couple of other get_admin_context calls below.","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"71b63966291049b3bd54dceaf07773cacdd469fc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":71,"context_line":"        port \u003d context.current"},{"line_number":72,"context_line":"        agent_host \u003d context.host"},{"line_number":73,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":74,"context_line":"        fdb_entries \u003d self._get_agent_fdb("},{"line_number":75,"context_line":"            admin_context, context.bottom_bound_segment, port, agent_host)"},{"line_number":76,"context_line":"        if port[\u0027device_owner\u0027] in l2pop_db.HA_ROUTER_PORTS and fdb_entries:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_18856c06","line":73,"in_reply_to":"7a77a97e_741ce477","updated":"2016-11-22 20:15:31.000000000","message":"@Iwamoto Toshihiro: I introduced this context in _get_agent_fdb in another patch and it got merged. Hence I have kept it as it is. \n\n@Victor Morales: The other contexts seems to not have session inside them. This admin_context has session and hence passes all tests.","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"90dc37c4e55f0b977a971b47af743f57d9bed6d7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":71,"context_line":"        port \u003d context.current"},{"line_number":72,"context_line":"        agent_host \u003d context.host"},{"line_number":73,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":74,"context_line":"        fdb_entries \u003d self._get_agent_fdb("},{"line_number":75,"context_line":"            admin_context, context.bottom_bound_segment, port, agent_host)"},{"line_number":76,"context_line":"        if port[\u0027device_owner\u0027] in l2pop_db.HA_ROUTER_PORTS and fdb_entries:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_741ce477","line":73,"in_reply_to":"9a629dbe_ac548dca","updated":"2016-11-21 21:51:56.000000000","message":"+1, same applies for is_ha_router_port method.  My major concern is that you\u0027re using admin context for executing these updates/deletes. Is this the right approach?","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9716027dcf380bd6caaeadfdb6f0d26150a6e3bb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        agent_host \u003d context.host"},{"line_number":73,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":74,"context_line":"        fdb_entries \u003d self._get_agent_fdb("},{"line_number":75,"context_line":"            admin_context, context.bottom_bound_segment, port, agent_host)"},{"line_number":76,"context_line":"        if port[\u0027device_owner\u0027] in l2pop_db.HA_ROUTER_PORTS and fdb_entries:"},{"line_number":77,"context_line":"            session \u003d db_api.get_session()"},{"line_number":78,"context_line":"            network_id \u003d port[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_22269268","line":75,"updated":"2016-12-08 15:39:52.000000000","message":"I am not sure it\u0027s the right thing to do. I believe we should instead extract context from \u0027context\u0027 object, using context._plugin_context. Same in other places.","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c64cba153651171fc761a4d610562d6cfe40da6d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        agent_host \u003d context.host"},{"line_number":73,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":74,"context_line":"        fdb_entries \u003d self._get_agent_fdb("},{"line_number":75,"context_line":"            admin_context, context.bottom_bound_segment, port, agent_host)"},{"line_number":76,"context_line":"        if port[\u0027device_owner\u0027] in l2pop_db.HA_ROUTER_PORTS and fdb_entries:"},{"line_number":77,"context_line":"            session \u003d db_api.get_session()"},{"line_number":78,"context_line":"            network_id \u003d port[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_7b9f5750","line":75,"in_reply_to":"3a71b18c_22269268","updated":"2016-12-13 17:22:51.000000000","message":"Done","commit_id":"618893e67bc18cb5c390c1205a268775bf35edd4"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"abbad35254dcf590523f077a76e930078e251598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ba5201f7_103615e6","updated":"2017-01-04 11:13:28.000000000","message":"How changes in this file are relevant to this PS?","commit_id":"f27e6f4fa28217e519ad42abbc234e08e560f2e7"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"88434e0626b0eb91d3a29e4e7b5db7eeb7a7737d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ba5201f7_73d5a1b7","in_reply_to":"ba5201f7_103615e6","updated":"2017-01-04 16:07:55.000000000","message":"These changes are to facilitate the use of context instead of session used during Router Extra Attribute OVO operations.","commit_id":"f27e6f4fa28217e519ad42abbc234e08e560f2e7"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ca0c12f0ad3897dd291ca7e5e07e41ce630b2024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ba5201f7_110d02e8","in_reply_to":"ba5201f7_1ba9bc24","updated":"2017-01-05 15:28:29.000000000","message":"I had introduced the \u0027context\u0027 in a previous patch: [1]. But that context does not contain session in its attributes since it is a port context. In the previous patch sets of the current patch, we were running into errors due to this and hence reviewers asked to change from \u0027context\u0027 to \u0027plugin_context\u0027. This made the tests to pass. This is why the changes are relevant to this patch. \n\n[1] - https://review.openstack.org/#/c/394627/","commit_id":"f27e6f4fa28217e519ad42abbc234e08e560f2e7"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"ffd29d1d5302558716399e9e5f4d8864084e2eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ba5201f7_1ba9bc24","in_reply_to":"ba5201f7_73d5a1b7","updated":"2017-01-05 00:38:00.000000000","message":"sorry, I do not get it either. These changes are from \"context\" to \"plugin_context\u003dcontext._plugin_context\", not from \"session\"","commit_id":"f27e6f4fa28217e519ad42abbc234e08e560f2e7"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_db.py":[{"author":{"_account_id":19591,"name":"Saisrikiran Mudigonda","email":"saisrikiran.mudigonda@intel.com","username":"saisrikiran"},"change_message_id":"fd2c9f62e9cb3631070f9593186a4efaccab1769","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self.ctx.session.add(models_v2.Network(id\u003dnetwork_id))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _create_router(self, distributed\u003dTrue, ha\u003dFalse):"},{"line_number":53,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":54,"context_line":"            self.ctx.session.add(l3_models.Router(id\u003dTEST_ROUTER_ID))"},{"line_number":55,"context_line":"            router.RouterExtraAttributes("},{"line_number":56,"context_line":"                self.ctx,"},{"line_number":57,"context_line":"                router_id\u003dTEST_ROUTER_ID,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_ed7fb6dd","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":69},"updated":"2016-11-10 17:17:01.000000000","message":"The logs show the following error -\nAttributeError: \u0027PortContext\u0027 object has no attribute \u0027session\u0027\nPlease check if \u0027session\u0027 needs to be removed/replaced.","commit_id":"ddc2df8471d9facf57aa3be6670bb4a60b816aa4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a61b3d95860e0c075d6cd14d361bd26046293880","unresolved":false,"context_lines":[{"line_number":34,"context_line":"HOST_3 \u003d \u0027HOST_3\u0027"},{"line_number":35,"context_line":"HOST_2_TUNNELING_IP \u003d \u002720.0.0.2\u0027"},{"line_number":36,"context_line":"HOST_3_TUNNELING_IP \u003d \u002720.0.0.3\u0027"},{"line_number":37,"context_line":"TEST_ROUTER_ID \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":"TEST_NETWORK_ID \u003d \u0027network_id\u0027"},{"line_number":39,"context_line":"TEST_HA_NETWORK_ID \u003d \u0027ha_network_id\u0027"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a3905b3_10a20a9b","line":37,"range":{"start_line":37,"start_character":17,"end_line":37,"end_character":42},"updated":"2017-01-24 17:49:44.000000000","message":"I found the same issue in L3HARouter patch[1]\n\n[1] https://review.openstack.org/#/c/361443/37/neutron/tests/unit/plugins/ml2/drivers/l2pop/test_db.py@37","commit_id":"1c85effc156fbcd6c54825c4e583590eaa3c1c51"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c68b7a3d09fbd1e7ebf092e04124a092d1b1d297","unresolved":false,"context_lines":[{"line_number":34,"context_line":"HOST_3 \u003d \u0027HOST_3\u0027"},{"line_number":35,"context_line":"HOST_2_TUNNELING_IP \u003d \u002720.0.0.2\u0027"},{"line_number":36,"context_line":"HOST_3_TUNNELING_IP \u003d \u002720.0.0.3\u0027"},{"line_number":37,"context_line":"TEST_ROUTER_ID \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":"TEST_NETWORK_ID \u003d \u0027network_id\u0027"},{"line_number":39,"context_line":"TEST_HA_NETWORK_ID \u003d \u0027ha_network_id\u0027"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a3905b3_8c689a89","line":37,"range":{"start_line":37,"start_character":17,"end_line":37,"end_character":42},"in_reply_to":"5a3905b3_10a20a9b","updated":"2017-01-24 20:48:49.000000000","message":"Done. I just added them here as well for consistency.","commit_id":"1c85effc156fbcd6c54825c4e583590eaa3c1c51"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7e347588786c0d122a00e78076aa80f9a6ce7152","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"                    self.driver, self.context, p[\u0027port\u0027],"},{"line_number":1144,"context_line":"                    self.driver.get_network("},{"line_number":1145,"context_line":"                        self.context, p[\u0027port\u0027][\u0027network_id\u0027]),"},{"line_number":1146,"context_line":"                    None, bindings)"},{"line_number":1147,"context_line":"                mock.patch.object(port_context, \u0027_expand_segment\u0027).start()"},{"line_number":1148,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1149,"context_line":"                # no exceptions are raised."}],"source_content_type":"text/x-python","patch_set":25,"id":"1a1ced50_e4b361e7","line":1146,"range":{"start_line":1146,"start_character":26,"end_line":1146,"end_character":34},"updated":"2017-03-21 15:57:46.000000000","message":"nit: given that there is no other reference it\u0027s not necessary to declare bindings variable in line 1141 and use it here, you can provide the value here.","commit_id":"76e09de50611c738ff53e8b08d8d183d29060561"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"7fddb87c04742947b62531ff6146193be4e1eb66","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"                    self.driver, self.context, p[\u0027port\u0027],"},{"line_number":1145,"context_line":"                    self.driver.get_network("},{"line_number":1146,"context_line":"                        self.context, p[\u0027port\u0027][\u0027network_id\u0027]),"},{"line_number":1147,"context_line":"                    None, bindings)"},{"line_number":1148,"context_line":"                mock.patch.object(port_context, \u0027_expand_segment\u0027).start()"},{"line_number":1149,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1150,"context_line":"                # no exceptions are raised."}],"source_content_type":"text/x-python","patch_set":28,"id":"dfeb2761_832271ff","line":1147,"range":{"start_line":1147,"start_character":26,"end_line":1147,"end_character":34},"updated":"2017-04-03 23:27:07.000000000","message":"Check my comment in PS25 \n\nhttps://review.openstack.org/#/c/381209/25/neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py@1146","commit_id":"4663978ea1028f13b725eb3fc0dda09da9714792"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"218b784e6559ea6cda9d9e8b4e76e4c86105d933","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"                    self.driver, self.context, p[\u0027port\u0027],"},{"line_number":1145,"context_line":"                    self.driver.get_network("},{"line_number":1146,"context_line":"                        self.context, p[\u0027port\u0027][\u0027network_id\u0027]),"},{"line_number":1147,"context_line":"                    None, bindings)"},{"line_number":1148,"context_line":"                mock.patch.object(port_context, \u0027_expand_segment\u0027).start()"},{"line_number":1149,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1150,"context_line":"                # no exceptions are raised."}],"source_content_type":"text/x-python","patch_set":28,"id":"dfeb2761_a8f76dd3","line":1147,"range":{"start_line":1147,"start_character":26,"end_line":1147,"end_character":34},"in_reply_to":"dfeb2761_48d46148","updated":"2017-04-04 19:46:07.000000000","message":"I was following what was done in the test case above. (_test_delete_port_handles_agentless_host_id)","commit_id":"4663978ea1028f13b725eb3fc0dda09da9714792"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b2481e734d35ec3abeab6aefece59bb337840d82","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"                    self.driver, self.context, p[\u0027port\u0027],"},{"line_number":1145,"context_line":"                    self.driver.get_network("},{"line_number":1146,"context_line":"                        self.context, p[\u0027port\u0027][\u0027network_id\u0027]),"},{"line_number":1147,"context_line":"                    None, bindings)"},{"line_number":1148,"context_line":"                mock.patch.object(port_context, \u0027_expand_segment\u0027).start()"},{"line_number":1149,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1150,"context_line":"                # no exceptions are raised."}],"source_content_type":"text/x-python","patch_set":28,"id":"dfeb2761_48d46148","line":1147,"range":{"start_line":1147,"start_character":26,"end_line":1147,"end_character":34},"in_reply_to":"dfeb2761_832271ff","updated":"2017-04-04 19:41:29.000000000","message":"It looks good for me. Explicit is better than implicit :)","commit_id":"4663978ea1028f13b725eb3fc0dda09da9714792"}]}
